Re: [PATCH 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-08-26 Thread Shashidhar Hiremath
On Sat, Aug 27, 2011 at 1:34 AM, James Hogan wrote: > Hi > > On 26 August 2011 19:06, Shashidhar Hiremath > wrote: >> Hi James, >>  thanks a lot for the reply. >>  I will fix all the indentation issues as well.Please find my >> comments/queries below: >> >> On Fri, Aug 26, 2011 at 7:09 PM, James

Re: [PATCH 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-08-26 Thread James Hogan
Hi On 26 August 2011 19:06, Shashidhar Hiremath wrote: > Hi James, >  thanks a lot for the reply. >  I will fix all the indentation issues as well.Please find my > comments/queries below: > > On Fri, Aug 26, 2011 at 7:09 PM, James Hogan wrote: >> Hi, >> >> Thanks for sending the patch. >> >> On

Re: [PATCH 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-08-26 Thread Shashidhar Hiremath
Hi James, thanks a lot for the reply. I will fix all the indentation issues as well.Please find my comments/queries below: On Fri, Aug 26, 2011 at 7:09 PM, James Hogan wrote: > Hi, > > Thanks for sending the patch. > > On 08/26/2011 11:31 AM, Shashidhar Hiremath wrote: >> This Patch adds the

Re: [PATCH v9 00/12] use nonblock mmc requests to minimize latency

2011-08-26 Thread Santosh
+ Balaji, On Friday 26 August 2011 09:49 PM, Russell King - ARM Linux wrote: I'm not sure who's responsible for this, but the nonblocking MMC stuff is broken on OMAPs HSMMC: mmcblk0: error -84 transferring data, sector 149201, nr 64, cmd response 0x900, card status 0xb00 mmcblk0: retrying usin

Re: [PATCH v9 00/12] use nonblock mmc requests to minimize latency

2011-08-26 Thread Russell King - ARM Linux
I'm not sure who's responsible for this, but the nonblocking MMC stuff is broken on OMAPs HSMMC: mmcblk0: error -84 transferring data, sector 149201, nr 64, cmd response 0x900, card status 0xb00 mmcblk0: retrying using single block re

Re: [PATCH 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-08-26 Thread James Hogan
Hi, Thanks for sending the patch. On 08/26/2011 11:31 AM, Shashidhar Hiremath wrote: > This Patch adds the support for Dual Buffer Descriptor mode of > Operation for the dw_mmc driver.The patch also provides the configurability > Option for choosing DUAL_BUFFER mode or the chained modes through m

Re: [PATCH] [RFC] ARM: shmobile: g4evm: Use multiple irq vectors for SDHI

2011-08-26 Thread Simon Horman
On Fri, Aug 26, 2011 at 02:56:50PM +0200, Guennadi Liakhovetski wrote: > On Fri, 26 Aug 2011, Simon Horman wrote: > > > On Fri, Aug 26, 2011 at 02:17:20PM +0200, Guennadi Liakhovetski wrote: > > > On Fri, 26 Aug 2011, Simon Horman wrote: > > > > > > > This patch is based on "ARM: arch-shmobile: U

Re: [PATCH] [RFC] ARM: shmobile: g4evm: Use multiple irq vectors for SDHI

2011-08-26 Thread Guennadi Liakhovetski
On Fri, 26 Aug 2011, Simon Horman wrote: > On Fri, Aug 26, 2011 at 02:17:20PM +0200, Guennadi Liakhovetski wrote: > > On Fri, 26 Aug 2011, Simon Horman wrote: > > > > > This patch is based on "ARM: arch-shmobile: Use multiple irq vectors for > > > SDHI" > > > > > > It removes multiplexing of th

Re: [PATCH] [RFC] ARM: shmobile: g4evm: Use multiple irq vectors for SDHI

2011-08-26 Thread Simon Horman
On Fri, Aug 26, 2011 at 02:17:20PM +0200, Guennadi Liakhovetski wrote: > On Fri, 26 Aug 2011, Simon Horman wrote: > > > This patch is based on "ARM: arch-shmobile: Use multiple irq vectors for > > SDHI" > > > > It removes multiplexing of the SDHI vectors and names each IRQ source > > to allow th

Re: [PATCH] [RFC] ARM: shmobile: g4evm: Use multiple irq vectors for SDHI

2011-08-26 Thread Guennadi Liakhovetski
On Fri, 26 Aug 2011, Simon Horman wrote: > This patch is based on "ARM: arch-shmobile: Use multiple irq vectors for SDHI" > > It removes multiplexing of the SDHI vectors and names each IRQ source > to allow the SDHI driver to used source-specific handlers. > > This is untested as I do not have a

Re: [PATCH 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-08-26 Thread Shashidhar Hiremath
thanks Will, I will make the changes soon. On Fri, Aug 26, 2011 at 4:36 PM, Will Newton wrote: > On Fri, Aug 26, 2011 at 11:31 AM, Shashidhar Hiremath > wrote: > > Hi Shashidhar, > > Thanks for the patch! A few comments below: > >> This Patch adds the support for Dual Buffer Descriptor mode of >

Re: [PATCH 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-08-26 Thread Will Newton
On Fri, Aug 26, 2011 at 11:31 AM, Shashidhar Hiremath wrote: Hi Shashidhar, Thanks for the patch! A few comments below: > This Patch adds the support for Dual Buffer Descriptor mode of > Operation for the dw_mmc driver.The patch also provides the configurability > Option for choosing DUAL_BUFFE

Re: [PATCH] mmc: sdhci-s3c: Fix mmc card I/O problem

2011-08-26 Thread Jaehoon Chung
This patch looks fine to me. Acked-by: Jaehoon Chung Girish K S wrote: > This patch fixes the problem in sdhci-s3c host driver for > Samsung Soc's. During the card identification stage the > mmc core driver enumerates for the best bus width in combination > with the highest available data rate.

[PATCH 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-08-26 Thread Shashidhar Hiremath
This Patch adds the support for Dual Buffer Descriptor mode of Operation for the dw_mmc driver.The patch also provides the configurability Option for choosing DUAL_BUFFER mode or the chained modes through menuconfig. The Menuconfig option for selecting Dual Buffer mode or chained mode is selected o

[PATCH] [RFC] ARM: shmobile: g4evm: Use multiple irq vectors for SDHI

2011-08-26 Thread Simon Horman
This patch is based on "ARM: arch-shmobile: Use multiple irq vectors for SDHI" It removes multiplexing of the SDHI vectors and names each IRQ source to allow the SDHI driver to used source-specific handlers. This is untested as I do not have access to a working g4evm. Signed-off-by: Simon Horman

Re: [PATCH v8 4/4] ARM: shmobile: ag5evm, ap4: Named SDHI IRQ sources

2011-08-26 Thread Simon Horman
On Fri, Aug 26, 2011 at 11:22:00AM +0200, Guennadi Liakhovetski wrote: > On Fri, 26 Aug 2011, Simon Horman wrote: > > > On Fri, Aug 26, 2011 at 10:44:16AM +0200, Guennadi Liakhovetski wrote: > > > On Thu, 25 Aug 2011, Simon Horman wrote: > > > > > > > This allows specific (non-multiplexed) IRQ ha

[PATCH] mmc: sdhci-s3c: Fix mmc card I/O problem

2011-08-26 Thread Girish K S
This patch fixes the problem in sdhci-s3c host driver for Samsung Soc's. During the card identification stage the mmc core driver enumerates for the best bus width in combination with the highest available data rate. It starts enumerating from the highest bus width (8) to lowest bus width (1). In

Re: [PATCH v8 4/4] ARM: shmobile: ag5evm, ap4: Named SDHI IRQ sources

2011-08-26 Thread Guennadi Liakhovetski
On Fri, 26 Aug 2011, Simon Horman wrote: > On Fri, Aug 26, 2011 at 10:44:16AM +0200, Guennadi Liakhovetski wrote: > > On Thu, 25 Aug 2011, Simon Horman wrote: > > > > > This allows specific (non-multiplexed) IRQ handlers to be used. > > > > Could you also prepare a similar patch for g4evm and ap

Re: [PATCH v8 4/4] ARM: shmobile: ag5evm, ap4: Named SDHI IRQ sources

2011-08-26 Thread Simon Horman
On Fri, Aug 26, 2011 at 10:44:16AM +0200, Guennadi Liakhovetski wrote: > On Thu, 25 Aug 2011, Simon Horman wrote: > > > This allows specific (non-multiplexed) IRQ handlers to be used. > > Could you also prepare a similar patch for g4evm and ap4evb? No need to > change this one, just prepare anot

Re: [PATCH 3/4 v9] mmc: sdhi: Allow named IRQs to use specific handlers

2011-08-26 Thread Simon Horman
On Fri, Aug 26, 2011 at 10:42:39AM +0200, Guennadi Liakhovetski wrote: > From: Simon Horman > > Allow named IRQs to use corresponding specific handlers. If named IRQs are > used, at least an "sdcard" IRQ has to be specified by the platform. If > names are not used, an arbitrary number of IRQs c

[PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay

2011-08-26 Thread Chunhe Lan
The mmc_delay() is a wrapper function for mdelay() and msleep(). o mdelay() -- block the system when busy-waiting. o msleep() -- suspend the currently running task to enable CPU to process other tasks, so it is non-blocking regarding the whole system. W

[PATCH 2/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay

2011-08-26 Thread Chunhe Lan
The mmc_delay() is a wrapper function for mdelay() and msleep(). o mdelay() -- block the system when busy-waiting. o msleep() -- suspend the currently running task to enable CPU to process other tasks, so it is non-blocking regarding the whole system. W

[PATCH 1/3 v2] mmc: Move mmc_delay() to include/linux/mmc/core.h

2011-08-26 Thread Chunhe Lan
Move mmc_delay() from drivers/mmc/core/core.h to include/linux/mmc/core.h. So when other functions call it with include syntax using of absolute path rather than "../core/core.h" of relative path. Signed-off-by: Chunhe Lan Cc: Chris Ball --- drivers/mmc/core/core.h | 12 includ

Re: [PATCH v8 4/4] ARM: shmobile: ag5evm, ap4: Named SDHI IRQ sources

2011-08-26 Thread Guennadi Liakhovetski
On Thu, 25 Aug 2011, Simon Horman wrote: > This allows specific (non-multiplexed) IRQ handlers to be used. Could you also prepare a similar patch for g4evm and ap4evb? No need to change this one, just prepare another one, please. Thanks Guennadi > > Cc: Guennadi Liakhovetski > Cc: Paul Mundt

RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-08-26 Thread Zang Roy-R61911
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Friday, August 12, 2011 18:05 PM > To: Zang Roy-R61911 > Cc: linux-mmc@vger.kernel.org; linuxppc-...@lists.ozlabs.org; akpm@linux- > foundation.org; Xu Lei-B33228; Kumar Gala; Wood Scott-B07421 > Subject:

Re: [PATCH 2/2] mmc: Use mmc_delay() instead of mdelay() for time delay

2011-08-26 Thread Lan Chunhe
On Thu, 25 Aug 2011 18:23:35 +0800, Kyungmin Park wrote: On Thu, Aug 25, 2011 at 5:54 PM, Chunhe Lan wrote: The mmc_delay() is a wrapper function for mdelay() and msleep(). o mdelay() -- block the system when busy-waiting. o msleep() -- suspend the currently running task to enable C

[PATCH 3/4 v9] mmc: sdhi: Allow named IRQs to use specific handlers

2011-08-26 Thread Guennadi Liakhovetski
From: Simon Horman Allow named IRQs to use corresponding specific handlers. If named IRQs are used, at least an "sdcard" IRQ has to be specified by the platform. If names are not used, an arbitrary number of IRQs can be provided by the platform, in which case the generic ISR will be used for e

[PATCH] mmc: core: Add default timeout value for CMD6.

2011-08-26 Thread Seungwon Jeon
EXT_CSD[248] includes the default maximum timeout for CMD6. This field is added at eMMC4.5 Spec. Signed-off-by: Seungwon Jeon --- drivers/mmc/core/mmc.c |4 include/linux/mmc/card.h |1 + include/linux/mmc/mmc.h |1 + 3 files changed, 6 insertions(+), 0 deletions(-) diff --g