Re: [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay

2011-09-05 Thread Chunhe Lan
On Thu, 01 Sep 2011 12:42:08 +0800, Kumar Gala wrote: On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote: The mmc_delay() is a wrapper function for mdelay() and msleep(). o mdelay() -- block the system when busy-waiting. o msleep() -- suspend the currently running task to enable CPU

Re: [PATCH] dw_mmc: ensure the ciu-reset

2011-09-05 Thread Jaehoon Chung
Hi Will Will Newton wrote: > On Mon, Sep 5, 2011 at 1:39 AM, Jaehoon Chung wrote: > > Hi Jaehoon, > >> This patch ensured the CIU-reset. >> >> If data0 line is low, bit[9] in status register is set to 1. >> Then we can know the card is busy. >> >> Using this bit in status register, we can ensu

Re: RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

2011-09-05 Thread Linus Walleij
On Mon, Sep 5, 2011 at 2:30 AM, NamJae Jeon wrote: >>> host >>> controller can just know whether card is finish to program to use busy >>> line. If unstable card is holding busy line while writing using DMA, >>> hang problem will happen by wait_for_completion. >>> so I think that mmc driver need

Re: [PATCH 2/2] mmc: core: Add poweroff notify handling feature

2011-09-05 Thread Girish K S
Hi Mr Park, On 5 September 2011 18:03, Kyungmin Park wrote: > Hi Girish, > > I think it's still incomplete, does power off short function is called > at suspend properly? > there are some comments below. > > Thank you, > Kyungmin Park > > On Mon, Sep 5, 2011 at 8:49 PM, Girish K S > wrote: >> Th

Re: [PATCH 2/2] mmc: core: Add poweroff notify handling feature

2011-09-05 Thread Kyungmin Park
Hi Girish, I think it's still incomplete, does power off short function is called at suspend properly? there are some comments below. Thank you, Kyungmin Park On Mon, Sep 5, 2011 at 8:49 PM, Girish K S wrote: > This patch adds the handling of the poweroff notify feature > during powerdown phase

[PATCH 2/2] mmc: core: Add poweroff notify handling feature

2011-09-05 Thread Girish K S
This patch adds the handling of the poweroff notify feature during powerdown phase. Signed-off-by: Girish K S --- drivers/mmc/core/core.c | 29 + drivers/mmc/core/mmc.c |3 +++ drivers/mmc/host/sdhci.c | 11 +++ include/linux/mmc/card.h | 29 +

[PATCH 1/2] mmc: core: Add power off notify feature(eMMC 4.5)

2011-09-05 Thread Girish K S
This patch adds the support for power off notify feature available in eMMC 4.5 devices. If the the host has support for this feature, then the mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON). This

[PATCH 0/2] mmc: core: Power off notify/handle (eMMC 4.5)

2011-09-05 Thread Girish K S
This set of patch add the feature of notify and handling of PowerOff notification for eMMC 4.5 devices Girish K S (2): mmc: core: Add power off notify feature(eMMC 4.5) mmc: core: Add poweroff notify handling feature drivers/mmc/core/core.c | 29 + drivers/mmc/

Re: [PATCH 2/2] arm: samsung: remove sdhci default configuration setup platform helper

2011-09-05 Thread Thomas Abraham
Dear Mr. Kim, On 5 September 2011 10:46, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> The sdhci platform helper function that sets up the default controller >> configuration is removed for all Samsung platforms since such default >> controller configuration can be handled by the driver. >> >>

Re: [PATCH] dw_mmc: ensure the ciu-reset

2011-09-05 Thread Will Newton
On Mon, Sep 5, 2011 at 1:39 AM, Jaehoon Chung wrote: Hi Jaehoon, > This patch ensured the CIU-reset. > > If data0 line is low, bit[9] in status register is set to 1. > Then we can know the card is busy. > > Using this bit in status register, we can ensure to reset the CIU correctly. > When card

Re: [PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-05 Thread Thomas Abraham
Dear Mr. Kim, On 5 September 2011 10:46, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> The default controller configuration which was previously setup by >> platform helper functions is moved into the driver. >> >> Cc: Ben Dooks >> Signed-off-by: Thomas Abraham >> --- >>  drivers/mmc/host/sdh

Re: [PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-05 Thread Thomas Abraham
Hi Jaehoon, On 5 September 2011 07:01, Jaehoon Chung wrote: > Hi Thomas. > > I have some question. This patch looks good. > Some names are used S3C_SDHCI_. but some names are used > S3C64XX_SDHCI_. > Do you know what differ them? I am not sure why there are S3C_SDHCI_xxx and S3C64XX_SDH

Re: [PATCH 0/2] mmc: sh_mmcif: simplify platform DMA configuration

2011-09-05 Thread Guennadi Liakhovetski
On Mon, 5 Sep 2011, Paul Mundt wrote: > On Tue, Aug 30, 2011 at 06:26:34PM +0200, Guennadi Liakhovetski wrote: > > A simple cosmetic clean-up, no functional changes. Patch 2/2 depends on > > patch 1/2 and can wait until 3.3. Paul, would you be able to put it under > > the carpet somewhere until