Re: [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay

2011-09-06 Thread Chunhe Lan
On Thu, 01 Sep 2011 12:42:08 +0800, Kumar Gala kumar.g...@freescale.com wrote: On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote: The mmc_delay() is a wrapper function for mdelay() and msleep(). o mdelay() -- block the system when busy-waiting. o msleep() -- suspend the currently

RE: [PATCH 2/2] mmc: core: Add poweroff notify handling feature

2011-09-06 Thread Seungwon Jeon
Hi Girish K S, I think short type is proper rather than long type by default. Long type seems to be unacceptable in suspend regarding long timeout. One question, Is this patch considered for system power off besides suspend? Beset regards, Seungwon Jeon. Girish K S wrote: Hi Mr Park, On 5

Re: [PATCH 2/2] mmc: core: Add poweroff notify handling feature

2011-09-06 Thread Girish K S
Hello Mr Jeon, i have modified the patch to handle the poweroff in suspend and normal condition. during suspend it is be short and during normal poweroff it is long. I will update the V2 patch with Mr Parks changes updated. regards Girish K S On 6 September 2011 12:31, Seungwon Jeon

[PATCH v2 0/2] PowerOff Notify/handle feature eMMC 4.5

2011-09-06 Thread Girish K S
This set of patch implements the PowerOff notification feature for eMMC 4.5 devices. Girish K S (2): mmc: core: Add power off notify feature(eMMC 4.5) mmc: core: Add Poweroff Notify handling drivers/mmc/core/core.c | 33 + drivers/mmc/core/mmc.c | 21

[PATCH v2 1/2] mmc: core: Add power off notify feature(eMMC 4.5)

2011-09-06 Thread Girish K S
This patch adds the support for power off notify feature available in eMMC 4.5 devices. If the the host has support for this feature, then the mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON).

[PATCH v2 2/2] mmc: core: Add Poweroff Notify handling

2011-09-06 Thread Girish K S
This patch adds the power off notification handling during suspend and system poweroff. For suspend mode short timeout is used, whereas for the normal poweroff long timeout is used. Signed-off-by: Girish K S girish.shivananja...@linaro.org --- drivers/mmc/core/core.c | 33

RE: [PATCH v2 2/2] mmc: core: Add Poweroff Notify handling

2011-09-06 Thread Seungwon Jeon
Hi Girish, In case of system poweroff, mmc_power_off can be called indeed? And I added some comments. Best regards, Seungwon Jeon. Girish K S wrote: This patch adds the power off notification handling during suspend and system poweroff. For suspend mode short timeout is used, whereas for

Re: [PATCH v2 2/2] mmc: core: Add Poweroff Notify handling

2011-09-06 Thread Girish K S
Hi Jeon, Thanks for the review. On 6 September 2011 17:22, Seungwon Jeon tgih@samsung.com wrote: Hi Girish, In case of system poweroff, mmc_power_off can be called indeed? And I added some comments. Best regards, Seungwon Jeon. Girish K S wrote: This patch adds the power off

Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-06 Thread Kishore Kadiyala
On Fri, Sep 2, 2011 at 12:35 AM, Venkatraman S svenk...@ti.com wrote: Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a single location in post_req function, to prevent double unmapping. Signed-off-by: Venkatraman S

Re: [PATCH v2 2/2] mmc: core: Add Poweroff Notify handling

2011-09-06 Thread Kyungmin Park
On Tue, Sep 6, 2011 at 7:59 PM, Girish K S girish.shivananja...@linaro.org wrote: This patch adds the power off notification handling during suspend and system poweroff. For suspend mode short timeout is used, whereas for the normal poweroff long timeout is used. Signed-off-by: Girish K S

Re: [PATCH v2 2/2] mmc: core: Add Poweroff Notify handling

2011-09-06 Thread Girish K S
On 7 September 2011 07:19, Kyungmin Park kmp...@infradead.org wrote: On Tue, Sep 6, 2011 at 7:59 PM, Girish K S girish.shivananja...@linaro.org wrote: This patch adds the power off notification handling during suspend and system poweroff. For suspend mode short timeout is used, whereas for