Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
On 14 September 2011 01:37, Akinobu Mita wrote: > 2011/9/14 Per Forlin : >> Hi Akinobu, >> >> On 13 September 2011 16:19, Per Forlin wrote: >>> On 13 September 2011 15:12, Akinobu Mita wrote: 2011/8/19 Per Forlin : > +#ifdef KERNEL > +/* > + * Internal function. Pass the bo

Re: [PATCH] mmc: sdhci-pxa: Check pdata before using its members

2011-09-13 Thread zhangfei gao
On Wed, Sep 14, 2011 at 1:59 PM, Tanmay Upadhyay wrote: > Signed-off-by: Tanmay Upadhyay Acked-by: Zhangfei Gao Thanks > --- >  drivers/mmc/host/sdhci-pxav2.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-mmc"

[PATCH] mmc: sdhci-pxa: Check pdata before using its members

2011-09-13 Thread Tanmay Upadhyay
Signed-off-by: Tanmay Upadhyay --- drivers/mmc/host/sdhci-pxav2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2.c index 38f5899..1114fe2 100644 --- a/drivers/mmc/host/sdhci-pxav2.c +++ b/drivers/mmc/host/s

RE: [PATCH] mmc: core: Fix the incorrect calculation for erase unit size.

2011-09-13 Thread Seungwon Jeon
Chris Ball wrote: > > Hi, > > On Tue, Sep 13 2011, Seungwon Jeon wrote: > >> On Thu, Sep 08 2011, Seungwon Jeon wrote: > >> > Erase unit size of high capacity is multiple of 512KiB not 1024KiB. > >> > >> Could we have some more info, please? What are the visible symptoms > >> of the erase unit s

Re: [PATCH] mmc: core: Fix the incorrect calculation for erase unit size.

2011-09-13 Thread Chris Ball
Hi, On Tue, Sep 13 2011, Seungwon Jeon wrote: >> On Thu, Sep 08 2011, Seungwon Jeon wrote: >> > Erase unit size of high capacity is multiple of 512KiB not 1024KiB. >> >> Could we have some more info, please? What are the visible symptoms >> of the erase unit size being incorrect, how did you rea

RE: [PATCH] mmc: core: Fix the incorrect calculation for erase unit size.

2011-09-13 Thread Seungwon Jeon
Chris Ball wrote: > > Hi, > > On Thu, Sep 08 2011, Seungwon Jeon wrote: > > Erase unit size of high capacity is multiple of 512KiB not 1024KiB. > > Could we have some more info, please? What are the visible symptoms > of the erase unit size being incorrect, how did you realize this was > a prob

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Akinobu Mita
2011/9/14 Per Forlin : > Hi Akinobu, > > On 13 September 2011 16:19, Per Forlin wrote: >> On 13 September 2011 15:12, Akinobu Mita wrote: >>> 2011/8/19 Per Forlin : >>> +#ifdef KERNEL +/* + * Internal function. Pass the boot param fail_mmc_request to + * the setup fault inject

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Jeremy Fitzhardinge
[ Re-added Cc:s ] On 09/13/2011 02:48 PM, Philip Rakity wrote: > cool -- rules out ALL sdhci 3.0 changes. > > > next step > > in sdhci.c -- look for -E (case matters) > > will show where errors are detected. > > add > > sdhci_dumpregs(host); > > so we can see the registers when the

[PATCH 3/3] fault-injection: update documenation with the mmc module param

2011-09-13 Thread Per Forlin
Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index 70f924e..ba4be8b 100644 --- a/Docu

[PATCH 2/3] mmc: add module param to set fault injection attributes

2011-09-13 Thread Per Forlin
Replace setup("fail_mmc_request") and faulty "ifdef KERNEL" with a simple module_param(). The module param mmc_core.fail_request may be used to set the fault injection attributes during boot time or module load time. Signed-off-by: Per Forlin --- drivers/mmc/core/debugfs.c | 29 +++

[PATCH 1/3] fault-inject: export setup_fault_attr()

2011-09-13 Thread Per Forlin
mmc_core module needs to use setup_fault_attr() in order to set fault injection attributes during module load time. Signed-off-by: Per Forlin --- lib/fault-inject.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 328d433..4

[PATCH 0/3] mmc: rectify boot param option for fault injection

2011-09-13 Thread Per Forlin
Akinobu Mita reported that the boot option for mmc fault injection is never compiled in due to a fauly "ifdef KERNEL" that is never set. A correct ifdef would be "ifndef MODULE". Akinobu suggested to use a module param instead. This patch set is for 3.2 Per Forlin (3): fault-inject: export setu

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Jeremy Fitzhardinge
On 09/13/2011 01:27 PM, Jeremy Fitzhardinge wrote: > I have 1.17 installed at the moment. It looks like 1.21 is current, so > I could try updating it. But the Fedora 15 2.6.38 kernel worked fine > with this controller and cards, so I don't think BIOS version is an > issue. Also, there's nothing

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Philip Rakity
What card are you using ? On Sep 13, 2011, at 1:27 PM, Jeremy Fitzhardinge wrote: > On 09/13/2011 12:29 PM, Manoj Iyer wrote: >> >> @Jeremy, Could the problem be BIOS related? we have seen a number of >> issues with older bioses on the x220s. > > I have 1.17 installed at the moment. It looks

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Jeremy Fitzhardinge
On 09/13/2011 12:29 PM, Manoj Iyer wrote: > > @Jeremy, Could the problem be BIOS related? we have seen a number of > issues with older bioses on the x220s. I have 1.17 installed at the moment. It looks like 1.21 is current, so I could try updating it. But the Fedora 15 2.6.38 kernel worked fine

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Jeremy Fitzhardinge
On 09/13/2011 11:49 AM, Chris Ball wrote: > I just asked Matthew Garrett to check his X220, and his has the same e823 > controller as you, is running a 3.1-rc kernel, and everything's working. > > So it's not even variation in the controller model, it's something even > more subtle. Perhaps try so

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Manoj Iyer
@Jeremy, Could the problem be BIOS related? we have seen a number of issues with older bioses on the x220s. Here are a few cards I tested with the 3.1 RC4 kernel on Ubuntu running on a Lenovo X220. with Ricoh e823 card reader. == kernel version == Linux u 3.1.0-0301rc4-generic #201108290905 S

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Chris Ball
Hi, On Tue, Sep 13 2011, Jeremy Fitzhardinge wrote: >> If it is running, and not helping, can I persuade you to try a full >> bisection? > > OK, will do. Thank you! >> I don't think we have other reports of this bug, and the >> only other person who has reported something like it wasn't a kern

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Jeremy Fitzhardinge
On 09/13/2011 10:12 AM, Chris Ball wrote: > Hi Jeremy, > > On Tue, Sep 13 2011, Jeremy Fitzhardinge wrote: >>> On Mon, Sep 12 2011, Jeremy Fitzhardinge wrote: Since 2.6.39, the SD card slot in my Lenovo X220 has stopped working. When I insert a card with current linux.git kernel (3.1-rc

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Chris Ball
Hi Jeremy, On Tue, Sep 13 2011, Jeremy Fitzhardinge wrote: >> On Mon, Sep 12 2011, Jeremy Fitzhardinge wrote: >>> Since 2.6.39, the SD card slot in my Lenovo X220 has stopped working. >>> When I insert a card with current linux.git kernel (3.1-rc6), I get: >>> >>> [ 3891.745549] mmc0: new SDHC c

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Jeremy Fitzhardinge
On 09/13/2011 06:22 AM, Chris Ball wrote: > Hi Jeremy, > > On Mon, Sep 12 2011, Jeremy Fitzhardinge wrote: >> Since 2.6.39, the SD card slot in my Lenovo X220 has stopped working. >> When I insert a card with current linux.git kernel (3.1-rc6), I get: >> >> [ 3891.745549] mmc0: new SDHC card at a

Re: [RFC PATCH] mmc: sdio: rw extended, use a sg entry for each block

2011-09-13 Thread Nicolas Ferre
Le 07/09/2011 13:40, Nicolas Ferre : > While using io multiple blocks operations, change the way that sg is built: > use one sg entry for each block instead of aggregating the whole buffer > in a single sg entry. > Using a single sg entry for a multiple block command may lead to > misunderstanding

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
Hi Akinobu, On 13 September 2011 16:19, Per Forlin wrote: > On 13 September 2011 15:12, Akinobu Mita wrote: >> 2011/8/19 Per Forlin : >> >>> +#ifdef KERNEL >>> +/* >>> + * Internal function. Pass the boot param fail_mmc_request to >>> + * the setup fault injection attributes routine. >>> + */ >>

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
On 13 September 2011 15:12, Akinobu Mita wrote: > 2011/8/19 Per Forlin : > >> +#ifdef KERNEL >> +/* >> + * Internal function. Pass the boot param fail_mmc_request to >> + * the setup fault injection attributes routine. >> + */ >> +static int __init setup_fail_mmc_request(char *str) >> +{ >> +    

Re: SDHCI regression since 2.6.39

2011-09-13 Thread Chris Ball
Hi Jeremy, On Mon, Sep 12 2011, Jeremy Fitzhardinge wrote: > Since 2.6.39, the SD card slot in my Lenovo X220 has stopped working. > When I insert a card with current linux.git kernel (3.1-rc6), I get: > > [ 3891.745549] mmc0: new SDHC card at address b368 > [ 3891.790704] mmcblk0: mmc0:b368 PNY

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Akinobu Mita
2011/8/19 Per Forlin : > +#ifdef KERNEL > +/* > + * Internal function. Pass the boot param fail_mmc_request to > + * the setup fault injection attributes routine. > + */ > +static int __init setup_fail_mmc_request(char *str) > +{ > +       return setup_fault_attr(&fail_mmc_request, str); > +} > +_

[PATCH] mmc: Fix hangs related to insert/remove of cards

2011-09-13 Thread Ulf Hansson
During a rescan operation mmc_attach(sd|mmc|sdio) functions are called. The error handling in these function can trigger a detach of the bus, which also meant a power off. This is not notified by the rescan operation which then continues to the next attach function. If a power off has been done, t

[PATCH V5 2/2] mmc: core: Add Poweroff Notify handling eMMC 4.5

2011-09-13 Thread Girish K S
This patch adds the power off notification handling during suspend and system poweroff. For suspend mode short timeout is used, whereas for the normal poweroff long timeout is used. Signed-off-by: Girish K S --- drivers/mmc/core/core.c | 34 ++ drivers/mmc/core

[PATCH V5 1/2] mmc: core: Add power off notify feature(eMMC 4.5)

2011-09-13 Thread Girish K S
This patch adds the support for power off notify feature available in eMMC 4.5 devices. If the the host has support for this feature, then the mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON). This

[PATCH V5 0/2] Poweroff Notify eMMC 4.5

2011-09-13 Thread Girish K S
This patch version fixes the problem with power off notify function, when called for the first time and card is not yet initialised. Earlier version will generate a core dump, so a check for NULL is required in the power off function. Girish K S (2): mmc: core: Add power off notify feature(eMM

[PATCH] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-13 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th

Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-13 Thread S, Venkatraman
On Tue, Sep 13, 2011 at 1:26 AM, Per Forlin wrote: > On 1 September 2011 21:05, Venkatraman S wrote: >> Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in >> omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a >> single location in post_req function, to prevent double unm