Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-14 Thread Per Forlin
On 14 September 2011 15:40, S, Venkatraman wrote: > On Tue, Sep 13, 2011 at 1:26 AM, Per Forlin wrote: >> On 1 September 2011 21:05, Venkatraman S wrote: >>> Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in >>> omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a >>> si

Re: SDHCI regression since 2.6.39

2011-09-14 Thread Jeremy Fitzhardinge
On 09/14/2011 11:38 AM, Chris Ball wrote: > Hi, > > On Wed, Sep 14 2011, Jeremy Fitzhardinge wrote: >> I powered it off with battery unplugged for about an hour, and rebooted >> into the known-working kernel, making sure that any fancy power mgmt >> features were disabled (like aspm), but it still

Re: SDHCI regression since 2.6.39

2011-09-14 Thread Chris Ball
Hi, On Wed, Sep 14 2011, Jeremy Fitzhardinge wrote: > I powered it off with battery unplugged for about an hour, and rebooted > into the known-working kernel, making sure that any fancy power mgmt > features were disabled (like aspm), but it still failed in the same way. > > I'm wondering if it's

Re: SDHCI regression since 2.6.39

2011-09-14 Thread Jeremy Fitzhardinge
On 09/14/2011 06:48 AM, Chris Ball wrote: > Long shot, but did you try removing power completely between the > reboots? I wonder if the PCI config space write patch could be (a) > bogus for your device, and (b) preserved across warm reboot by your > PCI hardware. So, you could just try removing the

Re: SDHCI regression since 2.6.39

2011-09-14 Thread Chris Ball
Hi Jeremy, On Tue, Sep 13 2011, Jeremy Fitzhardinge wrote: > Very strange. I reinstalled the original 2.6.38-based F15 kernel > (kernel-2.6.38.6-26.rc1.fc15.x86_64) which I'm sure did work, and it is > failing in the same way. So I guess some BIOS setting changed, or the > hardware itself has di

Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-14 Thread S, Venkatraman
On Tue, Sep 13, 2011 at 1:26 AM, Per Forlin wrote: > On 1 September 2011 21:05, Venkatraman S wrote: >> Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in >> omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a >> single location in post_req function, to prevent double unm

[PATCH v3 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
Replace setup("fail_mmc_request") and faulty "ifdef KERNEL" with a module_param_cb(). The module param mmc_core.fail_request may be used to set the fault injection attributes during boot time or module load time. Signed-off-by: Per Forlin --- drivers/mmc/core/debugfs.c | 38 +++

[PATCH v3 3/3] fault-injection: update documentation with the mmc module param

2011-09-14 Thread Per Forlin
Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index 70f924e..ba4be8b 100644 --- a/Docu

[PATCH v3 1/3] fault-inject: export setup_fault_attr()

2011-09-14 Thread Per Forlin
mmc_core module needs to use setup_fault_attr() in order to set fault injection attributes during module load time. Signed-off-by: Per Forlin --- lib/fault-inject.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 328d433..4

[PATCH v3 0/3] mmc: rectify boot param option for fault injection

2011-09-14 Thread Per Forlin
Akinobu Mita reported that the boot option for mmc fault injection is never compiled in due to a fauly "ifdef KERNEL" that is never set. A correct ifdef would be "ifndef MODULE". This patch set adds a module_param_cb() and thereby no ifndef MODULE is needed. Using a module_param makes it possible t

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Akinobu Mita
2011/9/14 Per Forlin : +static int fail_mmc_request_param_set(const char *val, +                                     const struct kernel_param *kp) +{ +       setup_fault_attr(&fail_default_attr, (char *) val); > I am thinking of returning failure here if setup_fault_attr() fai

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
On 14 September 2011 12:38, Per Forlin wrote: > On 14 September 2011 12:18, Per Forlin wrote: >> On 14 September 2011 12:05, Akinobu Mita wrote: >>> 2011/9/14 Per Forlin : >>> +#ifdef CONFIG_FAIL_MMC_REQUEST + +static DECLARE_FAULT_ATTR(fail_default_attr); +static char *fail_

[PATCH V1] Power Class Selection Feature

2011-09-14 Thread Girish K S
This patch version modifies the power_class_select function prototype. During device enumeration, when the host tries to read the extended csd register after switching to higher bus width, the read fails at higher bus width. So the power_class_select function is modified to reuse the extended csd

[PATCH V1] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-14 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
On 14 September 2011 12:18, Per Forlin wrote: > On 14 September 2011 12:05, Akinobu Mita wrote: >> 2011/9/14 Per Forlin : >> >>> +#ifdef CONFIG_FAIL_MMC_REQUEST >>> + >>> +static DECLARE_FAULT_ATTR(fail_default_attr); >>> +static char *fail_request; >> >> This is not used anymore and ... >> > Yes

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
On 14 September 2011 12:05, Akinobu Mita wrote: > 2011/9/14 Per Forlin : > >> +#ifdef CONFIG_FAIL_MMC_REQUEST >> + >> +static DECLARE_FAULT_ATTR(fail_default_attr); >> +static char *fail_request; > > This is not used anymore and ... > Yes of course. Will remove it. >> +static int fail_mmc_request

Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Akinobu Mita
2011/9/14 Per Forlin : > +#ifdef CONFIG_FAIL_MMC_REQUEST > + > +static DECLARE_FAULT_ATTR(fail_default_attr); > +static char *fail_request; This is not used anymore and ... > +static int fail_mmc_request_param_set(const char *val, > +                                     const struct kernel_param

[PATCH v2 3/3] fault-injection: update documentation with the mmc module param

2011-09-14 Thread Per Forlin
Signed-off-by: Per Forlin --- Documentation/fault-injection/fault-injection.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index 70f924e..ba4be8b 100644 --- a/Docu

[PATCH v2 1/3] fault-inject: export setup_fault_attr()

2011-09-14 Thread Per Forlin
mmc_core module needs to use setup_fault_attr() in order to set fault injection attributes during module load time. Signed-off-by: Per Forlin --- lib/fault-inject.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 328d433..4

[PATCH v2 2/3] mmc: add module param to set fault injection attributes

2011-09-14 Thread Per Forlin
Replace setup("fail_mmc_request") and faulty "ifdef KERNEL" with a module_param_cb(). The module param mmc_core.fail_request may be used to set the fault injection attributes during boot time or module load time. Signed-off-by: Per Forlin --- drivers/mmc/core/debugfs.c | 38 +++

[PATCH v2 0/3] mmc: rectify boot param option for fault injection

2011-09-14 Thread Per Forlin
Akinobu Mita reported that the boot option for mmc fault injection is never compiled in due to a fauly "ifdef KERNEL" that is never set. A correct ifdef would be "ifndef MODULE". This patch set adds a module_param_cb() and thereby no ifndef MODULE is needed. Using a module_param makes it possible t

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-14 Thread Per Forlin
On 14 September 2011 10:04, Akinobu Mita wrote: > 2011/9/14 Per Forlin : > >> It's simple and the patch would be just two lines. >> The reason for changing my mind is that it may be useful to be able to >> pass the fault injection attributes even when mmc_core is a module. >> >>> module_param is m

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-14 Thread Akinobu Mita
2011/9/14 Per Forlin : > It's simple and the patch would be just two lines. > The reason for changing my mind is that it may be useful to be able to > pass the fault injection attributes even when mmc_core is a module. > >> module_param is more complicated than this. Also the parameter is only >>

Testing Drivers

2011-09-14 Thread Shashidhar Hiremath
Is the rc4 version stable enough to test my driver ? -- regards, Shashidhar Hiremath -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] arm: samsung: remove sdhci default configuration setup platform helper

2011-09-14 Thread Thomas Abraham
The sdhci platform helper function that sets up the default controller configuration is removed for all Samsung platforms since such default controller configuration can be handled by the driver. Cc: Ben Dooks Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos4/setup-sdhci.c| 47 -

[PATCH v2 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-14 Thread Thomas Abraham
The default controller configuration which was previously setup by platform helper functions is moved into the driver. Cc: Ben Dooks Signed-off-by: Thomas Abraham --- drivers/mmc/host/sdhci-s3c.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git

[PATCH v2 0/2] Move sdhci-s3c platform helper into driver

2011-09-14 Thread Thomas Abraham
Changes since v1: - Rebased with 'for-next' branch of http://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git (tested with commit id a08b7e19811181309da2306338027fe1d3f8001d at the tip of the for-next branch, not sure if there have been further commits after that). The platf