Re: slow eMMC write speed

2011-09-27 Thread Linus Walleij
On Fri, Sep 23, 2011 at 7:05 AM, Praveen G K wrote: > I am working on the block driver module of the eMMC driver (SDIO 3.0 > controller).  I am seeing very low write speed for eMMC transfers.  On > further debugging, I observed that every 63rd and 64th transfer takes > a long time. Are you not j

Re: [PATCH 3/3] mmc: mmci: Change vdd_handler to a generic ios_handler

2011-09-27 Thread Linus Walleij
On Tue, Sep 27, 2011 at 1:42 PM, Ulf Hansson wrote: > The purpose of the vdd_handler does not make sense. We remove it > and use a generic approach instead. A new ios_handler is added, the > purpose of which e.g. can be to control GPIO pins to a levelshifter. > > Previously the vdd_handler was al

Re: [PATCH 2/3] mmc: mmci: Provide option to configure bus signal direction

2011-09-27 Thread Linus Walleij
On Tue, Sep 27, 2011 at 1:42 PM, Ulf Hansson wrote: > @@ -30,6 +43,8 @@ struct dma_chan; >  * @cd_invert: true if the gpio_cd pin value is active low >  * @capabilities: the capabilities of the block as implemented in >  * this platform, signify anything MMC_CAP_* from mmc/host.h > + * @sigdir: a

Re: [PATCH 1/3] mmc: mmci: Put power register deviations in variant data

2011-09-27 Thread Linus Walleij
On Tue, Sep 27, 2011 at 1:42 PM, Ulf Hansson wrote: > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > index 4da20ec..32de82b 100644 > --- a/drivers/mmc/host/mmci.c > +++ b/drivers/mmc/host/mmci.c > @@ -53,6 +53,7 @@ static unsigned int fmax = 515633; >  * @st_clkdiv: true if usin

Re: [PATCH 0/4] mmc: mmci: Improvements and bugfixes for SDIO

2011-09-27 Thread Linus Walleij
On Tue, Sep 27, 2011 at 9:45 AM, Ulf Hansson wrote: > This patchserie fixes a couple of SDIO related issues for the mmci host > driver. The intention is to keep each patch small and to have one patch > for one problem. It might makes sence to squash some of the patches, but > I leave this for dis

[PATCH V2] mmc: core: HS200 mode support for eMMC 4.5

2011-09-27 Thread Girish K S
This patch adds the support of the HS200 bus speed for eMMC 4.5 devices. The eMMC 4.5 devices have support for 200MHz bus speed. The mmc core and host modules have been touched to add support for this module. It is necessary to know the card type in the sdhci.c file to add support for eMMC tuning f

RE: [PATCH] mmc: dw_mmc: Support predefined multiple block transfers.

2011-09-27 Thread Seungwon Jeon
This is a duplicate patch from our security machine. Please ignore this resending. Best regards, Seungwon Jeon. > > This patch adds the support for predefined multiple block read/write. > > Signed-off-by: Seungwon Jeon > --- > drivers/mmc/host/dw_mmc.c | 32 ++--

Re: [PATCH v2] mmc : general purpose partition support.

2011-09-27 Thread NamJae Jeon
2011/9/27 J Freyensee : > On 09/23/2011 10:07 PM, Namjae Jeon wrote: >> >> It allows gerneral purpose partitions in MMC Device. >> And I try to simpliy make mmc_blk_alloc_parts using mmc_part structure >> suggested by Andrei Warkentin. >> After patching, we can see general purpose partitions like t

[PATCH] mmc: dw_mmc: Support predefined multiple block transfers.

2011-09-27 Thread Seungwon Jeon
This patch adds the support for predefined multiple block read/write. Signed-off-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc.c | 32 ++-- 1 files changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 0e

[PATCH 3/3] mmc: mmci: Change vdd_handler to a generic ios_handler

2011-09-27 Thread Ulf Hansson
The purpose of the vdd_handler does not make sense. We remove it and use a generic approach instead. A new ios_handler is added, the purpose of which e.g. can be to control GPIO pins to a levelshifter. Previously the vdd_handler was also used for making additional changes to the power register bit

[PATCH 2/3] mmc: mmci: Provide option to configure bus signal direction

2011-09-27 Thread Ulf Hansson
The ST Micro variant supports bus signal direction indication. A new member in the variant struct is added for this. Moreover the actual signal direction configuration is board specific, thus the amba mmci platform data is extended with a new member to be able provide mmci with these specific boar

[PATCH 0/3] Clearify code paths for how to modify the power register

2011-09-27 Thread Ulf Hansson
In the set_ios function there has been a mess of how the power register can be modified. One part, especially strange was related to the use of the vdd_handler. Note that this patch serie is formated based upon the previously submitted patch serie for mmci called "mmc: mmci: Improvements and bugf

[PATCH 1/3] mmc: mmci: Put power register deviations in variant data

2011-09-27 Thread Ulf Hansson
From: Sebastian Rasmussen Use variant data to store hardware controller deviations concerning power registers to improve readability of the code. Signed-off-by: Sebastian Rasmussen Signed-off-by: Ulf Hansson Reviewed-by: Linus Walleij --- drivers/mmc/host/mmci.c | 22 +-

[PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-09-27 Thread Shashidhar Hiremath
This Patch adds the support for Dual Buffer Descriptor mode of Operation for the dw_mmc driver.The patch also provides the configurability Option for choosing DUAL_BUFFER mode or the chained modes through menuconfig. The Menuconfig option for selecting Dual Buffer mode or chained mode is selected o

[PATCH] leds-class: change back LEDS_CLASS to tristate instead of bool

2011-09-27 Thread Bryan Wu
LEDS_CLASS is required by leds and trigger drivers, but we can build it as module. So change this option back as tristate and treak the help message as well. LEDS_TRIGGERS depends on LEDS_CLASSS, which should be tristate. So set it as tristate too and update header files as well. Change those i

[PATCH 3/4] mmc: mmci: Prepare for SDIO before setting up DMA job

2011-09-27 Thread Ulf Hansson
Move the SDIO preparation to be done before the DMA job is setup. This makes it possible to do DMA for SDIO transfers as well as the earlier supported pio mode. Signed-off-by: Ulf Hansson Signed-off-by: Stefan Nilsson XK --- drivers/mmc/host/mmci.c | 10 +- 1 files changed, 5 insertio

[PATCH 4/4] mmc: mmci: Fix incorrect handling of HW flow control for SDIO

2011-09-27 Thread Ulf Hansson
From: Stefan Nilsson XK For data writes smaller <= 8 bytes (only SDIO case), HW flow control was disabled but never re-enabled again. This meant that a following large read request would randomly give buffer overrun errors. Moreover HW flow control is not needed for transfers that fits in the FI

[PATCH 2/4] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2011-09-27 Thread Ulf Hansson
From: Stefan Nilsson XK For the ux500v2 variant of the PL18x block, non power of two block sizes are supported. This will make it possible to decrease data overhead for SDIO transfers. Signed-off-by: Stefan Nilsson XK Signed-off-by: Ulf Hansson --- drivers/mmc/host/mmci.c |9 +++-- 1

[PATCH 1/4] mmc: mmci: Bugfix in pio read for small packets

2011-09-27 Thread Ulf Hansson
From: Stefan Nilsson XK Corrects a bug in pio read when reading packets < 4 bytes. These small packets are only relevant for SDIO transfers. Signed-off-by: Ulf Hansson Signed-off-by: Stefan Nilsson XK --- drivers/mmc/host/mmci.c | 19 ++- 1 files changed, 18 insertions(+), 1

[PATCH 0/4] mmc: mmci: Improvements and bugfixes for SDIO

2011-09-27 Thread Ulf Hansson
This patchserie fixes a couple of SDIO related issues for the mmci host driver. The intention is to keep each patch small and to have one patch for one problem. It might makes sence to squash some of the patches, but I leave this for discussion. Stefan Nilsson XK (3): mmc: mmci: Bugfix in pio re