Re: [PATCH] drivers: mmc: sdhci-s3c: fix broken compilation for non-Exynos SoCs

2012-03-11 Thread Jaehoon Chung
Looks fine to me. Acked-by: Jaehoon Chung On 03/09/2012 10:44 PM, Marek Szyprowski wrote: > exynos4_sdhci_drv_data structure is not available on non-Exynos builds, > that's why EXYNOS4_SDHCI_DRV_DATA macro has been introduced. This patch > fixes commit 67819656 'mmc: sdhci-s3c: Add device tree

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-03-11 Thread Jaehoon Chung
On 03/12/2012 01:06 AM, Konstantin Dorfman wrote: > Hello Jaehoon, > > On Fri, January 20, 2012 8:48 am, Jaehoon Chung wrote: > ... >> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c >> index 4d41fa9..109d0f0 100644 >> --- a/drivers/mmc/core/mmc_ops.c >> +++ b/drivers/mmc/cor

[PATCH v2] mmc: core: add the warning message when card didn't support HPI

2012-03-11 Thread Jaehoon Chung
Though card didn't support HPI,someone could use the send_hpi_cmd(). Then maybe didn't work fine. Because card->ext_csd.hpi_cmd didn't set. So if card didn't support hpi, return the waring message. And CMD12's flags is MMC_RSP_R1B. Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park --- C

[PATCH REPOST 2/2] mmc: davinci: Poll status for small size transfers

2012-03-11 Thread Ido Yariv
For small size non-dma sdio transactions, it is sometimes better to poll the mmc host and avoid interrupts altogether. Polling lowers the number of interrupts and context switches. Tests have shown that for small transactions, only a few polling iterations are needed, so this is worth while. Signe

[PATCH REPOST 1/2] mmc: davinci: Eliminate spurious interrupts

2012-03-11 Thread Ido Yariv
The davinci mmc interrupt handler fills the fifo, as long as the DXRDY or DRRDY bits are set in the status register. If interrupts fire during this loop, they will be handled by the handler, but the interrupt controller will still buffer these. As a result, the handler will be called again to serv

RE: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-03-11 Thread merez
> Maya Erez wrote: >> > Hi. Merez. >> > >> > Thanks a lot about your performance measurement. >> > >> > I think that your measurement is enough and correct and the firmware >> > of mmc vender should be optimized or change properly rather than >> > modifying the current patch. >> > >> > And current

Re: [PATCH v7] mmc: support BKOPS feature for eMMC

2012-03-11 Thread Konstantin Dorfman
Hello Jaehoon, On Fri, January 20, 2012 8:48 am, Jaehoon Chung wrote: ... > diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c > index 4d41fa9..109d0f0 100644 > --- a/drivers/mmc/core/mmc_ops.c > +++ b/drivers/mmc/core/mmc_ops.c > @@ -392,13 +392,22 @@ int mmc_switch(struct mmc_c