Re: [PATCH] mmc: omap_hsmmc: release correct resource

2012-04-17 Thread S, Venkatraman
On Sat, Apr 14, 2012 at 7:11 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: res can be one of several resources, as this variable is re-used several times during probe.  This can cause the wrong resource parameters to be passed to release_mem_region(). Get the original memory

Re: [PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

2012-04-17 Thread Guennadi Liakhovetski
Hi Hartley Thanks for the patch. On Mon, 16 Apr 2012, H Hartley Sweeten wrote: Include the linux/mmc/cd-gpio.h header to pickup the prototypes for the two exported symbols. This quiets the sparse warnings: warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?

Re: [PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

2012-04-17 Thread S, Venkatraman
On Tue, Apr 17, 2012 at 6:54 AM, H Hartley Sweeten hartl...@visionengravers.com wrote: Include the linux/mmc/cd-gpio.h header to pickup the prototypes for the two exported symbols. This quiets the sparse warnings: warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?

[PATCH] mmc: omap_hsmmc: Fix check for mmc dt node

2012-04-17 Thread Jassi Brar
Proper check should be if the hsmmc driver got its platform_data via devicetree, and not if the devicetree is populated for the platform. Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- The patch is more than a nit-pick because upstream doesn't yet have dt nodes for mmc on OMAP while

Re: [PATCH] mmc: omap_hsmmc: Fix check for mmc dt node

2012-04-17 Thread T Krishnamoorthy, Balaji
On Tue, Apr 17, 2012 at 3:24 PM, Jassi Brar jaswinder.si...@linaro.org wrote: Proper check should be if the hsmmc driver got its platform_data via devicetree, and not if the devicetree is populated for the platform. Signed-off-by: Jassi Brar jaswinder.si...@linaro.org Hi, Similar patch by

Re: [PATCH] mmc: omap_hsmmc: Fix check for mmc dt node

2012-04-17 Thread Rajendra Nayak
On Tuesday 17 April 2012 03:24 PM, Jassi Brar wrote: Proper check should be if the hsmmc driver got its platform_data via devicetree, and not if the devicetree is populated for the platform. This one is already fixed here.. http://www.spinics.net/lists/linux-omap/msg67879.html

Re: [PATCH] mmc: omap_hsmmc: Fix check for mmc dt node

2012-04-17 Thread Jassi Brar
On 17 April 2012 15:41, T Krishnamoorthy, Balaji balaj...@ti.com wrote: The patch is more than a nit-pick because upstream doesn't yet have dt nodes for mmc on OMAP while the driver wrongly assumes it does. Which isn't a problem until you use some low-end sdhc card (Transcend 8GB Class-4 in

Re: [PATCH] mmc: omap_hsmmc: Fix check for mmc dt node

2012-04-17 Thread Jassi Brar
On 17 April 2012 15:41, Rajendra Nayak rna...@ti.com wrote: On Tuesday 17 April 2012 03:24 PM, Jassi Brar wrote: Proper check should be if the hsmmc driver got its platform_data via devicetree, and not if the devicetree is populated for the platform. This one is already fixed here..

RE: [PATCH] mmc: sdhci-spear: Add clk_{un}prepare() support

2012-04-17 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Viresh Kumar Sent: Tuesday, April 17, 2012 3:14 PM To: c...@laptop.org Cc: linux-mmc@vger.kernel.org; spear-de...@list.st.com; viresh.li...@gmail.com; Viresh Kumar

Re: [PATCH] mmc: sdhci-spear: Add clk_{un}prepare() support

2012-04-17 Thread Viresh Kumar
On 4/17/2012 4:32 PM, Subhash Jadavani wrote: It's better to use clk_prepare_enable() helper function if you are doing enable immediately after prepare. Sure. Will fix it. -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to

[PATCH V2] mmc: sdhci-spear: Add clk_{un}prepare() support

2012-04-17 Thread Viresh Kumar
clk_{un}prepare is mandatory for platforms using common clock framework. Since this driver is used by SPEAr platform, which supports common clock framework, add clk_{un}prepare() support for it. Signed-off-by: Viresh Kumar viresh.ku...@st.com --- V1-V2: - Use clk_prepare_enable and

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-17 Thread S, Venkatraman
On Sun, Apr 15, 2012 at 8:40 PM, Jae hoon Chung jh80.ch...@gmail.com wrote: Hi Venkatraman 2012/4/14 Namjae Jeon linkinj...@gmail.com: 2012/4/14 S, Venkatraman svenk...@ti.com: On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon linkinj...@gmail.com wrote: Hi. Venkatraman. You fixed 10 times. why

[PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Venkatraman S
mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at the end

Re: [PATCH] mmc: sdhci: refine non-removable card checking for card detection

2012-04-17 Thread Daniel Drake
Hi, On Tue, Apr 10, 2012 at 2:05 AM, Sascha Silbe si...@activitycentral.com wrote: What exactly is the behaviour after this patch? Will systems running from SD cards attached to a host controller that's _not_ marked as MMC_CAP_NONREMOVABLE (e.g. the external SD card slot on XOs) work again?

[PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

2012-04-17 Thread H Hartley Sweeten
Include the linux/mmc/cd-gpio.h header to pickup the prototypes for the two exported symbols. This quiets the sparse warnings: warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static? warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static? Signed-off-by: H

Re: [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

2012-04-17 Thread Guennadi Liakhovetski
On Tue, 17 Apr 2012, H Hartley Sweeten wrote: Include the linux/mmc/cd-gpio.h header to pickup the prototypes for the two exported symbols. This quiets the sparse warnings: warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static? warning: symbol 'mmc_cd_gpio_free' was

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Namjae Jeon
2012/4/17 Venkatraman S svenk...@ti.com: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by

[PATCH] mmc: unbreak sdhci-esdhc-imx on i.MX25

2012-04-17 Thread Eric Bénard
this was broken by me in 37865fe91582582a6f6c00652f6a2b1ff71f8a78 mmc: sdhci-esdhc-imx: fix timeout on i.MX's sdhc where more extensive tests would have shown that read or write of data to the card were failing (even if the partition table was correctly read). Signed-off-by: Eric Bénard

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Jaehoon Chung
On 04/18/2012 09:20 AM, Namjae Jeon wrote: 2012/4/17 Venkatraman S svenk...@ti.com: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Namjae Jeon
2012/4/18 Jaehoon Chung jh80.ch...@samsung.com: On 04/18/2012 09:20 AM, Namjae Jeon wrote: 2012/4/17 Venkatraman S svenk...@ti.com: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not

RE: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-04-17 Thread Subhash Jadavani
Hi Chris, -Original Message- From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- ow...@vger.kernel.org] On Behalf Of Subhash Jadavani Sent: Wednesday, April 11, 2012 12:22 AM To: 'Chris Ball' Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org Subject: RE:

Re: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-04-17 Thread Namjae Jeon
Hi. Subhash. Would you share which option you used in LMDD, iozone test ? Thanks. 2012/4/18 Subhash Jadavani subha...@codeaurora.org: Hi Chris, -Original Message- From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- ow...@vger.kernel.org] On Behalf Of Subhash Jadavani