Re: [PATCHv2 00/16] [FS, MM, block, MMC]: eMMC High Priority Interrupt Feature

2012-05-08 Thread Minchan Kim
On 05/09/2012 01:31 AM, S, Venkatraman wrote: > On Tue, May 8, 2012 at 1:16 PM, Minchan Kim wrote: >> On 05/03/2012 11:22 PM, Venkatraman S wrote: >> >>> Standard eMMC (Embedded MultiMedia Card) specification expects to execute >>> one request at a time. If some requests are more important than o

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-08 Thread Dave Chinner
On Mon, May 07, 2012 at 10:16:30PM +0530, S, Venkatraman wrote: > Mon, May 7, 2012 at 5:01 AM, Dave Chinner wrote: > > On Thu, May 03, 2012 at 07:53:00PM +0530, Venkatraman S wrote: > >> From: Ilan Smith > >> > >> Add attribute to identify demand paging requests. > >> Mark readpages with demand p

RE: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device

2012-05-08 Thread Seungwon Jeon
Maya Erez wrote: > -Original Message- > From: linux-mmc-ow...@vger.kernel.org > [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of > me...@codeaurora.org > Sent: Thursday, May 03, 2012 3:35 AM > To: Seungwon Jeon > Cc: me...@codeaurora.org; linux-mmc@vger.kernel.org; 'Chris Ball'; > l

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-08 Thread S, Venkatraman
On Tue, May 8, 2012 at 11:58 AM, mani wrote: > How about adding the AS_DMPG flag in the file -> address_space when getting > a filemap_fault() > so that we can treat the page fault pages as the high priority pages over > normal read requests. > How about changing below lines for the support of the

Re: [PATCHv2 00/16] [FS, MM, block, MMC]: eMMC High Priority Interrupt Feature

2012-05-08 Thread S, Venkatraman
On Tue, May 8, 2012 at 1:16 PM, Minchan Kim wrote: > On 05/03/2012 11:22 PM, Venkatraman S wrote: > >> Standard eMMC (Embedded MultiMedia Card) specification expects to execute >> one request at a time. If some requests are more important than others, they >> can't be aborted while the flash proce

Re: [PATCH 08/10] mmc: mxs-mmc: add device tree support

2012-05-08 Thread Shawn Guo
On Tue, May 08, 2012 at 01:58:07AM +0200, Marek Vasut wrote: > > +Optional properties: > > +- wp-gpios: Specify GPIOs for write protection > > You can have multiple wp-gpio per port? :-) > This is a naming idiom documented in Documentation/devicetree/bindings/gpio/gpio.txt -- Regards, Shawn --

Re: [PATCH 07/10] mmc: mxs-mmc: copy wp_gpio in struct mxs_mmc_host

2012-05-08 Thread Shawn Guo
On Tue, May 08, 2012 at 01:53:44AM +0200, Marek Vasut wrote: > Dear Shawn Guo, > > > It has wp_gpio copied in struct mxs_mmc_host from platform_data, > > Copy wp_gpio into struct ... > Updated. > > so that the use of platform_data can be limited in probe function, > > which will ease the device

Re: [PATCH 05/10] mmc: mxs-mmc: use devm_* helper to make cleanup simpler

2012-05-08 Thread Shawn Guo
On Tue, May 08, 2012 at 01:49:58AM +0200, Marek Vasut wrote: > btw do we have i2c dt bindings ? > I'm working on it. > Acked-by: Marek Vasut Thanks. -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 03/10] mmc: mxs-mmc: get rid of the use of cpu_is_xxx

2012-05-08 Thread Shawn Guo
On Tue, May 08, 2012 at 01:46:44AM +0200, Marek Vasut wrote: > > -#define SSP_VERSION_LATEST 4 > > -#define ssp_is_old(host) (host->version < SSP_VERSION_LATEST) > > +#define ssp_is_old(host) (host->devid == IMX23_MMC) > > (host)->devid ... > Fixed, as well as dma_is_apbh and apbh_is_old. Th

Re: [PATCH 02/10] mmc: mxs-mmc: let ssp_is_old take host as parameter

2012-05-08 Thread Shawn Guo
On Tue, May 08, 2012 at 01:43:49AM +0200, Marek Vasut wrote: > > #define SSP_VERSION_LATEST 4 > > -#define ssp_is_old() (host->version < SSP_VERSION_LATEST) > > +#define ssp_is_old(host) (host->version < SSP_VERSION_LATEST) > > (host)->version ... to make the macro safer. > Sound

Re: [PATCH 4/8] mmc: mmci: Use ios_handler to save power

2012-05-08 Thread Ulf Hansson
Hi Russell, Sorry for a late reply. On 04/18/2012 03:45 PM, Russell King - ARM Linux wrote: On Wed, Apr 18, 2012 at 01:57:27PM +0200, Vitaly Wool wrote: Hi Ulf, On Tue, Jan 17, 2012 at 3:34 PM, Ulf Hansson wrote: To disable a levelshifter when we are in an idle state will decrease current c

[PATCH 3/3] mmc: omap: convert to module_platform_driver

2012-05-08 Thread Venkatraman S
Get rid of boilerplate code by using module_platform_driver macro, no functional changes. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap.c | 14 +- 1 files changed, 1 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 0056bd

[PATCH 2/3] mmc: omap: make it behave well as module

2012-05-08 Thread Venkatraman S
Use proper __devinit and __devexit annotation for driver functions. Instantiate the probe function for driver_ops instead of a probe in the register function. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a

[PATCH 1/3] mmc: omap: convert to per instance workqueue

2012-05-08 Thread Venkatraman S
Currently, a global mmc_omap_wq is created for all instances of omap hosts, which can lead to races and doesn't lend itself to unload the module cleanly. Instead, create per instance workqueue and remove the common workqueue. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap.c | 29 ++

[PATCH 0/3] mmc: omap: driver registration cleanups

2012-05-08 Thread Venkatraman S
Cleanups for the legacy omap mmc driver to remove clutter and make it well behaved as module. Venkatraman S (3): mmc: omap: convert to per instance workqueue mmc: omap: make it behave well as module mmc: omap: convert to module_platform_driver drivers/mmc/host/omap.c | 48 +++

RE: dw_mmc: New sdio CMD53 starts with non-empty FIFO

2012-05-08 Thread Seungwon Jeon
Hi, Dmitry Shmidt wrote: > Hi, > > I am working with dw_mmc controller. Kernel 3.4-rc3. Sdio wlan device > in UHS_SDR50 mode. > What I see that sometimes next sdio CMD53 starts before FIFO is empty > and then controller goes insane and > sdio request will be blocked forever. > > And it looks li

Re: [PATCHv2 00/16] [FS, MM, block, MMC]: eMMC High Priority Interrupt Feature

2012-05-08 Thread Minchan Kim
On 05/03/2012 11:22 PM, Venkatraman S wrote: > Standard eMMC (Embedded MultiMedia Card) specification expects to execute > one request at a time. If some requests are more important than others, they > can't be aborted while the flash procedure is in progress. > > New versions of the eMMC standar