Re: [PATCH] esdhc: fix DMA_MASK to not break mx25 DMA access

Hi, On Tue, Jul 17 2012, Wilson & Cassie wrote: > Patch to not set reserved bits in i.MX25 PROCTL register. DMA stops working > if those bits get set. > > Signed-off-by: Wilson Callan > Acked-by: Sascha Hauer > > --- linux-3.4.4/drivers/mmc/host/sdhci-esdhc-imx.c.orig 2012-07-04 > 13:58

Re: [PATCH RESEND v7 2/2] mmc: card: Adding support for sanitize in eMMC 4.5

Hi Yaniv, On Thu, Jun 28 2012, Yaniv Gardi wrote: > This feature delete the unmap memory region of the eMMC card, > by writing to a specific register in the EXT_CSD > unmap region is the memory region that were previously deleted > (by erase, trim or discard operation) > > Signed-off-by: Yaniv Gar

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

Hi, On Wed, Jul 18 2012, Chris Ball wrote: > Girish/Philip, does this look good to you too? If so, I'll squash it > into the original patch. Thanks, everyone -- squashed in and pushed out to mmc-next. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from

Re: [PATCH] mmc: core: reset sigal voltage on power up

Hi, On Tue, Jul 17 2012, S, Venkatraman wrote: > On Tue, Jul 10, 2012 at 2:25 PM, Aaron Lu wrote: >> Add a call to mmc_set_signal_voltage to set signal voltage to 3.3v in >> mmc_power_up so that we do not need to touch signal voltage setting in >> mmc/sd/sdio init functions and rescan function. >

Re: [PATCH V1] mmc: dwmmc: Add quirk for broken Hardware Config

On 18 July 2012 18:25, S, Venkatraman wrote: > On Wed, Jul 18, 2012 at 2:08 PM, Girish K S > wrote: >> In some Soc'S that integrate Designware mmc host controllers, the >> HCON register is broken. The hardware configuration is not >> updated. One specific usecase is the IDMAC. In Exysons5 SoC >>

Re: [PATCH] MMC: OMAP: make MMC_OMAP* depend on DMA_OMAP

Hi Venkat -- please could you ACK/review this patch? On Wed, Jul 04 2012, Ming Lei wrote: > Recent commits on omap mmc/hsmmc in -next tree switch to > DMA_ENGINE entirely, so make MMC_OMAP* depend on DMA_OMAP > and DMA_ENGINE, otherwise OMAP MMC/HSMMC won't work without > enabling DMA_ENGINE and D

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

Hi, On Thu, Jul 19 2012, Girish K S wrote: > Looks like a better solution than earlier one. > Reviewed By: Girish K S Thanks. > Chris, > How about the holes created by removal of caps2 macros. Will they be > adjusted to follow the sequence or left as it is for future use. There actually isn't

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

On 18 July 2012 11:52, Aaron Lu wrote: > Hi Chris, > > On Wed, Jul 18, 2012 at 01:28:40AM -0400, Chris Ball wrote: >> Hi Aaron, >> >> On Wed, Jul 18 2012, Aaron Lu wrote: >> > Is the following patch OK? This is based on top of current mmc-next with >> > the previous one in tree. Not sure if this i

RE: [PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

Hi, This version does not seems to consider previous reviews fully. Could you check the comments below? July 12, 2012, Thomas Abraham wrote: > The instantiation of the Synopsis Designware controller on Exynos5250 > include extension for SDR and DDR specific tx/rx phase shift timing > and CIU int

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

It is much cleaner solution then before ! I like it. Reviewed-by: Philip Rakity On Jul 18, 2012, at 7:41 PM, Chris Ball wrote: > Hi, > > On Wed, Jul 18 2012, Aaron Lu wrote: >> I've prepared the following code, please check if this is better than >> the current one: > > I think the diffstat

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

Hi, On Wed, Jul 18 2012, Aaron Lu wrote: > I've prepared the following code, please check if this is better than > the current one: I think the diffstat speaks for itself. :-) drivers/mmc/core/sd.c| 77 ++ drivers/mmc/host/sdhci.c | 51 ++

Re: [PATCH v2 1/1] mmc: block: Add write packing control

> > I'd be willing to explore something like Venkat's idea if the block > layer maintainers insist, though. Yeah... I guess it's upto Jens. > > - Chris. > -- > Chris Ball > One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

>>> +void mmc_start_bkops(struct mmc_card *card) >>> +{ >>> + int err; >>> + int timeout; >>> + u8 use_busy_signal; >>> + >>> + BUG_ON(!card); >>> + if (!card->ext_csd.bkops_en || !(card->host->caps2 & MMC_CAP2_BKOPS)) >> >> Can you please explain why we need to have MMC_CAP2_BKOPS in ad

Re: Devicetree: Initialization order of mmc block devices?

On 07/18/2012 04:54 PM, Eric Nelson wrote: On 07/18/2012 07:11 AM, Knut Wohlrab wrote: On 07/18/2012 03:47 PM, Jassi Brar wrote: On 18 July 2012 15:19, Knut Wohlrab wrote: If a SD card is inserted at boot time, its "mmcblk0", the embedded MMC (eMMC) device "mmcblk1". This makes it difficult

Re: Devicetree: Initialization order of mmc block devices?

On 07/18/2012 07:11 AM, Knut Wohlrab wrote: On 07/18/2012 03:47 PM, Jassi Brar wrote: On 18 July 2012 15:19, Knut Wohlrab wrote: If a SD card is inserted at boot time, its "mmcblk0", the embedded MMC (eMMC) device "mmcblk1". This makes it difficult to give the kernel the correct device for th

Re: Devicetree: Initialization order of mmc block devices?

On 07/18/2012 03:47 PM, Jassi Brar wrote: On 18 July 2012 15:19, Knut Wohlrab wrote: If a SD card is inserted at boot time, its "mmcblk0", the embedded MMC (eMMC) device "mmcblk1". This makes it difficult to give the kernel the correct device for the eMMC root file system ("root=/dev/mmcblk?p

Re: Devicetree: Initialization order of mmc block devices?

On 18 July 2012 15:19, Knut Wohlrab wrote: > If a SD card is inserted at boot time, its "mmcblk0", the embedded > MMC (eMMC) device "mmcblk1". This makes it difficult to give the kernel the > correct device for the eMMC root file system ("root=/dev/mmcblk?p1 ..."). > How about root=UUID= ? --

Re: [PATCH V1] mmc: dwmmc: Add quirk for broken Hardware Config

On Wed, Jul 18, 2012 at 2:08 PM, Girish K S wrote: > In some Soc'S that integrate Designware mmc host controllers, the > HCON register is broken. The hardware configuration is not > updated. One specific usecase is the IDMAC. In Exysons5 SoC > there exist a internal DMA, but the HCON register's DM

Re: Devicetree: Initialization order of mmc block devices?

On 07/18/2012 09:23 AM, Jassi Brar wrote: On 18 July 2012 11:56, Dirk Behme wrote: Similar to [1] we have a device which has two mmc block devices connected: One external removable and a second internal hard wired one. Depending on the availability of the external removable mmc card at boot tim

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 3:08 PM, S, Venkatraman wrote: > On Wed, Jul 18, 2012 at 2:46 PM, Javier Martinez Canillas > wrote: [...] And what about enabling it at the SoC config level but making the drivers dependant on CONFIG_DMADEVICES and CONFIG_DMA_OMAP? If you agree I can

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 2:46 PM, Javier Martinez Canillas wrote: > On Wed, Jul 18, 2012 at 11:11 AM, Shilimkar, Santosh > wrote: >> On Wed, Jul 18, 2012 at 2:19 PM, Javier Martinez Canillas >> wrote: >>> On Wed, Jul 18, 2012 at 10:36 AM, Shilimkar, Santosh >>> wrote: On Wed, Jul 18, 2012 a

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 11:11 AM, Shilimkar, Santosh wrote: > On Wed, Jul 18, 2012 at 2:19 PM, Javier Martinez Canillas > wrote: >> On Wed, Jul 18, 2012 at 10:36 AM, Shilimkar, Santosh >> wrote: >>> On Wed, Jul 18, 2012 at 1:14 PM, S, Venkatraman wrote: On Wed, Jul 18, 2012 at 12:40 PM, To

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 2:19 PM, Javier Martinez Canillas wrote: > On Wed, Jul 18, 2012 at 10:36 AM, Shilimkar, Santosh > wrote: >> On Wed, Jul 18, 2012 at 1:14 PM, S, Venkatraman wrote: >>> On Wed, Jul 18, 2012 at 12:40 PM, Tony Lindgren wrote: * Shilimkar, Santosh [120718 00:09]: >

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 10:36 AM, Shilimkar, Santosh wrote: > On Wed, Jul 18, 2012 at 1:14 PM, S, Venkatraman wrote: >> On Wed, Jul 18, 2012 at 12:40 PM, Tony Lindgren wrote: >>> * Shilimkar, Santosh [120718 00:09]: On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: > * Javier Ma

[PATCH V1] mmc: dwmmc: Add quirk for broken Hardware Config

In some Soc'S that integrate Designware mmc host controllers, the HCON register is broken. The hardware configuration is not updated. One specific usecase is the IDMAC. In Exysons5 SoC there exist a internal DMA, but the HCON register's DMA_INTERFACE field is not set to indicate its existance. Thi

[PATCH V1] Add Quirk for Broken Configuration

This patch is based on the device tree support of dw_mmc host controller posted by Thomas Abraham. Below is the list of his patch in review stage mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference mmc: dw_mmc: allow probe to succeed even if one slot is initialized mmc: dw_m

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 1:14 PM, S, Venkatraman wrote: > On Wed, Jul 18, 2012 at 12:40 PM, Tony Lindgren wrote: >> * Shilimkar, Santosh [120718 00:09]: >>> On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: >>> > * Javier Martinez Canillas [120716 23:56]: >>> >> On Tue, Jul 17, 2012 at 8:4

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 8:59 AM, Tony Lindgren wrote: > * Javier Martinez Canillas [120716 23:56]: >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh >> wrote: >> > Hi, >> > >> > On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas >> > wrote: >> >> The OMAP MMC and OMAP High Speed MMC

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 12:40 PM, Tony Lindgren wrote: > * Shilimkar, Santosh [120718 00:09]: >> On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: >> > * Javier Martinez Canillas [120716 23:56]: >> >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh >> >> wrote: >> >> > Hi, >> >> > >>

Re: [PATCH v2 1/1] mmc: block: Add write packing control

Hi, [removing Jens and the documentation list, since now we're talking about the MMC side only] On Wed, Jul 18 2012, me...@codeaurora.org wrote: > Is there anything else that holds this patch from being pushed to mmc-next? Yes, I'm still uncomfortable with the write packing patchsets for a coupl

Re: Devicetree: Initialization order of mmc block devices?

On 18 July 2012 11:56, Dirk Behme wrote: > > Similar to [1] we have a device which has two mmc block devices connected: > One external removable and a second internal hard wired one. Depending on > the availability of the external removable mmc card at boot time, the > internal hard wired device b

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

* Shilimkar, Santosh [120718 00:09]: > On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: > > * Javier Martinez Canillas [120716 23:56]: > >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh > >> wrote: > >> > Hi, > >> > > >> > On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas >

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: > * Javier Martinez Canillas [120716 23:56]: >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh >> wrote: >> > Hi, >> > >> > On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas >> > wrote: >> >> The OMAP MMC and OMAP High Speed MM

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

* Javier Martinez Canillas [120716 23:56]: > On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh > wrote: > > Hi, > > > > On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas > > wrote: > >> The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA > >> engine API instead of the p