On 26 July 2012 11:30, Jaehoon Chung wrote:
> Hi Girish,
>
> I re-tested the your patch.
> How about locating into dw_mci_setup_bus()?
>
> And if compare the previously and current busmode,
> I think host needs not to re-write at register.
> For example,
> if (slot->bus_mode == ios->bus_mode)
>
Hi Girish,
I re-tested the your patch.
How about locating into dw_mci_setup_bus()?
And if compare the previously and current busmode,
I think host needs not to re-write at register.
For example,
if (slot->bus_mode == ios->bus_mode)
return;
Then this patch looks good to me.
Best Regards,
On 24 July 2012 10:48, Seungwon Jeon wrote:
> Hi Girish,
>
> July 23, 2012, Girish K S wrote:
>> In some Soc'S that integrate Designware mmc host controllers, the
>> HCON register is broken. The hardware configuration is not
>> updated. One specific usecase is the IDMAC. In Exysons5 SoC
>> there
July 26, 2012, Doug Anderson wrote:
> The documentation for the dw_mmc part says that the low power
> mode should normally only be set for MMC and SD memory and should
> be turned off for SDIO cards that need interrupts detected.
>
> The best place I could find to do this is when the SDIO interru
On 24 July 2012 18:37, Jae hoon Chung wrote:
> Hi Girish,
>
> Right, it be mentioned about the open-drain mode in synopsys spec.
> But if didn't work on other board, there is some problem.
> We can consider the location of set_busmode() .
Sure. Currently i am setting the bus mode after sending the
The documentation for the dw_mmc part says that the low power
mode should normally only be set for MMC and SD memory and should
be turned off for SDIO cards that need interrupts detected.
The best place I could find to do this is when the SDIO interrupt
was first enabled. I rely on the fact that
On Wed, Jul 25, 2012 at 3:02 AM, Jaehoon Chung wrote:
> Just use the slot. slot is already assigned to mmc_priv(mmc)
Oops. Now I feel sheepish. Done. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo
On 24 July 2012 19:14, Jae hoon Chung wrote:
> 2012/7/24 Girish K S :
>> On 24 July 2012 18:37, Jae hoon Chung wrote:
>>> Hi Girish,
>>>
>>> Right, it be mentioned about the open-drain mode in synopsys spec.
>>> But if didn't work on other board, there is some problem.
>>> We can consider the loc
Looks good to me.
Reviewed-by: Maya Erez
On Wed, July 25, 2012 4:31 am, Yaniv Gardi wrote:
> This feature delete the unmap memory region of the eMMC card,
> by writing to a specific register in the EXT_CSD
> unmap region is the memory region that were previously deleted
> (by erase, trim or disca
Looks good to me.
Reviewed-by: Maya Erez
On Wed, July 25, 2012 4:31 am, Yaniv Gardi wrote:
> Adding a new ioctl to support sanitize operation in eMMC
> cards version 4.5.
> The sanitize ioctl support helps performing this operation
> via user application.
>
> Signed-off-by: Yaniv Gardi
>
> ---
>
This feature delete the unmap memory region of the eMMC card,
by writing to a specific register in the EXT_CSD
unmap region is the memory region that were previously deleted
(by erase, trim or discard operation)
Signed-off-by: Yaniv Gardi
---
drivers/mmc/card/block.c | 72
Adding a new ioctl to support sanitize operation in eMMC
cards version 4.5.
The sanitize ioctl support helps performing this operation
via user application.
Signed-off-by: Yaniv Gardi
---
block/blk-core.c | 15 ++--
block/blk-lib.c | 51 +++
*** adding and exposing SANITIZE capability to the user space via a unique
IOCTL ***
Yaniv Gardi (2):
block: ioctl support for sanitize in eMMC 4.5
mmc: card: Adding support for sanitize in eMMC 4.5
block/blk-core.c | 15 +++--
block/blk-lib.c | 51 +++
On Wed, July 25, 2012 2:32 am, Yaniv Gardi wrote:
> @@ -238,6 +238,7 @@ struct mmc_host {
> #define MMC_CAP2_BROKEN_VOLTAGE (1 << 7)/* Use the broken
> voltage */
> #define MMC_CAP2_DETECT_ON_ERR (1 << 8)/* On I/O err check
> card removal
> */
> #define MMC_CAP2_HC_
Looks good to me.
Reviewed-by: Maya Erez
On Wed, July 25, 2012 2:32 am, Yaniv Gardi wrote:
> Adding a new ioctl to support sanitize operation in eMMC
> cards version 4.5.
> The sanitize ioctl support helps performing this operation
> via user application.
>
> Signed-off-by: Yaniv Gardi
>
> ---
>
> +
> static void dw_mci_enable_sdio_irq(struct mmc_host *mmc, int enb)
> {
> struct dw_mci_slot *slot = mmc_priv(mmc);
> @@ -871,6 +898,14 @@ static void dw_mci_enable_sdio_irq(struct mmc_host *mmc,
> int enb)
> /* Enable/disable Slot Specific SDIO interrupt */
> int_mask = mc
+ Jens Axboe
Hi Jens,
Can you please review the v8 patch and refer to it? As seen below,
everything is all set to push the change in the mmc layer,
But it's better to push the feature to both modules
Hi Chris,
I just uploaded a v8, which has small fix in the block layer. It has no
changes at all,
This feature delete the unmap memory region of the eMMC card,
by writing to a specific register in the EXT_CSD
unmap region is the memory region that were previously deleted
(by erase, trim or discard operation)
Signed-off-by: Yaniv Gardi
---
drivers/mmc/card/block.c | 72
Adding a new ioctl to support sanitize operation in eMMC
cards version 4.5.
The sanitize ioctl support helps performing this operation
via user application.
Signed-off-by: Yaniv Gardi
---
block/blk-core.c | 15 ++--
block/blk-lib.c | 51 +++
*** adding and exposing SANITIZE capability to the user space via a unique
IOCTL ***
Yaniv Gardi (2):
block: ioctl support for sanitize in eMMC 4.5
mmc: card: Adding support for sanitize in eMMC 4.5
block/blk-core.c | 15 +++--
block/blk-lib.c | 51 +++
On Tue, Jul 24, 2012 at 5:59 PM, Doug Anderson wrote:
> The documentation for the dw_mmc part says that the low power
> mode should normally only be set for MMC and SD memory and should
> be turned off for SDIO cards that need interrupts detected.
>
> The best place I could find to do this is when
It is expected that Extended CSD register(the size of this register
is larger than CID/CSD) will be referenced more frequently as more
fields have been added to Extended CSD and it seems that it is not
a good option to double the memory used.
This patch is intended to avoid the use of bounce buffe
22 matches
Mail list logo