Re: [PATCH v3 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-08-21 Thread shashidhar hiremath
On Mon, Aug 6, 2012 at 8:42 PM, Loic Pallardy loic.pallardy-...@stericsson.com wrote: RPMB partition is accessing though /dev/block/mmcXrpmb device User callers can read and write entire data frame(s) as defined by JEDEC Standard JESD84-A441, using standard IOCTL interface. Signed-off-by:

Re: [PATCH 00/10] Assorted MMC / OMAP HSMMC patches

2012-08-21 Thread Felipe Balbi
Hi, On Sat, Aug 18, 2012 at 12:22:20AM +0530, Venkatraman S wrote: Essentially, a lot of cleanups leading up to adding a new feature for OMAP HSMMC. The idea is to convert to the use of software timer instead of IP timer for timekeeping, due to the limitations of the counting range of the IP

[PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
'broken-cd' binding lets mmc controller device node to indicate that the card detect line is broken. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- The 'broken-cd' DT binding for MMC controllers is picked up from the OLPC project git repo and was originally conceived by Chris Ball

[PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
'broken-cd' binding lets mmc controller device node to indicate that the card detect line is broken. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- The 'broken-cd' DT binding for MMC controllers is picked up from the OLPC project git repo and was originally conceived by Chris Ball

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Chris Ball
Hi, On Tue, Aug 21 2012, Arnd Bergmann wrote: On Tuesday 21 August 2012, Thomas Abraham wrote: diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a6811f..1aa527a 100644 --- a/Documentation/devicetree/bindings/mmc/mmc.txt +++

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 16:31, Arnd Bergmann a...@arndb.de wrote: On Tuesday 21 August 2012, Thomas Abraham wrote: diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a6811f..1aa527a 100644 ---

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Arnd Bergmann
On Tuesday 21 August 2012, Chris Ball wrote: How about this? broken-cd: No CD available, use polling. cd-gpios: The CD pin on the host is working and brought out to a GPIO. external-cd-gpios: The CD pin on the host is broken, but there's an independent external GPIO

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 17:26, Chris Ball c...@laptop.org wrote: Hi, On Tue, Aug 21 2012, Thomas Abraham wrote: I am trying to have a way to represent a gpio line as card detect line that is not connected to the card-detect pad of the mmc controller but instead used as a gpio interrupt line or

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Rob Herring
On 08/21/2012 07:08 AM, Arnd Bergmann wrote: On Tuesday 21 August 2012, Chris Ball wrote: How about this? broken-cd: No CD available, use polling. cd-gpios: The CD pin on the host is working and brought out to a GPIO. external-cd-gpios: The CD pin on the host is broken, but there's an

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Chris Ball
Hi, adding Shawn and Wolfram, On Tue, Aug 21 2012, Arnd Bergmann wrote: On Tuesday 21 August 2012, Chris Ball wrote: How about this? broken-cd: No CD available, use polling. cd-gpios: The CD pin on the host is working and brought out to a GPIO. external-cd-gpios: The CD pin on the host

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Rob Herring
On 08/21/2012 09:48 AM, Chris Ball wrote: Hi, adding Shawn and Wolfram, snip... Rob Herring said: This makes the most sense to me. However, I prefer broken-cd over cd-internal. The binding should add properties for exceptions, not SDHCI spec compliant implementations. Agreed, I was going

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Chris Ball
Hi, On Tue, Aug 21 2012, Rob Herring wrote: cd-gpios and cd-external can be present on the same node. if broken-cd is present, it must be the only one of these nodes used. I don't see the point of cd-external. Either you just use the CD interrupt defined within the SDHCI or you have a gpio

Re: [PATCH 07/10] mmc: omap_hsmmc: consolidate flush posted writes for HSMMC IRQs

2012-08-21 Thread T Krishnamoorthy, Balaji
On Sat, Aug 18, 2012 at 12:22 AM, Venkatraman S svenk...@ti.com wrote: Flushing spurious IRQs from HSMMC IP is done twice in omap_hsmmc_irq and omap_hsmmc_do_irq. spurious IRQ is flushed in start of omap_hsmmc_do_irq and irq acked at the end of omap_hsmmc_do_irq Consolidate them to one

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 20:33, Rob Herring robherri...@gmail.com wrote: On 08/21/2012 09:48 AM, Chris Ball wrote: Hi, adding Shawn and Wolfram, snip... Rob Herring said: This makes the most sense to me. However, I prefer broken-cd over cd-internal. The binding should add properties for

Re: [PATCH 06/10] mmc: omap_hsmmc: remove access to SYSCONFIG register

2012-08-21 Thread Shubhrajyoti Datta
Hi Venkat, Some doubts below. On Sat, Aug 18, 2012 at 12:22 AM, Venkatraman S svenk...@ti.com wrote: SYSCONFIG register of HSMMC IP is managed by the omap hwmod abstraction layer. At init only right? Resetting the IP and configuring the correct SYSCONFIG mode is centrally managed by hwmod.

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Rob Herring
On 08/21/2012 10:18 AM, Chris Ball wrote: Hi, On Tue, Aug 21 2012, Rob Herring wrote: cd-gpios and cd-external can be present on the same node. if broken-cd is present, it must be the only one of these nodes used. I don't see the point of cd-external. Either you just use the CD interrupt

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 21:31, Rob Herring robherri...@gmail.com wrote: On 08/21/2012 10:18 AM, Chris Ball wrote: Hi, On Tue, Aug 21 2012, Rob Herring wrote: cd-gpios and cd-external can be present on the same node. if broken-cd is present, it must be the only one of these nodes used. I don't

Re: [PATCH 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-21 Thread Matt Porter
On Thu, Aug 16, 2012 at 05:44:29PM -0400, Matt Porter wrote: Add a DMA engine driver for the TI EDMA controller. This driver is implemented as a wrapper around the existing DaVinci private DMA implementation. This approach allows for incremental conversion of each peripheral driver to the DMA

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Mitch Bradley
On 8/21/2012 7:33 AM, Thomas Abraham wrote: On 21 August 2012 21:31, Rob Herring robherri...@gmail.com wrote: On 08/21/2012 10:18 AM, Chris Ball wrote: Hi, On Tue, Aug 21 2012, Rob Herring wrote: cd-gpios and cd-external can be present on the same node. if broken-cd is present, it must be

[PATCH v2 0/3] DaVinci DMA engine conversion

2012-08-21 Thread Matt Porter
Changes since v1: - Add virt-dma support. Better error checks and simplified descriptor handling. - Fix support for multiple EDMA controllers Tested on AM18x EVM with WL12xx on MMC1 This series begins the conversion of the DaVinci private EDMA API

[PATCH v2 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-21 Thread Matt Porter
Add a DMA engine driver for the TI EDMA controller. This driver is implemented as a wrapper around the existing DaVinci private DMA implementation. This approach allows for incremental conversion of each peripheral driver to the DMA engine API. The EDMA driver supports slave transfers but does not

[PATCH v2 2/3] mmc: davinci_mmc: convert to DMA engine API

2012-08-21 Thread Matt Porter
Removes use of the DaVinci EDMA private DMA API and replaces it with use of the DMA engine API. Signed-off-by: Matt Porter mpor...@ti.com --- drivers/mmc/host/davinci_mmc.c | 271 1 file changed, 82 insertions(+), 189 deletions(-) diff --git

[PATCH v2 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-21 Thread Matt Porter
Removes use of the DaVinci EDMA private DMA API and replaces it with use of the DMA engine API. Signed-off-by: Matt Porter mpor...@ti.com --- drivers/spi/spi-davinci.c | 292 - 1 file changed, 130 insertions(+), 162 deletions(-) diff --git

Re: [PATCH v2 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-21 Thread Vinod Koul
On Tue, 2012-08-21 at 14:43 -0400, Matt Porter wrote: Add a DMA engine driver for the TI EDMA controller. This driver is implemented as a wrapper around the existing DaVinci private DMA implementation. This approach allows for incremental conversion of each peripheral driver to the DMA engine

Re: [PATCH v2 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-21 Thread Vinod Koul
On Tue, 2012-08-21 at 14:43 -0400, Matt Porter wrote: Removes use of the DaVinci EDMA private DMA API and replaces it with use of the DMA engine API. Signed-off-by: Matt Porter mpor...@ti.com --- + struct dma_slave_config dma_rx_conf = { + .direction =

[PATCH 2/2] mmc: dw_mmc: Add a DISABLE_MMC quirk that sets the core mmc cap

2012-08-21 Thread Doug Anderson
On some systems we need a way to disable MMC card support in a MMC/SD card slot. Add support in the dw_mmc to support this. Signed-off-by: Doug Anderson diand...@chromium.org --- drivers/mmc/host/dw_mmc.c |3 +++ include/linux/mmc/dw_mmc.h |2 ++ 2 files changed, 5 insertions(+), 0

[PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-21 Thread Doug Anderson
On some systems we need a way to disable MMC card support in a MMC/SD card slot. Add support in the core SD/MMC code to support this. Signed-off-by: Doug Anderson diand...@chromium.org Signed-off-by: Alim Akhtar alim.akh...@samsung.com --- drivers/mmc/core/core.c |2 +-

Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-21 Thread Jaehoon Chung
Hi Doug, I didn't know what purpose is. Why need to add the MMC_CAP2_NO_MMC? If card is SD or SDIO, mmc_attach_mmc(host) should not be entered. Could you explain to me in more detail? Best Regards, Jaehoon Chung On 08/22/2012 01:05 PM, Doug Anderson wrote: On some systems we need a way to

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Shawn Guo
On Tue, Aug 21, 2012 at 11:03:59PM +0530, Thomas Abraham wrote: Ok, I agree with Rob. I was mixing pin muxing here. So if we have 'cd-gpios' and 'broken-cd' as generic bindings, would the following be valid? [A] cd-gpios not present , broken-cd not present : This means that there is no