Re: [PATCH] mmc: sdhci-s3c: fix checkpatch error and warnings

2012-08-29 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 08/29/2012 02:35 PM, Jingoo Han wrote: This patch fixes the checkpatch error and warnings listed below: ERROR: return is not a function, parentheses are not required WARNING: Prefer pr_err(... to printk(KERN_ERR, ... WARNING: quoted string

Re: [PATCH 2/2] mmc: omap_hsmmc: cleanup the bitmap definitions of Interrupt Register

2012-08-29 Thread T Krishnamoorthy, Balaji
On Tue, Aug 28, 2012 at 6:49 PM, Venkatraman S svenk...@ti.com wrote: Define the most frequently used bitmasks of the Interrupt Enable / Interrupt Status register with consistent naming ( with _EN suffix). Use meaningful concatenation of bitfields for INT_EN_MASK, which shows which interrupts

Re: [PATCH v6] mmc: card: Skip secure option for MoviNAND.

2012-08-29 Thread Jaehoon Chung
Hi Chris, Could you merge this patch? We want to prevent this problem at mainline kernel. Best Regards, Jaehoon Chung On 08/29/2012 03:05 PM, IAN CHEN wrote: For several MoviNAND, there are some known issue with secure option. For these specific MoviNAND device, we skip secure option. You

Re: [PATCH v6] mmc: card: Skip secure option for MoviNAND.

2012-08-29 Thread Chris Ball
Hi, On Wed, Aug 29 2012, IAN CHEN wrote: For several MoviNAND, there are some known issue with secure option. For these specific MoviNAND device, we skip secure option. You could refer this discussion in XDA developers. http://forum.xda-developers.com/showthread.php?t=1644364

[PATCH v5 1/9] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference

2012-08-29 Thread Thomas Abraham
The 'struct dw_mci' maintains a copy of the pdev-dev instance instead of maintaining a reference to that 'struct device' instance. Any resource allocated using the device resource management kernel API with the instance of 'struct device' in 'struct dw_mci' is then incorrect. Fix this by

[PATCH v5 2/9] mmc: dw_mmc: Use devm_* functions in dw_mmc platform driver

2012-08-29 Thread Thomas Abraham
Use devm_* managed functions for simpler error handling. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Will Newton will.new...@imgtec.com --- drivers/mmc/host/dw_mmc-pltfm.c | 29 - 1 files changed, 8 insertions(+), 21 deletions(-) diff --git

[PATCH v5 3/9] mmc: dw_mmc: allow probe to succeed even if one slot is initialized

2012-08-29 Thread Thomas Abraham
Instead of aborting the probe in case a slot initialization fails, allow initialization of as many slots as possible. If there are atleast one instance of slot that is successfully initialized, allow the driver probe to succeed. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by:

[PATCH v5 5/9] mmc: dw_mmc: add quirk to indicate missing write protect line

2012-08-29 Thread Thomas Abraham
If the write protect pad of the controller is not connected to the write protect pin of the slot, the driver should be notified of this condition so that incorrect check for write protection by reading the WRTORT register can avoided. The get_ro platform callback can be used for in such cases, but

[PATCH v5 6/9] mmc: dw_mmc: add device tree support

2012-08-29 Thread Thomas Abraham
Add device tree based discovery support. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Will Newton will.new...@imgtec.com --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 79 drivers/mmc/host/dw_mmc-pltfm.c|9 ++

[PATCH v5 7/9] mmc: dw_mmc: prepare functions in dw_mmc-pltfm for reuse

2012-08-29 Thread Thomas Abraham
Platform implementations of dw-mshc controller may choose to exterd the features of the standard dw-mshc controller such as adding additional clocking options or modifying the bus interface. Support for such implementation specific extensions can be incorporated into dw_mmc-pltfm, but including

[PATCH v5 8/9] mmc: dw_mmc: add support for implementation specific callbacks

2012-08-29 Thread Thomas Abraham
The core dw-mshc controller driver can let platform specific implementations of the dw-mshc controller to control the hardware as required by such implementations. This is acheived by invoking implementation specific (optional) callbacks. Define the list of callbacks supported the add invocation

[PATCH v5 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-29 Thread Thomas Abraham
Samsung Exynos SoC's extend the dw-mshc controller for additional clock and bus control. Add support for these extensions and include provide device tree based discovery suppory as well. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Will Newton will.new...@imgtec.com ---

Re: [PATCH] mmc: sdhci-s3c: fix checkpatch error and warnings

2012-08-29 Thread Chris Ball
Hi, On Wed, Aug 29 2012, Jingoo Han wrote: This patch fixes the checkpatch error and warnings listed below: ERROR: return is not a function, parentheses are not required WARNING: Prefer pr_err(... to printk(KERN_ERR, ... WARNING: quoted string split across lines WARNING: line over 80

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

2012-08-29 Thread Ulf Hansson
Hi Jaehoon, On 28 August 2012 06:33, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Ulf, This patch is to support eMMC5.0.(already discussing on eMMC5.0.) Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's case) Until the spec is really set we should not add some new code

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

2012-08-29 Thread Kyungmin Park
Hi Ulf, On 8/29/12, Ulf Hansson ulf.hans...@linaro.org wrote: Hi Jaehoon, On 28 August 2012 06:33, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Ulf, This patch is to support eMMC5.0.(already discussing on eMMC5.0.) Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's

Re: [PATCH] mmc: core: Quieten could not set regulator OCR error.

2012-08-29 Thread Ulf Hansson
Hi Chris, On 28 August 2012 01:33, Chris Ball c...@laptop.org wrote: Some distributions build with CONFIG_REGULATOR_DUMMY=y -- this makes regulator setup succeed harmlessly, but then trying to set the voltage on the dummy regulator will fail as below: [ 6.413866] sdhci-pci :03:00.0:

Re: [PATCH] mmc: core: Quieten could not set regulator OCR error.

2012-08-29 Thread Chris Ball
Hi, adding Mark and Liam, On Wed, Aug 29 2012, Ulf Hansson wrote: On 28 August 2012 01:33, Chris Ball c...@laptop.org wrote: Some distributions build with CONFIG_REGULATOR_DUMMY=y -- this makes regulator setup succeed harmlessly, but then trying to set the voltage on the dummy regulator will

RE: [PATCH v2 1/5] mmc: dw-mmc: ensure that the card is not busy when changing clock

2012-08-29 Thread Seungwon Jeon
On Tuesday, August 29, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/29/2012 10:21 AM, Seungwon Jeon wrote: On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: synopsys spec is mentioned. (7.1 Software/Hardware Restrictions) Before disabling clock, ensure that

RE: [PATCH v6] mmc: card: Skip secure option for MoviNAND.

2012-08-29 Thread IAN CHEN
Hi, Thanks for your help. The effected kernel will be all the version with MMC_CAP_ERASE SECURE option enabled. As commit content mentioned, the problem is unrecoverable corruption after SECURE ERASE or SECURE TRIM. For devices using defective eMMC with kernel supporting MMC_CAP_ERASE SECURE

RE: [PATCH v2 4/5] mmc: dw-mmc: add the use_hold_reg in CMD register

2012-08-29 Thread Seungwon Jeon
On Tuesday, August 29, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/29/2012 10:21 AM, Seungwon Jeon wrote: On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: This patch is added the use_hold_reg bit in CMD register. In upper version than 2.40a, bit[29] of

Re: [PATCH v6] mmc: card: Skip secure option for MoviNAND.

2012-08-29 Thread Chris Ball
Hi, On Wed, Aug 29 2012, IAN CHEN wrote: Thanks for your help. The effected kernel will be all the version with MMC_CAP_ERASE SECURE option enabled. As commit content mentioned, the problem is unrecoverable corruption after SECURE ERASE or SECURE TRIM. For devices using defective eMMC with

Re: [PATCH v2 4/5] mmc: dw-mmc: add the use_hold_reg in CMD register

2012-08-29 Thread Jaehoon Chung
On 08/30/2012 10:36 AM, Seungwon Jeon wrote: On Tuesday, August 29, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/29/2012 10:21 AM, Seungwon Jeon wrote: On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: This patch is added the use_hold_reg bit in CMD register.

Re: [PATCH v2 1/5] mmc: dw-mmc: ensure that the card is not busy when changing clock

2012-08-29 Thread Jaehoon Chung
On 08/30/2012 10:19 AM, Seungwon Jeon wrote: On Tuesday, August 29, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/29/2012 10:21 AM, Seungwon Jeon wrote: On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: synopsys spec is mentioned. (7.1 Software/Hardware