Re: [PATCH] mmc: mxs-mmc: implement broken-cd

2012-09-09 Thread Shawn Guo
On Fri, Sep 07, 2012 at 02:45:17PM +0300, Lauri Hintsala wrote: > This feature allows to use SDIO bus without wiring card detect > signal. This looks like a case of "broken-cd" ... > This is relevant in cases where SDIO device is connected to > SDIO bus and there is no way to disconnect device fr

Re: [PATCHv2 1/2] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-09-09 Thread S, Venkatraman
On Sat, Sep 8, 2012 at 3:29 AM, Kevin Hilman wrote: > Venkatraman S writes: > >> omap hsmmc controller IP has a built in timer that can be programmed to >> guard against unresponsive operations. But its range is very narrow, >> and the maximum countable time is a few seconds. >> >> Card maintenan

[PATCH] mmc: sdhci: set regulator min/max voltage according to spec

2012-09-09 Thread Kevin Liu
From: Kevin Liu Use voltage range as below rather than a specific value 3.3v: (3.2v, 3.4v) 3.0v: (2.9v, 3.1v) 1.8v: (1.65v, 1.95v) Signed-off-by: Jialing Fu Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff

[PATCH] mmc: sdhci: fix transfer mode setting bug for cmds w/o data transfer

2012-09-09 Thread Kevin Liu
From: Kevin Liu Commands without data transfer like cmd5/cmd7 will use previous transfer mode setting, which may lead to error since some bits may have been set unexpectedly. For example, cmd5 following cmd18/cmd25 will have timeout error since audo cmd23 has been enabled. Signed-off-by: Jialing

[PATCH v2] mmc: slot-gpio: Add support for power gpios

2012-09-09 Thread Chris Ball
A power gpio is a sideband output gpio that controls card power. Signed-off-by: Chris Ball --- Changelog: v2, addressing Guennadi's review comments: - More consistent comment and operator coding style - Only store pwr_gpio in ctx if requesting it was successful - Use GPIOF_OUT_INIT_{LOW,HIGH}

[PATCH v2] mmc: slot-gpio: Fix missing assignment to ctx->ro_gpio

2012-09-09 Thread Chris Ball
mmc_gpio_request_ro() doesn't store the requested gpio in ctx->ro_gpio. As a result, subsequent calls to mmc_gpio_get_ro() will always fail with -ENOSYS because the gpio number isn't available to that function. Cc: stable Signed-off-by: Chris Ball --- v2, addressing Guennadi's review comments:

Re: [PATCH] mmc: slot-gpio: Add support for power gpios

2012-09-09 Thread Chris Ball
Hi Guennadi, Thanks for getting to this review so quickly! I agree with all of your comments. I'm sending out v2 of both patches now. On Sun, Sep 09 2012, Guennadi Liakhovetski wrote: >> The zero-length array trick might be becoming unmaintainable as we add >> more labels to the struct like thi

Re: [PATCH] mmc: slot-gpio: Add support for power gpios

2012-09-09 Thread Guennadi Liakhovetski
Hi Chris On Sat, 8 Sep 2012, Chris Ball wrote: > A power gpio is a sideband output gpio that controls card power. > > Signed-off-by: Chris Ball > --- > Hi Guennadi, what do you think of this patch? I'm hoping to use it Looks good in general to me, thanks! Just a couple of nit-picks below. >

Re: [PATCH] mmc: slot-gpio: Fix missing assignment to ctx->ro_gpio

2012-09-09 Thread Guennadi Liakhovetski
Hi Chris On Sat, 8 Sep 2012, Chris Ball wrote: > mmc_gpio_request_ro() doesn't store the requested gpio in ctx->ro_gpio. > As a result, subsequent calls to mmc_gpio_get_ro() will always fail > with -ENOSYS because the gpio number isn't available to that function. > > Cc: stable > Signed-off-by:

RE: [PATCH v8 1/2] block: ioctl support for sanitize in eMMC 4.5

2012-09-09 Thread Yaniv Gardi
I didn't quite understand everything that you meant in your mail, however I will try to explain briefly: SANITIZE replaces the need to issue REQ_SECURE as part of the REQ_DISCARD request. In this way DISCARD request finishes much faster (order of magnitude) and thus improves system performance. Wh