2012/9/27 Ulf Hansson ulf.hans...@linaro.org:
On 27 September 2012 12:39, Kevin Liu keyuan@gmail.com wrote:
Hi, Ulf
2012/9/27 Ulf Hansson ulf.hans...@linaro.org:
Hi Kevin,
On 26 September 2012 13:38, Kevin Liu keyuan@gmail.com wrote:
From: Kevin Liu kl...@marvell.com
Mmc does NOT
Let the upper layers handle the details of the UHS signal voltage
switch, such as timings and detection and handling of failure states.
Implement the card_busy host_ops function to let the upper layers
check if the card is signaling busy.
Signed-off-by: Johan Rudholm johan.rudh...@stericsson.com
This patchset does as follows:
[PATCH v5 01/13] mmc: sdhci: fix transfer mode setting bug for cmds w/o data
transfer
[PATCH v5 02/13] mmc: sdhci: refine voltage support caps setting
[PATCH v5 03/13] mmc: sdhci: use regulator min/max voltage range according to
spec
[PATCH v5 04/13] mmc: sdhci:
From: Kevin Liu kl...@marvell.com
Commands without data transfer like cmd5/cmd7 will use previous
transfer mode setting, which may lead to error since some bits
may have been set unexpectedly.
For example, cmd5 following cmd18/cmd25 will have timeout error
since audo cmd23 has been enabled.
From: Kevin Liu kl...@marvell.com
No need to disable the voltage support caps if
it was NOT supported originally
Signed-off-by: Kevin Liu kl...@marvell.com
---
drivers/mmc/host/sdhci.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c
From: Kevin Liu kl...@marvell.com
The clock rate set to the sdh controller may not exactly as requested
by the mmc core, this patch make the clock rate saved in the mmc_ios
and sdhci_host updated with the actual setting as in the controller. Thus
/sys/kernel/debug/mmcx/ios and card detect prints
From: Kevin Liu kl...@marvell.com
For regulator vmmc/vmmcq, use voltage range as below
3.3v/3.0v: (2.7v, 3.6v)
1.8v: (1.7v, 1.95v)
Original code use the specific value which may fail in regulator
driver if it does NOT support the specific voltage.
Signed-off-by: Jialing Fu j...@marvell.com
From: Kevin Liu kl...@marvell.com
regulator_get() returns NULL when CONFIG_REGULATOR not defined,
which should not print out the warning.
Reviewed-by: Philip Rakity prak...@marvell.com
Signed-off-by: Bin Wang b...@marvell.com
Signed-off-by: Kevin Liu kl...@marvell.com
---
From: Kevin Liu kl...@marvell.com
Enable the quirk SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN since
SD_CAPABILITIES_1[15:8](BASE_FREQ) can't get correct base
clock value. It return a fixed pre-set value like 200 on
some sdhci-pxav3 based platforms like MMP3 while return 0
on the other sdhci-pxav3 based
From: Kevin Liu kl...@marvell.com
Both of MMC_TIMING_LEGACY and MMC_TIMING_UHS_SDR12 are defined
to 0. And ios-timing is set to MMC_TIMING_LEGACY during power up.
But set_ios can't distinguish these two timing if host support
spec 3.0. Just adjust timing values to be different can resolve
this
From: Kevin Liu kl...@marvell.com
Preset value support was added by 4d55c5a1.
But preset value is enabled after setting clock finished,
which means the clock is still set by driver firstly and
then switch to preset value at this point. So the
driver setting beforehand is useless and unnecessary.
From: Kevin Liu kl...@marvell.com
Signed-off-by: Kevin Liu kl...@marvell.com
---
drivers/mmc/host/sdhci-pxav3.c |2 ++
include/linux/platform_data/pxa_sdhci.h |2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c
From: Kevin Liu kl...@marvell.com
Some soc/platform need specific handling for signal voltage
switch. For example, mmp2/mmp3 need to set the AIB IO domain
control register accordingly.
Signed-off-by: Bin Wang b...@marvell.com
Signed-off-by: Philip Rakity prak...@marvell.com
Signed-off-by: Kevin
From: Kevin Liu kl...@marvell.com
Because sdhci can do the same thing so no need to implement this.
Signed-off-by: Kevin Liu kl...@marvell.com
---
drivers/mmc/host/sdhci-pxav3.c | 39 ---
1 files changed, 0 insertions(+), 39 deletions(-)
diff --git
Hi Viresh,
On Fri, Sep 28 2012, Viresh Kumar wrote:
This adds simple DT bindings for SDHCI SPEAr controller. It uses cd-gpios from
common mmc bindings.
This also fixes spear300-evb.dts with correct name for card detect binding.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
On Fri, Sep 28, 2012 at 2:33 PM, Chris Ball c...@laptop.org wrote:
On Fri, Sep 28 2012, Viresh Kumar wrote:
+- reg : Address range of the sdhci
+- interrupt-parent: Should be the phandle for the interrupt controller
+ that services interrupts for this device
+- interrupt: Should contain the
On Fri, Sep 28, 2012 at 2:33 PM, Chris Ball c...@laptop.org wrote:
You don't have to mention reg/interrupts, because they're already
covered in mmc.txt.
power-gpio should be power-gpios (even though there's only one), and
power_always_enb should use hyphens instead of underscores
Hi Chris,
On Fri, Sep 28, 2012 at 6:21 AM, Seungwon Jeon tgih@samsung.com wrote:
Even though platform_get_irq returns error, 'host-irq'
always has an unsigned value. Less-than-zero comparison
of an unsigned value is never true. Type of 'unsigned int'
will be changed for 'int'.
Signed-off-by:
In case both 'req' and 'mq-mqrq_prev-req' are null, there is no request
to be processed. That means there is no need to switch buffer.
Switching buffer is required only after finishing 'issue_fn'.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/card/queue.c | 17
This patch removes the following warning.
drivers/mmc/host/dw_mmc.c:1976: warning: passing argument 1 of
'_dev_info' from incompatible pointer type
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Hi,
On Fri, Sep 28 2012, viresh kumar wrote:
You should use a fixed regulator instead of this power-gpio hack.
It's easy to hook up a fixed regulator to a gpio:
vmmc1: fixedregulator@0 {
compatible = regulator-fixed;
regulator-name = fixed-supply;
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/mmc/host/sdhci-spear.c | 10
This adds simple DT bindings for SDHCI SPEAr controller. It uses cd-gpios from
common mmc bindings.
This also fixes spear300-evb.dts with correct name for card detect binding.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
V1-V2:
- Use cd-gpios instead of int-gpio as binding for card
Anton,
For adding a new QUICK which is something like SDHCI_QUICK_NEEDS_POLL, I think
it is unnecessary since it actually has the same meaning as
MMC_CAP_NEEDS_POLLING. Actually, we can directly set MMC_CAP_NEEDS_POLL in host
driver.
So I prefer to review all the host drivers, and proposed
On Fri, Sep 28, 2012 at 11:13 AM, Seungwon Jeon tgih@samsung.com wrote:
This patch removes the following warning.
drivers/mmc/host/dw_mmc.c:1976: warning: passing argument 1 of
'_dev_info' from incompatible pointer type
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
Hi,
On Fri, Sep 28 2012, Viresh Kumar wrote:
This adds simple DT bindings for SDHCI SPEAr controller. It uses cd-gpios from
common mmc bindings.
This also fixes spear300-evb.dts with correct name for card detect binding.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
V1-V2:
-
Hi,
On Fri, Sep 28 2012, Viresh Kumar wrote:
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Hi,
This is really a micro optimization. Still the patch looks correct.
CUR and PREV will have the same values before and after this patch.
Before this patch, NULL was assigned to NULL which is not necessary of course.
Reviewed-by: Per Forlin per.for...@stericsson.com
Thanks,
Per
On Fri, Sep
Hi,
Tested-by: Johan Rudholm johan.rudh...@stericsson.com
//Johan
2012/9/28 Per Forlin per.l...@gmail.com:
Hi,
This is really a micro optimization. Still the patch looks correct.
CUR and PREV will have the same values before and after this patch.
Before this patch, NULL was assigned to
Hi,
sorry, spotted one snafu:
2012/9/28 Johan Rudholm johan.rudh...@stericsson.com:
+static void sdhci_card_busy(struct mmc_host *mmc, bool keep_busy)
should be
static int sdhci_card_busy(struct mmc_host *mmc, int keep_busy)
Kind regards, Johan
--
To unsubscribe from this list: send the
The MODULE_DEVICE_TABLE() entry in the dw_mmc_exynos driver
points to the wrong symbol which results in a link error
when building as a loadable module.
Further, we get a warning about the driver_data being
marked constant, which requires annotating a few pointers
as const.
Signed-off-by: Arnd
On 09/11/2012 12:54 AM, wei_w...@realsil.com.cn wrote:
From: Wei WANG wei_w...@realsil.com.cn
Support for Realtek PCI-Express driver-based card readers including rts5209
and rts5229.
v2:
1. Using platform device to replace realtek slot bus
v3:
1. Fix a bug that DMA out of SW-IOMMU
32 matches
Mail list logo
