When booting with device tree, we don't have any pdata, and will
get the following when trying to unload omap_hsmmc:
Unable to handle kernel NULL pointer dereference at virtual address 0044
pgd = edafc000
*pgd=adbbd831, *pte=, *ppte=
SMP ARM
Modules linked in: omap_hsmmc(-) oma
Hi,
On Fri, Nov 09, 2012 at 09:36:16PM +0530, Balaji T K wrote:
> update error code to cmd->error for commands with response_busy and no data
>
> Signed-off-by: Balaji T K
Just one comment below, otherwise:
Reviewed-by: Felipe Balbi
> ---
> drivers/mmc/host/omap_hsmmc.c |4 ++--
> 1 fil
On Fri, Nov 09, 2012 at 09:36:15PM +0530, Balaji T K wrote:
> Avoid soft reset of command internal state machine on data errors.
>
> Signed-off-by: Balaji T K
Reviewed-by: Felipe Balbi
> ---
> drivers/mmc/host/omap_hsmmc.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> dif
On Fri, Nov 09, 2012 at 09:36:14PM +0530, Balaji T K wrote:
> "commit ae4bf788ee9bf7c2d51b0309117d1fcccbdd50a2
> mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ"
> sets both end_cmd and end_trans to 1.
>
> Setting end_cmd to 1 for Data Timeout/CRC leads to NULL pointer dereference
"commit ae4bf788ee9bf7c2d51b0309117d1fcccbdd50a2
mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ"
sets both end_cmd and end_trans to 1.
Setting end_cmd to 1 for Data Timeout/CRC leads to NULL pointer dereference of
host->cmd as the command complete has previously been handled.
Set
Avoid soft reset of command internal state machine on data errors.
Signed-off-by: Balaji T K
---
drivers/mmc/host/omap_hsmmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 245d7b5..d931e08 100644
---
update error code to cmd->error for commands with response_busy and no data
Signed-off-by: Balaji T K
---
drivers/mmc/host/omap_hsmmc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index d931e08..1503808
Balaji T K (3):
mmc: omap_hsmmc: Fix Oops in case of data errors
mmc: omap_hsmmc: no reset of cmd state machine for DCRC
mmc: omap_hsmmc: update error code for response_busy cmd
drivers/mmc/host/omap_hsmmc.c | 24 +++-
1 files changed, 15 insertions(+), 9 deletions(-)
On Tuesday 06 November 2012 10:22 PM, Venkatraman S wrote:
Sometimes, a error occurs just after the Command has been reported
to be successful (CC=1) but before data transfer completes (TC=1).
Setting end_cmd=1 here leads to a NULL pointer dereference of
host->cmd as the command complete has prev
Hi,
On Fri, Nov 09 2012, wwang wrote:
> I have noticed that the file rtsx_pci_sdmmc.c in your mmc-next branch
> is still v6 patch. In v7 patch, this MMC part has also been modified
> to comply with my MFD portion. So please update to this version.
>
> And one more question. Samuel have merged al
On Thu, 2012-10-18 at 16:29 +0800, Huang Shijie wrote:
> 于 2012年10月18日 16:16, Marek Vasut 写道:
> > So we can't stream data from the chip? About time to adjust the MTD
> > framework to
> > allow that. Maybe implement a command queue?
> >
>
> to Artem & David:
> is this possible to stream the da
On Friday 09 November 2012 08:22 PM, Felipe Balbi wrote:
On Fri, Nov 09, 2012 at 08:11:19PM +0530, Balaji T K wrote:
Setting end_cmd to 1 for Data Timeout/CRC leads to NULL pointer dereference of
host->cmd as the command complete has previously been handled.
Set end_cmd only in case of Data Time
于 11/08/2012 03:41 AM, Chris Ball 写道:
Hi,
On Mon, Oct 29 2012, wwang wrote:
I'm happy with the MMC portion. I think we're mainly waiting for the
MFD patch -- Samuel, do you have any remaining review comments that need
to be fixed?
Thanks,
- Chris.
Hi Chris:
I have noticed that the file rts
On Fri, Nov 09, 2012 at 08:11:19PM +0530, Balaji T K wrote:
> Setting end_cmd to 1 for Data Timeout/CRC leads to NULL pointer dereference of
> host->cmd as the command complete has previously been handled.
> Set end_cmd only in case of Data Timeout/CRC.
this comment doesnt match code as code is se
Setting end_cmd to 1 for Data Timeout/CRC leads to NULL pointer dereference of
host->cmd as the command complete has previously been handled.
Set end_cmd only in case of Data Timeout/CRC.
While at it restore error handling behaviour as was before the
"commit ae4bf788ee9bf7c2d51b0309117d1fcccbdd50a
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
tags/mmc-fixes-for-3.7-rc5
to receive MMC fixes for 3.7-rc5. There are no merge conflicts, and the
patches have been tested in linux-next. Thanks.
The following changes since commit ddffeb8c4d0331609ef25
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 2ff2b9e..2d3d76e 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -898,9 +898,9 @@
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 73bb41f..28da461 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1138,9 +1138,9
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index c7851c0..2ff2b9e 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -667,9 +667,9 @@
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 2d3d76e..73bb41f 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -924,9 +924,9
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c | 20
1 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 47cac71..5cddb74 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 4bed582..47cac71 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2286,9 +2286,9
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index b947155..4bed582 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1792,9 +1792,9
Signed-off-by: Tushar Behera
---
drivers/mmc/host/sdhci.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 28da461..b947155 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1386,9 +
Documents/CodingStyle Chapter 3 recommends usage of braces for both
if and else statements if any of the branches contains multiple
statements.
Cleaning up drivers/mmc/host/sdhci.c for all these occurrences.
Tushar Behera (8):
mmc: sdhci: fix coding style in sdhci_calc_timeout
mmc: sdhci: fix
clock shoud be supplied during bus transaction. This patch defers
clk_disabe in runtime_suspend if cmd/data line is used.
Signed-off-by: Seungwon Jeon
Acked-by: Heiko Stuebner
---
V3: Removed the error message. (reported by Fengguang Wu)
drivers/mmc/host/sdhci-s3c.c | 13 +
drive
Fengguang Wu wrote:
> On Wed, Nov 07, 2012 at 03:43:05PM -0500, Chris Ball wrote:
> > Hi,
> >
> > On Wed, Nov 07 2012, kbuild test robot wrote:
> > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc-next
> > > head: a6a567a4c25762e36228d2d0c8c1859085132e15
> > > commit: 90ba
On 06/09/2012 12:56 AM, philipspatc...@gmail.com wrote:
> From: Philip Rakity
>
> If we are using a regulator the SD Host Controller and the
> regulator should agree about the voltages supported. Use
> the common subset that is supported.
>
> Signed-off-by: Philip Rakity
> ---
> drivers/mmc/h
28 matches
Mail list logo
