[PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

2012-11-22 Thread Russell King
This commit taken from Rabeeh's Cubox kernel and re-worked for DT; Sebastian Hasselbrath is believed to be the original author. Some Cuboxes require a GPIO for card detection; this implements the optional GPIO support for card detection. This GPIO is logic 0 for card inserted. Signed-off-by: Rus

[PATCH 2/3] MMC: sdhci-dove: use two-stage initialization for sdhci-pltfm

2012-11-22 Thread Russell King
We need to use the two-stage initialization for sdhci-pltfm if we're going to do anything extra at initialization time. Signed-off-by: Russell King --- drivers/mmc/host/sdhci-dove.c | 24 +--- 1 files changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/

[PATCH 1/3] MMC: sdhci-dove: use devm_clk_get()

2012-11-22 Thread Russell King
Use devm_clk_get() rather than clk_get() to make cleanup paths more simple. Signed-off-by: Russell King --- drivers/mmc/host/sdhci-dove.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c index 8fd50a2

[PATCH 0/3] sdhci-dove GPIO support for card detection

2012-11-22 Thread Russell King - ARM Linux
The following three patches allow sdhci-dove to use a GPIO for card presence detection. This is a three stage process: 1. Clean up error paths by using devm_clk_get(). 2. Use the two-stage sdhci initialization. 3. Implement the GPIO card detection support. A very similar patch has been tested by

Re: [PATCH 414/493] mmc: remove use of __devexit

2012-11-22 Thread Guennadi Liakhovetski
On Mon, 19 Nov 2012, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devexit is no > longer needed. > drivers/mmc/host/sh_mmcif.c| 2 +- > drivers/mmc/host/tmio_mmc.c| 2 +- Acked-by: Guennadi Liakhovetski Thanks Guennadi --- Guennadi Liakhovetski, Ph.D.

Re: [PATCH 237/493] mmc: remove use of __devinit

2012-11-22 Thread Guennadi Liakhovetski
On Mon, 19 Nov 2012, Bill Pemberton wrote: > drivers/mmc/host/sh_mmcif.c| 2 +- > drivers/mmc/host/sh_mobile_sdhi.c | 2 +- > drivers/mmc/host/tmio_mmc.c| 2 +- > drivers/mmc/host/tmio_mmc_pio.c| 2 +- Acked-by: Guennadi Liakhovetski Thanks Guennadi --- Guennadi Liakhov

[PATCH v2 2/2] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-22 Thread Doug Anderson
On some SoCs (like exynos5250) you need to use an external GPIO for write protect. Add support for wp-gpios to the core dw_mmc driver since it could be useful across multiple SoCs. With this change I am able to make use of the write protect for the external SD slot on exynos5250-snow. Signed-off

[PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-22 Thread Doug Anderson
The exynos code claimed wp-gpio with devm_gpio_request() but never did anything with it. That meant that anyone using a write protect GPIO would effectively be write protected all the time. A future change will move the wp-gpio support to the core dw_mmc.c file. Now the exynos-specific code won'

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-22 Thread Rafael J. Wysocki
On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: > On 22/11/12 15:55, Chris Ball wrote: > > Hi, > > > > On Thu, Nov 22 2012, Adrian Hunter wrote: > >> Here is SDHCI ACPI driver. It is dependent on new ACPI Platform support > >> so I suggest Rafael takes the patches with Chris' Ack.

Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

2012-11-22 Thread Chris Ball
Hi Manoj, Matsumuro-san, On Mon, Jul 18 2011, Manoj Iyer wrote: > Right, without the patch I get.. > > [ 52.526665] mmc0: new SDHC card at address e624 > [ 52.571228] mmcblk0: mmc0:e624 SD16G 14.8 GiB > [ 52.591071] mmcblk0: retrying using single block read > [ 52.593105] mmcblk0: error -8

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-22 Thread Chris Ball
Hi, On Thu, Nov 22 2012, Adrian Hunter wrote: > Here is SDHCI ACPI driver. It is dependent on new ACPI Platform support > so I suggest Rafael takes the patches with Chris' Ack. > > Please note that I would prefer this to be queued for 3.8 Looks fine: Acked-by: Chris Ball I have some dumb ques

Re: [PATCH 2/2] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-22 Thread Doug Anderson
Jaehoon, Thanks for the review. See below for comments. I'll plan on a new patch either Monday or Tuesday when I have a chance to spin and re-test. On Wed, Nov 21, 2012 at 5:55 PM, Jaehoon Chung wrote: > On 11/22/2012 07:03 AM, Doug Anderson wrote: >> On some SoCs (like exynos5250) you need t

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-22 Thread Adrian Hunter
On 22/11/12 15:55, Chris Ball wrote: > Hi, > > On Thu, Nov 22 2012, Adrian Hunter wrote: >> Here is SDHCI ACPI driver. It is dependent on new ACPI Platform support >> so I suggest Rafael takes the patches with Chris' Ack. >> >> Please note that I would prefer this to be queued for 3.8 > > Looks

[PATCH 0/3] Add SDHCI ACPI driver

2012-11-22 Thread Adrian Hunter
Hi Here is SDHCI ACPI driver. It is dependent on new ACPI Platform support so I suggest Rafael takes the patches with Chris' Ack. Please note that I would prefer this to be queued for 3.8 Adrian Hunter (3): PNPACPI: exclude SDHCI devices ACPI: add SDHCI to ACPI platform devices

Re: [PATCH v3 0/5] mmc: Add access to RPMB partition

2012-11-22 Thread Sundar J. Dev
Hi Loic, On Wed, Nov 21, 2012 at 11:02 PM, Loic PALLARDY wrote: > Hi Sundar, > > On 11/21/2012 12:02 PM, Sundar J. Dev wrote: >> Hi Loic, >> >> On Wed, Nov 21, 2012 at 3:25 PM, Loic PALLARDY wrote: >>> I am guessing that you would expect the userspace application too call into the

Re: [PATCH v3 1/4] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

2012-11-22 Thread Jaehoon Chung
Hi Mr, Seungwon. Do you have any opinion about this patch and others? If you have, let me know, plz. Best Regards, Jaehoon Chung On 11/08/2012 05:35 PM, Jaehoon Chung wrote: > To ensure the stable clock need to enable before set the > DW_MMC_CARD_NEED_INIT flag. > If set DW_MMC_CARD_NEED_INIT f

Re: [PATCH 2/2] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-22 Thread Doug Anderson
On Wed, Nov 21, 2012 at 5:42 PM, Seungwon Jeon wrote: > Hi, > > wp-gpios has been implemented in dw_mmc-exynos.c > It can be reused for EXYNOS platform? We need to modify some though. Yup, I've seen that. Patch 1/2 ("mmc: dw_mmc: exynos: Stop claiming wp-gpio") addressed that. For some reason I

Re: [PATCH 2/2] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-22 Thread Jaehoon Chung
On 11/22/2012 07:03 AM, Doug Anderson wrote: > On some SoCs (like exynos5250) you need to use an external GPIO for > write protect. Add support for wp-gpios to the core dw_mmc driver > since it could be useful across multiple SoCs. > > With this change I am able to make use of the write protect f

RE: [PATCH 2/2] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-22 Thread Seungwon Jeon
On Thursday, November 22, 2012, Doug Anderson wrote: > On Wed, Nov 21, 2012 at 5:42 PM, Seungwon Jeon wrote: > > Hi, > > > > wp-gpios has been implemented in dw_mmc-exynos.c > > It can be reused for EXYNOS platform? We need to modify some though. > > Yup, I've seen that. Patch 1/2 ("mmc: dw_mmc

RE: [PATCH 2/2] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-22 Thread Seungwon Jeon
Hi, wp-gpios has been implemented in dw_mmc-exynos.c It can be reused for EXYNOS platform? We need to modify some though. Thanks, Seungwon Jeon On Thursday, November 22, 2012, Doug Anderson wrote: > On some SoCs (like exynos5250) you need to use an external GPIO for > write protect. Add suppor

Re: FW: eMMC

2012-11-22 Thread Kevin Liu
> From: linux-mmc-ow...@vger.kernel.org > [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Philip Rakity > Sent: Wednesday, November 21, 2012 8:42 PM > To: linux-mmc@vger.kernel.org > Subject: RFC: eMMC > > Recently there have been a number of patches to sdhci.c and discussions on > regulato

Re: eMMC

2012-11-22 Thread Kevin Liu
2012/11/22 Philip Rakity : > > On Nov 22, 2012, at 11:26 AM, Kevin Liu wrote: > >>> From: linux-mmc-ow...@vger.kernel.org >>> [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Philip Rakity >>> Sent: Wednesday, November 21, 2012 8:42 PM >>> To: linux-mmc@vger.kernel.org >>> Subject: RFC: eMMC

[PATCH 2/2] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-22 Thread Doug Anderson
On some SoCs (like exynos5250) you need to use an external GPIO for write protect. Add support for wp-gpios to the core dw_mmc driver since it could be useful across multiple SoCs. With this change I am able to make use of the write protect for the external SD slot on exynos5250-snow. Signed-off

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-22 Thread Ulf Hansson
On 21 November 2012 17:50, Russell King - ARM Linux wrote: > On Wed, Nov 21, 2012 at 05:13:55PM +0100, Per Forlin wrote: >> On Wed, Nov 21, 2012 at 4:38 PM, Russell King - ARM Linux >> wrote: >> > On Fri, Oct 12, 2012 at 04:02:02PM +0200, Ulf Hansson wrote: >> >> /* >> >> + * Validate mmc prereq

[PATCH 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-22 Thread Doug Anderson
The exynos code claimed wp-gpio with devm_gpio_request() but never did anything with it. That meant that anyone using a write protect GPIO would effectively be write protected all the time. A future change will move the wp-gpio support to the core dw_mmc.c file. Now the exynos-specific code won'

[PATCH 2/3] ACPI: add SDHCI to ACPI platform devices

2012-11-22 Thread Adrian Hunter
Signed-off-by: Adrian Hunter --- drivers/acpi/scan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 8c4ac6d..67a7fa6 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -35,6 +35,8 @@ static const char *dummy_hid = "device"; */ s

Re: eMMC

2012-11-22 Thread Kevin Liu
2012/11/22 Philip Rakity : > > On Nov 22, 2012, at 11:44 AM, Kevin Liu wrote: > >> 2012/11/22 Philip Rakity : >>> >>> On Nov 22, 2012, at 11:26 AM, Kevin Liu wrote: >>> > From: linux-mmc-ow...@vger.kernel.org > [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Philip Rakity > Sen

[PATCH 1/3] PNPACPI: exclude SDHCI devices

2012-11-22 Thread Adrian Hunter
These devices will be handled by a ACPI Platform driver. Signed-off-by: Adrian Hunter --- drivers/pnp/pnpacpi/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c index 26b5d4b..5b17cc8 100644 --- a/drivers/pnp/pnpacpi/core.c +++ b/dr

[PATCH 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-22 Thread Adrian Hunter
Signed-off-by: Adrian Hunter --- drivers/mmc/host/Kconfig | 12 ++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-acpi.c | 304 ++ 3 files changed, 317 insertions(+) create mode 100644 drivers/mmc/host/sdhci-acpi.c diff --git a/driver

Re: eMMC

2012-11-22 Thread Philip Rakity
On Nov 22, 2012, at 11:26 AM, Kevin Liu wrote: >> From: linux-mmc-ow...@vger.kernel.org >> [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Philip Rakity >> Sent: Wednesday, November 21, 2012 8:42 PM >> To: linux-mmc@vger.kernel.org >> Subject: RFC: eMMC >> >> Recently there have been a n

Re: eMMC

2012-11-22 Thread Philip Rakity
On Nov 22, 2012, at 11:44 AM, Kevin Liu wrote: > 2012/11/22 Philip Rakity : >> >> On Nov 22, 2012, at 11:26 AM, Kevin Liu wrote: >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Philip Rakity Sent: Wednesday, November 21, 2012 8:42

[PATCH] mmc: esdhi: Add SDHCI_QUIRK_QORIQ_CIRCUIT_SUPPORT_VS33 quirk support

2012-11-22 Thread Chunhe Lan
On the some platforms of Freescale, sdhci controller can only support 1.8V voltage, but the peripheral hardware circuit has capability to support 3.3V voltage. Signed-off-by: Chunhe Lan --- drivers/mmc/host/sdhci.c |3 +++ include/linux/mmc/sdhci.h |4 2 files changed, 7 insertions

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2012 at 06:28:30PM +0100, Per Forlin wrote: > On Wed, Nov 21, 2012 at 5:50 PM, Russell King - ARM Linux > wrote: > > On Wed, Nov 21, 2012 at 05:13:55PM +0100, Per Forlin wrote: > >> On Wed, Nov 21, 2012 at 4:38 PM, Russell King - ARM Linux > >> wrote: > >> > On Fri, Oct 12, 2012 a

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2012 at 02:43:10PM +0100, Ulf Hansson wrote: > The mmci_pio_read|write functions are being provided with sg element > buffers, which may have any length and any address alignment, as you > stated. > > This example is a read: > -sg-list has 2 elements. > -sg-element [0], is 3 bytes

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-22 Thread Per Forlin
On Wed, Nov 21, 2012 at 5:50 PM, Russell King - ARM Linux wrote: > On Wed, Nov 21, 2012 at 05:13:55PM +0100, Per Forlin wrote: >> On Wed, Nov 21, 2012 at 4:38 PM, Russell King - ARM Linux >> wrote: >> > On Fri, Oct 12, 2012 at 04:02:02PM +0200, Ulf Hansson wrote: >> >> /* >> >> + * Validate mmc