Re: [PATCH v2 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Rafael J. Wysocki
On Friday, November 23, 2012 01:35:58 PM Adrian Hunter wrote: > Hi > > Here is SDHCI ACPI driver. > > Changes for v2: > > Dropped "PNPACPI: exclude SDHCI devices" > Added "PNPACPI: exclude devices already bound" > Changed dev->acpi_handle to ACPI_HANDLE(dev) > Added Chris

Re: [PATCH v2 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Fri, Nov 23, 2012 at 01:36:01PM +0200, Adrian Hunter wrote: > Signed-off-by: Adrian Hunter > Acked-by: Chris Ball Looks like you left that redundant check in place but it doesn't hurt anyway. Reviewed-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-mmc

Re: [PATCH v2 2/3] ACPI: add SDHCI to ACPI platform devices

2012-11-23 Thread Mika Westerberg
On Fri, Nov 23, 2012 at 01:36:00PM +0200, Adrian Hunter wrote: > Signed-off-by: Adrian Hunter Reviewed-by: Mika Westerberg > --- > drivers/acpi/scan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index 8c4ac6d..67a7fa6 100644 > --- a/d

Re: [PATCH] mmc: dw_mmc: enable controller interrupt before calling mmc_start_host

2012-11-23 Thread James Hogan
Hi, I looked at the clock thing, and it appears that there's an extra divide by two in hardware (the TRM says "Clock division is 2*n"), so those numbers do appear to be correct. >From some experimentation the other day, it appeared to be a race condition which is affected by the position of the d

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

2012-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2012 at 08:14:27PM +0800, Shawn Guo wrote: > On Fri, Nov 23, 2012 at 08:57:26AM +, Russell King - ARM Linux wrote: > > Does this work with the sdhci stuff? > > Honestly, I'm not sure, but I guess it does, since I have seen > sdhci-pxav3 driver using the helpers. Anyway, I'm go

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

2012-11-23 Thread Shawn Guo
On Fri, Nov 23, 2012 at 08:57:26AM +, Russell King - ARM Linux wrote: > Does this work with the sdhci stuff? Honestly, I'm not sure, but I guess it does, since I have seen sdhci-pxav3 driver using the helpers. Anyway, I'm going to adopt the helpers for sdhci-esdhc-imx driver to find it out.

[PATCH v2 1/3] PNPACPI: exclude devices already bound

2012-11-23 Thread Adrian Hunter
From: Mika Westerberg This will exclude ACPI platform devices from also being created as PNP devices. Signed-off-by: Adrian Hunter --- drivers/pnp/pnpacpi/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c index 26b5d4b..653d5

[PATCH v2 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-23 Thread Adrian Hunter
Signed-off-by: Adrian Hunter Acked-by: Chris Ball --- drivers/mmc/host/Kconfig | 12 ++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-acpi.c | 304 ++ 3 files changed, 317 insertions(+) create mode 100644 drivers/mmc/host/sdhci-acpi.

[PATCH v2 2/3] ACPI: add SDHCI to ACPI platform devices

2012-11-23 Thread Adrian Hunter
Signed-off-by: Adrian Hunter --- drivers/acpi/scan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 8c4ac6d..67a7fa6 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -35,6 +35,8 @@ static const char *dummy_hid = "device"; */ s

[PATCH v2 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Adrian Hunter
Hi Here is SDHCI ACPI driver. Changes for v2: Dropped "PNPACPI: exclude SDHCI devices" Added "PNPACPI: exclude devices already bound" Changed dev->acpi_handle to ACPI_HANDLE(dev) Added Chris' Ack for sdhci-acpi Adrian Hunter (2): ACPI: add SDHCI to ACPI pl

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Rafael J. Wysocki
On Friday, November 23, 2012 12:23:11 PM Adrian Hunter wrote: > On 22/11/12 23:24, Rafael J. Wysocki wrote: > > On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: > >> On 22/11/12 15:55, Chris Ball wrote: > >>> Hi, > >>> > >>> On Thu, Nov 22 2012, Adrian Hunter wrote: > Here is SD

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Rafael J. Wysocki
On Friday, November 23, 2012 12:13:13 PM Adrian Hunter wrote: > On 23/11/12 11:34, Mika Westerberg wrote: > > On Thu, Nov 22, 2012 at 10:24:33PM +0100, Rafael J. Wysocki wrote: > >> On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: > >>> On 22/11/12 15:55, Chris Ball wrote: > Hi,

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Adrian Hunter
On 22/11/12 23:24, Rafael J. Wysocki wrote: > On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: >> On 22/11/12 15:55, Chris Ball wrote: >>> Hi, >>> >>> On Thu, Nov 22 2012, Adrian Hunter wrote: Here is SDHCI ACPI driver. It is dependent on new ACPI Platform support so I sug

[PATCH] SDHC: support command with busy response expecting for TC

2012-11-23 Thread r66093
From: Jerry Huang The IP verions older than 2.3 didn't support the command with busy response which expect for TC bit set. But after the VVN2.3, eSDHC IP has supported it. Signed-off-by: Jerry Huang CC: Anton Vorontsov CC: Chris Ball --- drivers/mmc/host/sdhci-of-esdhc.c |3 +++ 1 file c

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Adrian Hunter
On 23/11/12 11:34, Mika Westerberg wrote: > On Thu, Nov 22, 2012 at 10:24:33PM +0100, Rafael J. Wysocki wrote: >> On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: >>> On 22/11/12 15:55, Chris Ball wrote: Hi, On Thu, Nov 22 2012, Adrian Hunter wrote: > Here is SDHCI

Re: [PATCH 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Thu, Nov 22, 2012 at 10:43:50AM +0200, Adrian Hunter wrote: > +static int __devinit sdhci_acpi_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + acpi_handle handle = dev->acpi_handle; This is not going to work anymore, you'll have to use ACPI_HANDLE(dev)

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Thu, Nov 22, 2012 at 10:24:33PM +0100, Rafael J. Wysocki wrote: > On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: > > On 22/11/12 15:55, Chris Ball wrote: > > > Hi, > > > > > > On Thu, Nov 22 2012, Adrian Hunter wrote: > > >> Here is SDHCI ACPI driver. It is dependent on new AC

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

2012-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2012 at 04:31:20PM +0800, Shawn Guo wrote: > On Thu, Nov 22, 2012 at 11:55:51PM +, Russell King wrote: > > This commit taken from Rabeeh's Cubox kernel and re-worked for DT; > > Sebastian Hasselbrath is believed to be the original author. > > > > Some Cuboxes require a GPIO for

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

2012-11-23 Thread Shawn Guo
On Thu, Nov 22, 2012 at 11:55:51PM +, Russell King wrote: > This commit taken from Rabeeh's Cubox kernel and re-worked for DT; > Sebastian Hasselbrath is believed to be the original author. > > Some Cuboxes require a GPIO for card detection; this implements the > optional GPIO support for card