RE: [PATCH v3 1/4] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

2012-11-26 Thread Seungwon Jeon
On Thursday, November 08, 2012, Jaehoon Chung wrote: > To ensure the stable clock need to enable before set the > DW_MMC_CARD_NEED_INIT flag. > If set DW_MMC_CARD_NEED_INIT flag, wait for 80-clock before first command > after power-up. As we have discussed, the location of 'dw_mci_setup_bus' see

Re: linux-next: Tree for Nov 26 (mmc/host/tifm_sd.c)

2012-11-26 Thread Randy Dunlap
On 11/26/2012 06:17 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20121115: > on i386: drivers/built-in.o: In function `tifm_sd_request': tifm_sd.c:(.text+0x588f95): undefined reference to `__udivdi3' somewhere inside tifm_sd_request(): I'm guessing that the call to tifm_sd_set_d

Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

2012-11-26 Thread Chris Ball
Hi Manoj, On Mon, Nov 26 2012, Manoj Iyer wrote: > Do you know what systems produce these errors? I can look and see if > we have those for testing your patch. One T430s using the ExpressCard reader¹, and one X220, both with :e823. Thanks, - Chris. ¹: http://support.lenovo.com/en_US/product-an

Re: [PATCH] mmc: Added quirks for Ricoh 1180:e823 lower base clock frequency

2012-11-26 Thread Manoj Iyer
Chris, Do you know what systems produce these errors? I can look and see if we have those for testing your patch. Cheers Manoj On Wed, 21 Nov 2012, Chris Ball wrote: Hi Manoj, Matsumuro-san, On Mon, Jul 18 2011, Manoj Iyer wrote: Right, without the patch I get.. [ 52.526665] mmc0: new

Re: [PATCH 2/2] mmc: sdhci-spear: Don't call clk_{un}prepare() in suspend resume

2012-11-26 Thread Chris Ball
Hi, On Thu, Nov 08 2012, Viresh Kumar wrote: > clk_{un}prepare is mandatory for platforms using common clock framework. > Because > for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones > in probe/remove. > > Signed-off-by: Viresh Kumar > --- > drivers/mmc/host/sdhci-sp

Re: [PATCH 1/2] mmc: sdhci-spear: Initialize sdhci clk to 50 MHz

2012-11-26 Thread Chris Ball
Hi, On Thu, Nov 08 2012, Viresh Kumar wrote: > From: Vipul Kumar Samar > > SPEAr sdhci driver expects the clock to be set to 50 MHz for proper > functioning. > This patch sets clk to 50 MHz in probe. > > Signed-off-by: Vipul Kumar Samar > Signed-off-by: Viresh Kumar > --- > drivers/mmc/host/s

Re: [PATCH v1] mmc: fix async request mechanism for sequential read scenarios

2012-11-26 Thread Konstantin Dorfman
Hello, On 11/19/2012 11:34 PM, Per Förlin wrote: On 11/19/2012 03:32 PM, Per Förlin wrote: On 11/19/2012 10:48 AM, Konstantin Dorfman wrote: I'm fine with wait_event() (block request transfers) combined with completion (for other transfer), as long as the core.c API is intact. I don't see a

Re: [PATCH 1/2] mmc: sdhci-spear: Initialize sdhci clk to 50 MHz

2012-11-26 Thread Viresh Kumar
On 26 November 2012 20:39, Chris Ball wrote: > On Thu, Nov 08 2012, Viresh Kumar wrote: >> + ret = clk_set_rate(sdhci->clk, 5000); >> + if (ret) >> + dev_dbg(&pdev->dev, "Error setting desired clk, clk=%lu\n", >> + clk_get_rate(sdhci->clk)); >> +

Re: [PATCH 1/2] mmc: sdhci-spear: Initialize sdhci clk to 50 MHz

2012-11-26 Thread Chris Ball
Hi, On Thu, Nov 08 2012, Viresh Kumar wrote: > From: Vipul Kumar Samar > > SPEAr sdhci driver expects the clock to be set to 50 MHz for proper > functioning. > This patch sets clk to 50 MHz in probe. > > Signed-off-by: Vipul Kumar Samar > Signed-off-by: Viresh Kumar > --- > drivers/mmc/host/s

Re: [PATCH 1/2] mmc: sdhci-spear: Initialize sdhci clk to 50 MHz

2012-11-26 Thread Viresh Kumar
On 20 November 2012 12:11, Viresh Kumar wrote: > On 8 November 2012 20:39, Viresh Kumar wrote: >> From: Vipul Kumar Samar >> >> SPEAr sdhci driver expects the clock to be set to 50 MHz for proper >> functioning. >> This patch sets clk to 50 MHz in probe. >> >> Signed-off-by: Vipul Kumar Samar

Re: [PATCH 1/7] mmc: omap_hsmmc: Fix Oops in case of data errors

2012-11-26 Thread Venkatraman S
On Mon, Nov 26, 2012 at 2:19 AM, Chris Ball wrote: > Hi Venkat, > > On Mon, Nov 19 2012, Venkatraman S wrote: >> From: Balaji T K >> >> "commit ae4bf788ee9bf7c2d51b0309117d1fcccbdd50a2 >> mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ" >> sets both end_cmd and end_trans to 1. >>

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-26 Thread Per Förlin
On 11/26/2012 11:27 AM, Russell King - ARM Linux wrote: > On Mon, Nov 26, 2012 at 11:20:32AM +0100, Per Förlin wrote: >> On 11/22/2012 06:37 PM, Russell King - ARM Linux wrote: >>> On Thu, Nov 22, 2012 at 06:28:30PM +0100, Per Forlin wrote: On Wed, Nov 21, 2012 at 5:50 PM, Russell King - ARM L

[MX25][MMC]: SDHC very slow (300-600 KB/s) on i.MX25 board

2012-11-26 Thread Stefan Koch
Hi, I have ported linux-3.7-rc4 to a board with i.MX257 CPU. As distribution I use Debian squeeze. Booting time (with Xorg and IceWM) is different with different SD-Cards. Boot time with 2GB Standard micro SD-Card: over 2:30 minutes Boot time with 4GB Class 10 micro SDHC: 1:40 minutes Boot time w

Re: [PATCH 1/2] mmc: Remove redundant null check before kfree in sdio_bus.c

2012-11-26 Thread Sachin Kamat
Hi Chris Any comments on these 2 patches? On 20 November 2012 14:43, Sachin Kamat wrote: > kfree on a null pointer is a no-op. > > Signed-off-by: Sachin Kamat > --- > drivers/mmc/core/sdio_bus.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/sd

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2012 at 11:20:32AM +0100, Per Förlin wrote: > On 11/22/2012 06:37 PM, Russell King - ARM Linux wrote: > > On Thu, Nov 22, 2012 at 06:28:30PM +0100, Per Forlin wrote: > >> On Wed, Nov 21, 2012 at 5:50 PM, Russell King - ARM Linux > >> wrote: > >>> On Wed, Nov 21, 2012 at 05:13:55PM

Re: [PATCH] mmc: mmci: Support non-power-of-two block sizes for ux500v2 variant

2012-11-26 Thread Per Förlin
On 11/22/2012 06:37 PM, Russell King - ARM Linux wrote: > On Thu, Nov 22, 2012 at 06:28:30PM +0100, Per Forlin wrote: >> On Wed, Nov 21, 2012 at 5:50 PM, Russell King - ARM Linux >> wrote: >>> On Wed, Nov 21, 2012 at 05:13:55PM +0100, Per Forlin wrote: On Wed, Nov 21, 2012 at 4:38 PM, Russell

RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

2012-11-26 Thread Zhang Haijun-B42677
Hi Chris I see patches modified the public C file and Powerpc Host C file. But it also used by other host C file. So need to replace all the u64 division by macro div_u64 to avoid this error. Two new patches had send and reviewed by Anton. I think they can fix the `__aeabi_uldivmod' error. All th

[PATCH 1/2 V2] mmc:block : Convert the cmd_timeou_ms to u64 to avoid overflow

2012-11-26 Thread Haijun Zhang
Convert the cmd_timeou_ms to u64 to avoid overflow Signed-off-by: Jerry Huang Signed-off-by: Haijun Zhang Reviewed-by: Anton Vorontsov CC: Chris Ball --- drivers/mmc/card/block.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/

[PATCH 2/2 V2] mmc:host: Use u64 to calculate the timeout value to avoid overflow

2012-11-26 Thread Haijun Zhang
As data timeout_ns use u64 to avoid overflow. So we use macro div_u64 to perform a division. Below C file modified: - drivers/mmc/host/atmel-mci.c - drivers/mmc/host/bfin_sdh.c - drivers/mmc/host/davinci_mmc.c - drivers/mmc/host/mmci.c - drivers/mmc/host/mvsdio.c - drivers/mmc/host/mxs-mmc.c

Re: [PATCH 3/3] MMC: sdhci-dove: allow GPIOs to be used for card detection on Dove

2012-11-26 Thread Guennadi Liakhovetski
Hi Chris On Sun, 25 Nov 2012, Chris Ball wrote: > Hi, adding Guennadi, > > On Fri, Nov 23 2012, Russell King - ARM Linux wrote: > > On Fri, Nov 23, 2012 at 08:14:27PM +0800, Shawn Guo wrote: > >> On Fri, Nov 23, 2012 at 08:57:26AM +, Russell King - ARM Linux wrote: > >> > Does this work with

RE: [PATCH] Powerpc eSDHC: Convert the cmd_timeou_ms to u64 to avoid overflow

2012-11-26 Thread Zhang Haijun-B42677
Hi, Anton This patch was for public C file. That was for different Host controller. I think let them standalone will be better. The u32 conversion will be removed. Thanks. Regards Haijun. > -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Monday, Nov

Re: [PATCH] Powerpc eSDHC: Convert the cmd_timeou_ms to u64 to avoid overflow

2012-11-26 Thread Anton Vorontsov
On Mon, Nov 26, 2012 at 04:35:58PM +0800, Haijun Zhang wrote: > Convert the cmd_timeou_ms to u64 to avoid overflow > > Signed-off-by: Jerry Huang > Signed-off-by: Haijun Zhang Reviewed-by: Anton Vorontsov But I think you should merge the two patches... Thanks, > CC: Chris Ball > --- > dri

Re: [PATCH] Use u64 to calculate the timeout value to avoid overflow

2012-11-26 Thread Anton Vorontsov
On Mon, Nov 26, 2012 at 04:35:59PM +0800, Haijun Zhang wrote: > As data timeout_ns use u64 to avoid overflow. > So we use macro div_u64 to perform a division. [...] > --- a/drivers/mmc/host/atmel-mci.c > +++ b/drivers/mmc/host/atmel-mci.c > @@ -593,17 +593,16 @@ static void atmci_timeout_timer(unsi

[PATCH] Use u64 to calculate the timeout value to avoid overflow

2012-11-26 Thread Haijun Zhang
As data timeout_ns use u64 to avoid overflow. So we use macro div_u64 to perform a division. Below C file modified: - drivers/mmc/host/atmel-mci.c - drivers/mmc/host/bfin_sdh.c - drivers/mmc/host/davinci_mmc.c - drivers/mmc/host/mmci.c - drivers/mmc/host/mvsdio.c - drivers/mmc/host/mxs-mmc.c

[PATCH] Powerpc eSDHC: Convert the cmd_timeou_ms to u64 to avoid overflow

2012-11-26 Thread Haijun Zhang
Convert the cmd_timeou_ms to u64 to avoid overflow Signed-off-by: Jerry Huang Signed-off-by: Haijun Zhang CC: Anton Vorontsov CC: Chris Ball --- drivers/mmc/card/block.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/bloc