Re: [PATCH] mmc: core: disable the cache before suspend only after stopping BKOPS

2013-01-11 Thread Subhash Jadavani
On 1/12/2013 2:12 AM, Maya Erez wrote: mmc_cache_ctrl was called in runtime suspend before MMC interrupted BKOPS in case it is still running on the card. This caused the cache disable to timeout. I guess even if the idle time bkops polling is not implemented, this patch is good to have. cache co

[PATCH] mmc: core: disable the cache before suspend only after stopping BKOPS

2013-01-11 Thread Maya Erez
mmc_cache_ctrl was called in runtime suspend before MMC interrupted BKOPS in case it is still running on the card. This caused the cache disable to timeout. Therefore, mmc_cache_ctrl has to move to mmc_suspend where we are sure that the card can go into suspend and there is no pending activity. Si

Re: [PATCH v4 00/14] DMA Engine support for AM33XX

2013-01-11 Thread Arnd Bergmann
On Friday 11 January 2013, Matt Porter wrote: > We have tightly coupled the link-time dependency for > omap_dma_filter_fn by going down the path of using > dma_request_slave_channel_compat() as Tony suggested to avoid extra > ifdefry. > > That dependency will go away naturally if all the "legacy"

Re: [PATCH v4 1/2] mmc: core: Add support for idle time BKOPS

2013-01-11 Thread merez
Thanks, Ulf. Your help is appreciated. > On 10 January 2013 10:22, wrote: >> Hi Ulf, >> >> See below. >> >> Thanks, >> Maya >>> Hi Maya, >>> >>> On 24 December 2012 14:51, Maya Erez wrote: Devices have various maintenance operations need to perform internally. In order to reduce

Re: [PATCH v4 00/14] DMA Engine support for AM33XX

2013-01-11 Thread Matt Porter
On Fri, Jan 11, 2013 at 11:40:41AM +, Arnd Bergmann wrote: > On Friday 11 January 2013, Matt Porter wrote: > > The approach taken is similar to how OMAP DMA is being converted to > > DMA Engine support. With the functional EDMA private API already > > existing in mach-davinci/dma.c, we first mo

Re: [PATCH v4,03/14] ARM: edma: add AM33XX support to the private EDMA API

2013-01-11 Thread Lars Poeschel
Hi Matt, On Friday 11 January 2013 at 06:48:39, Matt Porter wrote: > diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c > index a3d189d..1951d63 100644 > --- a/arch/arm/common/edma.c > +++ b/arch/arm/common/edma.c > @@ -24,6 +24,13 @@ > #include > #include > #include > +#include

Re: [PATCH v4,03/14] ARM: edma: add AM33XX support to the private EDMA API

2013-01-11 Thread Matt Porter
On Fri, Jan 11, 2013 at 06:14:27PM +, Lars Poeschel wrote: > Hi Matt, > > On Friday 11 January 2013 at 06:48:39, Matt Porter wrote: > > > diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c > > index a3d189d..1951d63 100644 > > --- a/arch/arm/common/edma.c > > +++ b/arch/arm/common/e

Re: [PATCH v4 11/14] ARM: dts: add AM33XX MMC support

2013-01-11 Thread Tony Lindgren
* Matt Porter [130110 21:47]: > Adds AM33XX MMC support for am335x-bone, am335x-evm, and > am335x-evmsk.. This one should be queued separately by Benoit: Acked-by: Tony Lindgren > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/am335x-bone.dts |7 +++ > arch/arm/boot/dts/am335

Re: [PATCH v4 10/14] mmc: omap_hsmmc: add generic DMA request support to the DT binding

2013-01-11 Thread Tony Lindgren
* Matt Porter [130110 21:47]: > The binding definition is based on the generic DMA request binding. Acked-by: Tony Lindgren > Signed-off-by: Matt Porter > --- > .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 25 > +++- > 1 file changed, 24 insertions(+), 1 deletion(-

Re: [PATCH v4 09/14] mmc: omap_hsmmc: set max_segs based on dma engine limitations

2013-01-11 Thread Tony Lindgren
* Matt Porter [130110 21:47]: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. The DMA Engine > API reports the maximum number of segments a channel can support > via the optional dma_get_channel_caps() API. If the nr_segs > cap

Re: [PATCH v4 08/14] mmc: omap_hsmmc: convert to dma_request_slave_channel_compat()

2013-01-11 Thread Tony Lindgren
* Matt Porter [130110 21:47]: > Convert dmaengine channel requests to use > dma_request_slave_channel_compat(). This supports the DT case of > platforms requiring channel selection from either the OMAP DMA or > the EDMA engine. AM33xx only boots from DT and is the only user > implementing EDMA so

Re: [PATCH v4 07/14] dmaengine: add dma_request_slave_channel_compat()

2013-01-11 Thread Tony Lindgren
* Matt Porter [130110 21:47]: > Adds a dma_request_slave_channel_compat() wrapper which accepts > both the arguments from dma_request_channel() and > dma_request_slave_channel(). Based on whether the driver is > instantiated via DT, the appropriate channel request call will be > made. > > This al

Re: [RFC PATCH] MAINTAINERS: Add an orphaned entry for the dw_mmc driver.

2013-01-11 Thread Chris Ball
Hi, On Fri, Jan 11 2013, Will Newton wrote: > I submitted this driver but will shortly no longer have access > to hardware that uses it. The driver is quite widely used so > there may be someone out there that feels strongly enough to > step up and maintain it. > --- > MAINTAINERS |6 ++ >

[RFC PATCH] MAINTAINERS: Add an orphaned entry for the dw_mmc driver.

2013-01-11 Thread Will Newton
I submitted this driver but will shortly no longer have access to hardware that uses it. The driver is quite widely used so there may be someone out there that feels strongly enough to step up and maintain it. --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --

Re: [PATCH v4 1/5] mmc: dw_mmc: Add "disable-wp" device tree property

2013-01-11 Thread Will Newton
On Fri, Jan 11, 2013 at 5:03 PM, Doug Anderson wrote: > The "disable-wp" property is used to specify that a given SD card slot > doesn't have a concept of write protect. This eliminates the need for > special case code for SD slots that should never be write protected > (like a micro SD slot or a

[PATCH v4 2/5] ARM: dts: Add disable-wp for sd card slot on smdk5250

2013-01-11 Thread Doug Anderson
The next change will remove the code from the dw_mmc-exynos that added the DW_MCI_QUIRK_NO_WRITE_PROTECT. Keep existing functionality of having no write protect pin on smdk5250 by adding the disable-wp property. Signed-off-by: Doug Anderson Acked-by: Seungwon Jeon --- Changes in v4: None Change

[PATCH v4 3/5] mmc: dw_mmc: exynos: Remove code for wp-gpios

2013-01-11 Thread Doug Anderson
The exynos code claimed the write protect with devm_gpio_request() but never did anything with it. That meant that anyone using a write protect GPIO would effectively be write protected all the time. The handling for wp-gpios belongs in the main dw_mmc driver and has been moved there. Signed-off

[PATCH v4 5/5] mmc: dw_mmc: Remove DW_MCI_QUIRK_NO_WRITE_PROTECT

2013-01-11 Thread Doug Anderson
The original quirk was added in the change 'mmc: dw_mmc: add quirk to indicate missing write protect line'. The original quirk was added at a controller level even though each slot has its own write protect (so the quirk should be at the slot level). A recent change (mmc: dw_mmc: Add "disable-wp"

[PATCH v4 1/5] mmc: dw_mmc: Add "disable-wp" device tree property

2013-01-11 Thread Doug Anderson
The "disable-wp" property is used to specify that a given SD card slot doesn't have a concept of write protect. This eliminates the need for special case code for SD slots that should never be write protected (like a micro SD slot or a dev board). The dw_mmc driver is special in needing to specif

[PATCH v4 4/5] mmc: dw_mmc: Handle wp-gpios from device tree

2013-01-11 Thread Doug Anderson
On some SoCs (like exynos5250) you need to use an external GPIO for write protect. Add support for wp-gpios to the core dw_mmc driver since it could be useful across multiple SoCs. With this change I am able to make use of the write protect for the external SD slot on exynos5250-snow. Signed-off

[PATCH v1 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-11 Thread Subhash Jadavani
blk_rq_map_sg() function merges the physically contiguous pages to use same scatter-gather node without checking if their page descriptors are contiguous or not. Now when dma_map_sg() is called on the scatter gather list, it would take the base page pointer from each node (one by one) and iterates

Re: [PATCH v4 05/14] dmaengine: edma: Add TI EDMA device tree binding

2013-01-11 Thread Matt Porter
On Fri, Jan 11, 2013 at 07:54:05AM +, Hebbar, Gururaja wrote: > On Fri, Jan 11, 2013 at 11:18:41, Porter, Matt wrote: > > The binding definition is based on the generic DMA controller > > binding. > > > > Signed-off-by: Matt Porter > > --- > > Documentation/devicetree/bindings/dma/ti-edma.tx

Re: [PATCH v4 01/14] ARM: davinci: move private EDMA API to arm/common

2013-01-11 Thread Matt Porter
On Fri, Jan 11, 2013 at 06:15:06AM +, Hebbar, Gururaja wrote: > On Fri, Jan 11, 2013 at 11:18:37, Porter, Matt wrote: > > Move mach-davinci/dma.c to common/edma.c so it can be used > > by OMAP (specifically AM33xx) as well. This just moves the > > private EDMA API and enables it to build on OMA

Re: [PATCH v4 1/2] mmc: core: Add support for idle time BKOPS

2013-01-11 Thread Ulf Hansson
On 10 January 2013 10:22, wrote: > Hi Ulf, > > See below. > > Thanks, > Maya >> Hi Maya, >> >> On 24 December 2012 14:51, Maya Erez wrote: >>> Devices have various maintenance operations need to perform internally. >>> In order to reduce latencies during time critical operations like read >>> an

Query regarding ADMA descriptor allocation

2013-01-11 Thread Asutosh Das
Hi In sdhci_add_host function, the number of adma descriptors allocated are 128 and each descriptor consumes 8 bytes and 1 4byte is added in the end like, kmalloc((128 * 2 + 1) * 4, GFP_KERNEL); In sdhci_adma_table_pre function, each node in sg-list is iterated and in case of a misaligned nod

Re: [PATCH v4 00/14] DMA Engine support for AM33XX

2013-01-11 Thread Arnd Bergmann
On Friday 11 January 2013, Matt Porter wrote: > The approach taken is similar to how OMAP DMA is being converted to > DMA Engine support. With the functional EDMA private API already > existing in mach-davinci/dma.c, we first move that to an ARM common > area so it can be shared. Adding DT and runt

Re: [PATCH v5 0/3] Add support for periodic BKOPS

2013-01-11 Thread Jaehoon Chung
Hi Maya, I didn't see about "[PATCH v5 1/3]mmc: core: Add support for idle time BKOPS" at mailing. Could you check the patch set? Best Regards, Jaehoon Chung On 01/11/2013 05:15 AM, Maya Erez wrote: > Devices have various maintenance operations need to perform internally. > In order to reduce l

Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-11 Thread Russell King - ARM Linux
On Fri, Jan 11, 2013 at 12:09:09PM +0100, Thomas Petazzoni wrote: > Dear Russell King - ARM Linux, > > On Fri, 11 Jan 2013 11:02:10 +, Russell King - ARM Linux wrote: > > > What remains? The assumption that GPIO0 means "no GPIO" rather than > > testing with gpio_valid() and the IRQ stuff. >

Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-11 Thread Thomas Petazzoni
Dear Russell King - ARM Linux, On Fri, 11 Jan 2013 11:02:10 +, Russell King - ARM Linux wrote: > What remains? The assumption that GPIO0 means "no GPIO" rather than > testing with gpio_valid() and the IRQ stuff. Patches that I have written have been merged by Jason Cooper and while adding t

Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-11 Thread Russell King - ARM Linux
On Thu, Jan 10, 2013 at 09:29:15PM +0100, Andrew Lunn wrote: > A NULL is a valid clk cookie, so we should not be tested with > IS_ERR_NULL(). Replace it with IS_ERR(). > > Signed-off-by: Andrew Lunn > --- > drivers/mmc/host/mvsdio.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >