Re: [PATCH v2 03/11] mmc: provide a standard MMC device-tree binding parser centrally

2013-01-24 Thread Guennadi Liakhovetski
Hi Joseph On Fri, 25 Jan 2013, Joseph Lo wrote: > Hi Guennadi, > > > MMC defines a number of standard DT bindings. Having each driver parse > > them individually adds code redundancy and is error prone. Provide a > > standard function to unify the parsing. After all drivers are > converted > > t

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-24 Thread Santosh Shilimkar
On Friday 25 January 2013 02:19 AM, Matt Porter wrote: On Thu, Jan 24, 2013 at 05:12:05AM +, Shilimkar, Santosh wrote: On Thursday 24 January 2013 02:19 AM, Matt Porter wrote: On Wed, Jan 23, 2013 at 04:37:55PM +0530, Santosh Shilimkar wrote: Matt, On Wednesday 16 January 2013 02:02 AM, M

Re: [PATCH 0/6] sdhci-esdhc-imx: 8bit mmc support

2013-01-24 Thread Dirk Behme
On 21.01.2013 12:02, Shawn Guo wrote: The series makes Auto CMD23 work for imx6q usdhc and then adds 8bit mmc support. Sascha Hauer (2): mmc: sdhci: rename platform_8bit_width to platform_bus_width mmc: sdhci-esdhc-imx: support 8bit mode Shawn Guo (4): mmc: sdhci-esdhc-imx: separate trans

Re: [PATCH 2/2] mmc: sdhci-esdhc-imx: name esdhc specific definitions with ESDHC_ prefix

2013-01-24 Thread Dirk Behme
On 15.01.2013 16:36, Shawn Guo wrote: Rename esdhc local definitions with ESDHC_ rather than SDHCI_ prefix, so that we can distinguish them from SDHCI core definitions from name. A couple of bit fields are also changed use shift for consistency and better readability. Signed-off-by: Shawn Guo

Re: [PATCH 1/2] mmc: sdhci-esdhc-imx: remove D3CD check from SDHCI_HOST_CONTROL write

2013-01-24 Thread Dirk Behme
On 15.01.2013 16:36, Shawn Guo wrote: SDHCI_CTRL_D3CD is not a standard SDHCI_HOST_CONTROL, so there is no need to check it in SDHCI_HOST_CONTROL write at all. Remove it. Signed-off-by: Shawn Guo Tested-by: Dirk Behme Tested on i.MX6. Thanks Dirk --- drivers/mmc/host/sdhci-esdhc-imx.c

Re: [PATCH v2 03/11] mmc: provide a standard MMC device-tree binding parser centrally

2013-01-24 Thread Joseph Lo
Hi Guennadi, > MMC defines a number of standard DT bindings. Having each driver parse > them individually adds code redundancy and is error prone. Provide a > standard function to unify the parsing. After all drivers are converted > to using it instead of their own parsers, this function can be in

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-24 Thread Matt Porter
On Thu, Jan 24, 2013 at 05:12:05AM +, Shilimkar, Santosh wrote: > On Thursday 24 January 2013 02:19 AM, Matt Porter wrote: > > On Wed, Jan 23, 2013 at 04:37:55PM +0530, Santosh Shilimkar wrote: > >> Matt, > >> > >> On Wednesday 16 January 2013 02:02 AM, Matt Porter wrote: > >> > >> [..] > >> >

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-24 Thread Matt Porter
On Thu, Jan 24, 2013 at 05:14:13AM +, Sekhar Nori wrote: > Matt, > > On 1/24/2013 3:07 AM, Matt Porter wrote: > > On Wed, Jan 23, 2013 at 10:21:42AM +0800, Mark Brown wrote: > >> On Tue, Jan 22, 2013 at 09:26:34PM +0530, Sekhar Nori wrote: > >>> On 1/16/2013 2:02 AM, Matt Porter wrote: > >> >

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Ulf Hansson
On 24 January 2013 18:12, Linus Walleij wrote: > On Thu, Jan 24, 2013 at 1:59 PM, Russell King - ARM Linux > wrote: > >> The clock can be masked independently too via the clock enable bit in >> the clock register. >> >> However, it's interesting to note: experiments that Linus did with having >>

[PATCH v2] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-01-24 Thread Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos5_drv_data not to use SoC specific name. Signed-off-by: Dongjin Kim --- drivers/mmc/host/d

device tree support for MMC host OCR mask

2013-01-24 Thread Barak Wasserstrom
Hi, Is there a standard support for providing the MMC host OCR mask in the device tree structure? I'm using ARM PrimeCell PL180/181 Multimedia Card Interface driver. In 'mmci_dt_populate_generic_pdata' I cannot see any evidence for parsing oct mask. I wonder if I can just add to the function: of_p

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Linus Walleij
On Thu, Jan 24, 2013 at 1:59 PM, Russell King - ARM Linux wrote: > The clock can be masked independently too via the clock enable bit in > the clock register. > > However, it's interesting to note: experiments that Linus did with having > the primecell automatically masking the clock to the card

Re: [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings

2013-01-24 Thread Chris Ball
Hi, On Thu, Jan 24 2013, Guennadi Liakhovetski wrote: > I tried to keep this binding similar to others, that I proposed in "mmc: > add DT bindings for more MMC capability flags." Actually, the above is > indeed wrong, I would call it "cap-sdio-irq." And in that patch I tried to > keep binding n

Re: [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings

2013-01-24 Thread Guennadi Liakhovetski
On Thu, 24 Jan 2013, Chris Ball wrote: > Hi, > > On Thu, Jan 24 2013, Guennadi Liakhovetski wrote: > > After an internal discussion it occurred to us, that this binding > > > > On Wed, 23 Jan 2013, Guennadi Liakhovetski wrote: > > > > [snip] > > > >> +- toshiba,mmc-cap-sdio-irq: SDIO IRQ

Re: [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings

2013-01-24 Thread Chris Ball
Hi, On Thu, Jan 24 2013, Guennadi Liakhovetski wrote: > After an internal discussion it occurred to us, that this binding > > On Wed, 23 Jan 2013, Guennadi Liakhovetski wrote: > > [snip] > >> +- toshiba,mmc-cap-sdio-irq : SDIO IRQ signalling should be used, if >> +supported by the hardware, i

Re: [PATCH/RFC v2 06/11] mmc: tmio-mmc: define device-tree bindings

2013-01-24 Thread Guennadi Liakhovetski
After an internal discussion it occurred to us, that this binding On Wed, 23 Jan 2013, Guennadi Liakhovetski wrote: [snip] > +- toshiba,mmc-cap-sdio-irq : SDIO IRQ signalling should be used, if > + supported by the hardware, i.e. set MMC_CAP_SDIO_IRQ if > + TMIO_MMC_SDIO_IRQ is also se

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Ulf Hansson
On 24 January 2013 13:59, Russell King - ARM Linux wrote: > On Thu, Jan 24, 2013 at 01:48:39PM +0100, Ulf Hansson wrote: >> Correct. ST-variants requires to use the POWER register to gate the >> clock. So if this is not the case for VE you don't need to bother, >> otherwise you should set "pwrreg_

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Ulf Hansson
On 24 January 2013 14:04, Ulf Hansson wrote: > On 24 January 2013 13:54, Pawel Moll wrote: >> Hi Chris, >> >> On Fri, 2012-12-14 at 15:38 +, Pawel Moll wrote: >>> The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 >>> and v116/216) contains a modified version of the PL180

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Ulf Hansson
On 24 January 2013 13:54, Pawel Moll wrote: > Hi Chris, > > On Fri, 2012-12-14 at 15:38 +, Pawel Moll wrote: >> The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 >> and v116/216) contains a modified version of the PL180 MMCI, with >> PeriphID Configuration value changed to

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Pawel Moll
On Thu, 2013-01-24 at 12:57 +, Chris Ball wrote: > Hi Pawel, > > On Fri, Dec 14 2012, Pawel Moll wrote: > > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 > > and v116/216) contains a modified version of the PL180 MMCI, with > > PeriphID Configuration value changed to 0

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Russell King - ARM Linux
On Thu, Jan 24, 2013 at 01:48:39PM +0100, Ulf Hansson wrote: > Correct. ST-variants requires to use the POWER register to gate the > clock. So if this is not the case for VE you don't need to bother, > otherwise you should set "pwrreg_clkgate" for this variant as well. The ARM variant does gate th

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Chris Ball
Hi Pawel, On Fri, Dec 14 2012, Pawel Moll wrote: > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 > and v116/216) contains a modified version of the PL180 MMCI, with > PeriphID Configuration value changed to 0x2. > > This version adds an optional "hardware flow control" fea

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2013-01-24 Thread Ulf Hansson
On 23 January 2013 12:18, Lee Jones wrote: > On Wed, 23 Jan 2013, Russell King - ARM Linux wrote: > >> On Wed, Jan 23, 2013 at 10:13:49AM +, Lee Jones wrote: >> > On Tue, 22 Jan 2013, Lee Jones wrote: >> > > Are you saying that you won't do it? :) >> > > >> > > Is there anything I can do to ma

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Pawel Moll
Hi Chris, On Fri, 2012-12-14 at 15:38 +, Pawel Moll wrote: > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 > and v116/216) contains a modified version of the PL180 MMCI, with > PeriphID Configuration value changed to 0x2. > > This version adds an optional "hardware fl

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Ulf Hansson
Hi Pawel, On 24 January 2013 13:36, Pawel Moll wrote: > Hello Ulf, > > On Fri, 2012-12-21 at 11:05 +, Ulf Hansson wrote: >> On 14 December 2012 16:38, Pawel Moll wrote: >> > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 >> > and v116/216) contains a modified version

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2013-01-24 Thread Pawel Moll
Hello Ulf, On Fri, 2012-12-21 at 11:05 +, Ulf Hansson wrote: > On 14 December 2012 16:38, Pawel Moll wrote: > > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 > > and v116/216) contains a modified version of the PL180 MMCI, with > > PeriphID Configuration value changed

Re: [PATCH] mmc: tmio: add barriers to IO operations

2013-01-24 Thread Paul Mundt
On Wed, Jan 23, 2013 at 05:46:18PM +0100, Guennadi Liakhovetski wrote: > Without barriers SDIO operations fail with runtime PM enabled. > > Signed-off-by: Guennadi Liakhovetski > --- > drivers/mmc/host/tmio_mmc.h | 14 -- > 1 files changed, 8 insertions(+), 6 deletions(-) > > diff

Re: [PATCH] mmc: tmio: add barriers to IO operations

2013-01-24 Thread Guennadi Liakhovetski
On Thu, 24 Jan 2013, Paul Mundt wrote: > On Thu, Jan 24, 2013 at 12:20:19PM +0100, Guennadi Liakhovetski wrote: > > On Thu, 24 Jan 2013, Paul Mundt wrote: > > > > > On Wed, Jan 23, 2013 at 05:46:18PM +0100, Guennadi Liakhovetski wrote: > > > > Without barriers SDIO operations fail with runtime PM

Re: [PATCH] mmc: tmio: add barriers to IO operations

2013-01-24 Thread Paul Mundt
On Thu, Jan 24, 2013 at 12:20:19PM +0100, Guennadi Liakhovetski wrote: > On Thu, 24 Jan 2013, Paul Mundt wrote: > > > On Wed, Jan 23, 2013 at 05:46:18PM +0100, Guennadi Liakhovetski wrote: > > > Without barriers SDIO operations fail with runtime PM enabled. > > > > > > Signed-off-by: Guennadi Lia

Re: [PATCH] mmc: tmio: add barriers to IO operations

2013-01-24 Thread Guennadi Liakhovetski
On Thu, 24 Jan 2013, Paul Mundt wrote: > On Wed, Jan 23, 2013 at 05:46:18PM +0100, Guennadi Liakhovetski wrote: > > Without barriers SDIO operations fail with runtime PM enabled. > > > > Signed-off-by: Guennadi Liakhovetski > > --- > > drivers/mmc/host/tmio_mmc.h | 14 -- > > 1 fi