[PATCH] mmc: core: restore ocr and operation voltage in resume

2013-02-20 Thread Kevin Liu
host-ocr has been reset in power off but not restored after power up in resume. And operation voltage will be set to the highest after resume back. This patch fix these two bugs. Signed-off-by: Kevin Liu kl...@marvell.com --- drivers/mmc/core/core.c |3 ++- include/linux/mmc/host.h |1 +

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-20 Thread Kevin Liu
2013/2/14 Ulf Hansson ulf.hans...@linaro.org: On 14 February 2013 09:05, Marek Szyprowski m.szyprow...@samsung.com wrote: On 2/13/2013 12:35 PM, Mark Brown wrote: On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote: On Wed, 13 Feb 2013, Marek Szyprowski wrote: BTW,

[PATCH] mmc: core: enhance card remove detection for gpio detect

2013-02-20 Thread Kevin Liu
Current code detect card removal only by judging the result of sending cmd13 to card, which is not safe for card with external gpio detection. The communication status between host and card may out of sync with the external gpio status if remove slowly or hand shake during card removal. For a

dw_mmc build broken in next-20130220 (was Re: [PATCH v3 2/2] lib/scatterlist: use page iterator in the mapping iterator)

2013-02-20 Thread James Hogan
sg_page_iter __piter;/* page iterator */ + unsigned int__remaining;/* remaining bytes on page */ unsigned int__flags; }; Hi, FYI, in next-20130220 this appears to break the build of the dw_mmc driver: drivers/mmc/host/dw_mmc.c In function

Re: [PATCH 1/2] ARM: dts: tegra: fix the activate polarity of cd-gpio in mmc host

2013-02-20 Thread Stephen Warren
On 02/20/2013 12:05 AM, Joseph Lo wrote: The GPIO pin of SD slot card detection should active low. Thierry, Lucas, can you please check if the same change should be made to all the Avionic Design and Toradex boards? I assume MMC CD should be active low on all of them. Once you've confirmed this,

OMAP4 bust: MMC causes hung tasks

2013-02-20 Thread Russell King - ARM Linux
MMC looks sick - not sure what's going on with it though. mmc0 I believe is the onboard eMMC, mmc1 is the external SD card with the rootfs. Any ideas? [0.00] Linux version 3.8.0-rc7+ (r...@rmk-pc.arm.linux.org.uk) (gcc version 4.5.4 (GCC) ) #468 SMP Wed Feb 20 16:44:50 GMT 2013 [

Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings

2013-02-20 Thread Stephen Warren
On 02/20/2013 12:05 AM, Joseph Lo wrote: Updating the sdhci-tegra driver to use mmc_of_parse to support standard MMC DT bindings. Then we can remove the redundant code that already support static unsigned int tegra_sdhci_get_ro(struct sdhci_host *host) { - struct sdhci_pltfm_host

Re: OMAP4 bust: MMC causes hung tasks

2013-02-20 Thread Chris Ball
Hi, On Wed, Feb 20 2013, Russell King - ARM Linux wrote: MMC looks sick - not sure what's going on with it though. mmc0 I believe is the onboard eMMC, mmc1 is the external SD card with the rootfs. Any ideas? Is this with 3.8 final, or mmc-next? [1.253265] mmc0: new high speed MMC card

[PATCH 0/4] Tegra114 Add Minimal SDHCI support

2013-02-20 Thread Rhyland Klein
This patchset adds the minimal support for Tegra114 SDHCI support and enables it for tegra114-dalmore. This patchset is dependent on: - Tegra114 Clock framework (v7) from Peter De Schrijver ( http://patchwork.ozlabs.org/patch/220727/ ...) - Tegra114 Pinctrl patches (v2) I sent 2/11 (

[PATCH 1/4] ARM tegra: add SDHCI nodes with common properties

2013-02-20 Thread Rhyland Klein
From: Pritesh Raithatha praitha...@nvidia.com This patch adds in the SDHCI nodes for the busses supported on Tegra114 boards. Signed-off-by: Pritesh Raithatha praitha...@nvidia.com [Rhyland added clk refs to reordered sdhci nodes and removed spaces] Signed-off-by: Rhyland Klein

[PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-02-20 Thread Rhyland Klein
The structs wrapped with the SOC ifdefs are small enough where having them always there shouldn't be a big overhead. Removing the ifdefs also makes the code a little cleaner. Signed-off-by: Rhyland Klein rkl...@nvidia.com --- drivers/mmc/host/sdhci-tegra.c |8 1 file changed, 8

[PATCH 2/4] ARM: tegra: add SDHCI support for Dalmore

2013-02-20 Thread Rhyland Klein
Based on changes by: Pritesh Raithatha praitha...@nvidia.com Signed-off-by: Rhyland Klein rkl...@nvidia.com --- arch/arm/boot/dts/tegra114-dalmore.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts

[PATCH 4/4] mmc: host: sdhci-tegra: add basic support for Tegra114

2013-02-20 Thread Rhyland Klein
The mmc controller on Tegra114 platforms is basically compatible with the settings used for Tegra30. However there is a difference where we don't need the extra ENABLE_SDHCI_SPEC_300 quirk as Tegra114 hardware advertises v3.0 support already. Signed-off-by: Rhyland Klein rkl...@nvidia.com ---

Re: dw_mmc build broken in next-20130220 (was Re: [PATCH v3 2/2] lib/scatterlist: use page iterator in the mapping iterator)

2013-02-20 Thread Imre Deak
*/ + unsigned int__offset; /* offset within page */ + struct sg_page_iter __piter;/* page iterator */ + unsigned int__remaining;/* remaining bytes on page */ unsigned int__flags; }; Hi, FYI, in next-20130220

Re: [PATCH 1/4] ARM tegra: add SDHCI nodes with common properties

2013-02-20 Thread Stephen Warren
On 02/20/2013 11:35 AM, Rhyland Klein wrote: From: Pritesh Raithatha praitha...@nvidia.com This patch adds in the SDHCI nodes for the busses supported on Tegra114 boards. This patch looks fine, although it'd need some modifications to rebase it on top of the cpp usage in *.dts, which I

Re: [PATCH 2/4] ARM: tegra: add SDHCI support for Dalmore

2013-02-20 Thread Stephen Warren
On 02/20/2013 11:35 AM, Rhyland Klein wrote: Based on changes by: Pritesh Raithatha praitha...@nvidia.com Signed-off-by: Rhyland Klein rkl...@nvidia.com A patch description would be useful here. Something simple like: Dalmore has a built-in eMMC device and a user-accessible SD card slot. Add

Re: [PATCH 2/4] ARM: tegra: add SDHCI support for Dalmore

2013-02-20 Thread Rhyland Klein
On 2/20/2013 2:07 PM, Stephen Warren wrote: On 02/20/2013 11:35 AM, Rhyland Klein wrote: Based on changes by: Pritesh Raithatha praitha...@nvidia.com Signed-off-by: Rhyland Klein rkl...@nvidia.com A patch description would be useful here. Something simple like: Dalmore has a built-in eMMC

Re: [PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-02-20 Thread Stephen Warren
On 02/20/2013 11:35 AM, Rhyland Klein wrote: The structs wrapped with the SOC ifdefs are small enough where having them always there shouldn't be a big overhead. Removing the ifdefs also makes the code a little cleaner. Patch 3 and 4 to the MMC driver look fine. But I'd ask Chris to hold off

Re: [PATCH 2/4] ARM: tegra: add SDHCI support for Dalmore

2013-02-20 Thread Stephen Warren
On 02/20/2013 12:14 PM, Rhyland Klein wrote: On 2/20/2013 2:07 PM, Stephen Warren wrote: On 02/20/2013 11:35 AM, Rhyland Klein wrote: Based on changes by: Pritesh Raithatha praitha...@nvidia.com Signed-off-by: Rhyland Klein rkl...@nvidia.com A patch description would be useful here. Something

Re: OMAP4 bust: MMC causes hung tasks

2013-02-20 Thread Russell King - ARM Linux
On Wed, Feb 20, 2013 at 12:15:51PM -0500, Chris Ball wrote: Hi, On Wed, Feb 20 2013, Russell King - ARM Linux wrote: MMC looks sick - not sure what's going on with it though. mmc0 I believe is the onboard eMMC, mmc1 is the external SD card with the rootfs. Any ideas? Is this with

Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings

2013-02-20 Thread Joseph Lo
On Thu, 2013-02-21 at 01:07 +0800, Stephen Warren wrote: On 02/20/2013 12:05 AM, Joseph Lo wrote: Updating the sdhci-tegra driver to use mmc_of_parse to support standard MMC DT bindings. Then we can remove the redundant code that already support static unsigned int

Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings

2013-02-20 Thread Stephen Warren
On 02/20/2013 07:23 PM, Joseph Lo wrote: On Thu, 2013-02-21 at 01:07 +0800, Stephen Warren wrote: On 02/20/2013 12:05 AM, Joseph Lo wrote: Updating the sdhci-tegra driver to use mmc_of_parse to support standard MMC DT bindings. Then we can remove the redundant code that already support @@

Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings

2013-02-20 Thread Joseph Lo
On Thu, 2013-02-21 at 12:20 +0800, Stephen Warren wrote: On 02/20/2013 07:23 PM, Joseph Lo wrote: On Thu, 2013-02-21 at 01:07 +0800, Stephen Warren wrote: On 02/20/2013 12:05 AM, Joseph Lo wrote: Updating the sdhci-tegra driver to use mmc_of_parse to support standard MMC DT bindings. Then

Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings

2013-02-20 Thread Joseph Lo
On Thu, 2013-02-21 at 14:26 +0800, Joseph Lo wrote: On Thu, 2013-02-21 at 12:20 +0800, Stephen Warren wrote: On 02/20/2013 07:23 PM, Joseph Lo wrote: On Thu, 2013-02-21 at 01:07 +0800, Stephen Warren wrote: On 02/20/2013 12:05 AM, Joseph Lo wrote: Updating the sdhci-tegra driver to use