Re: [PATCH v2] mmc: sdhci: update check code for cd-broken or nonremovable card

2013-03-01 Thread Kevin Liu
2013/3/1 Philip Rakity : > > On Mar 1, 2013, at 9:40 AM, Kevin Liu wrote: > >> in function sdhci_request: >> 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no >> card detection available and polling must be used. Gpio detect must >> _not_ be supported under this case. >> Chang

[PATCH 2/3] mmc: core: Add bus_ops for runtime pm callbacks

2013-03-01 Thread Ulf Hansson
From: Ulf Hansson SDIO is the only protocol that uses runtime pm for the card device right now. To provide the option for sd and mmc to use runtime pm as well the bus_ops callback are extended with two new functions. One for runtime_suspend and one for runtime_resume. This patch will also implem

[PATCH 3/3] mmc: block: Enable runtime pm for mmc blkdevice

2013-03-01 Thread Ulf Hansson
From: Ulf Hansson Once the mmc blkdevice is being probed, runtime pm will be enabled. By using runtime autosuspend, the power save operations can be done when request inactivity occurs for a certain time. Right now the selected timeout value is set to 3 s. Moreover, when the blk device is being

[PATCH 0/3] mmc: Use runtime pm for blkdevice

2013-03-01 Thread Ulf Hansson
From: Ulf Hansson SDIO has been using runtime pm for a while to handle runtime power save operations. This patchset is enabling the option to make the sd/mmc blockdevices to use runtime pm as well. The runtime pm implementation for the block device will make use of autosuspend to defer power sav

[PATCH 1/3] mmc: core: Remove power_restore bus_ops for mmc and sd

2013-03-01 Thread Ulf Hansson
From: Ulf Hansson The mmc_power_restore|save_host API is only used by SDIO func drivers. SDIO func drivers are also moving towards use of runtime pm to accomplish the the same operation and since this API is not used for mmc and sd it makes sense to remove the corresponding bus_ops. Moreover, at

Re: [PATCH v2] mmc: sdhci: update check code for cd-broken or nonremovable card

2013-03-01 Thread Philip Rakity
On Mar 1, 2013, at 9:40 AM, Kevin Liu wrote: > in function sdhci_request: > 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no > card detection available and polling must be used. Gpio detect must > _not_ be supported under this case. > Change the sequence to check SDHCI_QUIR

Re: [PATCH] mmc: sdhci: update card present check code

2013-03-01 Thread Kevin Liu
2013/2/28 Kevin Liu : > 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no > card detection available and polling must be used. Gpio detect must > _not_ be supported under this case. > Change the sequence to check SDHCI_QUIRK_BROKEN_CARD_DETECTION first, > which make code more c

[PATCH 3/3] mmc: sdhci-pxav3: remove cd-broken quirk for permanently present card

2013-03-01 Thread Kevin Liu
For permanently present card, cd-broken quirk should _not_ be selected. Otherwise polling will be used to detect the card. Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci-pxav3.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/dri

[PATCH 2/3] mmc: sdhci-pxav3: transfer platform data to sdhci_pltfm_init

2013-03-01 Thread Kevin Liu
Let sdhci_pltfm_init set host->ops and host->quirks. Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci-pxav3.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index a0cdbc5..55d0784 100644 -

[PATCH 1/3] mmc: sdhci: add quirks2 in sdhci_pltfm_init

2013-03-01 Thread Kevin Liu
Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci-pltfm.c |4 +++- drivers/mmc/host/sdhci-pltfm.h |1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index 3145a78..e605509 100644 --- a/drivers/mmc/host/sdhc

[PATCH v2] mmc: sdhci: update check code for cd-broken or nonremovable card

2013-03-01 Thread Kevin Liu
in function sdhci_request: 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no card detection available and polling must be used. Gpio detect must _not_ be supported under this case. Change the sequence to check SDHCI_QUIRK_BROKEN_CARD_DETECTION first, which make code more clear.

Re: [PATCH v2 2/2] mmc: sdhci: add function get_cd

2013-03-01 Thread Linus Walleij
On Fri, Mar 1, 2013 at 4:19 AM, Kevin Liu wrote: > Thanks for the review. Can you also help to review the latest v3? > The only difference to v2 is swap the check sequence between gpio and > cd-broken quirk. Yes I saw that, please add my Reviewed-by. Yours, Linus Walleij -- To unsubscribe from