Hi James,
There is no reason that can't change the verid check position.
So this patch looks good to me.
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 03/12/2013 07:43 PM, James Hogan wrote:
> host->data_offset is initialised at the end of the probe function
> depending on the VERID r
Acked-by: Jaehoon Chung
On 02/18/2013 05:53 PM, Sachin Kamat wrote:
> 'dw_mci_exynos_match' is always compiled in. Hence of_match_ptr
> is not required.
>
> Signed-off-by: Sachin Kamat
> ---
> drivers/mmc/host/dw_mmc-exynos.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> d
Hi Jaehoon,
On 13 March 2013 09:50, Jaehoon Chung wrote:
> Hi All,
>
> this patch has already got acked-by of Seungwon and me.
It is needed for the second patch of this series
"[PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()"
https://patchwork.kernel.org/patch/2156621/
Hi All,
this patch has already got acked-by of Seungwon and me.
Best Regards,
Jaehoon Chung
On 03/13/2013 12:04 AM, Sachin Kamat wrote:
> On 12 March 2013 20:30, Chris Ball wrote:
>> Hi,
>>
>> On Tue, Mar 12 2013, Sachin Kamat wrote:
>>> There is also another patch in this series [1] that needs
Use resource_size() instead of explicit calculation. This was found via
make coccicheck.
Signed-off-by: Silviu-Mihai Popescu
---
drivers/mmc/host/android-goldfish.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/android-goldfish.c
b/drivers/mmc/host/andr
On 03/12/2013 04:52 AM, Lars-Peter Clausen wrote:
> The sdhci_pltfm_data struct is never modified within the sdhci_pltfm module.
> So
> make the pdata parameter to sdhci_pltfm_init and sdhci_pltfm_register const.
> This allows drivers to declare their sdhci_pltfm_data struct as const.
>
> This pa
On 12/03/13 11:26, Jaehoon Chung wrote:
> Looks good to me.
>
> Acked-by: Jaehoon Chung
Thanks Jaehoon
Cheers
James
>
> Best Regards,
> Jaehoon Chung
>
> On 03/12/2013 07:43 PM, James Hogan wrote:
>> Call the setpower platform callback in response to set_ios with
>> ios->power_mode == MMC_PO
On Tue, Mar 12, 2013 at 06:53:03AM +, Sekhar Nori wrote:
> On 3/6/2013 9:45 PM, Matt Porter wrote:
> > The binding definition is based on the generic DMA controller
> > binding.
> >
> > Signed-off-by: Matt Porter
>
> Okay the bindings the documented after they are used leading to some
> conf
On Tue, Mar 12, 2013 at 06:45:46AM +, Sekhar Nori wrote:
>
>
> On 3/6/2013 9:45 PM, Matt Porter wrote:
> > Adds support for parsing the TI EDMA DT data into the
> > required EDMA private API platform data. Enables runtime
> > PM support to initialize the EDMA hwmod. Adds AM33XX EDMA
> > cross
> "Matt" == Matt Porter writes:
Hi,
Matt> +edma: edma@4900 {
Matt> +reg = <0x4900 0x1>;
Matt> +interrupt-parent = <&intc>;
Matt> +interrupts = <12 13 14>;
>>
>> Probably interrupt-parent should be removed from the example as well to
>> match am33xx
On Wed, Mar 06, 2013 at 08:24:06PM +, Peter Korsgaard wrote:
> > "Matt" == Matt Porter writes:
>
> Matt> The binding definition is based on the generic DMA controller
> Matt> binding.
>
> Matt> Signed-off-by: Matt Porter
> Matt> ---
> Matt> Documentation/devicetree/bindings/dma/ti
On Thu, Mar 07, 2013 at 08:42:18AM +0200, Andy Shevchenko wrote:
> On Wed, Mar 6, 2013 at 6:15 PM, Matt Porter wrote:
> > Adds support for parsing the TI EDMA DT data into the
> > required EDMA private API platform data. Enables runtime
> > PM support to initialize the EDMA hwmod. Adds AM33XX EDMA
On 12 March 2013 20:30, Chris Ball wrote:
> Hi,
>
> On Tue, Mar 12 2013, Sachin Kamat wrote:
>> There is also another patch in this series [1] that needs your attention.
>> [1] https://patchwork.kernel.org/patch/2156621/
>
> I'd rather have one of the dw_mmc maintainers handle ACKing patches
> bef
Hi,
On Tue, Mar 12 2013, Sachin Kamat wrote:
> There is also another patch in this series [1] that needs your attention.
> [1] https://patchwork.kernel.org/patch/2156621/
I'd rather have one of the dw_mmc maintainers handle ACKing patches
before I apply them. If they haven't reviewed it by the t
>> -int dw_mci_exynos_probe(struct platform_device *pdev)
>> +static int dw_mci_exynos_probe(struct platform_device *pdev)
>> {
>> const struct dw_mci_drv_data *drv_data;
>> const struct of_device_id *match;
>
> Thanks, pushed to mmc-next for 3.10.
Thanks Chris.
There is also another
Hi,
On Tue, Mar 12 2013, Arnd Bergmann wrote:
>> Need add regulator_put here since regulator_get has succeed?
>
> Hmm, we still don't actually bail out if the error is encountered, so
> the reference count is balanced with the current patch, but I maybe
> a failed regulator_enable() should actuall
Remove specifying mmc controller IP version information via platform
data, instead specify device name so that driver derives it from
platform_device_id table. Also change the clock node name to match
the changed dev_id.
Tested on da850-evm to make sure driver loads without clk_get failures.
Signe
Add DT entry for MMC. Also add entry for pinmux information.
Tested:
1) Without GPIO card detection and EDMA support as DT support for
GPIO and EDMA are yet come.
2) By creating/deleting files and mounting/unmounting the partition.
Signed-off-by: Manjunathappa, Prakash
Cc: linux-mmc@vger.kerne
Adds device tree support for davinci_mmc. Also add binding documentation.
As of now in non-dma PIO mode and without GPIO card_detect/write_protect
option because of dependencies on EDMA and GPIO module DT support.
Signed-off-by: Manjunathappa, Prakash
Reviewed-by: Mark Rutland
Cc: linux-mmc@vger
Populate OF_DEV_AUXDATA with desired device name expected by
davinci_mmc driver. Without this clk_get of davinci_mmc DT driver
fails.
Signed-off-by: Manjunathappa, Prakash
Cc: linux-mmc@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-ker...@vger.kernel.org
Cc: davinci-linux-ope
Patch set adds DT support for davinci_mmc driver and is
verified on da850-evm without card_detect/write_protect and
EDMA support. Also takecare to derive controller IP version from
platform_device_id table, remove version specification in pdata.
Applies on top of below patch under community review
On Tuesday 12 March 2013, Kevin Liu wrote:
> > - regulator_enable(host->vqmmc);
> > + ret = regulator_enable(host->vqmmc);
> > if (!regulator_is_supported_voltage(host->vqmmc, 170,
> > 195))
> > caps
Hi,
On Mon, Feb 18 2013, Sachin Kamat wrote:
> Silences the following sparse warning:
> drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat
> ---
> drivers/mmc/host/dw_mmc-exynos.c |2 +-
> 1 f
Looks good to me.
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 03/12/2013 07:43 PM, James Hogan wrote:
> Call the setpower platform callback in response to set_ios with
> ios->power_mode == MMC_POWER_UP or MMC_POWER_OFF, instead of from the
> card detect work function.
>
> This appea
Commit f9c2a0dc42a6938ff2a80e55ca2bbd1d5581c72e
"mmc: dw_mmc: Fix PIO mode with support of highmem" introduced
a regression since v3.2 making the mmc_test hang on test #13
with a "Data starvation by host timeout" interrupt.
This is because, sg_mapping_iter is used to iterate through the
data which
Previously, it was possible to add either 0 bytes or add nbytes
twice if we broke out of the outer loop and then carry on to the
"done" label. This is now fixed by adding the transferred bytes
right after the pull/pop operation
Signed-off-by: Markos Chandras
Cc: Seungwon Jeon
Cc: Jaehoon Chung
There is no reason to loop when handling an interrupt. The "if" clauses
will handle all of them sequentially. This also eliminates the extra loop
we used to take with no pending interrupts and we ended up breaking out
of the while loop.
Signed-off-by: Markos Chandras
Cc: Seungwon Jeon
Cc: Jaehoo
All users of the sdhci_ops struct in the sdhci core already treat it as const.
The sdhci-pltfm code itself never actually looks at the ops field of the
sdhci_pltfm_data struct and merely passes it on to the sdhci core, so make we
can make it const in the sdhci_pltfm_data struct as well. This allows
Basically all drivers can have sdhci_ops struct const, but almost none do so.
This patch constifies all sdhci_ops struct declarations where possible.
The patch was auto-generated with the following coccinelle semantic patch:
//
@r1@
identifier ops;
identifier fld;
@@
ops.fld = ...;
@disable opt
The sdhci_pltfm_data struct is never modified within the sdhci_pltfm module. So
make the pdata parameter to sdhci_pltfm_init and sdhci_pltfm_register const.
This allows drivers to declare their sdhci_pltfm_data struct as const.
This patch also makes the sdhci_pltfm_data declarations const where po
host->data_offset is initialised at the end of the probe function
depending on the VERID register, and is used for PIO operations. Move
this initialisation earlier, before IRQs or slots are initialised, to be
sure that PIO won't occur prior to host->data_offset being initialised.
Signed-off-by: Ja
Call the setpower platform callback in response to set_ios with
ios->power_mode == MMC_POWER_UP or MMC_POWER_OFF, instead of from the
card detect work function.
This appears to fix a problem I have where a card stuck in a funny state
doesn't get properly cleared by the power being turned off, pres
On 4 March 2013 10:06, Sachin Kamat wrote:
> Hi Chris,
>
> On 18 February 2013 16:21, Seungwon Jeon wrote:
>> Hi Sachin,
>>
>> You're right.
>> 'dw_mci_exynos_probe' is only used here.
>>
>> Acked-by: Seungwon Jeon
>>
>> On Monday, February 18, 2013, Jaehoon Chung wrote:
>>> Acked-by: Jaehoon Ch
Used resource_size function instead of explicit computation.
Patch found using coccinelle.
Signed-off-by: Alexandru Gheorghiu
---
drivers/mmc/host/wmt-sdmmc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
index
34 matches
Mail list logo
