Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice

On 3/8/2013 8:44 AM, Ulf Hansson wrote: On 7 March 2013 22:14, Kevin Liu wrote: 2013/3/7 Kevin Liu : 2013/3/7 Ulf Hansson : On 7 March 2013 01:12, Kevin Liu wrote: From: Ulf Hansson mailto:ulf.hans...@stericsson.com>> Date: Fri, Mar 1, 2013 at 8:47 PM Subject: [PATCH 0/3] mmc: Use runtime

Re: [PATCH v2] wait while adding MMC host to ensure root mounts

On 03/14/2013 01:08 PM, Namjae Jeon wrote: > 2013/3/14, Sergey Yanovich : >> MMC hosts are added asynchronously. We need to wait until detect returns to >> avoid failed root filesystem mounts. >> ---8<--- >> VFS: Cannot open root device "mmcblk0p1" or unknown-block(0,0): error -6 >> Please append a

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

On Thursday 14 March 2013, Anatolij Gustschin wrote: > I wanted to avoid additional levels of indirection and function calls > on i.MX. If something like > > static inline u32 mxcmci_readl(struct mxcmci_host *host, int reg) > { > #if IS_ENABLED(CONFIG_PPC_MPC512x) > return in_be32(host->ba

Re: [PATCH 4/5] mmc: mxcmmc: enable DMA support on mpc512x

On Thu, 14 Mar 2013 21:11:39 +0100 Sascha Hauer wrote: > On Thu, Mar 14, 2013 at 05:40:53PM +0100, Anatolij Gustschin wrote: > > Add SDHC DMA channel description to the mpc512x device > > tree to enable slave channel requesting in the mxcmmc > > driver. > > > > mpc512x DMA engine doesn't support

Re: [PATCH 4/5] mmc: mxcmmc: enable DMA support on mpc512x

On Thu, Mar 14, 2013 at 05:40:53PM +0100, Anatolij Gustschin wrote: > Add SDHC DMA channel description to the mpc512x device > tree to enable slave channel requesting in the mxcmmc > driver. > > mpc512x DMA engine doesn't support endianness conversion > when reading/writing data from peripheral's

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

On Thu, Mar 14, 2013 at 07:13:32PM +0100, Anatolij Gustschin wrote: > On Thu, 14 Mar 2013 17:50:08 +0100 > Arnd Bergmann wrote: > > > On Thursday 14 March 2013 17:40:49 Anatolij Gustschin wrote: > > > > > + > > > +struct mxcmci_reg_ops mxcmci_reg_ops = { > > > + .read_l = mpcmci_readl, > > > + .

Re: [PATCH v2] mmc: mxcmmc: fix bug that may block a data transfer forever.

Hi Fabio, On Thu, 21 Feb 2013 12:49:49 -0300 Fabio Estevam wrote: > Hi Anatolij, > > Anatolij Gustschin wrote: > > > this change introduces a race condition for host->req (and maybe > > for host->data) accesses. The callback is running in soft-irq context and > > can > > be interrupted by the

Re: [PATCH 3/5] mmc: mxcmmc: constify mxcmci_devtype and fix build warning

On Thu, 14 Mar 2013 17:40:52 +0100 Anatolij Gustschin wrote: > Fix: > drivers/mmc/host/mxcmmc.c: In function 'mxcmci_probe': > drivers/mmc/host/mxcmmc.c:1137:41: warning: initialization discards > 'const' qualifier from pointer target type [enabled by default] > > Signed-off-by: Anatolij Gustsch

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

On Thu, 14 Mar 2013 17:50:08 +0100 Arnd Bergmann wrote: > On Thursday 14 March 2013 17:40:49 Anatolij Gustschin wrote: > > > + > > +struct mxcmci_reg_ops mxcmci_reg_ops = { > > + .read_l = mpcmci_readl, > > + .write_l = mpcmci_writel, > > + .read_w = mpcmci_readw, > > + .write_w = mpcmci

Re: [PATCH v8 1/3] mmc: core: enhance card removal judgement for slow removal

On Wed, Mar 6, 2013 at 4:29 AM, Kevin Liu wrote: > This patch add the card detect status check in function > _mmc_detect_card_removed if cmd13 check succeed and host->ops->get_cd > provided. If get_cd detect no card present then schedule another detect > work 200ms later. Tested-by: Linus Wallei

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

On Thursday 14 March 2013 17:40:49 Anatolij Gustschin wrote: > + > +struct mxcmci_reg_ops mxcmci_reg_ops = { > + .read_l = mpcmci_readl, > + .write_l = mpcmci_writel, > + .read_w = mpcmci_readw, > + .write_w = mpcmci_writew, > +}; > +#else > +struct mxcmci_reg_ops mxcmci_reg_ops; >

[PATCH 5/5] mmc: mxcmmc: fix race conditions for host->req and host->data access

mxcmci_dma_callback() is invoked by DMA drivers in soft-irq context and can be interrupted by the mxcmci_irq() interrupt which can finish the mmc request or data transfer and set host->req or host->data pointers to NULL. Then mxcmci_data_done() crashes with a null pointer dereferences. Protect all

[PATCH 4/5] mmc: mxcmmc: enable DMA support on mpc512x

Add SDHC DMA channel description to the mpc512x device tree to enable slave channel requesting in the mxcmmc driver. mpc512x DMA engine doesn't support endianness conversion when reading/writing data from peripheral's FIFO, so we have to swap data buffers before each DMA write and after each DMA r

[PATCH 3/5] mmc: mxcmmc: constify mxcmci_devtype and fix build warning

Fix: drivers/mmc/host/mxcmmc.c: In function 'mxcmci_probe': drivers/mmc/host/mxcmmc.c:1137:41: warning: initialization discards 'const' qualifier from pointer target type [enabled by default] Signed-off-by: Anatolij Gustschin --- drivers/mmc/host/mxcmmc.c |4 ++-- 1 files changed, 2 insertio

[PATCH 3/5] mmc: mxcmmc: constify mxcmci_devtype and fix build warning

Fix: drivers/mmc/host/mxcmmc.c: In function 'mxcmci_probe': drivers/mmc/host/mxcmmc.c:1137:41: warning: initialization discards 'const' qualifier from pointer target type [enabled by default] Signed-off-by: Anatolij Gustschin --- drivers/mmc/host/mxcmmc.c |4 ++-- 1 files changed, 2 insertio

[PATCH 2/5] mmc: mxcmmc: use slot-gpio API for write-protect detection

slot-gpio API suppors read-only detection when "wp-gpios" property is present in the device tree mmc node. Use this API for write-protect detection. Signed-off-by: Anatolij Gustschin --- drivers/mmc/host/mxcmmc.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

The SDHC controller on mpc512x is compatible with i.MX31 SDHC, so the mxcmmc driver can be used on mpc512x, too. Extend the driver to support mpc512x as well. Signed-off-by: Anatolij Gustschin --- drivers/mmc/host/Kconfig | 10 +- drivers/mmc/host/mxcmmc.c | 222 +

[PATCH 0/5] mmc: mxcmmc: add mpc512x support

The SDHC controller on mpc512x is compatible with i.MX31 SDHC controller, the existing MMC host driver can be used on mpc512x with some modifications, the patch series extends the existing driver. It is based on the following mxcmmc DT support patch: http://thread.gmane.org/gmane.linux.kernel.mmc

Re: [PATCH] mmc: mxcmmc: DT support

On Thu, Mar 14, 2013 at 04:50:48PM +0100, Anatolij Gustschin wrote: > On Mon, 25 Feb 2013 19:28:05 +0100 > Markus Pargmann wrote: > > > Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic > > gpio helper functions by Guennadi and generic DMA devicetree bindings. > > > > Signe

Re: [PATCH] mmc: mxcmmc: DT support

On Mon, 25 Feb 2013 19:28:05 +0100 Markus Pargmann wrote: > Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic > gpio helper functions by Guennadi and generic DMA devicetree bindings. > > Signed-off-by: Markus Pargmann > --- > .../devicetree/bindings/mmc/fsl-imx-mmc.txt

Re: [PATCH] mmc: block: fix the host's claim-release in special request

On 14 March 2013 12:56, Johan Rudholm wrote: > Hi Seungwon, > > 2013/3/14 Seungwon Jeon : >> For normal request mmc_blk_issue_rq is called twice with asynchronous >> transfer(cur and prev). Host's claim and release can be done in each >> mmc_blk_issue_rq. However, Special request is currently excl

[PATCH] mmc: sdhci-esdhc-imx: fix multiblock reads on i.MX53

The eSDHC controller on the i.MX53 needs an additional, non spec compliant CMD12 after a multiblock read with a predefined number of blocks. Otherwise the internal state machine won't go back to the idle state. This commit effectively reverts ebe31e44 (mmc: sdhci-esdhc-imx: fix for mmc cards on i.

RE: [PATCH v5 0/4] Add DT support for davinci_mmc driver

On Thu, Mar 14, 2013 at 17:25:13, Nori, Sekhar wrote: > On 3/12/2013 7:43 PM, Manjunathappa, Prakash wrote: > > Patch set adds DT support for davinci_mmc driver and is > > verified on da850-evm without card_detect/write_protect and > > EDMA support. Also takecare to derive controller IP version fro

RE: [PATCH v5 1/4] ARM: davinci: mmc: derive version information from device name

On Thu, Mar 14, 2013 at 16:38:09, Nori, Sekhar wrote: > Prakash, > > The series looks good to me. I tested it again on DA850 EVM (with and > without DT). > > On 3/12/2013 7:43 PM, Manjunathappa, Prakash wrote: > > Remove specifying mmc controller IP version information via platform > > data, inst

Re: [PATCH v2] wait while adding MMC host to ensure root mounts

On 14/03/13 08:08, Namjae Jeon wrote:> 2013/3/14, Sergey Yanovich : Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) Have you ever tried to use rootwait or rootdelay on command line ? If no, You can use them. Those options work. However, they introduce a delay

Re: [PATCH] mmc: block: fix the host's claim-release in special request

Hi Seungwon, 2013/3/14 Seungwon Jeon : > For normal request mmc_blk_issue_rq is called twice with asynchronous > transfer(cur and prev). Host's claim and release can be done in each > mmc_blk_issue_rq. However, Special request is currently excluded in > asynchronous transfer. After special request

Re: [PATCH v5 0/4] Add DT support for davinci_mmc driver

On 3/12/2013 7:43 PM, Manjunathappa, Prakash wrote: > Patch set adds DT support for davinci_mmc driver and is > verified on da850-evm without card_detect/write_protect and > EDMA support. Also takecare to derive controller IP version from > platform_device_id table, remove version specification in

Re: [PATCH v5 1/4] ARM: davinci: mmc: derive version information from device name

Prakash, The series looks good to me. I tested it again on DA850 EVM (with and without DT). On 3/12/2013 7:43 PM, Manjunathappa, Prakash wrote: > Remove specifying mmc controller IP version information via platform > data, instead specify device name so that driver derives it from > platform_devi

Re: [PATCH] wait while adding MMC host to ensure root mounts

On 14/03/13 06:47, Greg Kroah-Hartman wrote: On Thu, Mar 14, 2013 at 05:06:23AM +0400, Sergey Yanovich wrote: /* wait for the known devices to complete their probing */ - wait_event(probe_waitqueue, atomic_read(&probe_count) == 0); You didn't need to change this file, please do

RE: [PATCH] mmc: dw_mmc: setpower on MMC_POWER_{UP,OFF}

On Wednesday, March 13, 2013, James Hogan wrote: > On 13/03/13 14:20, Seungwon Jeon wrote: > > Hi James, > > > > On Tuesday, March 12, 2013, James Hogan wrote: > >> Call the setpower platform callback in response to set_ios with > >> ios->power_mode == MMC_POWER_UP or MMC_POWER_OFF, instead of from

Re: MMC block discard / erase ioctl

On 13/03/13 16:51, Mark Deneen wrote: > On Wed, Mar 13, 2013 at 3:59 AM, Adrian Hunter > wrote: > > On 12/03/13 18:13, Mark Deneen wrote: > > I assume that this never made it into mainline? I'm looking to do > something > > similar, and I was wonde