RE: [PATCH v6 3/5] mmc: davinci_mmc: add DT support

2013-03-27 Thread Manjunathappa, Prakash
Hi Arnd, On Wed, Mar 20, 2013 at 18:56:09, Arnd Bergmann wrote: On Wednesday 20 March 2013, Manjunathappa, Prakash wrote: Adds device tree support for davinci_mmc. Also add binding documentation. As of now in non-dma PIO mode and without GPIO card_detect/write_protect option because of

Re: [PATCH v6 3/5] mmc: davinci_mmc: add DT support

2013-03-27 Thread Arnd Bergmann
On Wednesday 27 March 2013, Manjunathappa, Prakash wrote: On Wed, Mar 20, 2013 at 18:56:09, Arnd Bergmann wrote: On Wednesday 20 March 2013, Manjunathappa, Prakash wrote: Adds device tree support for davinci_mmc. Also add binding documentation. As of now in non-dma PIO mode and without

Re: [PATCH v2] wait while adding MMC host to ensure root mounts

2013-03-27 Thread Ulf Hansson
On 22 March 2013 18:03, Chris Ball c...@laptop.org wrote: Hi Sergey, On Wed, Mar 13 2013, Sergey Yanovich wrote: MMC hosts are added asynchronously. We need to wait until detect returns to avoid failed root filesystem mounts. ---8--- VFS: Cannot open root device mmcblk0p1 or

Re: [PATCH v2] wait while adding MMC host to ensure root mounts

2013-03-27 Thread Chris Ball
Hi, On Wed, Mar 27 2013, Ulf Hansson wrote: I noticed you merged this. I thought the idea was to use the rootwait or rootdelay? That's necessary before the patch, but it would be better if we didn't have to pass rootwait, all else being equal. Moreover, this patch will have bad impact on

RE: [PATCH] mmc: dw_mmc: rewrite CLKDIV computation

2013-03-27 Thread Seungwon Jeon
On Wednesday, March 27, 2013, Grant Grundler wrote: Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation. For easily identifying, it would be good to point the commit id and subject. But when debugging a related issue (http://crbug.com/221828) I found It is not easy to catch up

Re: [PATCH v2] wait while adding MMC host to ensure root mounts

2013-03-27 Thread Сергей Янович
Hi Ulf, On 27 March 2013 15:13, Ulf Hansson ulf.hans...@linaro.org wrote: Moreover, this patch will have bad impact on booting the kernel, since every host device that has scheduled a detect work from it's probe function will also wait for it to finish. Even if it is the boot device of not.

Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice

2013-03-27 Thread Chris Ball
Hi Maya, Kevin, Seungwon, Jaehoon, On Fri, Mar 01 2013, Ulf Hansson wrote: From: Ulf Hansson ulf.hans...@linaro.org SDIO has been using runtime pm for a while to handle runtime power save operations. This patchset is enabling the option to make the sd/mmc blockdevices to use runtime pm as

Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice

2013-03-27 Thread Arnd Bergmann
On Friday 01 March 2013, Ulf Hansson wrote: From: Ulf Hansson ulf.hans...@linaro.org SDIO has been using runtime pm for a while to handle runtime power save operations. This patchset is enabling the option to make the sd/mmc blockdevices to use runtime pm as well. The runtime pm

Re: [PATCH] mmc: dw-mmc: control the power-enable register

2013-03-27 Thread James Hogan
On 26/03/13 12:36, Jaehoon Chung wrote: When card is power-on/off, need to control the power-enable register. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: James Hogan james.ho...@imgtec.com Cheers James -- To

Re: [PATCH] mmc: dw_mmc: rewrite CLKDIV computation

2013-03-27 Thread Doug Anderson
Grant, Thanks for posting! See below... On Tue, Mar 26, 2013 at 3:50 PM, Grant Grundler grund...@chromium.org wrote: Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation. But when debugging a related issue (http://crbug.com/221828) I found the code unreadable. This rewrite

[PATCH] mmc: core: Re-use code for MMC_CAP2_DETECT_ON_ERR in polling mode

2013-03-27 Thread Ulf Hansson
From: Ulf Hansson ulf.hans...@linaro.org Previously the MMC_CAP2_DETECT_ON_ERR was invented for detecting slow card removal. In was never a realy good solution and a proper fix has been merged using gpio debouncing instead. We remove this cap in this patch. Although when using polling card

RE: [PATCH v6 3/5] mmc: davinci_mmc: add DT support

2013-03-27 Thread Manjunathappa, Prakash
On Wed, Mar 27, 2013 at 16:13:51, Arnd Bergmann wrote: On Wednesday 27 March 2013, Manjunathappa, Prakash wrote: On Wed, Mar 20, 2013 at 18:56:09, Arnd Bergmann wrote: On Wednesday 20 March 2013, Manjunathappa, Prakash wrote: Adds device tree support for davinci_mmc. Also add binding

Re: [PATCH] mmc: dw_mmc: rewrite CLKDIV computation

2013-03-27 Thread Grant Grundler
Sorry - please ignore the previous version. Did not include a copyright (implied to be mine...but it's not) nor license. Same thing but with proper attribution. cheers, grant On Tue, Mar 26, 2013 at 3:53 PM, Grant Grundler grund...@chromium.org wrote: I've attached the test program I wrote to

Re: [PATCH] mmc: dw_mmc: rewrite CLKDIV computation

2013-03-27 Thread Chris Ball
Hi Grant, On Wed, Mar 27 2013, Grant Grundler wrote: On Wed, Mar 27, 2013 at 5:25 AM, Seungwon Jeon tgih@samsung.com wrote: On Wednesday, March 27, 2013, Grant Grundler wrote: Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation. For easily identifying, it would be good to

Re: [PATCH] mmc: dw_mmc: rewrite CLKDIV computation

2013-03-27 Thread Grant Grundler
On Wed, Mar 27, 2013 at 8:07 AM, Doug Anderson diand...@chromium.org wrote: Grant, Thanks for posting! See below... thanks for reviewing/feedback! :) On Tue, Mar 26, 2013 at 3:50 PM, Grant Grundler grund...@chromium.org wrote: Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV

Re: [PATCH] mmc: dw_mmc: rewrite CLKDIV computation

2013-03-27 Thread Grant Grundler
Hi Chris, On Wed, Mar 27, 2013 at 10:58 AM, Chris Ball c...@laptop.org wrote: Hi Grant, ... Please use the following (standard) syntax in the commit message: Commit e419990b5e8 (mmc: dw_mmc: correct the calculation for CLKDIV) fixed a bug in CLKDIV computation. [..] Ok - I didn't know that

Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice

2013-03-27 Thread Sujit Reddy Thumma
Hi Ulf, Sorry for the delayed response. The patches looks good to me except one concern mentioned below. On 3/21/2013 3:28 AM, Ulf Hansson wrote: If any driver wants to implement this then the runtime PM code would be refactored again. So I guess we might want to think about this now itself?

Re: [PATCH v5 1/3] block: Add support for reinsert a dispatched req

2013-03-27 Thread tlinder
Hi Jens Add support for reinserting a dispatched request back to the scheduler's internal data structures. This capability is used by the device driver when it chooses to interrupt the current request transmission and execute another (more urgent) pending request. For example: interrupting

[PATCH V2] mmc: dw_mmc: rewrite CLKDIV computation

2013-03-27 Thread Grant Grundler
When backporting Commit e419990b5e8 (mmc: dw_mmc: correct the calculation for CLKDIV) to 3.4 kernel and debugging a FW issue, I found the code unreadable. This rewrite simplifies the computation and explains each step. Signed-off-by: Grant Grundler grund...@chromium.org --- V2: rewrote commit

Re: [PATCH 0/3] mmc: Use runtime pm for blkdevice

2013-03-27 Thread Kevin Liu
-Original Message- From: Chris Ball [mailto:c...@laptop.org] Sent: Wednesday, March 27, 2013 9:32 PM To: Ulf Hansson Cc: linux-mmc@vger.kernel.org; Johan Rudholm; Ulf Hansson; Maya Erez; Kevin Liu; Seungwon Jeon; jh80.ch...@samsung.com Subject: Re: [PATCH 0/3] mmc: Use runtime pm

[PATCH 1/2] mmc: dw_mmc: Check return value of regulator_enable

2013-03-27 Thread Sachin Kamat
regulator_enable() is declared with __must_check attribute. Hence check the return value to ensure that the regulator is enabled. Fixes the following warning: drivers/mmc/host/dw_mmc.c:2461:19: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result

[PATCH 2/2] mmc: dw_mmc: Use pr_info instead of printk

2013-03-27 Thread Sachin Kamat
pr_info(... is preferred to printk(KERN_INFO ... Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 1ba09d0..b8582d0 100644 ---

Re: [PATCH 1/2] mmc: dw_mmc: Check return value of regulator_enable

2013-03-27 Thread Jaehoon Chung
Hi, Sachin Your patch is right. I want to use the mmc_regulator_set_ocr() into core.c. Then I think we can remove the regulator_enable/disable in suspend/resume. how about this? If you have any opinion, let me know. Anyway, this patch looks good to me. Thanks for your effort. Acked-by: Jaehoon

Re: [PATCH 2/2] mmc: dw_mmc: Use pr_info instead of printk

2013-03-27 Thread Jaehoon Chung
Hi Sachin, On 03/28/2013 01:25 PM, Sachin Kamat wrote: pr_info(... is preferred to printk(KERN_INFO ... Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c