Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-08 Thread Thomas Abraham
-- >> drivers/mmc/host/dw_mmc.c| 12 ++-- >> drivers/mmc/host/dw_mmc.h|3 --- >> 3 files changed, 2 insertions(+), 51 deletions(-) > > This patch applies fine but fails to compile on linux-next > "next-20130408". You lost the rac

Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-08 Thread Thomas Abraham
On 8 April 2013 17:49, Seungwon Jeon wrote: > On Friday, April 05, 2013, Thomas Abraham wrote: >> With device core now able to setup the default pin configuration, >> the pin configuration code based on the deprecated Samsung specific >> gpio bindings is removed. >> >> Signed-off-by: Thomas Abraha

[PATCH v4] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-08 Thread Thomas Abraham
With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. Signed-off-by: Thomas Abraham Acked-by: Linus Walleij Reviewed-by: Doug Anderson Tested-by: Doug Anderson Acked-by: Seungwon Jeon ---

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-08 Thread Doug Anderson
Seungwon, On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon wrote: > I guess Doug are debugging it with wifi, right? Yes, we're debugging it on the Samsung ARM Chromebook on a part that has an SDIO WiFi module by Marvell. Bing Zhao (CCed) has a unit in hand that generates lots of CRC errors and has

[PATCH v3 1/5] mmc: mxcmmc: fix race conditions for host->req and host->data access

2013-04-08 Thread Anatolij Gustschin
mxcmci_dma_callback() is invoked by DMA drivers in soft-irq context and can be interrupted by the mxcmci_irq() interrupt which can finish the mmc request or data transfer and set host->req or host->data pointers to NULL. Then mxcmci_data_done() crashes with a null pointer dereferences. Protect all

[PATCH v3 2/5] mmc: mxcmmc: add mpc512x SDHC support

2013-04-08 Thread Anatolij Gustschin
The SDHC controller on mpc512x is compatible with i.MX31 SDHC, so the mxcmmc driver can be used on mpc512x, too. Extend the driver to support mpc512x as well. Signed-off-by: Anatolij Gustschin Acked-by: Sascha Hauer --- v3: - no changes, only add Acked-by tag v2: - change to select register a

[PATCH v3 4/5] mmc: mxcmmc: constify mxcmci_devtype

2013-04-08 Thread Anatolij Gustschin
mxcmci_devtype struct contains constant data, so constify this struct. Signed-off-by: Anatolij Gustschin Acked-by: Sascha Hauer --- v3: - add Acked-by line v2: - remove build warning fix (already fixed elsewhere) and change commit log drivers/mmc/host/mxcmmc.c |2 +- 1 files changed,

[PATCH v3 5/5] mmc: mxcmmc: enable DMA support on mpc512x

2013-04-08 Thread Anatolij Gustschin
Add SDHC DMA channel description to the mpc512x device tree to enable slave channel requesting in the mxcmmc driver. mpc512x DMA engine doesn't support endianness conversion when reading/writing data from peripheral's FIFO, so we have to swap data buffers before each DMA write and after each DMA r

[PATCH v3 3/5] mmc: mxcmmc: use slot-gpio API for write-protect detection

2013-04-08 Thread Anatolij Gustschin
slot-gpio API suppors read-only detection when "wp-gpios" property is present in the device tree mmc node. Use this API for write-protect detection. Signed-off-by: Anatolij Gustschin Acked-by: Sascha Hauer --- v3: - add Acked-by line v2: - no changes drivers/mmc/host/mxcmmc.c |8 +--

[PATCH v3 0/5] mmc: mxcmmc: add mpc512x support

2013-04-08 Thread Anatolij Gustschin
The SDHC controller on mpc512x is compatible with i.MX31 SDHC controller, the existing MMC host driver can be used on mpc512x with some modifications, the patch series extends the existing driver. It is based on the following v3 mxcmmc DT support patch: https://patchwork.kernel.org/patch/236863

Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-08 Thread Doug Anderson
branch. > > drivers/mmc/host/dw_mmc-exynos.c | 38 > -- > drivers/mmc/host/dw_mmc.c| 12 ++-- > drivers/mmc/host/dw_mmc.h|3 --- > 3 files changed, 2 insertions(+), 51 deletions(-) This patch applies fine but fails to compile

Re: [PATCH] mmc: atmel-mci: pio hang on block errors

2013-04-08 Thread Chris Ball
Hi, On Mon, Apr 08 2013, Ludovic Desroches wrote: > Could you take this fix? If there are no objections of course. Thanks for the reminder; pushed to mmc-next now. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/5 V2] mmc: core: call pm_runtime_put_noidle in pm_runtime_get_sync failed case

2013-04-08 Thread Ohad Ben-Cohen
On Mon, Apr 8, 2013 at 4:36 AM, Li Fei wrote: > Even in failed case of pm_runtime_get_sync, the usage_count > is incremented. In order to keep the usage_count with correct > value and runtime power management to behave correctly, call > pm_runtime_put_noidle in such case. > > Signed-off-by Liu Chu

RE: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-08 Thread Seungwon Jeon
On Friday, April 05, 2013, Thomas Abraham wrote: > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. > > Signed-off-by: Thomas Abraham Acked-by: Seungwon Jeon I hope that your anoth

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-08 Thread Seungwon Jeon
On Friday, April 05, 2013, Jaehoon Chung wrote: > Hi Doug, > > You're right..it's something wrong. > Actually i didn't test with your patch, but your commit message is reasonable. > > I will check until next week after test. Doug Anderson, Jaehoon Chung, Sorry for late response. Could I explain

[PATCH V2 2/2] mmc: block: Enable runtime pm for mmc blkdevice

2013-04-08 Thread Ulf Hansson
From: Ulf Hansson Once the mmc blkdevice is being probed, runtime pm will be enabled. By using runtime autosuspend, the power save operations can be done when request inactivity occurs for a certain time. Right now the selected timeout value is set to 3 s. Moreover, when the blk device is being

[PATCH V2 1/2] mmc: core: Add bus_ops for runtime pm callbacks

2013-04-08 Thread Ulf Hansson
From: Ulf Hansson SDIO is the only protocol that uses runtime pm for the card device right now. To provide the option for sd and mmc to use runtime pm as well the bus_ops callback are extended with two new functions. One for runtime_suspend and one for runtime_resume. This patch will also implem

[PATCH V4 2/2] mmc: core: fix performance regression initializing MMC host controllers

2013-04-08 Thread Adrian Hunter
Commit fa5501890d8974301042e0202d342a6cbe8609f4 introduced a boot time performance regression by adding mmc_power_up() to mmc_start_host(). mmc_power_up() is not necessary to host controller initialization, it is part of card initialization and is performed anyway asynchronously. Please see the ori

Re: [PATCH V3 2/2] mmc: core: fix performance regression initializing MMC host controllers

2013-04-08 Thread Ulf Hansson
On 5 April 2013 15:31, Adrian Hunter wrote: > Commit fa5501890d8974301042e0202d342a6cbe8609f4 introduced a boot time > performance regression by adding mmc_power_up() to mmc_start_host(). > mmc_power_up() is not necessary to host controller initialization, it is > part of card initialization and i

[PATCH] mmc: Adding (more) ftrace event logging to the mmc layer

2013-04-08 Thread Månsson, Björn
From: Bjorn Mansson Adding ftrace to the mmc layer facilitates debugging, making it easier to debug commend sequences without rebuilding the kernel. It is also possible to parse the ftrace output into VCD format and visualize it in GTKWave. Patch is for the 3.7.5 Kernel. Signed-off-by: Bjorn

Re: core: negotiate ocr during resume

2013-04-08 Thread Prasanna NAVARATNA
Kevin : you didn't handle the special case that the card is changed to a new card during suspended. So the ocr may be different here. PNN : This case doesn't holds good because even when new card is inserted during suspend, cd interrupt is generated and mmc_detect_change will be called and mmc_re