Re: [PATCH 09/10] arm: add debug uarts for rockchip rk29xx and rk3xxx series

2013-06-03 Thread Heiko Stübner
Am Montag, 3. Juni 2013, 04:08:37 schrieb Arnd Bergmann: On Monday 03 June 2013 01:01:03 Heiko Stübner wrote: +#if defined(CONFIG_DEBUG_RK29_UART0) +#define ROCKCHIP_UART_DEBUG_PHYS_BASE 0x2006 +#define ROCKCHIP_UART_DEBUG_VIRT_BASE 0xfe06 0xfed6 maybe? looks like a typo.

Re: [PATCH 10/10] arm: add basic support for Rockchip RK3066a boards

2013-06-03 Thread Heiko Stübner
Am Montag, 3. Juni 2013, 04:15:46 schrieb Arnd Bergmann: On Monday 03 June 2013 01:02:20 Heiko Stübner wrote: index 000..094b37d --- /dev/null +++ b/arch/arm/mach-rockchip/rockchip.c If all goes well, this file can be removed again in 3.11 since it's all generic, but let's add it

Re: [PATCH 08/10] clk: add basic Rockchip rk3066a clock support

2013-06-03 Thread Heiko Stübner
Am Montag, 3. Juni 2013, 05:27:11 schrieb Olof Johansson: On Mon, Jun 03, 2013 at 01:00:31AM +0200, Heiko Stübner wrote: This adds basic support for clocks on Rockchip rk3066 SoCs. The clock handling thru small dt nodes is heavily inspired by the sunxi clk code. The clock specifiers

Re: [PATCH 10/10] arm: add basic support for Rockchip RK3066a boards

2013-06-03 Thread Arnd Bergmann
On Monday 03 June 2013 10:23:49 Heiko Stübner wrote: Am Montag, 3. Juni 2013, 04:15:46 schrieb Arnd Bergmann: Can't you use of_clk_init(NULL); clocksource_of_init(); here and change the two drivers to provide the respective macros? hmm, while this would make a lot of

Re: [PATCH 10/10] arm: add basic support for Rockchip RK3066a boards

2013-06-03 Thread Heiko Stübner
Am Montag, 3. Juni 2013, 11:22:35 schrieb Arnd Bergmann: On Monday 03 June 2013 10:23:49 Heiko Stübner wrote: Am Montag, 3. Juni 2013, 04:15:46 schrieb Arnd Bergmann: Can't you use of_clk_init(NULL); clocksource_of_init(); here and change the two drivers to provide the

Re: [PATCH 10/10] arm: add basic support for Rockchip RK3066a boards

2013-06-03 Thread Arnd Bergmann
On Monday 03 June 2013 11:46:57 Heiko Stübner wrote: The timers are of the same type and the clocksource driver just grabs the first of them as clockevent and the second as clocksource, so I think two CLOCKSOURCE_OF_DECLARE lines won't do. Ok, got it. I was confused by the fact that the

Re: [RFC] dw_apb_timer_of: use clocksource_of_init

2013-06-03 Thread Rob Herring
On 06/03/2013 07:15 AM, Heiko Stübner wrote: dw_apb_timer_init used to search the devicetree for matching timer devices, making calls to it from board files necessary. Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE. With this change the function gets called once for each

Re: [RFC] dw_apb_timer_of: use clocksource_of_init

2013-06-03 Thread Arnd Bergmann
On Monday 03 June 2013 14:15:28 Heiko Stübner wrote: dw_apb_timer_init used to search the devicetree for matching timer devices, making calls to it from board files necessary. Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE. With this change the function gets called once for

Re: [RFC/PATCH V2]: mmc: card/core: support password locked cards

2013-06-03 Thread Peter Turczak
Thanks Arnd for the input. I've prepared a RFC-Version of the patch. I'm not quite happy calling mmc_sd_resume() from the rescan ioctl. Unfortunately the rescan needed it twofold: 1. Force the SD layer to reread scr, ssr, etc. by somehow reaching mmc_sd_setup_card() 2. Remove

Re: [RFC/PATCH V2b]: mmc: card/core: support password locked cards

2013-06-03 Thread Peter Turczak
Sorry, forgot to attach the patch file. Thanks Arnd for the input. I've prepared a RFC-Version of the patch. I'm not quite happy calling mmc_sd_resume() from the rescan ioctl. Unfortunately the rescan needed it twofold: 1. Force the SD layer to reread scr, ssr, etc. by somehow reaching

[PATCH] mmc: sirf: fix sdhci_pltfm_init sequence

2013-06-03 Thread Arnd Bergmann
Patch mmc: sdhci: Add size for caller in init+register changed the interface for sdhci_pltfm_init, while patch mmc: sdhci-sirf: add mmc host sdhci-pltfm based driver for SiRF SoCs added a new driver with the old interface. This changes the sirf driver to use the new interface, avoiding one

Re: [PATCH] mmc: sirf: fix sdhci_pltfm_init sequence

2013-06-03 Thread Barry Song
Hi Arnd, 2013/6/4 Arnd Bergmann a...@arndb.de: Patch mmc: sdhci: Add size for caller in init+register changed the interface for sdhci_pltfm_init, while patch mmc: sdhci-sirf: add mmc host sdhci-pltfm based driver for SiRF SoCs added a new driver with the old interface. This changes the sirf

Re: [PATCH 05/10] mmc: dw_mmc-pltfm: remove static from dw_mci_pltfm_remove

2013-06-03 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 06/03/2013 07:58 AM, Heiko Stübner wrote: dw_mci_pltfm_remove gets exported and used by dw_mmc-exynos, so should not be static. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/mmc/host/dw_mmc-pltfm.c |2 +- 1 files changed,

Re: [PATCH 06/10] mmc: dw_mmc-pltfm: add Rockchip variant

2013-06-03 Thread Jaehoon Chung
On 06/03/2013 07:59 AM, Heiko Stübner wrote: Cortex-A9 SoCs from Rockchip use a slightly modified variant of dw_mmc controllers that seems to require the SDMMC_CMD_USE_HOLD_REG bit to always be set. There also seem to be no other modifications (additional register etc) present, so to keep

Re: [PATCH 4/4] mmc: core: Initiate suspend|resume from mmc bus instead of mmc host

2013-06-03 Thread Jaehoon Chung
Hi Ulf, On 05/30/2013 09:53 PM, Ulf Hansson wrote: From: Ulf Hansson ulf.hans...@linaro.org The host should be responsible to suspend|resume the host and not the card. This patch changes this behaviour, by moving the responsiblity to the mmc bus instead which already holds the card device.