[PATCHv8 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-06-10 Thread dinguyen
From: Dinh Nguyen Add platform specific functionality for the DW SD/MMC driver for SoCFPGA. Move SDMMC_CMD_USE_HOLD_REG to dw_mmc.h so other platforms can use this define. Signed-off-by: Dinh Nguyen Reviewed-by: Pavel Machek Acked-by: Jaehoon Chung CC: Seungwon Jeon CC: Jaehoon Chung CC: Ar

Re: [PATCHv7 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-06-10 Thread Jaehoon Chung
Dear Dinh, Sure... Could you resend the patch with my acked-by.? Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung On 06/11/2013 11:17 AM, Dinh Nguyen wrote: > Hi Jaehoon, > > On 06/10/2013 06:57 PM, Jaehoon Chung wrote: >> Dear Dinh, >> >> Could you run the checkpatch? > > I have ran chec

Re: [PATCHv7 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-06-10 Thread Dinh Nguyen
Hi Jaehoon, On 06/10/2013 06:57 PM, Jaehoon Chung wrote: > Dear Dinh, > > Could you run the checkpatch? I have ran checkpatch on all 6 patches. I did not think this warning needed a fix. Can I have your Ack-by if I fix the warning? Thanks, Dinh > > WARNING: line over 80 characters > #128: FILE

Re: [PATCH] drivers: mmc: reordered shutdown sequence in mmc_bld_remove_req

2013-06-10 Thread Paul Taysom
On Mon, Jun 10, 2013 at 2:44 AM, Ulf Hansson wrote: > On 4 June 2013 23:42, Paul Taysom wrote: >> We had a multi-partition SD-Card with two ext2 file systems. The partition >> table was getting overwritten by a race between the card removal and >> the unmount of the 2nd ext2 partition. >> >> What

Re: [PATCHv7 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-06-10 Thread Jaehoon Chung
Dear Dinh, Could you run the checkpatch? WARNING: line over 80 characters #128: FILE: drivers/mmc/host/dw_mmc-socfpga.c:63: + regmap_write(priv->sysreg, SYSMGR_SDMMCGRP_CTRL_OFFSET, priv->hs_timing); Best Regards, Jaehoon Chung On 06/11/2013 08:38 AM, dingu...@altera.com wrote: > From:

[PATCHv7 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

2013-06-10 Thread dinguyen
From: Dinh Nguyen Add platform specific functionality for the DW SD/MMC driver for SoCFPGA. Move SDMMC_CMD_USE_HOLD_REG to dw_mmc.h so other platforms can use this define. Signed-off-by: Dinh Nguyen Reviewed-by: Pavel Machek CC: Seungwon Jeon CC: Jaehoon Chung CC: Arnd Bergmann CC: Olof Joh

Re: [RESEND PATCH V3 6/8] mmc: tegra: handle mmc_of_parse() errors during probe

2013-06-10 Thread Simon Baatz
Hi Stephen, On Mon, Jun 10, 2013 at 03:11:14PM -0600, Stephen Warren wrote: > On 06/09/2013 02:14 PM, Simon Baatz wrote: > > Signed-off-by: Simon Baatz > > Tested-by: Stephen Warren Thanks! > (On Seaboard/Springbank board, i.e. Tegra20) > > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/dr

Re: [RESEND PATCH V3 6/8] mmc: tegra: handle mmc_of_parse() errors during probe

2013-06-10 Thread Stephen Warren
On 06/09/2013 02:14 PM, Simon Baatz wrote: > Signed-off-by: Simon Baatz Tested-by: Stephen Warren (On Seaboard/Springbank board, i.e. Tegra20) > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > +err_parse_dt: > err_power_req: > err_alloc_tegra_host: Nit: It'd

Re: [PATCH V2 0/3] mmc: mmci: Support ap_sleep in cpuidle for ux500

2013-06-10 Thread Ulf Hansson
On 27 May 2013 13:40, Rickard ANDERSSON wrote: > Acked-by: Rickard Andersson > > -Original Message- > From: Ulf HANSSON > Sent: den 23 maj 2013 11:45 > To: linux-arm-ker...@lists.infradead.org; Russell King > Cc: linux-mmc@vger.kernel.org; Chris Ball; Daniel Lezcano; Linus Walleij; > Ric

[PATCH] sdhci-pxav3: Fix runtime PM initialization

2013-06-10 Thread Daniel Drake
Commit bb691ae464b77d30e74c66480e98d74e88d6b194 breaks boot on OLPC XO-4, it hangs somewhere inside sdhci_add_host. When pm_runtime_set_autosuspend_delay() was being called, the device's usage counter was 0, causing the PM layer to runtime-suspend the device. We then went on to call sdhci_add_host

"exclude asynchronous transfer" patch causes boot fail

2013-06-10 Thread Daniel Drake
Hi, Testing the latest linus kernel on OLPC XO-4 (sdhci-pxav3), boot fails. Userspace does start, and I see that systemd is starting a few services (feels a bit slower than usual), then it hangs still while loading initial services - I don't even get to a shell prompt. git-bisect shows the follow

Re: [RESEND PATCH V3 0/8] mmc_of_parse() adaptations, switch mvsdio to mmc_of_parse()

2013-06-10 Thread Andrew Lunn
On Sun, Jun 09, 2013 at 10:14:10PM +0200, Simon Baatz wrote: > Hi, > > RESEND V3: > - Dropped patches 9 and 10, they are part of linux-next already > NB: patch 7 as well, but I did not want to change the numbering > > V3 changes: > - Patch 01/10: Added EPROBE_DEFER c

[PATCH] MMC: FSL SDHC: Add support for non-removable card. Kernel version 3.4.48

2013-06-10 Thread Oded Gabbay
This patch adds support of recognizing non-removable cards to Freescale's SDHC host driver. This is done by detecting the attribute "non-removable" in the probe function This patch depends on patch[2/3] from 6-jun-2013: https://patchwork.kernel.org/patch/2649381/ This patch is instead of patch[3/

Re: [PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent) card. Kernel version 3.4.47

2013-06-10 Thread Oded Gabbay
Hi All, Just noticed that 3.4.47/8 doesn't have the mmc_of_parse (compared to 3.9.4). Therefore, I will not use it and just fix the code to recognize the property "non-removable" Best regards, Oded On 06/10/2013 04:43 PM, Oded Gabbay wrote: Hi Dirk, You are absolutely right. I will revise

Re: [PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-10 Thread Tony Lindgren
* Linus Walleij [130610 09:09]: > > You can use the new infrastructure to make the core select: > > pinctrl_pm_select_default_state(host->dev); > pinctrl_pm_select_idle_state(host->dev); OK great. > What is the semantic difference between "default" and "active"? We only should remux the pins

Re: [PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-10 Thread Linus Walleij
On Fri, Jun 7, 2013 at 11:49 PM, Tony Lindgren wrote: > On some omaps we need to remux MMC pins for PM, and for some omaps > we need to remux the SDIO IRQ pin. > > Based on an earlier patch by Andreas Fenkart . (...) > + host->pinctrl = devm_pinctrl_get(host->dev); > + if (IS_ERR(host

[PATCH 10/12] mmc: core: Enable power_off_notify for eMMC shutdown sequence

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson In suspend mode it is important to save power. If the host is able to cut buth vcc and vccq, the MMC_CAP2_POWEROFF_NOTIFY shall be set. It will mean the card will be completely powered down at suspend and the power off notification cmd will be sent prior power down. It seems co

[PATCH 08/12] mmc: core: Handle both poweroff notification types for eMMC

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson Depending on the context of the operation while powering down the card, either POWER_OFF_NOTIFY_SHORT or POWER_OFF_NOTIFY_LONG will be used. In suspend context a short timeout is preferred while a long timeout would be acceptable in a shutdown/hibernation context. We add a new

[PATCH 06/12] mmc: core: Extend shutdown sequence to handle bus operations

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson By adding an optional .shutdown callback to the bus_ops struct we provide the possibility to let each bus type handle it's shutdown requirements. Signed-off-by: Ulf Hansson --- drivers/mmc/core/bus.c |9 + drivers/mmc/core/core.h |1 + 2 files changed, 10 ins

[PATCH 07/12] mmc: core: Add shutdown callback for SD bus_ops

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson For the SD .shutdown callback we re-use the SD suspend function since it performs the relevant actions. Signed-off-by: Ulf Hansson --- drivers/mmc/core/sd.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index cacef27..1

[PATCH 09/12] mmc: core: Add shutdown callback for (e)MMC bus_ops

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson The shutdown sequence of an (e)MMC is very similar to a suspend. We re-use the suspend function and tell it we are not in suspend context. Signed-off-by: Ulf Hansson --- drivers/mmc/core/mmc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/mmc/core/

[PATCH 05/12] mmc: core: Handle card shutdown from mmc_bus

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson Considering shutdown of the card, the responsibility to initate this sequence shall be driven from the mmc_bus. This patch enables the mmc_bus to handle this sequence properly. A new .shutdown callback is added in the mmc_driver struct which is used to shutdown the blk device.

[PATCH 01/12] mmc: core: Remove unnecessary check for the remove callback

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson For every bus_ops type the .remove callback always exist, thus there are no need to check the existence of it, before we decide to call it. Signed-off-by: Ulf Hansson Tested-by: Jaehoon Chung --- drivers/mmc/core/core.c | 11 +++ 1 file changed, 3 insertions(+), 8

[PATCH 12/12] mmc: core: Add DT-bindings for MMC_CAP2_FULL_PWR_CYCLE

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson The DT-binding for MMC_CAP2_FULL_PWR_CYCLE, is used to indicate whether it is possible to perform a full power cycle of the card. Signed-off-by: Ulf Hansson --- Documentation/devicetree/bindings/mmc/mmc.txt |1 + drivers/mmc/core/host.c |2 ++ 2

[PATCH 11/12] mmc: core: Invent MMC_CAP2_FULL_PWR_CYCLE

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson MMC_CAP2_FULL_PWR_CYCLE shall be set by host drivers which are able to do a complete power cycle of the card. In the eMMC case that includes both vcc and vccq. This CAP is providing the protocol layer with important information, needed to take optimized decisions during card in

[PATCH 03/12] mmc: core: Push common suspend|resume code into each bus_ops

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson By moving code from the mmc_suspend|resume_host down into each .suspend|resume bus_ops callback, we get a more flexible solution. Some nice side effects are that we get a better understanding of each bus_ops suspend|resume sequence and the common code don't have to take care of

[PATCH 02/12] mmc: core: Validate suspend prerequisites for SDIO at SUSPEND_PREPARE

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson This patch moves the validation for all the suspend prerequisites to be done at SUSPEND_PREPARE notification. Previously in the SDIO case parts of the validation was done from mmc_suspend_host. This patch invents a new pre_suspend bus_ops callback and implements it for SDIO. Re

[PATCH 04/12] mmc: core: Initiate suspend|resume from mmc bus instead of mmc host

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson The host should be responsible to suspend|resume the host and not the card. This patch changes this behaviour, by moving the responsiblity to the mmc bus instead which already holds the card device. The exported functions mmc_suspend|resume_host are now to be considered as depc

[PATCH 00/12] mmc: core: mmc_bus to handle suspend|resume|shutdown

2013-06-10 Thread Ulf Hansson
From: Ulf Hansson The MMC/SD/SDIO cards are registered on the mmc_bus and should from a power management perspective be controlled from there. As of today each and every host driver needs to issue mmc_suspend|resume_host from their respective .suspend|resume methods, which seems like an unnecessa

Re: [PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent) card. Kernel version 3.4.47

2013-06-10 Thread Oded Gabbay
Hi Dirk, You are absolutely right. I will revise my patch series to reflect the change. Basically, I will call the generic mmc_of_parse from the probe function of Freescale's driver. That will handle all the additional capabilities. Thanks Oded On 06/10/2013 09:29 AM, Dirk Behme wrote: On 02

[PATCH 00/15] Convert to use devm_ioremap_resource

2013-06-10 Thread Tushar Behera
These are the remaining instances of devm_request_and_ioremap. Convert them to use devm_ioremap_resource as introduced by commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()). Patches 1 to 13 remove occurrences of devm_request_and_ioremap. Patch 14 modifies one comment that speaks

[PATCH 03/15] mmc: mvsdio: Convert to use devm_ioremap_resource

2013-06-10 Thread Tushar Behera
Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). Signed-off-by: Tushar Behera CC: linux-mmc@vger.kernel.org CC: Chris Ball --- drivers/mmc/host/mvsdio.c |6 +++--- 1 file changed,

Re: [PATCH] drivers: mmc: reordered shutdown sequence in mmc_bld_remove_req

2013-06-10 Thread Ulf Hansson
On 4 June 2013 23:42, Paul Taysom wrote: > We had a multi-partition SD-Card with two ext2 file systems. The partition > table was getting overwritten by a race between the card removal and > the unmount of the 2nd ext2 partition. > > What was observed: > 1. Suspend/resume would call to remove the