Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 7:07 PM, Joel A Fernandes wrote: > Hi Sekhar, > > On Fri, Jun 21, 2013 at 5:27 AM, Sekhar Nori wrote: >> Joel, >> >> On 6/21/2013 2:36 AM, Joel A Fernandes wrote: >>> From: Joel A Fernandes >>> >>> This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA >>

[PATCH v2] ARM: common: edma: Fix dangling pointer dereference

2013-06-21 Thread Joel A Fernandes
Fixup for linux-davinci/soc-v2 branch. Please ignore v1 and use this. Returning a pointer to a variable in the setup_from_dt function is causing dangling pointer dereferences. This causes boot to fail on AM33XX. Add ninfo to the caller's stack and just return the kzalloc'ed ptr from the calling fu

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
>> > config TI_EDMA >> > tristate "TI EDMA support" >> > default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >> > select DMA_ENGINE >> > select DMA_VIRTUAL_CHANNELS >> >> >> MMC depends on EDMA specially on AM33xx there's no PIO mode AFAIK. The >> 'm' option will

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-21 Thread Joel A Fernandes
Hi Sekhar, On Fri, Jun 21, 2013 at 5:27 AM, Sekhar Nori wrote: > Joel, > > On 6/21/2013 2:36 AM, Joel A Fernandes wrote: >> From: Joel A Fernandes >> >> This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA >> support >> with changes for few pending review comments on v11 serie

[PATCH] ARM: common: edma: Fix dangling pointer dereference

2013-06-21 Thread Joel A Fernandes
Returning a pointer to a variable in the setup_from_dt function is causing dangling pointer dereferences. This causes boot to fail on AM33XX. Add ninfo to the caller's stack and just return the kzalloc'ed ptr from the calling function. Seen on linux-davinci/soc-v2 branch. Cc: Sekhar Nori Signed

Re: [PATCH 2/2] mmc: dw_mmc: add a quirk for Security Management Unit

2013-06-21 Thread Doug Anderson
Yuvaraj, On Fri, May 24, 2013 at 3:04 AM, Yuvaraj Kumar C D wrote: > index bc3a1bc..a047ecf 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1959,6 +1959,9 @@ static int dw_mci_init_slot(struct dw_mci *host, > unsigned int id) > mmc->caps |= MMC_CA

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: > > On Friday 21 June 2013, Joel A Fernandes wrote: > >> I think we are talking about different things, I agree the 'select > >> DMADEVICES' can be dropped but lets please keep the

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
Hi Arnd, On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: > On Friday 21 June 2013, Joel A Fernandes wrote: >> I think we are talking about different things, I agree the 'select >> DMADEVICES' can be dropped but lets please keep the default y option >> (not adding new select statements, just

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > I think we are talking about different things, I agree the 'select > DMADEVICES' can be dropped but lets please keep the default y option > (not adding new select statements, just saying that if someone select > DMADEVICES in menuconfig and if they'

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 9:32 AM, Arnd Bergmann wrote: > On Friday 21 June 2013, Joel A Fernandes wrote: >> I haven't come across this problem but- are you saying there is a >> shortcoming in Kbuild/Kconfig that selects an option even if its >> dependency is not met? > > Well, the shortcoming is th

Re: [PATCH 1/1] mmc: sdhci-sirf: Fix build breakage

2013-06-21 Thread Christian Daudt
On 13-06-18 01:54 AM, Sachin Kamat wrote: Commit 0e74823429 ("mmc: sdhci: Add size for caller in init+register") introduced size parameter to sdhci_pltfm_init(). This driver probably got left out during the conversion. Passing in zero as done for other drivers to avoid the following build error:

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > I haven't come across this problem but- are you saying there is a > shortcoming in Kbuild/Kconfig that selects an option even if its > dependency is not met? Well, the shortcoming is that it lets you specify impossible contraints. You get a warning

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 9:00 AM, Arnd Bergmann wrote: > On Friday 21 June 2013, Joel A Fernandes wrote: >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> >> index b1c66a4..7d58cd9 100644 >> >> --- a/arch/arm/Kconfig >> >> +++ b/arch/arm/Kconfig >> >> @@ -841,6 +841,7 @@ config ARCH_DAVINCI

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index b1c66a4..7d58cd9 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -841,6 +841,7 @@ config ARCH_DAVINCI > >> select HAVE_IDE > >> select NEED_MACH_GPIO_H

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 5:16 AM, Sekhar Nori wrote: > On 6/21/2013 2:36 AM, Joel A Fernandes wrote: >> From: Joel A Fernandes >> >> Build TI_EDMA by default for ARCH_DAVINCI and ARCH_OMAP2PLUS >> >> Signed-off-by: Joel A Fernandes > > You should sign-off with author e-mail address. > >> --- >>

Re: [PATCH v12 02/11] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 4:37 AM, Sekhar Nori wrote: > Joel, > > Looks like you have not addressed all comments from last time. > For now, in the interest of time, I have fixed them myself. But next > time on, if you are not going to fix any comment, then please reply > upfront before sending out *

Re: [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat()

2013-06-21 Thread Sourav Poddar
Hi Mark, On Friday 21 June 2013 04:58 PM, Mark Brown wrote: On Fri, Jun 21, 2013 at 04:07:51PM +0530, Sekhar Nori wrote: We can resend the patch if you don't have it from the mailing list. I'll probably have it assuming it's been sent to some mailing list I read (the CC list here looks absurld

Re: [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat()

2013-06-21 Thread Mark Brown
On Fri, Jun 21, 2013 at 04:07:51PM +0530, Sekhar Nori wrote: > We can resend the patch if you don't have it from the mailing list. I'll probably have it assuming it's been sent to some mailing list I read (the CC list here looks absurldy large...) but if you don't send me the patch and/or ignore

Re: [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat()

2013-06-21 Thread Sekhar Nori
Fixing Mark's e-mail. Mark, On 6/21/2013 3:56 PM, Sourav Poddar wrote: > Hi Mark, > On Friday 21 June 2013 02:36 AM, Joel A Fernandes wrote: >> From: Matt Porter >> >> Convert dmaengine channel requests to use >> dma_request_slave_channel_compat(). This supports the DT case of >> platforms requi

Re: [PATCH v12 08/11] spi: omap2-mcspi: add generic DMA request support to the DT binding

2013-06-21 Thread Sourav Poddar
Hi Benoit, On Friday 21 June 2013 02:36 AM, Joel A Fernandes wrote: From: Matt Porter The binding definition is based on the generic DMA request binding Signed-off-by: Matt Porter Signed-off-by: Joel A Fernandes --- Documentation/devicetree/bindings/spi/omap-spi.txt | 27 +++

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-21 Thread Sekhar Nori
Joel, On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Joel A Fernandes > > This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA support > with changes for few pending review comments on v11 series. I have posted a branch with fixes for patches accepted by me in this seri

Re: [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat()

2013-06-21 Thread Sourav Poddar
Hi Mark, On Friday 21 June 2013 02:36 AM, Joel A Fernandes wrote: From: Matt Porter Convert dmaengine channel requests to use dma_request_slave_channel_compat(). This supports the DT case of platforms requiring channel selection from either the OMAP DMA or the EDMA engine. AM33xx only boots from

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Joel A Fernandes > > Build TI_EDMA by default for ARCH_DAVINCI and ARCH_OMAP2PLUS > > Signed-off-by: Joel A Fernandes You should sign-off with author e-mail address. > --- > arch/arm/Kconfig|1 + > arch/arm/mach-omap2/Kcon

[PATCH] ARM: edma: Add EDMA crossbar event mux support

2013-06-21 Thread Sekhar Nori
From: Matt Porter EDMA supports a cross bar which provides ability to mux additional events into physical channels present in the channel controller. This is required when the number of events present in the system are more than number of available physical channels. Changes by Joel: * Split ED

Re: [PATCH v12 04/11] dmaengine: edma: enable build for AM33XX

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Matt Porter > > Enable TI EDMA option on OMAP and TI_PRIV_EDMA > > Signed-off-by: Matt Porter > Signed-off-by: Joel A Fernandes This will have to be taken by Tony. Thanks, Sekhar > --- > arch/arm/mach-omap2/Kconfig |1 + > drivers/d

Re: [PATCH v12 03/11] ARM: edma: Add EDMA crossbar event mux support

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Matt Porter > > You should add a description apart from just documenting what you changed in this patch. Changes by Joel: > * Split EDMA xbar support out of original EDMA DT parsing patch > to keep it easier for review. > * Rewrite shift an

[PATCH v13] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-21 Thread Sekhar Nori
From: Matt Porter Adds support for parsing the TI EDMA DT data into the required EDMA private API platform data. Enables runtime PM support to initialize the EDMA hwmod. Enables build on OMAP. Changes by Joel: * Setup default one-to-one mapping for queue_priority and queue_tc mapping as discusse

Re: [PATCH v12 02/11] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-21 Thread Sekhar Nori
Joel, Looks like you have not addressed all comments from last time. For now, in the interest of time, I have fixed them myself. But next time on, if you are not going to fix any comment, then please reply upfront before sending out *any* new versions. Also, *please* run checkpatch and fix all bu