[PATCH] mmc: omap_hsmmc: clear status flags before starting a new command

2013-06-28 Thread Francesco Lavra
Commit 1f6b9fa40e76fffaaa0b3bd6a0bfdcf1cdc06efa consolidated writes to the STAT register in one location, moving them from omap_hsmmc_do_irq() to omap_hsmmc_irq(). This move has the unwanted side effect that the controller status flags are potentially cleared after a new command has been starte

[PATCH -next] mmc: jz4740: fix return value check in jz4740_mmc_probe()

2013-06-28 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Also there is already a error message within devm_ioremap_resource(), so remove the dev_err call to avoid re

Q: mmc au size

2013-06-28 Thread H Hartley Sweeten
Hello all, I have a question concerning the "au" size of a SD Card. I have an old Kingston 64MB SD-Card and lately I have noticed this kernel message when I use the card: mmc0: SD Status: Invalid Allocation Unit size. This is due to the following commit: commit b63b5e819d5b21ae493c17c356018ffa

RE: [PATCH 0/5] AM33xx: MMC resources from DT without HWMOD data

2013-06-28 Thread Fernandes, Joel
> -Original Message- > From: Krishnamoorthy, Balaji T > Sent: Friday, June 28, 2013 10:49 AM > To: Fernandes, Joel > Cc: benoit.cous...@gmail.com; l...@metafoo.de; Tony Lindgren; Nori, Sekhar; > Matt Porter; Grant Likely; Rob Herring; Vinod Koul; Mark Brown; Russell King; > Rob Landley; And

Re: [PATCH] mmc: dw_mmc: don't queue up a card detect at slot startup

2013-06-28 Thread Doug Anderson
Seungwon, On Mon, Jun 24, 2013 at 1:04 AM, Seungwon Jeon wrote: > This patch looks good to me. I agree above. > Card detection procedure of mmc subsystem will be started by mmc_start_host > during probe time. > There is no need to do same in host driver. > Could you describe the race point of th

Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well

2013-06-28 Thread Balaji T K
On Friday 28 June 2013 06:04 PM, a-bin...@ti.com wrote: From: Amarinder Bindra OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root

Re: [PATCH 0/5] AM33xx: MMC resources from DT without HWMOD data

2013-06-28 Thread Balaji T K
On Thursday 27 June 2013 11:38 PM, Fernandes, Joel wrote: Hi Balaji, Some patches were squashed and others dropped in the series resulting in the single patch above. This patch should be good to apply Hi Joel, Before pushing mmc dts support for am335x, Can you please let me know if below

Re: [PATCH 0/2] mmc: add support for eMMC hardware reset for BYT eMMC

2013-06-28 Thread Chris Ball
Hi Adrian, On Fri, Jun 28 2013, Adrian Hunter wrote: > Thanks, but "mmc: sdhci-pci: add support for eMMC hardware reset for BYT > eMMC." has been mixed with someone else's patch. i.e. it now looks like this: Ouch, that's terrible, thank you for catching it. Will fix. - Chris. -- Chris Ball

[PATCH] mmc: omap_hsmmc: use for OMAP5 as well

2013-06-28 Thread a-bindra
From: Amarinder Bindra OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configuration

Re: [PATCHv3] ARM: socfpga: dts: Add support for SD/MMC

2013-06-28 Thread Pavel Machek
Hi! Just some nit-picking... (not worth blocking apply for this, can easily go through trivial tree later.) > create mode 100644 Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt > b/Documentation/devicetree/bin

Re: [PATCH v2] mmc: sh_mmcif: add SET_BLOCK_COUNT support

2013-06-28 Thread Shimoda, Yoshihiro
Hi, Guennadi-san, (2013/06/28 16:54), Guennadi Liakhovetski wrote:> Hi Shimoda-san > > Thanks for an update. Sorry it took me so long to get down to reviewing > it. I looked at it originally and I knew, I would need a significant time > this time to look and think about it, so, I had to postpone.

Re: [PATCH v2 2/4] mmc: atmel-mci: prepare clk before calling enable

2013-06-28 Thread boris brezillon
On 28/06/2013 09:44, Nicolas Ferre wrote: On 25/06/2013 10:11, Boris BREZILLON : Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON It seems that you forgot the Acked-by line from Ludovic. One comment..

Re: [PATCH v2] mmc: sh_mmcif: add SET_BLOCK_COUNT support

2013-06-28 Thread Guennadi Liakhovetski
Hi Shimoda-san Thanks for an update. Sorry it took me so long to get down to reviewing it. I looked at it originally and I knew, I would need a significant time this time to look and think about it, so, I had to postpone. This looks much better already, thanks! The flow is already correct, but

Re: [PATCH v2 2/4] mmc: atmel-mci: prepare clk before calling enable

2013-06-28 Thread Nicolas Ferre
On 25/06/2013 10:11, Boris BREZILLON : Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON It seems that you forgot the Acked-by line from Ludovic. One comment... --- drivers/mmc/host/atmel-mci.c |

Re: [PATCH 0/2] mmc: add support for eMMC hardware reset for BYT eMMC

2013-06-28 Thread Adrian Hunter
On 27/06/13 18:54, Chris Ball wrote: > Hi Adrian, > > On Thu, Jun 13 2013, Adrian Hunter wrote: >> Here are 2 patches to add support for eMMC hardware reset for BYT eMMC. >> >> >> Adrian Hunter (2): >> mmc: sdhci-pci: add support for eMMC hardware reset for BYT eMMC. >> mmc: sdhci-acpi

Re: [PATCH 1/1] mmc: sdhci-pci: add another device id

2013-06-28 Thread Adrian Hunter
On 27/06/13 19:06, Chris Ball wrote: > Hi Adrian, > > On Thu, Jun 20 2013, Adrian Hunter wrote: >> Add another PCI device id for an eMMC host controller. >> >> Signed-off-by: Adrian Hunter >> --- >> drivers/mmc/host/sdhci-pci.c | 9 + >> 1 file changed, 9 insertions(+) >> >> diff --git a