Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-02 Thread Dan Carpenter
On Fri, Aug 02, 2013 at 09:11:19AM +0900, Jingoo Han wrote: On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote: drivers/mmc/host/dw_mmc-pltfm.c:58:24: warning: incorrect type in argument 1 (different address spaces) drivers/mmc/host/dw_mmc-pltfm.c:58:24:expected void const *ptr

Re: [PATCH 1/1] mmc: vub300: Staticize vub300_init_card

2013-08-02 Thread Sachin Kamat
On 26 June 2013 12:02, Sachin Kamat sachin.ka...@linaro.org wrote: 'vub300_init_card' is used only in this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/vub300.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/1] mmc: sdhci-bcm2835: Staticize bcm2835_sdhci_get_min_clock

2013-08-02 Thread Sachin Kamat
On 26 June 2013 11:57, Sachin Kamat sachin.ka...@linaro.org wrote: 'bcm2835_sdhci_get_min_clock' is used only in this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/sdhci-bcm2835.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion

2013-08-02 Thread Sachin Kamat
On 20 July 2013 02:01, Christian Daudt c...@broadcom.com wrote: On 13-07-07 11:11 PM, Sachin Kamat wrote: version.h header inclusion is not necessary as detected by versioncheck. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/sdhci-bcm-kona.c |1 - 1 file

Re: [PATCH] tmio_mmc_dma: fix PIO fallback on SDHI

2013-08-02 Thread Guennadi Liakhovetski
Hi Sergei, Thanks for your patch. On Fri, 2 Aug 2013, Sergei Shtylyov wrote: I'm testing SH-Mobile SDHI driver in DMA mode with a new DMA controller using 'bonnie++' and getting DMA error after which the tmio_mmc_dma.c code falls back to PIO but all commands time out after that. It

[PATCH] mmc: sh_mmcif: move header include from header into .c

2013-08-02 Thread Guennadi Liakhovetski
sh_dma.h isn't needed in sh_mmcif.h, move it into sh_mmcif.c. Signed-off-by: Guennadi Liakhovetski g.liakhovetski+rene...@gmail.com --- drivers/mmc/host/sh_mmcif.c |1 + include/linux/mmc/sh_mmcif.h |1 - 2 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-08-02 Thread Sekhar Nori
On 8/2/2013 1:58 AM, Joel Fernandes wrote: On 08/01/2013 01:13 AM, Sekhar Nori wrote: On Thursday 01 August 2013 07:57 AM, Joel Fernandes wrote: On 07/31/2013 04:18 AM, Sekhar Nori wrote: On Wednesday 31 July 2013 10:19 AM, Joel Fernandes wrote: Hi Sekhar, On 07/30/2013 02:05 AM, Sekhar

[PATCH v2 2/4] mmc: sdhci-s3c: initialize host-quirks2 for using quirk2

2013-08-02 Thread Jaehoon Chung
In order to use the quirks2, initialized the host-quirks2. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changelog v2: - Nothing drivers/mmc/host/sdhci-s3c.c |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 3/4] mmc: sdhci-s3c: revert fix missing clock for gpio card-detect

2013-08-02 Thread Jaehoon Chung
Fixed the warning message.(clk_disable/enable didn't pair) [2.11] [ cut here ] [2.11] WARNING: at drivers/clk/clk.c:780 clk_disable+0x18/0x24() [2.11] Modules linked in: [2.11] CPU: 0 PID: 34 Comm: kworker/0:1 Not tainted

[PATCH v2 1/4] mmc: sdhci-s3c: fix the wrong register value, when clock is disabled

2013-08-02 Thread Jaehoon Chung
When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. This patch is fixed this problem. ([PATCHv2] mmc: sdhci-s3c: fix teh wrong register value, when clock is disabled) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park

[PATCH v2 4/4] mmc: sdhci-s3c: remove the duplicated calling sequence

2013-08-02 Thread Jaehoon Chung
Didn't need to call the sdhci_s3c_notify_change in setup_card_detect_gpio(). Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Heiko Stuebner he...@sntech.de Tested-by: Heiko Stuebner he...@sntech.de --- Changelog v2: -

Re: [PATCH] tmio_mmc_dma: fix PIO fallback on SDHI

2013-08-02 Thread Sergei Shtylyov
On 08/02/2013 03:35 PM, Guennadi Liakhovetski wrote: I'm testing SH-Mobile SDHI driver in DMA mode with a new DMA controller using 'bonnie++' and getting DMA error after which the tmio_mmc_dma.c code falls back to PIO but all commands time out after that. It turned out that the fallback code

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-08-02 Thread Joel Fernandes
Hi Sekhar, Thanks for your detailed illustrations. On 08/02/2013 08:26 AM, Sekhar Nori wrote: [..] This can be used only for buffers that are contiguous in memory, not those that are scattered across memory. I was hinting at using the linking facility of EDMA to achieve this. Each PaRAM set

[PATCH v2] tmio_mmc_dma: fix PIO fallback on SDHI

2013-08-02 Thread Sergei Shtylyov
I'm testing SH-Mobile SDHI driver in DMA mode with a new DMA controller using 'bonnie++' and getting DMA error after which the tmio_mmc_dma.c code falls back to PIO but all commands time out after that. It turned out that the fallback code calls tmio_mmc_enable_dma() with RX/TX channels already

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-08-02 Thread Joel Fernandes
Hi Sekhar, Considering you agree with my understanding of the approach you proposed, I worked on some code to quickly try the different approach (ping-pong) between sets, here is a hack patch: https://github.com/joelagnel/linux-kernel/commits/dma/edma-no-sg-limits-interleaved As I suspected it