On 08/09/2013 02:39 PM, Barry Song wrote:
2013/8/9 Haijun Zhang :
When command with busy flags send and also data busy end interrupt
will be generate, the command will be finished when data transfer
complete or data busy state end, Sometimes this will expend more than
10*Hz time to finish this c
2013/8/9 Haijun Zhang :
> When command with busy flags send and also data busy end interrupt
> will be generate, the command will be finished when data transfer
> complete or data busy state end, Sometimes this will expend more than
> 10*Hz time to finish this command, so we should wait longer to d
Add function to support get voltage from device-tree.
If there are voltage-range specified in device-tree node, this function
will parse it and return the available voltage mask.
Signed-off-by: Haijun Zhang
---
changes for V3:
- Correct the type of return value.
changes for v2:
-
We use host->ocr_mask to hold the voltage get from device-tree
node, In case host->ocr_mask was available, we use host->ocr_mask
as the final available voltage can be used by MMC/SD/SDIO card.
Signed-off-by: Haijun Zhang
---
changes for v2:
- Change the type of the value
drivers/mmc/hos
Using function mmc_of_parse_voltage() to get voltage-ranges.
Signed-off-by: Haijun Zhang
---
changes for V2:
- changed the type of ocr_mask
drivers/mmc/host/of_mmc_spi.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/mmc/host/of_mmc_s
On 08/09/2013 08:15 AM, Anton Vorontsov wrote:
On Wed, Jul 31, 2013 at 02:25:25PM +0800, Haijun Zhang wrote:
Add function to support get voltage from device-tree.
If there are voltage-range specified in device-tree node, this function
will parse it and return the avail voltage mask.
Signed-off-
On Fri, August 09, 2013, Chris Ball wrote:
> On Fri, Aug 09 2013, Olof Johansson wrote:
> > On Thu, Aug 8, 2013 at 5:16 PM, Doug Anderson wrote:
> >
> >> I guess my overall question is: if there are no actual implementations
> >> of multislot, shouldn't we kill it and simplify the code a whole lot
Hi Dinh
On 08/09/2013 07:55 AM, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> Remove the "samsung" in "samsung,dw-mshc-ciu-div",
> "samsung,dw-mshc-sdr-timing",
> and "samsung,dw-mshc-ddr-timing". These characteristics are not applicable to
> just Samsung platforms, but to any platform tha
When command with busy flags send and also data busy end interrupt
will be generate, the command will be finished when data transfer
complete or data busy state end, Sometimes this will expend more than
10*Hz time to finish this command, so we should wait longer to detect
command complete timeout e
Hi,
On Fri, Aug 09 2013, Olof Johansson wrote:
> On Thu, Aug 8, 2013 at 5:16 PM, Doug Anderson wrote:
>
>> I guess my overall question is: if there are no actual implementations
>> of multislot, shouldn't we kill it and simplify the code a whole lot?
>> If someone out there has a real multislot d
On Wed, Jul 31, 2013 at 04:21:44PM +0800, Haijun Zhang wrote:
> When command with busy flags send and also data busy end interrupt
> will be generate, the command will be finished when data transfer
> complete or data busy state end, Sometimes this will expend more than
> 10*Hz time to finish this
On Wed, Jul 31, 2013 at 02:25:25PM +0800, Haijun Zhang wrote:
> Add function to support get voltage from device-tree.
> If there are voltage-range specified in device-tree node, this function
> will parse it and return the avail voltage mask.
>
> Signed-off-by: Haijun Zhang
> ---
> changes for v2
On Thu, Aug 8, 2013 at 5:16 PM, Doug Anderson wrote:
> I guess my overall question is: if there are no actual implementations
> of multislot, shouldn't we kill it and simplify the code a whole lot?
> If someone out there has a real multislot device they can step back in
> and do it more correctly
Hi,
A quick question: does anyone know of any hardware that actually
implements multiple slots per host on the dw_mmc controller?
When working on the driver I often find myself running into questions
about how things should work on the theoretical "multiple slot" dw_mmc
implementation. ...and I
On Wed, Jul 31, 2013 at 02:25:27PM +0800, Haijun Zhang wrote:
> int num_ranges;
> + u32 ocr_mask;
> int i;
> int ret = -EINVAL;
>
> @@ -102,26 +103,11 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct
> spi_device *spi)
> if (!oms)
> return NULL;
On Thu, 2013-08-08 at 15:13 -0600, Stephen Warren wrote:
> On 08/08/2013 02:54 PM, Dinh Nguyen wrote:
> > On Thu, 2013-08-08 at 14:37 -0600, Stephen Warren wrote:
> >> On 08/08/2013 02:32 PM, Dinh Nguyen wrote:
> >>> On Thu, 2013-08-08 at 14:14 -0600, Stephen Warren wrote:
> On 08/05/2013 02:4
From: Dinh Nguyen
Remove the "samsung" in "samsung,dw-mshc-ciu-div", "samsung,dw-mshc-sdr-timing",
and "samsung,dw-mshc-ddr-timing". These characteristics are not applicable to
just Samsung platforms, but to any platform that uses the Synopsis SD/MMC IP.
Signed-off-by: Dinh Nguyen
CC: Arnd Berg
On 08/08/2013 02:54 PM, Dinh Nguyen wrote:
> On Thu, 2013-08-08 at 14:37 -0600, Stephen Warren wrote:
>> On 08/08/2013 02:32 PM, Dinh Nguyen wrote:
>>> On Thu, 2013-08-08 at 14:14 -0600, Stephen Warren wrote:
On 08/05/2013 02:43 PM, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
>>>
On 13-08-08 02:06 PM, Guennadi Liakhovetski wrote:
On Thu, 8 Aug 2013, Christian Daudt wrote:
Given that mmc_gpio_get_cd can be called in softirq
context (by sdhci_tasklet_card -> sdhci_card_event ->
sdhci_do_get_cd -> mmc_gpio_get_cd ), it is necessary
for it to use gpio_get_value instead of
g
On Thu, 8 Aug 2013, Christian Daudt wrote:
> Given that mmc_gpio_get_cd can be called in softirq
> context (by sdhci_tasklet_card -> sdhci_card_event ->
> sdhci_do_get_cd -> mmc_gpio_get_cd ), it is necessary
> for it to use gpio_get_value instead of
> gpio_get_value_cansleep
> Note that at presen
On Thu, 2013-08-08 at 14:37 -0600, Stephen Warren wrote:
> On 08/08/2013 02:32 PM, Dinh Nguyen wrote:
> > On Thu, 2013-08-08 at 14:14 -0600, Stephen Warren wrote:
> >> On 08/05/2013 02:43 PM, dingu...@altera.com wrote:
> >>> From: Dinh Nguyen
> >>>
> >>> Add bindings for SD/MMC for SOCFPGA.
> >>>
Given that mmc_gpio_get_cd can be called in softirq
context (by sdhci_tasklet_card -> sdhci_card_event ->
sdhci_do_get_cd -> mmc_gpio_get_cd ), it is necessary
for it to use gpio_get_value instead of
gpio_get_value_cansleep
Note that at present sdhci_card_event gets called both
from mmc_gpio_cd_irq
On 08/08/2013 02:32 PM, Dinh Nguyen wrote:
> On Thu, 2013-08-08 at 14:14 -0600, Stephen Warren wrote:
>> On 08/05/2013 02:43 PM, dingu...@altera.com wrote:
>>> From: Dinh Nguyen
>>>
>>> Add bindings for SD/MMC for SOCFPGA.
>>> Add "syscon" to the "altr,sys-mgr" binding.
>>
>>> diff --git a/Documen
On Thu, 2013-08-08 at 14:14 -0600, Stephen Warren wrote:
> On 08/05/2013 02:43 PM, dingu...@altera.com wrote:
> > From: Dinh Nguyen
> >
> > Add bindings for SD/MMC for SOCFPGA.
> > Add "syscon" to the "altr,sys-mgr" binding.
>
> > diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-msh
On 08/05/2013 02:43 PM, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> Add bindings for SD/MMC for SOCFPGA.
> Add "syscon" to the "altr,sys-mgr" binding.
> diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
> b/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
>
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote:
> We certainly don't want error conditions to be cleared any other
> place but the EDMA error handler, as this will make us 'forget'
> about missed events we might need to know errors have occurred.
>
> This fixes a race condition where the
There is a typo when the mapped space is from BAR 2, but BAR 0 is used instead.
This patch fixes the typo.
Signed-off-by: Andy Shevchenko
---
drivers/mmc/host/dw_mmc-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-
This patch enables bus-mastering mode for MMC controller to allow IDMAC
transfers.
Signed-off-by: Andy Shevchenko
---
drivers/mmc/host/dw_mmc-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
index 7d148d6..f70546a 100644
--
The callback isn't used by the mmcif driver, don't initialize it in
board code.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
arch/sh/boards/mach-ecovec24/setup.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/arch/sh/boards/mach-ecovec24/setup.c
b/arch/sh/board
All platforms pass the CD GPIO number to the driver in the .cd_gpio
field. The .get_cd() callback isn't used anymore, remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/sh_mobile_sdhi.c | 9 -
include/linux/mmc/sh_mobile_sdhi.h | 1 -
2 file
Pass the CD and RO GPIO numbers to the MMC SPI driver and remove the
custom .get_cd() and .get_ro() callback functions.
Signed-off-by: Laurent Pinchart
Acked-by: H Hartley Sweeten
---
arch/arm/mach-ep93xx/vision_ep9307.c | 57
1 file changed, 5 insertions(+)
The SHDI platform data .set_pwr() callback is used to control the
vmmc/vqmmc power supplies. As the power supplies already register
control GPIOs there's no need to perform the operation manually.
Remove the callback functions.
Signed-off-by: Laurent Pinchart
---
arch/arm/mach-shmobile/board-ag5
The .set_pwr() callback isn't used anymore as all platforms register
GPIO-controlled regulators. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/sh_mobile_sdhi.c | 9 -
include/linux/mmc/sh_mobile_sdhi.h | 1 -
2 files changed, 10 deletio
The callback isn't used by the driver and isn't initialized by board
code. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
include/linux/mmc/sh_mmcif.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mmc/sh_mmcif.h b/include/linux/mmc/sh_mmcif.h
i
All platforms pass the CD GPIO number to the driver in the .cd_gpio
field. The .get_cd() callback isn't used anymore, remove it
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/tmio_mmc_pio.c | 16 +---
include/linux/mfd/tmio.h| 1 -
2 fi
Add a debounce parameter to the mmc_gpio_request_cd() function that
enables GPIO debouncing when set to a non-zero value. This can be used
by MMC host drivers to enable debouncing on the card detect signal.
Signed-off-by: Laurent Pinchart
Reviewed-by: H Hartley Sweeten
---
drivers/mmc/core/host
The .set_pwr() callback isn't used anymore as all platforms register
GPIO-controlled regulators. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/tmio_mmc.h | 1 -
drivers/mmc/host/tmio_mmc_pio.c | 7 ---
include/linux/mfd/tmio.h| 1
Pass the CD and RO GPIO numbers to the MMC SPI and SDHI drivers and
remove the custom .get_cd() and .get_ro() callback functions.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
arch/sh/boards/mach-ecovec24/setup.c | 42 +++-
1 file changed, 8
All platforms now pass the CD and RO GPIOs to the MMC SPI driver, those
callbacks are not used anymore. Remove them.
Signed-off-by: Laurent Pinchart
Reviewed-by: H Hartley Sweeten
---
drivers/mmc/host/mmc_spi.c | 24 ++--
include/linux/spi/mmc_spi.h | 9 -
2 files
The .set_pwr() callback isn't used anymore as all platforms register
GPIO-controlled regulators. Remove it.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakhovetski
---
drivers/mmc/host/sh_mmcif.c | 3 ---
include/linux/mmc/sh_mmcif.h | 1 -
2 files changed, 4 deletions(-)
diff --git a
Add support for passing CD/RO GPIO numbers directly to the mmc_spi
driver instead of relying solely on board code callbacks to retrieve the
CD/RO signals values. The driver will enable debouncing on the card
detect GPIO if the cd_debounce field is set to a non-zero value.
Signed-off-by: Laurent Pi
Hello,
This patch set replaces callbacks to board code with regulators and GPIOs in
the mmc_spi, sh_mmcif and sh_mobile_sdhi MMC drivers.
Most of the required infrastructure is in place already on the drivers side,
except for CD debouncing support in the MMC core and CD/RO GPIOs support in
the mm
The MMCIF and SHDI platform data .set_pwr() callbacks are used to
control the vmmc/vqmmc power supplies. As the power supplies already
register control GPIOs there's no need to perform the operation
manually. Remove the callback functions.
Signed-off-by: Laurent Pinchart
Acked-by: Guennadi Liakho
43 matches
Mail list logo
