Re: [PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots

2013-08-12 Thread Joel Fernandes
On 08/12/2013 12:56 AM, Sekhar Nori wrote: > On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: >> We'd now need a separate slot just for the channel and separate >> ones for the 2 linked sets, so we make adjustments to allocate >> an extra channel accordingly. >> >> Signed-off-by: Joel Ferna

Re: [PATCH v3 07/12] dma: edma: Add function to dump a PaRAM set from PaRAM

2013-08-12 Thread Joel Fernandes
On 08/12/2013 12:52 AM, Sekhar Nori wrote: > On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: >> Previously, such a dump function was used but it wasn't reading >> from the PaRAM, rather just from a edmacc_param structure, we >> add a helpful function for debugging that directly reads from

Re: [PATCH v3 09/12] dma: edma: Implement multiple linked sets for continuity

2013-08-12 Thread Joel Fernandes
On 08/12/2013 01:56 PM, Sekhar Nori wrote: > On Monday 05 August 2013 04:14 PM, Joel Fernandes wrote: >> Here we implement splitting up of the total MAX number of slots >> available for a channel into 2 cyclically linked sets. Transfer >> completion Interrupts are enabled on both linked sets and re

Re: [PATCH v3 01/12] dma: edma: Setup parameters to DMA MAX_NR_SG at a time

2013-08-12 Thread Joel Fernandes
Responding to other comments in this post, On 08/12/2013 02:15 AM, Sekhar Nori wrote: [..] >> if (unlikely(!echan || !sgl || !sg_len)) >> return NULL; >> @@ -262,8 +262,11 @@ static struct dma_async_tx_descriptor >> *edma_prep_slave_sg( >> >> edesc->pset_nr = sg_len; >>

MMC locking: mmc_request accesses from dw_mmc driver ok?

2013-08-12 Thread Grant Grundler
I've been working on an "task mmcqd/0:84 blocked for more than 120 seconds" panic for the past month or so in the chromeos-3.4 kernel tree. Stack trace below. Feel free to tell me "fixed in v3.x". :) After staring at the 14 MMC and DW driver data structures, I now think dw_mmc driver is accessing

Re: [PATCH] mmc: dw_mmc-exynos: Common bindings for dw-mshc timing

2013-08-12 Thread Stephen Warren
On 08/08/2013 04:55 PM, dingu...@altera.com wrote: > From: Dinh Nguyen > > Remove the "samsung" in "samsung,dw-mshc-ciu-div", > "samsung,dw-mshc-sdr-timing", > and "samsung,dw-mshc-ddr-timing". These characteristics are not applicable to > just Samsung platforms, but to any platform that uses th

Re: [PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots

2013-08-12 Thread Joel Fernandes
On 08/12/2013 08:31 AM, Mark Brown wrote: > On Mon, Aug 12, 2013 at 11:26:49AM +0530, Sekhar Nori wrote: > >> No need for a separate patch for this, just do this in the patch where >> you include the two linked sets. > > Can you guys please think about the CC lists you're using for these > patch

Re: [PATCH] mmc: dw_mmc: Don't disable vmmc if keeping power in suspend

2013-08-12 Thread Doug Anderson
Seungwon and Derek, On Mon, Aug 12, 2013 at 3:33 AM, Seungwon Jeon wrote: > On Wed, August 07, 2013, Derek Basehore >> If we keep power for suspend on a host for dw_mmc, don't disable vmmc-supply >> regulator when suspending the host. > > I have a trivial comment. > It would be better to add some

Re: [PATCH 1/3 V2] mmc:core: parse voltage from device-tree

2013-08-12 Thread Scott Wood
On Mon, 2013-08-12 at 10:46 +0800, Zhang Haijun wrote: > On 08/09/2013 10:48 PM, Kumar Gala wrote: > > > On Jul 31, 2013, at 1:25 AM, Haijun Zhang wrote: > > > > > Add function to support get voltage from device-tree. > > > If there are voltage-range specified in device-tree node, this function >

[PATCHv3] ARM: socfpga: dts: Add support for SD/MMC

2013-08-12 Thread dinguyen
From: Dinh Nguyen Add bindings for SD/MMC for SOCFPGA. Add "syscon" to the "altr,sys-mgr" binding. Signed-off-by: Dinh Nguyen Reviewed-by: Pavel Machek Acked-by: Jaehoon Chung Cc: Jaehoon Chung Cc: Seungwon Jeon Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian

Re: [PATCHv2] ARM: socfpga: dts: Add support for SD/MMC

2013-08-12 Thread Dinh Nguyen
On Fri, 2013-08-09 at 16:58 -0600, Stephen Warren wrote: > On 08/09/2013 04:41 PM, Dinh Nguyen wrote: > > On Fri, 2013-08-09 at 15:00 -0600, Stephen Warren wrote: > >> On 08/08/2013 05:10 PM, Dinh Nguyen wrote: > >>> On Thu, 2013-08-08 at 15:13 -0600, Stephen Warren wrote: > >> ... > Why is th

Re: [PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 11:26:49AM +0530, Sekhar Nori wrote: > No need for a separate patch for this, just do this in the patch where > you include the two linked sets. Can you guys please think about the CC lists you're using for these patch serieses? I've certainly no interest in random patche

Re: [PATCH v3 09/12] dma: edma: Implement multiple linked sets for continuity

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 04:14 PM, Joel Fernandes wrote: > Here we implement splitting up of the total MAX number of slots > available for a channel into 2 cyclically linked sets. Transfer > completion Interrupts are enabled on both linked sets and respective > handler recycles them on completion t

Re: mmc oops on suspend - remove device

2013-08-12 Thread Alban Browaeys
Le lundi 12 août 2013 à 16:08 +0900, Jaehoon Chung a écrit : > Hi, Alban. > > I think that it needs be set to "non-removable" for emmc. > If emmc is set to removable, it should be removed when entered suspend. > Indeed I thought so too. But everytime I try to set it as non removable the emmc is

Re: [PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > We'd now need a separate slot just for the channel and separate > ones for the 2 linked sets, so we make adjustments to allocate > an extra channel accordingly. > > Signed-off-by: Joel Fernandes No need for a separate patch for this, jus

Re: [PATCH v3 07/12] dma: edma: Add function to dump a PaRAM set from PaRAM

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > Previously, such a dump function was used but it wasn't reading > from the PaRAM, rather just from a edmacc_param structure, we > add a helpful function for debugging that directly reads from > the PaRAM and gives the current state correctl

RE: [PATCH] mmc: dw_mmc-exynos: Common bindings for dw-mshc timing

2013-08-12 Thread Seungwon Jeon
On Fri, August 09, 2013, Dinh Nguyen wrote: > Hi Seungwon Jeon, > > On Fri, 2013-08-09 at 21:36 +0900, Seungwon Jeon wrote: > > On Fri, August 09, 2013, Jaehoon Chung wrote: > > > Hi Dinh > > > > > > On 08/09/2013 07:55 AM, dingu...@altera.com wrote: > > > > From: Dinh Nguyen > > > > > > > > Remo

RE: [PATCH] mmc: dw_mmc: Don't disable vmmc if keeping power in suspend

2013-08-12 Thread Seungwon Jeon
On Wed, August 07, 2013, Derek Basehore > If we keep power for suspend on a host for dw_mmc, don't disable vmmc-supply > regulator when suspending the host. I have a trivial comment. It would be better to add some macro for checking MMC_PM_KEEP_POWER. And I just wonder how the problem is silent. O

RE: [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode

2013-08-12 Thread Seungwon Jeon
On Monday, August 12, 2013, Prabu Thangamuthu wrote: > > Tested-by: Prabu Thangamuthu > > Regards, > Prabu Thangamuthu. > > On 08/12/2013 04:15 PM, Andy Shevchenko wrote: > > This patch enables bus-mastering mode for MMC controller to allow IDMAC > > transfers. > > > > Signed-off-by: Andy Shevc

RE: [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR

2013-08-12 Thread Seungwon Jeon
On Monday, August 12, 2013, Prabu Thangamuthu wrote: > > Tested-by: Prabu Thangamuthu > > Regards, > Prabu Thangamuthu. > > On 08/12/2013 04:15 PM, Andy Shevchenko wrote: > > There is a typo when the mapped space is from BAR 2, but BAR 0 is used > > instead. > > This patch fixes the typo. > > >

RE: [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR

2013-08-12 Thread Prabu Thangamuthu
Tested-by: Prabu Thangamuthu Regards, Prabu Thangamuthu. On 08/12/2013 04:15 PM, Andy Shevchenko wrote: > There is a typo when the mapped space is from BAR 2, but BAR 0 is used > instead. > This patch fixes the typo. > > Signed-off-by: Andy Shevchenko > --- > drivers/mmc/host/dw_mmc-pci.c | 2

RE: [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode

2013-08-12 Thread Prabu Thangamuthu
Tested-by: Prabu Thangamuthu Regards, Prabu Thangamuthu. On 08/12/2013 04:15 PM, Andy Shevchenko wrote: > This patch enables bus-mastering mode for MMC controller to allow IDMAC > transfers. > > Signed-off-by: Andy Shevchenko > --- > drivers/mmc/host/dw_mmc-pci.c | 2 ++ > 1 file changed, 2 i

RE: mmc oops on suspend - remove device

2013-08-12 Thread Seungwon Jeon
On Sun, August 11, 2013, Alban Browaeys wrote: > The oops spots commit add710e , though I cannot tell if the commit is > at fault. That is could card from md->queue.card be null and then checks > are missing before dereference or is the issue that card is null when it > ought not. > This happens w

RE: [PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-12 Thread Seungwon Jeon
Doug, Looks good to me except for minor comment. On Sat, August 10, 2013, Doug Anderson wrote: > If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up > looping around forever. This has been seen to happen on exynos5420 > silicon despite the fact that we haven't enabled any wakeup

RE: [PATCH v4 3/4] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-08-12 Thread Seungwon Jeon
On Sat, August 10, 2013,Doug Anderson wrote: > Seungwon, > > On Fri, Aug 9, 2013 at 6:35 AM, Seungwon Jeon wrote: > > On Wed, August 07, 2013, Doug Anderson wrote: > >> After suspend/resume all of the dw_mmc registers are reset to > >> defaults. We restore most of them, but specifically don't se

Re: [PATCH v3 03/12] dma: edma: remove limits on number of slots

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > With this series, this check is no longer required and > we shouldn't need to reject drivers DMA'ing more than the > MAX number of slots. > > Signed-off-by: Joel Fernandes > --- > drivers/dma/edma.c |6 -- > 1 file changed, 6 del

Re: [PATCH v3 01/12] dma: edma: Setup parameters to DMA MAX_NR_SG at a time

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > Changes are made here for configuring existing parameters to support > DMA'ing them out in batches as needed. > > Also allocate as many as slots as needed by the SG list, but not more > than MAX_NR_SG. Then these slots will be reused accor

RE: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-12 Thread Seungwon Jeon
On Sat, August 10, 2013, Doug Anderson wrote: > Seungwon and Jaehoon, > > On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon wrote: > > On Wed, August 07, 2013, Doug Anderson wrote: > >> The dw_mmc driver keeps a cache of the current slot->clock in order to > >> avoid doing a whole lot of work every t

Re: mmc oops on suspend - remove device

2013-08-12 Thread Jaehoon Chung
Hi, Alban. I think that it needs be set to "non-removable" for emmc. If emmc is set to removable, it should be removed when entered suspend. Best Regards, Jaehoon Chung On 08/11/2013 01:10 AM, Alban Browaeys wrote: > > The oops spots commit add710e , though I cannot tell if the commit is > at

mmc: core: Add check for card type before mmc_hw_reset_for_init

2013-08-12 Thread Prasanna NAVARATNA
Almost all the places, before calling hw_reset ops, the card type is checked to make sure it is eMMC but missed during mmc_rescan_try_freq. The below patch adds the check for card type before calling hardware reset for init as double safety measure. >From e7941c5b3b4999318feb59fa83b78c15c13493b3 M