Re: [PATCH 2/3] mmc: dw_mmc: Remove redundant of_match_ptr

2013-10-06 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 09/30/2013 01:59 PM, Sachin Kamat wrote: The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc-pltfm.c |2

Re: [PATCH] mmc: dw_mmc: Add hardware lock error (HLE) to the CMD error flag

2013-10-06 Thread Jaehoon Chung
Hi Alim, On 10/03/2013 06:18 PM, alim akhtar wrote: From: Alim Akhtar alim.akh...@samsung.com Hardware locked error set when the dw_mmc controller cannot load a command issued by software. When software sets the start_cmd bit in the CMD register, the controller tries to load the command. If

Re: [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

2013-10-06 Thread Georgi Djakov
Hi Bjorn, Hi Georgi, Thanks for working on this, unfortunately it seems like I need to port the rpm regulators to be able to test this. But I did find that... Yes, the regulators support is still missing upstream. Until then, a basic testing can be done by bypassing the regulators init

Re: Question about commit mmc: core: Support aggressive power management for (e)MMC/SD

2013-10-06 Thread Ulf Hansson
Axel Lin axel@ingics.com skrev: Hi Ulf, While reading the code, I don't figure out why we need a nested mmc_claim_host /mmc_release_host calls and additional mmc_power_off/mmc_power_up calls in commit c4d770d72. Hi Axel, Please have a look at a patch I sent 3 October. mmc: core: Remove

[PATCH FIX+RESEND 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

2013-10-06 Thread Jarkko Nikula
Omap MMC driver initialization can cause a NULL pointer dereference in tasklet_hi_action on Nokia N810 if its miniSD cover is open during driver initialization. Reason for this is that omap_notify_cover_event which calls tasklet_hi_schedule gets called before struct cover_tasklet is initialized.

[PATCH FIX+RESEND 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

2013-10-06 Thread Jarkko Nikula
Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 15 +-- 1 file changed, 5 insertions(+),

[PATCH FIX+RESEND 2/7] mmc: omap: Convert to devm_kzalloc

2013-10-06 Thread Jarkko Nikula
Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 31f33ac..1d0d21f 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c

[PATCH FIX+RESEND 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host

2013-10-06 Thread Jarkko Nikula
Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 4 +--- 1 file changed, 1

[PATCH FIX+RESEND 3/7] mmc: omap: Remove duplicate host-irq assignment

2013-10-06 Thread Jarkko Nikula
host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 1d0d21f..7668d47 100644 --- a/drivers/mmc/host/omap.c +++

[PATCH FIX+RESEND 7/7] mmc: omap: Get DMA request numbers via platform resource

2013-10-06 Thread Jarkko Nikula
There is no need to define MMC DMA TX and RX request numbers locally for OMAP1xxx and OMAP24xx and assign them non-portable way since they already come via platform resources. See commits 6c432f7 (ARM: OMAP1: Pass dma request lines in platform data to MMC driver) b955eef (ARM: OMAP2: Use hwmod to

[PATCH FIX+RESEND 5/7] mmc: omap: Convert to devm_ioremap_resource

2013-10-06 Thread Jarkko Nikula
Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 41

Re: [PATCH 1/6] mmc: omap: Convert to devm_kzalloc

2013-10-06 Thread Jarkko Nikula
Hi On 09/11/2013 09:01 PM, Jarkko Nikula wrote: Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) I resent this set with a subject prefix PATCH FIX+RESEND since I found a NULL pointer dereference

Re: Re: [PATCH] mmc: dw_mmc: Add hardware lock error (HLE) to the CMD error flag

2013-10-06 Thread ALIM AKHTAR
Hi Jaehoon, --- Original Message --- Sender : Jaehoon Chungjh80.ch...@samsung.com S4/Engineer/System S/W Lab./Samsung Electronics Date : Oct 06, 2013 17:28 (GMT+09:00) Title : Re: [PATCH] mmc: dw_mmc: Add hardware lock error (HLE) to the CMD error flag   Hi Alim, On 10/03/2013 06:18

Re: [PATCH] mmc: dw_mmc: Add hardware lock error (HLE) to the CMD error flag

2013-10-06 Thread Jaehoon Chung
On 10/07/2013 01:22 PM, ALIM AKHTAR wrote: Hi Jaehoon, --- Original Message --- Sender : Jaehoon Chungjh80.ch...@samsung.com S4/Engineer/System S/W Lab./Samsung Electronics Date : Oct 06, 2013 17:28 (GMT+09:00) Title : Re: [PATCH] mmc: dw_mmc: Add hardware lock error (HLE) to the