Re: [PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-30 Thread zhangfei
On 12/30/2013 10:32 AM, Zhangfei Gao wrote: On Mon, Dec 30, 2013 at 7:55 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 12/30/2013 06:05 AM, Arnd Bergmann wrote: On Saturday 28 December 2013, Zhangfei Gao wrote: Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao

Re: [PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-30 Thread Arnd Bergmann
On Monday 30 December 2013, zhangfei wrote: +static int dw_mci_k3_suspend(struct device *dev) +{ +struct dw_mci *host = dev_get_drvdata(dev); +int ret = 0; + +ret = dw_mci_suspend(host); You should never initialize local variables when they are set later in the

Re: [PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-30 Thread zhangfei
Dear Arnd, On 12/31/2013 04:27 AM, Arnd Bergmann wrote: On Monday 30 December 2013, zhangfei wrote: +static int dw_mci_k3_suspend(struct device *dev) +{ +struct dw_mci *host = dev_get_drvdata(dev); +int ret = 0; + +ret = dw_mci_suspend(host); You should never initialize local

Re: [PATCH V2 1/2] mmc: sdhci-esdhc-imx: fix access hardirq-unsafe lock in atomic context

2013-12-30 Thread Shawn Guo
On Thu, Dec 26, 2013 at 03:23:53PM +0800, Dong Aisheng wrote: Sometimes we may meet the following lockdep issue. The root cause is .set_clock callback is executed with spin_lock_irqsave in sdhci_do_set_ios. However, the IMX set_clock callback will try to access clk_get_rate which is using a