Re: [PATCH v3] mmc/sdio: add a quirk for broken SDIO_CCCR_INTx polling

2014-01-17 Thread Chris Ball
Hi, On Tue, Nov 26 2013, Bing Zhao wrote: > Polling SDIO_CCCR_INTx could create a fake interrupt with Marvell > SD8797 card. Add a quirk to handle this case. The fixup here is > to issue a dummy CMD52 read to function 0 register 0xff, and this > dummy read must be right after SDIO_CCCR_INTx is rea

RE: [PATCH v3] mmc/sdio: add a quirk for broken SDIO_CCCR_INTx polling

2014-01-17 Thread Bing Zhao
Hi Chris, > Polling SDIO_CCCR_INTx could create a fake interrupt with Marvell > SD8797 card. Add a quirk to handle this case. The fixup here is > to issue a dummy CMD52 read to function 0 register 0xff, and this > dummy read must be right after SDIO_CCCR_INTx is read. > > Patch has been verified

Re: [PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread Chris Ball
Hi, On Sat, Jan 18 2014, Andrew Bresticker wrote: There's an existing patch for that... http://www.spinics.net/lists/arm-kernel/msg296596.html >>> >>> Ah, I see. Looks like it has yet to be picked up... >> >> The patches aren't quite identical -- Andrew's leaves the >> disable_irq() cal

Re: [PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread Andrew Bresticker
On Fri, Jan 17, 2014 at 3:40 PM, Chris Ball wrote: > Hi, adding Aisheng, > > On Fri, Jan 17 2014, Andrew Bresticker wrote: >> On Fri, Jan 17, 2014 at 3:11 PM, John Tobias >> wrote: >>> There's an existing patch for that... >>> http://www.spinics.net/lists/arm-kernel/msg296596.html >> >> Ah, I se

Re: [PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread Chris Ball
Hi, adding Aisheng, On Fri, Jan 17 2014, Andrew Bresticker wrote: > On Fri, Jan 17, 2014 at 3:11 PM, John Tobias wrote: >> There's an existing patch for that... >> http://www.spinics.net/lists/arm-kernel/msg296596.html > > Ah, I see. Looks like it has yet to be picked up... The patches aren't q

Re: [PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread Andrew Bresticker
On Fri, Jan 17, 2014 at 3:11 PM, John Tobias wrote: > There's an existing patch for that... > http://www.spinics.net/lists/arm-kernel/msg296596.html Ah, I see. Looks like it has yet to be picked up... > > On Fri, Jan 17, 2014 at 2:58 PM, Philip Rakity wrote: >> >> On Jan 17, 2014, at 7:57 PM,

Re: [PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread John Tobias
There's an existing patch for that... http://www.spinics.net/lists/arm-kernel/msg296596.html On Fri, Jan 17, 2014 at 2:58 PM, Philip Rakity wrote: > > On Jan 17, 2014, at 7:57 PM, Andrew Bresticker wrote: > >> sdhci_execute_tuning() takes host->lock without disabling interrupts. >> Use spin_lock

Re: [PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread Andrew Bresticker
On Fri, Jan 17, 2014 at 2:58 PM, Philip Rakity wrote: > > On Jan 17, 2014, at 7:57 PM, Andrew Bresticker wrote: > >> sdhci_execute_tuning() takes host->lock without disabling interrupts. >> Use spin_lock_irq{save,restore} instead so that we avoid taking an >> interrupt and scheduling while holdin

Re: [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table

2014-01-17 Thread Chris Ball
Hi Mike, On Fri, Jan 17 2014, Mike Turquette wrote: > Oops, I just read this mail. I have taken in patch #1 through the clk > tree but have not yet pushed it out to my public mirror. > > Chris, I'm happy to take it if you haven't yet. That's fine. I'd like to take 2/2, just pushed it to mmc-next

Re: [PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread Philip Rakity
On Jan 17, 2014, at 7:57 PM, Andrew Bresticker wrote: > sdhci_execute_tuning() takes host->lock without disabling interrupts. > Use spin_lock_irq{save,restore} instead so that we avoid taking an > interrupt and scheduling while holding host->lock. > > Signed-off-by: Andrew Bresticker > --- > d

Re: [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table

2014-01-17 Thread Mike Turquette
Quoting Seungwon Jeon (2014-01-17 08:10:23) > On Sat, Jan 18, 2014 at 12:01 AM, Chris Ball wrote: > > > > Hi, > > > > On Tue, Jan 14 2014, Seungwon Jeon wrote: > > > On Monday, January 13, 2014, Zhangfei Gao wrote: > > >> Remove clk_table and directly use ios->clock as clock source rate. > > >> Ab

Re: [PATCH 1/7] mmc: clarify DDR timing mode between SD-UHS and eMMC

2014-01-17 Thread Ulf Hansson
On 16 January 2014 11:50, Ulf Hansson wrote: > On 15 January 2014 15:10, Seungwon Jeon wrote: >> This change distinguishes DDR timing mode of current >> mixed usage to clarify device type. >> >> Signed-off-by: Seungwon Jeon > > Acked-by: Ulf Hansson > >> --- >> drivers/mmc/core/debugfs.c |

[PATCH] mmc: sdhci: fix possible scheduling while atomic

2014-01-17 Thread Andrew Bresticker
sdhci_execute_tuning() takes host->lock without disabling interrupts. Use spin_lock_irq{save,restore} instead so that we avoid taking an interrupt and scheduling while holding host->lock. Signed-off-by: Andrew Bresticker --- drivers/mmc/host/sdhci.c | 13 +++-- 1 file changed, 7 insertio

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Nicolas Pitre
On Fri, 17 Jan 2014, Rob Herring wrote: > On Thu, Jan 16, 2014 at 9:08 PM, Nicolas Pitre wrote: > > On Thu, 16 Jan 2014, Olof Johansson wrote: > > > >> "for SDIO slots" is somewhat misleading; nearly all controllers only > >> do one slot/device per controller. The designware controller can do > >

Re: [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table

2014-01-17 Thread Seungwon Jeon
On Sat, Jan 18, 2014 at 12:01 AM, Chris Ball wrote: > > Hi, > > On Tue, Jan 14 2014, Seungwon Jeon wrote: > > On Monday, January 13, 2014, Zhangfei Gao wrote: > >> Remove clk_table and directly use ios->clock as clock source rate. > >> Abstract init clock rate and max clock limitation in clk.c > >

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Rob Herring
On Thu, Jan 16, 2014 at 9:08 PM, Nicolas Pitre wrote: > On Thu, 16 Jan 2014, Olof Johansson wrote: > >> "for SDIO slots" is somewhat misleading; nearly all controllers only >> do one slot/device per controller. The designware controller can do >> multiple slots, and that adds a bit of driver and b

Re: [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table

2014-01-17 Thread Chris Ball
Hi, On Tue, Jan 14 2014, Seungwon Jeon wrote: > On Monday, January 13, 2014, Zhangfei Gao wrote: >> Remove clk_table and directly use ios->clock as clock source rate. >> Abstract init clock rate and max clock limitation in clk.c >> >> Signed-off-by: Zhangfei Gao > > Acked-by: Seungwon Jeon It

[PATCH v2 2/7] mmc: mmci: clarify DDR timing mode between SD-UHS and eMMC

2014-01-17 Thread Seungwon Jeon
Added MMC_DDR52 as eMMC's DDR mode distinguished from SD-UHS. CC: Russell King Signed-off-by: Seungwon Jeon --- drivers/mmc/host/mmci.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index f320579..92d40be 100644 -

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Arnd Bergmann
On Friday 17 January 2014, Nicolas Pitre wrote: > On Thu, 16 Jan 2014, Olof Johansson wrote: > > > "for SDIO slots" is somewhat misleading; nearly all controllers only > > do one slot/device per controller. The designware controller can do > > multiple slots, and that adds a bit of driver and bind

RE: [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table

2014-01-17 Thread Seungwon Jeon
+ Chris Ball (New e-mail) On Tue, January 14, 2014, Seungwon Jeon wrote: > On Monday, January 13, 2014, Zhangfei Gao wrote: > > Remove clk_table and directly use ios->clock as clock source rate. > > Abstract init clock rate and max clock limitation in clk.c > > > > Signed-off-by: Zhangfei Gao >

Re: [PATCH v6] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2014-01-17 Thread Arnd Bergmann
On Friday 17 January 2014, Jonas Jensen wrote: > Add SDHCI driver for MOXA ART SoCs. > > Signed-off-by: Jonas Jensen I think this should be renamed to something other than SDHCI, since that implies a specific register layout and would use the sdhci.c driver. Maybe moxart-mmc? > diff --git a/Do

RE: [PATCH 4/7] mmc: sh_mmcif: clarify DDR timing mode between SD-UHS and eMMC

2014-01-17 Thread Seungwon Jeon
On Thu, January 16, 2014, Ulf Hansson wrote: > On 15 January 2014 15:12, Seungwon Jeon wrote: > > Replaced UHS_DDR50 with MMC_DDR52. > > > > CC: Guennadi Liakhovetski > > Signed-off-by: Seungwon Jeon > > --- > > drivers/mmc/host/sh_mmcif.c |9 + > > 1 files changed, 5 insertions(+),

Re: [PATCH] mmc: dw_mmc: fix dw_mci_get_cd

2014-01-17 Thread Chris Ball
Hi, On Fri, Jan 17 2014, Seungwon Jeon wrote: > On Fri, January 17, 2014, Kevin Hilman wrote: >> Zhangfei Gao writes: >> >> > Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b >> > CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc) >> > can not be checked by IS_E

RE: [PATCH 2/7] mmc: mmci: clarify DDR timing mode between SD-UHS and eMMC

2014-01-17 Thread Seungwon Jeon
On Thu, January 16, 2014, Ulf Hansson wrote: > On 15 January 2014 15:11, Seungwon Jeon wrote: > > Replaced UHS_DDR50 with MMC_DDR52. > > > > CC: Russell King > > Signed-off-by: Seungwon Jeon > > --- > > drivers/mmc/host/mmci.c |4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) >

RE: [PATCH] mmc: dw_mmc: fix dw_mci_get_cd

2014-01-17 Thread Seungwon Jeon
On Fri, January 17, 2014, Kevin Hilman wrote: > Zhangfei Gao writes: > > > Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b > > CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc) > > can not be checked by IS_ERR_VALUE. > > Add spin_lock_bh(&host->lock) for atomic

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Andrew Lunn
> The TI wilink chips (TiWi, wl12xx, wl18xx) have wifi on SDIO and BT on > UART but they share the same clock. So, the next question would be what > if I just want to enable one or the other (and take that decision at > runtime) ? At least for the clock is it not an issue. The generic clock framew

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Alexandre Belloni
On Fri, Jan 17, 2014 at 06:06:41PM +0800, Chen-Yu Tsai wrote : > On Fri, Jan 17, 2014 at 5:39 PM, Alexandre Belloni > wrote: > > Maybe it is not completely related but I think it needs to be thought > > about while you are it: > > > > The TI wilink chips (TiWi, wl12xx, wl18xx) have wifi on SDIO an

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Chen-Yu Tsai
On Fri, Jan 17, 2014 at 5:39 PM, Alexandre Belloni wrote: > On Thu, Jan 16, 2014 at 12:00:47PM -0800, Olof Johansson wrote : >> On Thu, Jan 16, 2014 at 11:58 AM, Russell King - ARM Linux >> wrote: >> > On Thu, Jan 16, 2014 at 09:15:17AM -0800, Olof Johansson wrote: >> >> We've dealt with it with

[PATCH v6] mmc: sdhci-moxart: Add MOXA ART SDHCI driver

2014-01-17 Thread Jonas Jensen
Fatal exception in interrupt Changes since v5: 1. add local dma_cookie_t to host struct 2. store dmaengine_submit() return value to [1] 3. use [1] when calling dmaengine_tx_status() Applies to next-20140117 .../devicetree/bindings/mmc/moxa,moxart-sdhci.txt | 28

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Alexandre Belloni
On Thu, Jan 16, 2014 at 12:00:47PM -0800, Olof Johansson wrote : > On Thu, Jan 16, 2014 at 11:58 AM, Russell King - ARM Linux > wrote: > > On Thu, Jan 16, 2014 at 09:15:17AM -0800, Olof Johansson wrote: > >> We've dealt with it with local code in our tree for Chrome OS, and I > >> suspect everyone

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Nicolas Ferre
On 17/01/2014 10:02, Alexandre Belloni : > On Thu, Jan 16, 2014 at 09:15:17AM -0800, Olof Johansson wrote : >> "for SDIO slots" is somewhat misleading; nearly all controllers only >> do one slot/device per controller. The designware controller can do >> multiple slots, and that adds a bit of driver

Re: How to support SDIO wifi/bt in DT

2014-01-17 Thread Alexandre Belloni
On Thu, Jan 16, 2014 at 09:15:17AM -0800, Olof Johansson wrote : > "for SDIO slots" is somewhat misleading; nearly all controllers only > do one slot/device per controller. The designware controller can do > multiple slots, and that adds a bit of driver and binding complexity > for something that s