Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-21 Thread Chris Ruehl
On Wednesday, January 22, 2014 03:23 PM, Sascha Hauer wrote: On Wed, Jan 22, 2014 at 03:19:48PM +0800, Chris Ruehl wrote: On Wednesday, January 22, 2014 02:42 PM, Sascha Hauer wrote: On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote: Function mxcmci_request() throw an exception on a

Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-21 Thread Sascha Hauer
On Wed, Jan 22, 2014 at 03:19:48PM +0800, Chris Ruehl wrote: > On Wednesday, January 22, 2014 02:42 PM, Sascha Hauer wrote: > >On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote: > >>Function mxcmci_request() throw an exception on a imx27 cpu. > >>This patch fix the problem by test the poi

Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-21 Thread Chris Ruehl
On Wednesday, January 22, 2014 02:42 PM, Sascha Hauer wrote: On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote: Function mxcmci_request() throw an exception on a imx27 cpu. This patch fix the problem by test the pointer before access it. diff --git a/drivers/mmc/host/mxcmmc.c b/driver

Re: [PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-21 Thread Sascha Hauer
On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote: > Function mxcmci_request() throw an exception on a imx27 cpu. > This patch fix the problem by test the pointer before access it. > > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c > index f7199c8..8645d6a 100644 > --

[PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-21 Thread Chris Ruehl
Function mxcmci_request() throw an exception on a imx27 cpu. This patch fix the problem by test the pointer before access it. [ 516.783407] Unable to handle kernel NULL pointer dereference at virtual address 0004 [ 516.791639] pgd = c0004000 [ 516.794445] [0004] *pgd= [ 516.79

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-21 Thread Tomasz Figa
On 21.01.2014 22:30, Olof Johansson wrote: On Tue, Jan 21, 2014 at 10:34 AM, Tomasz Figa wrote: What do you think? Sure, post the patches. OK. Will give it a try this weekend. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a mes

[PATCH 61/73] drivers/mmc: delete non-required instances of include

2014-01-21 Thread Paul Gortmaker
None of these files are actually using any __init type directives and hence don't need to include . Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Cc: Chris Ball Cc: linux-mmc@vger.kernel.org Signed-off-by: Paul G

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-21 Thread Olof Johansson
On Tue, Jan 21, 2014 at 10:34 AM, Tomasz Figa wrote: > What do you think? Sure, post the patches. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-01-21 Thread Felipe Balbi
On Tue, Jan 21, 2014 at 01:39:20PM -0600, Nishanth Menon wrote: > On Tue, Jan 21, 2014 at 12:05 PM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jan 21, 2014 at 11:38:00AM -0600, Nishanth Menon wrote: > >> On 01/20/2014 05:39 PM, Felipe Balbi wrote: > >> > On Mon, Jan 20, 2014 at 05:29:02PM -0600,

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-01-21 Thread Nishanth Menon
On Tue, Jan 21, 2014 at 12:05 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jan 21, 2014 at 11:38:00AM -0600, Nishanth Menon wrote: >> On 01/20/2014 05:39 PM, Felipe Balbi wrote: >> > On Mon, Jan 20, 2014 at 05:29:02PM -0600, Nishanth Menon wrote: >> >> When device is booted using devicetree, platform

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-21 Thread Russell King - ARM Linux
On Mon, Jan 20, 2014 at 04:47:34PM -0200, Fabio Estevam wrote: > On Mon, Jan 20, 2014 at 3:16 PM, Russell King - ARM Linux > wrote: > > > Not as far as I can see. fixed-clock appears to have two properies: > > > > clock-frequency > > clock-output-names > > > > and nothing else.

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-21 Thread Tomasz Figa
Hi, On 20.01.2014 04:56, Olof Johansson wrote: This patch enables support for power-on sequencing of SDIO peripherals through DT. In general, it's quite common that wifi modules and other similar peripherals have several signals in addition to the SDIO interface that needs wiggling before the

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-21 Thread Olof Johansson
On Tue, Jan 21, 2014 at 12:55 AM, Ulf Hansson wrote: [pruning quotes a bit] >>> Is the above regulator related to host->ocr_avail mask? Could the >>> above regulator be replaced by vmmc? >> >> I have to admit that I don't know MMC as well as I could, but OCR seems to be >> something that's between

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-01-21 Thread Felipe Balbi
Hi, On Tue, Jan 21, 2014 at 11:38:00AM -0600, Nishanth Menon wrote: > On 01/20/2014 05:39 PM, Felipe Balbi wrote: > > On Mon, Jan 20, 2014 at 05:29:02PM -0600, Nishanth Menon wrote: > >> When device is booted using devicetree, platforms impacted by > >> Erratum 2.1.1.128 is not detected easily in

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-01-21 Thread Nishanth Menon
On 01/20/2014 05:39 PM, Felipe Balbi wrote: > On Mon, Jan 20, 2014 at 05:29:02PM -0600, Nishanth Menon wrote: >> When device is booted using devicetree, platforms impacted by >> Erratum 2.1.1.128 is not detected easily in the mmc driver. This erratum >> indicates that the module cannot do multi-blo

[PATCH 4/5] mmc: omap_hsmmc: add cmd23 support

2014-01-21 Thread Balaji T K
Add set block count command support for close ended multiblock read/write. Signed-off-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c | 21 + 1 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH 3/5] mmc: omap_hsmmc: split dma setup

2014-01-21 Thread Balaji T K
split start dma function into setup and start dma to keep track of host_cookie when cmd23 support is enabled along with async request. Signed-off-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c | 26 ++ 1 files changed, 18 insertions(+), 8 deletions(-) diff --git a/dr

[PATCH 1/5] mmc: omap_hsmmc: save clock rate to use in interrupt context

2014-01-21 Thread Balaji T K
clk_get_rate throws DEBUG_LOCKS_WARN_ON(in_interrupt()) warning if called from interrupt context. use cached clock rate in set_data_timeout, so that set_data_timeout can be called from interrupt context. Signed-off-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c |4 +++- 1 files changed, 3

[PATCH 5/5] mmc: omap_hsmmc: add autocmd23 support

2014-01-21 Thread Balaji T K
Add support for autocmd23 support Signed-off-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c | 39 --- 1 files changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index bad246e..fba67ab 10064

[PATCH 0/5] mmc: omap_hsmmc: add support for set block count

2014-01-21 Thread Balaji T K
Balaji T K (5): mmc: omap_hsmmc: save clock rate to use in interrupt context mmc: omap_hsmmc: fix request done for sbc error case mmc: omap_hsmmc: split dma setup mmc: omap_hsmmc: add cmd23 support mmc: omap_hsmmc: add autocmd23 support drivers/mmc/host/omap_hsmmc.c | 88 +

[PATCH 2/5] mmc: omap_hsmmc: fix request done for sbc error case

2014-01-21 Thread Balaji T K
mrq is not populated for set block count(cmd23) command. Use block read/write mmc_commond pointer for request done and avoid NULL pointer access in error case for sbc (cmd23). Signed-off-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH 1/7] mmc: core add the property for hs200

2014-01-21 Thread Arnd Bergmann
On Tuesday 21 January 2014, Jaehoon Chung wrote: > On 01/21/2014 09:12 PM, Ulf Hansson wrote: > > On 21 January 2014 11:30, Arnd Bergmann wrote: > >> On Tuesday 21 January 2014 19:16:54 Jaehoon Chung wrote: > >> > >> Unfortunately, the names are not particularly intuitive (the caps2 > >> part in p

Re: [PATCH 1/7] mmc: core add the property for hs200

2014-01-21 Thread Jaehoon Chung
On 01/21/2014 09:12 PM, Ulf Hansson wrote: > On 21 January 2014 11:30, Arnd Bergmann wrote: >> On Tuesday 21 January 2014 19:16:54 Jaehoon Chung wrote: >>> caps2-mmc-hs200-1.8v and caps2-mmc-hs200-1.2v can be used to the general >>> capability. >>> >>> Signed-off-by: Jaehoon Chung >>> --- >>> d

Re: [PATCH 1/7] mmc: core add the property for hs200

2014-01-21 Thread Ulf Hansson
On 21 January 2014 11:30, Arnd Bergmann wrote: > On Tuesday 21 January 2014 19:16:54 Jaehoon Chung wrote: >> caps2-mmc-hs200-1.8v and caps2-mmc-hs200-1.2v can be used to the general >> capability. >> >> Signed-off-by: Jaehoon Chung >> --- >> drivers/mmc/core/host.c |4 >> 1 file change

[PATCH v7] mmc: moxart: Add MOXA ART SD/MMC driver

2014-01-21 Thread Jonas Jensen
ample ("coreclk" renamed "clk_apb", DMA channel number is no longer needed) 5. rename "sdhci-moxart" "moxart-mmc" 6. remove dmaengine_tx_status() / don't print DMA error 7. format comments / use correct grammar Applies to next-20140121

Re: [PATCH 1/7] mmc: core add the property for hs200

2014-01-21 Thread Arnd Bergmann
On Tuesday 21 January 2014 19:16:54 Jaehoon Chung wrote: > caps2-mmc-hs200-1.8v and caps2-mmc-hs200-1.2v can be used to the general > capability. > > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/core/host.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/core/ho

[PATCH 1/7] mmc: core add the property for hs200

2014-01-21 Thread Jaehoon Chung
caps2-mmc-hs200-1.8v and caps2-mmc-hs200-1.2v can be used to the general capability. Signed-off-by: Jaehoon Chung --- drivers/mmc/core/host.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index 49bc403..96ac4c1 100644 --- a/drivers/

[PATCH 6/7] mmc: dw_mmc: remove the unnecessary function.

2014-01-21 Thread Jaehoon Chung
Remove unnecessary function. This function didn't re-use anywhere. Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index ac16308..1418d33 100644 --- a/dr

[PATCH 3/7] mmc: dw_mmc: replace the bus_hz checking point

2014-01-21 Thread Jaehoon Chung
It's right that check immediately whether host->bus_hz is assigned or not. Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index c915293..39

[PATCH 5/7] mmc: dw-mmc: fix minor coding style.

2014-01-21 Thread Jaehoon Chung
Fixed the coding style. Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 9bac3ed..ac16308 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/hos

[PATCH 0/7] mmc: dw_mmc: minor code cleanup

2014-01-21 Thread Jaehoon Chung
This patch-set is minor code cleanup. Jaehoon Chung (7): mmc: core add the property for hs200 mmc: dw_mmc: use the mmc_of_parse() instead of local parser mmc: dw_mmc: replace the bus_hz checking point mmc: dw_mmc: remove unused member variable. mmc: dw-mmc: fix minor coding style. mmc:

[PATCH 2/7] mmc: dw_mmc: use the mmc_of_parse() instead of local parser

2014-01-21 Thread Jaehoon Chung
mmc_of_parse() have been already parsed the general capability. Didn't need to use the local parser. Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c | 48 + 1 file changed, 1 insertion(+), 47 deletions(-) diff --git a/drivers/mmc/host/dw_

[PATCH 4/7] mmc: dw_mmc: remove unused member variable.

2014-01-21 Thread Jaehoon Chung
Since using the device-tree, didn't use the callback pointer. So removed the unused callback pointer. Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c | 33 +++-- include/linux/mmc/dw_mmc.h | 14 -- 2 files changed, 3 insertions(+), 44 delet

[PATCH 7/7] mmc: dw_mmc: remove the dw_mci_of_cd_gpio()

2014-01-21 Thread Jaehoon Chung
If mmc_of_parse() is used, dw_mci_of_get_cd_gpio didn't need. Already implemented into mmc_of_parse(). Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c

Re: [PATCH 1/3] mmc: add support for power-on sequencing through DT

2014-01-21 Thread Ulf Hansson
On 20 January 2014 20:13, Olof Johansson wrote: > On Mon, Jan 20, 2014 at 09:44:23AM +0100, Ulf Hansson wrote: >> On 20 January 2014 04:56, Olof Johansson wrote: >> > This patch enables support for power-on sequencing of SDIO peripherals >> > through DT. >> > >> > In general, it's quite common t