Re: [patch] mmc: omap_hsmmc: precedence bug in omap_hsmmc_context_restore()

2014-01-30 Thread Dan Carpenter
On Thu, Aug 22, 2013 at 08:16:28PM +0530, Balaji T K wrote: On Thursday 22 August 2013 06:26 PM, Dan Carpenter wrote: '!' has higher precedence than '' so this doesn't work as intended although since RESETDONE is 1 it would work if none of the other bits are set. Hi Dan, Thanks for the

[patch 2/2] mmc: omap_hsmmc: checking for ERR_PTR instead of NULL

2014-01-30 Thread Dan Carpenter
The of_get_hsmmc_pdata() function returns NULL on error, it doesn't return ERR_PTRs. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index bfb0dbd052c0..76dbc7b759c2 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++

[patch 1/2] mmc: omap_hsmmc: remove a duplicative test

2014-01-30 Thread Dan Carpenter
Static checkers complain that testing for both next and !next is duplicative. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 2a629fbde613..bfb0dbd052c0 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++

Re: [patch 1/2] mmc: omap_hsmmc: remove a duplicative test

2014-01-30 Thread Balaji T K
On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote: Static checkers complain that testing for both next and !next is duplicative. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Looks good to me Acked-by: Balaji T K balaj...@ti.com diff --git a/drivers/mmc/host/omap_hsmmc.c

Re: [patch 2/2] mmc: omap_hsmmc: checking for ERR_PTR instead of NULL

2014-01-30 Thread Balaji T K
On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote: The of_get_hsmmc_pdata() function returns NULL on error, it doesn't return ERR_PTRs. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

Re: [patch] mmc: omap_hsmmc: precedence bug in omap_hsmmc_context_restore()

2014-01-30 Thread Balaji T K
On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote: On Thu, Aug 22, 2013 at 08:16:28PM +0530, Balaji T K wrote: On Thursday 22 August 2013 06:26 PM, Dan Carpenter wrote: '!' has higher precedence than '' so this doesn't work as intended although since RESETDONE is 1 it would work if

Re: [PATCH v7 1/2] mmc: sdhci-msm: Initial SDHCI MSM driver documentation

2014-01-30 Thread Georgi Djakov
Hi, Apologies for the delayed reply. On 12/09/2013 11:38 AM, Mark Rutland wrote: On Fri, Dec 06, 2013 at 11:59:46AM +, Georgi Djakov wrote: On 12/05/2013 11:52 AM, Mark Rutland wrote: [...] + +- qcom,{vdd,vdd-io}-lpm-sup - specifies whether the supply can be kept in low power mode.

Re: [PATCH v7 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

2014-01-30 Thread Georgi Djakov
On 12/09/2013 11:46 AM, Mark Rutland wrote: [...] + /* +* CORE_SW_RST above may trigger power irq if previous status of PWRCTL +* was either BUS_ON or IO_HIGH_V. So before we enable the power irq +* interrupt in GIC (by registering the interrupt handler), we need

Re: [PATCH v7 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

2014-01-30 Thread Georgi Djakov
Hi, Apologies for the delayed reply. On 12/09/2013 07:00 PM, Courtney Cavin wrote: On Wed, Nov 06, 2013 at 04:56:45PM +0100, Georgi Djakov wrote: This platform driver adds the initial support of Secure Digital Host Controller Interface compliant controller found in Qualcomm MSM chipsets.

[PATCH v8 0/3] mmc: sdhci-msm: Add support for Qualcomm chipsets

2014-01-30 Thread Georgi Djakov
This patchset adds basic support of the Secure Digital Host Controller Interface compliant controller found in Qualcomm chipsets. Tested with eMMC and various micro SD cards on APQ8074 Dragonboard. Changes from v7: - Added call to sdhci_get_of_property(). - Refactored

[PATCH v8 3/3] mmc: sdhci-msm: Add platform_execute_tunning implementation

2014-01-30 Thread Georgi Djakov
This patch adds implementation for platform specific tuning in order to support HS200 bus speed mode on Qualcomm SDHCI controller. Signed-off-by: Georgi Djakov gdja...@mm-sol.com --- drivers/mmc/host/sdhci-msm.c | 417 +- 1 file changed, 412

[PATCH v8 2/3] mmc: sdhci-msm: Initial support for Qualcomm chipsets

2014-01-30 Thread Georgi Djakov
This platform driver adds the initial support of Secure Digital Host Controller Interface compliant controller found in Qualcomm chipsets. Signed-off-by: Georgi Djakov gdja...@mm-sol.com --- drivers/mmc/host/Kconfig | 13 ++ drivers/mmc/host/Makefile|1 +

[PATCH v8 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation

2014-01-30 Thread Georgi Djakov
This patch adds the device-tree binding documentation for Qualcomm SDHCI driver. It contains the differences between the core properties in mmc.txt and the properties used by the sdhci-msm driver. Signed-off-by: Georgi Djakov gdja...@mm-sol.com --- .../devicetree/bindings/mmc/sdhci-msm.txt

Re: [PATCH 0/3] RFC/RFT: Powering on MMC Wifi/BT modules in MMC core

2014-01-30 Thread Russell King - ARM Linux
On Sun, Jan 19, 2014 at 07:56:52PM -0800, Olof Johansson wrote: This is a small series enhancing the MMC core code to power on modules before the host in cases where needed, and the corresponding DT bindings changes. I've got some other issues to debug on the Chromebook, i.e. the interface

Re: mmc: sh_mobile_sdhi: DT update for R-Car

2014-01-30 Thread Simon Horman
On Wed, Jan 29, 2014 at 11:08:00PM -0800, Kuninori Morimoto wrote: Hi Simon, Chris Previously I was somewhat ambivalent to this but experience has shown me that taking shmobile patches through my tree is best. The reason is that it reduces (eliminates?) merge conflicts. Conflicts that

Re: mmc: sh_mobile_sdhi: DT update for R-Car

2014-01-30 Thread Kuninori Morimoto
Hi Chris, Simon These are v2 of updates code for R-Car. I separated v1 patches into for mmc, and for SH-ARM. This is mmc part patches. Kuninori Morimoto (4): mmc: SDHI: tidyup sh_mobile_sdhi_of_match position mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7778 mmc: SDHI:

[PATCH 1/4] mmc: SDHI: tidyup sh_mobile_sdhi_of_match position

2014-01-30 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com it is easy to read if sh_mobile_sdhi_of_cfg and sh_mobile_sdhi_of_match are closer Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/mmc/host/sh_mobile_sdhi.c | 26 +- 1 file changed,

[PATCH 2/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7778

2014-01-30 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch updates r8a7778 DT data to have SoC specific settings. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/mmc/host/sh_mobile_sdhi.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[PATCH 3/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7779

2014-01-30 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch updates r8a7779 DT data to have SoC specific settings. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/mmc/host/sh_mobile_sdhi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790

2014-01-30 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch updates r8a7790 DT data to have SoC specific settings. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/mmc/host/sh_mobile_sdhi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-)

[PATCH 2/3] ARM: shmobile: r8a7779: removed unnecessary mmc option

2014-01-30 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com r8a7779 specific MMC options are cared by driver. This driver removes these from DTSI Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- arch/arm/boot/dts/r8a7779.dtsi |8 1 file changed, 8 deletions(-)

[PATCH 3/3] ARM: shmobile: r8a7790: removed unnecessary mmc option

2014-01-30 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com r8a7790 specific MMC options are cared by driver. This driver removes these from DTSI Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- arch/arm/boot/dts/r8a7790.dtsi |4 1 file changed, 4 deletions(-) diff

[PATCH] ARM: shmobile: bockw: use wp-gpios instead of WP pin

2014-01-30 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Latest Renesas Chip has some SDHI channels and the WP pin availability depends on its channel or HW implementation. Thus, this patch decides new policy whch indicates WP is disabled as default. But, we can use wp-gpios property to enable it