Re: [PATCH v10 0/7] mmc: omap_hsmmc: pbias dt and cleanup

2014-02-04 Thread Balaji T K
On Monday 13 January 2014 09:06 PM, Balaji T K wrote: Few cleanups to reduce code indent, Add pbias_regulator support and adapt omap_hsmmc to use pbias regulator to configure required voltage on mmc1 pad(SD card) i/o rails on OMAP SoCs. Hi Tony, Considering the dependencies with regulator,

HARDIRQ-safe - HARDIRQ-unsafe lock order detected

2014-02-04 Thread Christian Gmeiner
I have some filesystem anomalies and and enabled all kind of debug stuff and got the following: [1.265237] [1.266761] == [1.272969] [ INFO: HARDIRQ-safe - HARDIRQ-unsafe lock order detected ] [1.279699] 3.12.9 #1 Not tainted [

mmc0: BKOPS_EN bit is not set

2014-02-04 Thread Christian Gmeiner
Should I care about it? -- Christian Gmeiner, MSc https://soundcloud.com/christian-gmeiner -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC] dmaengine: omap-dma: split header file

2014-02-04 Thread Balaji T K
On Friday 24 January 2014 10:21 PM, Balaji T K wrote: To Resolve build failure seen with sh-allmodconfig: include/linux/omap-dma.h:171:8: error: expected identifier before numeric constant make[4]: *** [drivers/mmc/host/omap_hsmmc.o] Error 1 due to CCR redefinition, move dmaengine

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-04 Thread Balaji T K
On Tuesday 21 January 2014 04:59 AM, Nishanth Menon wrote: When device is booted using devicetree, platforms impacted by Erratum 2.1.1.128 is not detected easily in the mmc driver. This erratum indicates that the module cannot do multi-block transfers. Handle this by providing a boolean flag to

RE: [PATCH V2 2/2] mmc: core: Enable MMC_CAP2_CACHE_CTRL as default

2014-02-04 Thread Seungwon Jeon
Hi Alim, On Mon, February 03, 2014, Alim Akhtar wrote: Hi Ulf On Thu, Dec 19, 2013 at 12:04 PM, Ulf Hansson ulf.hans...@linaro.org wrote: There are no reason to why the use of a non-volatile internal eMMC cache should be controlled by a host cap. Instead let's just enable it if the eMMC

Re: [PATCH v8 0/3] mmc: sdhci-msm: Add support for Qualcomm chipsets

2014-02-04 Thread Christopher Covington
Hi Georgi, On 01/30/2014 01:45 PM, Georgi Djakov wrote: This patchset adds basic support of the Secure Digital Host Controller Interface compliant controller found in Qualcomm chipsets. Tested with eMMC and various micro SD cards on APQ8074 Dragonboard. [...]

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-04 Thread Nishanth Menon
On 02/04/2014 06:44 AM, Balaji T K wrote: On Tuesday 21 January 2014 04:59 AM, Nishanth Menon wrote: When device is booted using devicetree, platforms impacted by Erratum 2.1.1.128 is not detected easily in the mmc driver. This erratum indicates that the module cannot do multi-block transfers.

[PATCH 04/17] mmc: mmci: Let runtime PM callbacks be available for CONFIG_PM

2014-02-04 Thread Ulf Hansson
Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM callbacks. This means the callbacks becomes available for both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed to handle the combinations of these scenarios. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Ulf

[PATCH 08/17] spi: pl022: Fully gate clocks at request inactivity

2014-02-04 Thread Ulf Hansson
Use clk_disable_unprepare and clk_prepare_enable from the runtime PM callbacks, to fully gate|ungate clocks. Potentially this will save more power, depending on the clock tree for the current SOC. Cc: Mark Brown broo...@kernel.org Signed-off-by: Ulf Hansson ulf.hans...@linaro.org ---

[PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend

2014-02-04 Thread Ulf Hansson
Due to the available runtime PM callbacks, we are now able to put our device into low power state at system suspend. Earlier we could not accomplish this without trusting a power domain for the device to take care of it. Now we are able to cope with scenarios both with and without a power domain.

[PATCH 11/17] i2c: nomadik: Convert to devm functions

2014-02-04 Thread Ulf Hansson
Use devm_* functions to simplify code and error handling. Cc: Alessandro Rubini rub...@unipv.it Cc: Linus Walleij linus.wall...@linaro.org Cc: Wolfram Sang w...@the-dreams.de Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 29

[PATCH 13/17] i2c: nomadik: Leave probe with the device in active state

2014-02-04 Thread Ulf Hansson
Since the runtime PM state is expected to be active according to the amba bus, we must align our behaviour while probing to it. Moreover, this is needed to be able to have the driver fully functional without depending on CONFIG_RUNTIME_PM. Cc: Alessandro Rubini rub...@unipv.it Cc: Linus Walleij

[PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-04 Thread Ulf Hansson
Since the device is active while a successful probe has been completed, the reference counting for the clock will be screwed up and never reach zero. The issue is resolved by implementing runtime PM callbacks and let them handle the resources accordingly, including the clock. Cc: Alessandro

[PATCH 16/17] i2c: nomadik: Remove busy check for transfers at suspend late

2014-02-04 Thread Ulf Hansson
We should never be busy performing transfers at suspend late, thus there are no reason to check for it. Cc: Alessandro Rubini rub...@unipv.it Cc: Linus Walleij linus.wall...@linaro.org Cc: Wolfram Sang w...@the-dreams.de Signed-off-by: Ulf Hansson ulf.hans...@linaro.org ---

[PATCH 17/17] i2c: nomadik: Fixup system suspend

2014-02-04 Thread Ulf Hansson
For !CONFIG_PM_RUNTIME, the device were never put back into active state while resuming. For CONFIG_PM_RUNTIME, we blindly trusted the device to be inactive while we were about to handle it at suspend late, which is just too optimistic. Even if the driver uses pm_runtime_put_sync() after each

[PATCH 15/17] i2c: nomadik: Convert to late and early system PM callbacks

2014-02-04 Thread Ulf Hansson
At system suspend_late, runtime PM has been disabled by the PM core which means we can safely operate on these resources. Consequentially we no longer have to wait until the noirq phase of the system suspend. Cc: Alessandro Rubini rub...@unipv.it Cc: Linus Walleij linus.wall...@linaro.org Cc:

[PATCH 09/17] spi: pl022: Simplify clock handling

2014-02-04 Thread Ulf Hansson
Make use of clk_prepare_enable and clk_disable_unprepare to simplify code. No functional change. Cc: Mark Brown broo...@kernel.org Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/spi/spi-pl022.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git

[PATCH 12/17] i2c: nomadik: Remove redundant call to pm_runtime_disable

2014-02-04 Thread Ulf Hansson
The amba bus are responsible for pm_runtime_enable|disable, remove the redundant pm_runtime_disable at driver removal. Cc: Alessandro Rubini rub...@unipv.it Cc: Linus Walleij linus.wall...@linaro.org Cc: Wolfram Sang w...@the-dreams.de Signed-off-by: Ulf Hansson ulf.hans...@linaro.org ---

[PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend

2014-02-04 Thread Ulf Hansson
Due to the available runtime PM callbacks for CONFIG_PM, we are now able to put the device into complete low power state at system suspend. Previously only the resources controlled by the driver were put into low power state at system suspend. Both the amba bus and a potential power domain were

[PATCH 10/17] spi: pl022: Remove redundant pinctrl to default state in probe

2014-02-04 Thread Ulf Hansson
The driver core is now taking care of putting our pins into default state at probe. Thus we can remove the redundant call for it in probe. Cc: Mark Brown broo...@kernel.org Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/spi/spi-pl022.c |2 -- 1 file changed, 2 deletions(-)

[PATCH 06/17] spi: pl022: Let runtime PM callbacks be available for CONFIG_PM

2014-02-04 Thread Ulf Hansson
Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM callbacks. This means the callbacks becomes available for both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed to handle the combinations of these scenarios. Cc: Mark Brown broo...@kernel.org Signed-off-by: Ulf Hansson

[PATCH 02/17] amba: Add late and early PM callbacks

2014-02-04 Thread Ulf Hansson
To give provision for amba drivers to make use of the late|early PM callbacks, we point the amba bus PM callbacks to the generic versions of these. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/amba/bus.c |6 ++ 1 file changed, 6

[PATCH 03/17] mmc: mmci: Mask IRQs for all variants during runtime suspend

2014-02-04 Thread Ulf Hansson
In runtime suspended state, we are not expecting IRQs and thus we can safely mask them, not only for pwrreg_nopower variants but for all. Obviously we then also need to make sure we restore the IRQ mask while becoming runtime resumed. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Ulf

[PATCH 01/17] amba: Let runtime PM callbacks be available for CONFIG_PM

2014-02-04 Thread Ulf Hansson
Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM callbacks. This means the callbacks becomes available for both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed by drivers and power domains. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Ulf Hansson

[PATCH 00/17] amba: PM fixups for amba bus and some amba drivers

2014-02-04 Thread Ulf Hansson
This patchset fixes the PM problems you yet when combining CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME. In principle these drivers did not manage to put it's devices into low power state at system suspend, which then this patchset intend to fix. Both the drivers and the amba bus converts to the new

Re: [GIT PULL] MMC updates for mmc-next for 3.14, take 1

2014-02-04 Thread Ulf Hansson
On 16 January 2014 11:55, Ulf Hansson ulf.hans...@linaro.org wrote: On 15 January 2014 15:28, Chris Ball ch...@printf.net wrote: Hi Ulf, On Tue, Jan 14 2014, Ulf Hansson wrote: Any thoughts on this pull request? Sorry for the delay -- I'm a little worried about these and would like lots of

Re: [PATCH v8 0/3] mmc: sdhci-msm: Add support for Qualcomm chipsets

2014-02-04 Thread Georgi Djakov
Hi Christopher, On 02/04/2014 03:19 PM, Christopher Covington wrote: Hi Georgi, On 01/30/2014 01:45 PM, Georgi Djakov wrote: This patchset adds basic support of the Secure Digital Host Controller Interface compliant controller found in Qualcomm chipsets. Tested with eMMC and various micro SD

Re: [PATCH 08/17] spi: pl022: Fully gate clocks at request inactivity

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 04:58:49PM +0100, Ulf Hansson wrote: Use clk_disable_unprepare and clk_prepare_enable from the runtime PM callbacks, to fully gate|ungate clocks. Potentially this will save more power, depending on the clock tree for the current SOC. The same patch has already been

Re: [PATCH 00/17] amba: PM fixups for amba bus and some amba drivers

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 04:58:41PM +0100, Ulf Hansson wrote: The fixes for the amba bus needs to be merged prior to the other, thus I think it could make sense to merge this complete patchset through Russell's tree, if he and the other maintainers think this is okay. What are the actual

Re: [PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 04:58:48PM +0100, Ulf Hansson wrote: @@ -2328,8 +2300,23 @@ static int pl022_suspend(struct device *dev) return ret; } - pm_runtime_get_sync(dev); - pl022_suspend_resources(pl022, false); + pm_runtime_disable(dev); + + if

Re: [PATCH 09/17] spi: pl022: Simplify clock handling

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 04:58:50PM +0100, Ulf Hansson wrote: Make use of clk_prepare_enable and clk_disable_unprepare to simplify code. No functional change. I went ahead and applied this since it looks good and seems like an unrelated cleanup to the runtime PM stuff which seems to be where the

Re: [PATCH 10/17] spi: pl022: Remove redundant pinctrl to default state in probe

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 04:58:51PM +0100, Ulf Hansson wrote: The driver core is now taking care of putting our pins into default state at probe. Thus we can remove the redundant call for it in probe. I applied this one too, as with the last patch it looks independant of the runtime PM stuff.

Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend

2014-02-04 Thread Kevin Hilman
Ulf Hansson ulf.hans...@linaro.org writes: Due to the available runtime PM callbacks, we are now able to put our device into low power state at system suspend. Earlier we could not accomplish this without trusting a power domain for the device to take care of it. Now we are able to cope with

[PATCH v2 5/6] ARM: dts: sun4i: Add support for mmc

2014-02-04 Thread David Lanzendörfer
--- arch/arm/boot/dts/sun4i-a10-a1000.dts |8 arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8 arch/arm/boot/dts/sun4i-a10.dtsi | 54 3 files changed, 70 insertions(+) diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts

[PATCH v2 1/6] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-04 Thread David Lanzendörfer
This is based on the driver Allwinner ships in the Android kernel sources. Initial porting to upstream kernels done by David Lanzendörfer, additional fixes and cleanups by Hans de Goede. It uses dma in bus-master mode using a built-in designware idmac controller, which is identical to the one

[PATCH v2 3/6] ARM: sunxi: clk: export clk_sunxi_mmc_phase_control

2014-02-04 Thread David Lanzendörfer
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com --- include/linux/clk/sunxi.h | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 include/linux/clk/sunxi.h diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h

[PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-04 Thread David Lanzendörfer
Hello The following patchset adds support for the SD/MMC host found in the Allwinner SoCs. It contains all the necessary modifications for clock environment and also the device tree script modification which add it to all the boards using it. The clock environment function needed for phase

[PATCH v2 4/6] ARM: dts: sun7i: Add support for mmc

2014-02-04 Thread David Lanzendörfer
--- arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++ arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++ arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23 + arch/arm/boot/dts/sun7i-a20.dtsi| 61 +++ 4 files changed, 100

[PATCH v2 2/6] clk: sunxi: Implement MMC phase control

2014-02-04 Thread David Lanzendörfer
From: Emilio López emi...@elopez.com.ar Signed-off-by: Emilio López emi...@elopez.com.ar --- drivers/clk/sunxi/clk-sunxi.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index

[PATCH v2 6/6] ARM: dts: sun5i: Add support for mmc

2014-02-04 Thread David Lanzendörfer
--- arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++ arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++ arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 15 arch/arm/boot/dts/sun5i-a13-olinuxino.dts| 15

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-04 Thread David Lanzendörfer
Hi I forgot to mention that the autoparenting patch of Emilios is a crucial depency... http://git.o2s.ch/?p=linux-next.git;a=commit;h=f8e936772672a3a6ec934558d2a7aef030c663c4 Without it, the clock will return the wrong value and the card will refuse to initialize regards david signature.asc

[RESEND PATCHv4] mmc: dw_mmc: Enable the hold reg for certain speed modes

2014-02-04 Thread dinguyen
From: Dinh Nguyen dingu...@altera.com This patch will enable the SDMMC_CMD_USE_HOLD_REG bit when the slot is operating all timing modes, except for SDR50, DDR50, SDR104, and MMC_HS200. According to the Synopsys databook :To meet the relatively high Input Hold Time requirement for SDR12, SDR25,

[PATCH RESEND] mmc: sdhci-bcm-kona: Add basic use of clocks

2014-02-04 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org Reviewed-by: Christian Daudt