Re: [PATCH] ARM: shmobile: bockw: use wp-gpios instead of WP pin

2014-02-05 Thread Simon Horman
On Mon, Feb 03, 2014 at 05:32:08PM -0800, Kuninori Morimoto wrote: > > Hi Simon > > > > Latest Renesas Chip has some SDHI channels and the WP pin > > > availability depends on its channel or HW implementation. > > > Thus, this patch decides new policy whch indicates > > > WP is disabled as defaul

[PATCH RESEND] mmc:sdhci: handle busy-end interrupt during command

2014-02-05 Thread Chanho Min
It is fully legal for a controller to start handling busy-end interrupt before it has signaled that the command has completed. So make sure we do things in the proper order, Or it results that command interrupt is ignored so it can cause unexpected operations. This is founded at some toshiba emmc w

Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend

2014-02-05 Thread Kevin Hilman
Linus Walleij writes: > On Tue, Feb 4, 2014 at 8:22 PM, Kevin Hilman wrote: >> Ulf Hansson writes: >> >>> Due to the available runtime PM callbacks, we are now able to put our >>> device into low power state at system suspend. > (...) >> I'm trying to thing of a good reason to not make PM_SLEEP

Re: [PATCH v3 0/7] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread David Lanzendörfer
As Maxime has pointed out, I've forgotten to add a changelog in my coverletter. Here is, what has changed in this revision: Changes since v1: -Using mmc_of_parse instead of diy dt parsing -Adding nodes for all mmc controller to the dtsi files, including sofar unused controllers -Using generic GP

Re: How to support SDIO wifi/bt in DT

2014-02-05 Thread Mark Brown
On Fri, Jan 17, 2014 at 11:44:23AM +0100, Andrew Lunn wrote: > I've not looked at regulators, but i would hope it also does reference > counting of a regulators users. Yes, it does. signature.asc Description: Digital signature

Re: [PATCHv9 1/4] clk: socfpga: Add a clk-phase property to the "altr, socfpga-gate-clk"

2014-02-05 Thread Dinh Nguyen
On Wed, 2014-02-05 at 08:03 -0800, Mike Turquette wrote: > Quoting Dinh Nguyen (2014-01-15 04:36:52) > > Hi Mike, > > > > Can you apply this to your clk tree? > > The patch looks good to me, but I think it depends on your pending pull > request. Can you add this to that pull request and rebase it

Re: [PATCHv9 1/4] clk: socfpga: Add a clk-phase property to the "altr, socfpga-gate-clk"

2014-02-05 Thread Mike Turquette
Quoting Dinh Nguyen (2014-01-15 04:36:52) > Hi Mike, > > Can you apply this to your clk tree? The patch looks good to me, but I think it depends on your pending pull request. Can you add this to that pull request and rebase it to 3.14-rc1? Thanks, Mike > > Thanks, > Dinh > -- To unsubscribe f

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread Hans de Goede
Hi David, On 02/05/2014 02:01 PM, David Lanzendörfer wrote: Hi Maxime I have four comments here: - Read Documentation/SubmittingPatches, especially Section 5 and 12 (hints, you forgot the clock maintainers for your clock patches and you didn't put any signed-off-by tags) Oops. I a

Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-05 Thread Fabio Estevam
On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson wrote: > +static int nmk_i2c_runtime_resume(struct device *dev) > +{ > + struct amba_device *adev = to_amba_device(dev);, > + struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev); > + > + clk_prepare_enable(nmk_i2c->clk); Previously t

Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM

2014-02-05 Thread Linus Walleij
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > Since the device is active while a successful probe has been completed, > the reference counting for the clock will be screwed up and never reach > zero. > > The issue is resolved by implementing runtime PM callbacks and let them > handle the r

Re: [PATCH 11/17] i2c: nomadik: Convert to devm functions

2014-02-05 Thread Linus Walleij
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > Use devm_* functions to simplify code and error handling. > > Cc: Alessandro Rubini > Cc: Linus Walleij > Cc: Wolfram Sang > Signed-off-by: Ulf Hansson Acked-by: Linus Walleij However make sure this (and the rest) applies on top of this

Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend

2014-02-05 Thread Mark Brown
On Wed, Feb 05, 2014 at 01:49:49PM +0100, Linus Walleij wrote: > On Tue, Feb 4, 2014 at 8:22 PM, Kevin Hilman wrote: > > I'm trying to thing of a good reason to not make PM_SLEEP depend on > > PM_RUNTIME for platforms like this. > Isn't the typical Android platform using PM_SLEEP without using >

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-05 Thread Nishanth Menon
On Wed 05 Feb 2014 08:10:34 AM CST, Balaji T K wrote: > On Tuesday 04 February 2014 08:48 PM, Nishanth Menon wrote: >> On 02/04/2014 06:44 AM, Balaji T K wrote: >>> On Tuesday 21 January 2014 04:59 AM, Nishanth Menon wrote: When device is booted using devicetree, platforms impacted by Err

Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot

2014-02-05 Thread Balaji T K
On Tuesday 04 February 2014 08:48 PM, Nishanth Menon wrote: On 02/04/2014 06:44 AM, Balaji T K wrote: On Tuesday 21 January 2014 04:59 AM, Nishanth Menon wrote: When device is booted using devicetree, platforms impacted by Erratum 2.1.1.128 is not detected easily in the mmc driver. This erratum

[RESEND PATCHv9] mmc: dw_mmc-socfpga: Remove the SOCFPGA specific platform for dw_mmc

2014-02-05 Thread dinguyen
From: Dinh Nguyen It turns now that the only really platform specific code that is needed for SOCFPGA is using the SDMMC_CMD_USE_HOLD_REG in the prepare_command function. Since the Rockchip already has this functionality, re-use the code that is already in dw_mmc-pltfm.c. Signed-off-by: Dinh Ngu

[PATCH v3 6/7] ARM: dts: sun4i: Add support for mmc

2014-02-05 Thread David Lanzendörfer
Signed-off-by: David Lanzendörfer Signed-off-by: Hans de Goede --- arch/arm/boot/dts/sun4i-a10-a1000.dts |8 arch/arm/boot/dts/sun4i-a10-cubieboard.dts |8 arch/arm/boot/dts/sun4i-a10.dtsi | 54 3 files changed, 70 insertions(+) di

[PATCH v3 5/7] ARM: dts: sun7i: Add support for mmc

2014-02-05 Thread David Lanzendörfer
Signed-off-by: David Lanzendörfer Signed-off-by: Hans de Goede --- arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8 +++ arch/arm/boot/dts/sun7i-a20-cubietruck.dts |8 +++ arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 23 + arch/arm/boot/dts/sun7i-a20.dtsi

[PATCH v3 3/7] ARM: sunxi: clk: export clk_sunxi_mmc_phase_control

2014-02-05 Thread David Lanzendörfer
From: Hans de Goede Signed-off-by: Hans de Goede --- include/linux/clk/sunxi.h | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 include/linux/clk/sunxi.h diff --git a/include/linux/clk/sunxi.h b/include/linux/clk/sunxi.h new file mode 100644 index 000..1e

[PATCH v3 7/7] ARM: dts: sun5i: Add support for mmc

2014-02-05 Thread David Lanzendörfer
Signed-off-by: David Lanzendörfer Signed-off-by: Hans de Goede --- arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 30 +++ arch/arm/boot/dts/sun5i-a10s.dtsi| 44 ++ arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 15 arch/arm/b

[PATCH v3 4/7] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-05 Thread David Lanzendörfer
This is based on the driver Allwinner ships in their Android kernel sources. Initial porting to upstream kernels done by David Lanzendörfer, additional fixes and cleanups by Hans de Goede. It uses dma in bus-master mode using a built-in designware idmac controller, which is identical to the one f

[PATCH v3 1/7] clk: sunxi: factors: automatic reparenting support

2014-02-05 Thread David Lanzendörfer
From: Emilio López This commit implements .determine_rate, so that our factor clocks can be reparented when needed. Signed-off-by: Emilio López --- drivers/clk/sunxi/clk-factors.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/clk/sunxi/clk-

[PATCH v3 2/7] clk: sunxi: Implement MMC phase control

2014-02-05 Thread David Lanzendörfer
From: Emilio López Signed-off-by: Emilio López --- drivers/clk/sunxi/clk-sunxi.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index abb6c5a..33b9977 100644 --- a/drivers/clk/sunxi/clk-sun

[PATCH v3 0/7] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread David Lanzendörfer
Hello The following patchset adds support for the SD/MMC host found in the Allwinner SoCs. It contains all the necessary modifications for clock environment and also the device tree script modification which add it to all the boards using it. The clock environment function needed for phase offset

Re: [PATCH 1/5] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-05 Thread David Lanzendörfer
Hi > I'm not that fond of these "default y" patterns. It forces the driver > down to every user of the multiplatform kernels. I'd suggest removing > the default and adding the driver to the defconfigs we have. Ok. Removed it. > > +static void sunxi_mmc_init_host(struct mmc_host *mmc) > > +{ > > [.

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread David Lanzendörfer
would be bloaty. That's why I've squashed them into small and corrected patches. > Looking forward for the next iteration! Good :-) You can have a look at the recent status here: http://git.o2s.ch/?p=linux-next.git;a=shortlog;h=refs/heads/20140205 cheers David signature.asc Description: This is a digitally signed message part.

Re: [PATCH 10/17] spi: pl022: Remove redundant pinctrl to default state in probe

2014-02-05 Thread Linus Walleij
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > The driver core is now taking care of putting our pins into default > state at probe. Thus we can remove the redundant call for it in probe. > > Cc: Mark Brown > Signed-off-by: Ulf Hansson Acked-by: Linus Walleij Yours, Linus Walleij -- To

Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend

2014-02-05 Thread Linus Walleij
On Tue, Feb 4, 2014 at 8:22 PM, Kevin Hilman wrote: > Ulf Hansson writes: > >> Due to the available runtime PM callbacks, we are now able to put our >> device into low power state at system suspend. (...) > I'm trying to thing of a good reason to not make PM_SLEEP depend on > PM_RUNTIME for platf

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread Maxime Ripard
Hi David, On Tue, Feb 04, 2014 at 08:24:13PM +0100, David Lanzendörfer wrote: > Hello > The following patchset adds support for the SD/MMC host found in the > Allwinner SoCs. > It contains all the necessary modifications for clock environment and also > the device > tree script modification whic