Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-22 Thread Maxime Ripard
Hi Hans, (As a side note, your mailer just did something nasty with the wrapping which made the code snippets totally unreadable. I'm going to drop them.) On Wed, Feb 19, 2014 at 01:14:58PM +0100, Hans de Goede wrote: +wmb(); /* Ensure idma_des hit main mem before we start the idmac

Re: [PATCH v7 8/8] ARM: sunxi: Add documentation for driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-22 Thread Maxime Ripard
Hi David, On Sat, Feb 22, 2014 at 08:32:03AM +0100, David Lanzendörfer wrote: Ditto. Plus, this is not a mod0 clock. Yes it is! But maybe the formulation hasn't been clear enough... Technically, it's not, it has this phase controls features a mod0 clock doesn't have. You never talked about

Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-22 Thread Hans de Goede
Hi, On 02/22/2014 09:31 AM, Maxime Ripard wrote: snip This should be before the registration. Otherwise, you're racy. Nope, we only need this to get the data on sunxi_mmc_remove, everywhere else the data is found through the mmc-host struct. Still, if anyone makes a following patch using

[PATCH 1/2] mmc: mxcmmc: Convert to devm-* API

2014-02-22 Thread Alexander Shiyan
Replace existing resource handling in the driver with managed device resource, this ensures more consistent error values and simplifies error paths. Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- drivers/mmc/host/mxcmmc.c | 101 +- 1 file

[PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-02-22 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- drivers/mmc/host/mxcmmc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index 84d630e..86401c0 100644 --- a/drivers/mmc/host/mxcmmc.c +++

Re: [PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-02-22 Thread Fabio Estevam
On Sat, Feb 22, 2014 at 11:46 AM, Alexander Shiyan shc_w...@mail.ru wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- drivers/mmc/host/mxcmmc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c

Re: [PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-02-22 Thread Alexander Shiyan
Суббота, 22 февраля 2014, 11:51 -03:00 от Fabio Estevam feste...@gmail.com: On Sat, Feb 22, 2014 at 11:46 AM, Alexander Shiyan shc_w...@mail.ru wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- drivers/mmc/host/mxcmmc.c | 13 +++-- 1 file changed, 3 insertions(+), 10

Re: [PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-02-22 Thread Fabio Estevam
On Sat, Feb 22, 2014 at 11:57 AM, Alexander Shiyan shc_w...@mail.ru wrote: Суббота, 22 февраля 2014, 11:51 -03:00 от Fabio Estevam feste...@gmail.com: On Sat, Feb 22, 2014 at 11:46 AM, Alexander Shiyan shc_w...@mail.ru wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru ---

Re: [PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-02-22 Thread Alexander Shiyan
Суббота, 22 февраля 2014, 11:59 -03:00 от Fabio Estevam feste...@gmail.com: On Sat, Feb 22, 2014 at 11:57 AM, Alexander Shiyan shc_w...@mail.ru wrote: Суббота, 22 февраля 2014, 11:51 -03:00 от Fabio Estevam feste...@gmail.com: On Sat, Feb 22, 2014 at 11:46 AM, Alexander Shiyan

Re: [PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-02-22 Thread Fabio Estevam
On Sat, Feb 22, 2014 at 12:02 PM, Alexander Shiyan shc_w...@mail.ru wrote: but then you would get a warning saying that mxcmci_suspend/resume are defined by not used when CONFIG_PM_SLEEP=n Please see the patch first, this warnings is avoided by __maybe_unused attributes. Ok, I see it now

Re: [PATCH 1/2] mmc: mxcmmc: Convert to devm-* API

2014-02-22 Thread Arnd Bergmann
On Saturday 22 February 2014 18:46:11 Alexander Shiyan wrote: Replace existing resource handling in the driver with managed device resource, this ensures more consistent error values and simplifies error paths. Signed-off-by: Alexander Shiyan shc_w...@mail.ru Nice cleanup!

Re: [PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-02-22 Thread Arnd Bergmann
On Saturday 22 February 2014 12:05:43 Fabio Estevam wrote: On Sat, Feb 22, 2014 at 12:02 PM, Alexander Shiyan shc_w...@mail.ru wrote: but then you would get a warning saying that mxcmci_suspend/resume are defined by not used when CONFIG_PM_SLEEP=n Please see the patch first, this

Re: [PATCH 1/2] mmc: mxcmmc: Convert to devm-* API

2014-02-22 Thread Alexander Shiyan
Суббота, 22 февраля 2014, 16:37 +01:00 от Arnd Bergmann a...@arndb.de: On Saturday 22 February 2014 18:46:11 Alexander Shiyan wrote: Replace existing resource handling in the driver with managed device resource, this ensures more consistent error values and simplifies error paths.

[RESEND 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

2014-02-22 Thread Jarkko Nikula
I've sent these patches earlier early December. See http://www.spinics.net/lists/linux-mmc/msg23540.html Resending now as mmc.git is updated over v3.13-rc2-208-g8ecffd791448. No other changes than added Acked-by and Tested-by lines from Tony and Aaro. Note Jarkko Lavinen is not cc'ed since he no

[RESEND 5/7] mmc: omap: Convert to devm_ioremap_resource

2014-02-22 Thread Jarkko Nikula
Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen

[RESEND 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

2014-02-22 Thread Jarkko Nikula
Omap MMC driver initialization can cause a NULL pointer dereference in tasklet_hi_action on Nokia N810 if its miniSD cover is open during driver initialization. [1.07] Unable to handle kernel NULL pointer dereference at virtual address [1.08] pgd = c0004000 [

[RESEND 2/7] mmc: omap: Convert to devm_kzalloc

2014-02-22 Thread Jarkko Nikula
Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c

[RESEND 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

2014-02-22 Thread Jarkko Nikula
Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen

[RESEND 3/7] mmc: omap: Remove duplicate host-irq assignment

2014-02-22 Thread Jarkko Nikula
host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c

[RESEND 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host

2014-02-22 Thread Jarkko Nikula
Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen

[RESEND 7/7] mmc: omap: Add erase capability

2014-02-22 Thread Jarkko Nikula
This patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e (omap_hsmmc: add erase capability) that we disable the data timeout interrupt for erases. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com

Re: [PATCH 0/5][RESENT]mmc: sh_mobile_sdhi: DT update for R-Car

2014-02-22 Thread Chris Ball
Hi Morimoto-san, On Fri, Feb 21 2014, Kuninori Morimoto wrote: These are re-sent patches for R-Car, since there were no response. Basically, these clarifies chip dependent settings inside driver. These are based on mmc/mmc-next branch (7536d3f83aa42ba1a3b1c6b30c2b6d94a820cbb2) Thanks, I've

Re: [RESEND 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

2014-02-22 Thread Chris Ball
Hi Jarkko, On Sat, Feb 22 2014, Jarkko Nikula wrote: I've sent these patches earlier early December. See http://www.spinics.net/lists/linux-mmc/msg23540.html Resending now as mmc.git is updated over v3.13-rc2-208-g8ecffd791448. No other changes than added Acked-by and Tested-by lines from

Re: [PATCH] mmc: sdhci: add support for realtek rts5250

2014-02-22 Thread Chris Ball
Hi Micky, On Fri, Feb 21 2014, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn Add support for realtek rts5250 pci card reader. The card reader have some problem with DDR50 mode, so add a new quirks2 for broken ddr50. Signed-off-by: Micky Ching

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-22 Thread Chris Ball
Hi, On Fri, Feb 21 2014, Russell King - ARM Linux wrote: On Thu, Feb 20, 2014 at 04:48:58PM +0530, Viresh Kumar wrote: Nothing wrong in that, only right.. Do you want me to float a patch for this or you can get that done along with your series? I'll send a follow-up mini-series of five

Re: [PATCH v2 0/3] mmc: rtsx: fix bug and support nonblocking request

2014-02-22 Thread Chris Ball
Hi Micky, On Mon, Feb 17 2014, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn First we fix the card poweroff bug: the card power is not shutdown when sd/mmc card removed, this will make UHS-card failed to running in high speed mode if we insert the card

Re: [PATCH 1/3] mmc: core: Add DT bindings for SD card's UHS bus speed modes

2014-02-22 Thread Chris Ball
Hi Ulf, On Fri, Feb 14 2014, Ulf Hansson wrote: Provide the option to configure these speed modes per host, for those host driver's that can't distinguish this in runtime. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Thanks, pushed all 3/3 to mmc-next for 3.15. - Chris. -- Chris Ball

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-22 Thread Russell King - ARM Linux
On Sat, Feb 22, 2014 at 06:27:06PM +, Chris Ball wrote: Hi, On Fri, Feb 21 2014, Russell King - ARM Linux wrote: On Thu, Feb 20, 2014 at 04:48:58PM +0530, Viresh Kumar wrote: Nothing wrong in that, only right.. Do you want me to float a patch for this or you can get that done along

Re: [PATCH] MAINTAINERS: Add maintainer for the mmc subsystem

2014-02-22 Thread Chris Ball
Hi Ulf, On Tue, Feb 18 2014, Ulf Hansson wrote: Put myself as a (co)maintainer of the mmc subsystem to help out Chris Ball in a more official role. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- Chris, if you are happy having me as your co-maintainer, the plan from my side are to

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-22 Thread Chris Ball
Hi Russell, On Sat, Feb 22 2014, Russell King - ARM Linux wrote: I'll send a follow-up mini-series of five patches for it. It shouldn't depend all that much on the bigger series - and I think the first two patches could well do with going into -rc. Thanks. Since testing resources might