SDIO driver return -ENOSYS behaviour change?

2014-02-27 Thread Aaron Lu
Hi Ulf, I was tracking some SDIO suspend problem and came across this. As Neil mentioned here: http://lkml.org/lkml/2012/3/25/20 Quote: SDIO (and possible MMC in general) has a protocol where the suspend method can return -ENOSYS and this means There is no point in suspending, just turn me

Re: SDIO driver return -ENOSYS behaviour change?

2014-02-27 Thread Ulf Hansson
On 27 February 2014 10:10, Aaron Lu aaron...@intel.com wrote: Hi Ulf, I was tracking some SDIO suspend problem and came across this. As Neil mentioned here: http://lkml.org/lkml/2012/3/25/20 Quote: SDIO (and possible MMC in general) has a protocol where the suspend method can return

Re: SDIO driver return -ENOSYS behaviour change?

2014-02-27 Thread Aaron Lu
On 02/27/2014 06:18 PM, Ulf Hansson wrote: On 27 February 2014 10:10, Aaron Lu aaron...@intel.com wrote: Hi Ulf, I was tracking some SDIO suspend problem and came across this. As Neil mentioned here: http://lkml.org/lkml/2012/3/25/20 Quote: SDIO (and possible MMC in general) has a

Re: SDIO driver return -ENOSYS behaviour change?

2014-02-27 Thread Ulf Hansson
On 27 February 2014 12:26, Aaron Lu aaron...@intel.com wrote: On 02/27/2014 06:18 PM, Ulf Hansson wrote: On 27 February 2014 10:10, Aaron Lu aaron...@intel.com wrote: Hi Ulf, I was tracking some SDIO suspend problem and came across this. As Neil mentioned here:

[PATCH 2/4] ARM: dove: prepare new Dove DT Kconfig variable

2014-02-27 Thread Sebastian Hesselbarth
DT-enabled Dove will move over from ARCH_DOVE in mach-dove to MACH_DOVE in mach-mvebu. As non-DT ARCH_DOVE will stay to rot for a while, add a new DT-only MACH_DOVE to mmc, thermal, wdt, and asoc Kconfigs. Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com --- Cc: Chris Ball

Re: [PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-02-27 Thread Tony Lindgren
* Andreas Fenkart afenk...@gmail.com [140225 04:46]: For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting anyways.

Re: [PATCH v7 2/4] mmc: omap_hsmmc: Remux SDIO pins within driver.

2014-02-27 Thread Tony Lindgren
* Andreas Fenkart afenk...@gmail.com [140225 04:49]: This is a preparation for the am335x workaround where we reconfigure dat1 as GPIO before going to suspend. If you don't specify active/idle pinctrl there should be no change. I've updated this too, hope it still works for you. And there's no

Re: [PATCH v7 3/4] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2014-02-27 Thread Tony Lindgren
* Andreas Fenkart afenk...@gmail.com [140225 04:51]: The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interrupts are detected with the GPIO, the GPIO will only wake the module from suspend, SDIO irq detection will

Re: [PATCH v7 4/4] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2014-02-27 Thread Tony Lindgren
* Andreas Fenkart afenk...@gmail.com [140225 04:57]: Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com No changes to this one, so: Acked-by: Tony Lindgren t...@atomide.com -- To

Re: [PATCH v7 2/4] mmc: omap_hsmmc: Remux SDIO pins within driver.

2014-02-27 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [140227 13:40]: * Andreas Fenkart afenk...@gmail.com [140225 04:49]: This is a preparation for the am335x workaround where we reconfigure dat1 as GPIO before going to suspend. If you don't specify active/idle pinctrl there should be no change. I've

Re: [PATCH 2/4] ARM: dove: prepare new Dove DT Kconfig variable

2014-02-27 Thread Sebastian Hesselbarth
On 02/27/2014 10:51 PM, Wim Van Sebroeck wrote: Acked-by me. Thanks Wim, as I forgot to explicitly ask for maintainer Acks: It would be great to get Acked-by's from mmc, thermal, and asoc, too. Sebastian DT-enabled Dove will move over from ARCH_DOVE in mach-dove to MACH_DOVE in mach-mvebu.

Re: [PATCH 2/4] ARM: dove: prepare new Dove DT Kconfig variable

2014-02-27 Thread Wim Van Sebroeck
Hi Sebastian, Acked-by me. Kind regards, Wim. DT-enabled Dove will move over from ARCH_DOVE in mach-dove to MACH_DOVE in mach-mvebu. As non-DT ARCH_DOVE will stay to rot for a while, add a new DT-only MACH_DOVE to mmc, thermal, wdt, and asoc Kconfigs. Signed-off-by: Sebastian Hesselbarth

Re: [PATCH 2/4] ARM: dove: prepare new Dove DT Kconfig variable

2014-02-27 Thread Mark Brown
On Thu, Feb 27, 2014 at 10:28:03PM +0100, Sebastian Hesselbarth wrote: DT-enabled Dove will move over from ARCH_DOVE in mach-dove to MACH_DOVE in mach-mvebu. As non-DT ARCH_DOVE will stay to rot for a while, add a new DT-only MACH_DOVE to mmc, thermal, wdt, and asoc Kconfigs. I'd be much

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-02-27 Thread Grant Grundler
Avi, thanks for posting this and apologies for not seeing/reviewing this earlier. Comments inline below. On Sun, Feb 9, 2014 at 1:07 AM, Avi Shchislowski avi.shchislow...@sandisk.com wrote: Add Support to Field Firmware Update (FFU) for eMMC v5.0 and up devices. The code implemented

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-02-27 Thread Grant Grundler
Sorry. Gmail isn't vi and accidentally sent this prematurely. /o\ Continuing the review comments... On Thu, Feb 27, 2014 at 6:12 PM, Grant Grundler grund...@chromium.org wrote: ... + +/* + * Map memory into a scatterlist. + */ +static int mmc_ffu_map_sg(struct mmc_ffu_mem *mem, unsigned long

Re: SDIO driver return -ENOSYS behaviour change?

2014-02-27 Thread Aaron Lu
On 02/27/2014 09:05 PM, Ulf Hansson wrote: On 27 February 2014 12:26, Aaron Lu aaron...@intel.com wrote: On 02/27/2014 06:18 PM, Ulf Hansson wrote: On 27 February 2014 10:10, Aaron Lu aaron...@intel.com wrote: Hi Ulf, I was tracking some SDIO suspend problem and came across this. As Neil