RE: [PATCH 3/7] mmc: dw_mmc: exynos: move definitions to header file

2014-03-23 Thread Seungwon Jeon
On Mon, March 24, 2014, Jaehoon Chung wrote: > Hi, Seungwon. > > On 03/21/2014 11:03 PM, Seungwon Jeon wrote: > > Moves some parts related to definition to header file > > > > Signed-off-by: Seungwon Jeon > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 46 --- > > dr

RE: [PATCH 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available

2014-03-23 Thread Seungwon Jeon
On Mon, March 24, 2014, Jaehoon Chung wrote: > Hi, Seungwon. > > On 03/21/2014 11:03 PM, Seungwon Jeon wrote: > > Adds checking whether the clock is valid. > > > > Signed-off-by: Seungwon Jeon > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 14 +++--- > > 1 files changed, 11 insertions(

Re: [PATCH V2] mmc: sdhci: don't read cd-gpio while holding spinlock

2014-03-23 Thread Adrian Hunter
On 24.03.2014 03:43, Andrew Bresticker wrote: > sdhci_request() and sdhci_card_event() read the cd-gpio via > mmc_gpio_get_cd(), which can sleep, while holding host->lock. > This may result in the following BUG: > > BUG: spinlock wrong CPU on CPU#2, kworker/u8:16/4296 > lock: 0xea6b9c80, .magi

Re: [PATCH V2] mmc: dw_mmc: exynos: Turn SDIO interrupts on

2014-03-23 Thread Yuvaraj Kumar
On Mon, Mar 24, 2014 at 9:59 AM, Jaehoon Chung wrote: > Hi, Yuvaraj. > > NACK. we can use "mmc_of_parese()". Thanks Jaehoon for the pointer.I will use "mmc_of_parse()". > > I have sent the patch that use "mmc_of_parse()". > https://patchwork.kernel.org/patch/3750681/ > > Best Regards, > Jaehoon Ch

Re: [PATCH] mmc: dw_mmc: Fix the max_blk_count in IDMAC

2014-03-23 Thread Yuvaraj Kumar
On Mon, Mar 24, 2014 at 9:36 AM, Jaehoon Chung wrote: > Hi, > > Did you know that Seungwon has sent the patch "[PATCH 1/7] mmc: dw_mmc: fix > the max_blk_count in IDMAC"? > I think this patch looks like same, isn't it? Yes.Its the same one.Please discard this patch. > Plz check it. > > Best Regar

Re: [PATCH V2] mmc: dw_mmc: exynos: Turn SDIO interrupts on

2014-03-23 Thread Jaehoon Chung
Hi, Yuvaraj. NACK. we can use "mmc_of_parese()". I have sent the patch that use "mmc_of_parse()". https://patchwork.kernel.org/patch/3750681/ Best Regards, Jaehoon Chung On 03/24/2014 01:23 PM, Yuvaraj Kumar C D wrote: > The mmc part in exynos supports SDIO interrupts and they work fine, so > t

[PATCH V2] mmc: dw_mmc: exynos: Turn SDIO interrupts on

2014-03-23 Thread Yuvaraj Kumar C D
The mmc part in exynos supports SDIO interrupts and they work fine, so turn the capability on. With this I see download speeds increase about 10x. This V1 of this patch is posted to LKML at https://patchwork.kernel.org/patch/2429661/) by Doug Anderson. Signed-off-by: Doug Anderson Sign

Re: [PATCH 3/7] mmc: dw_mmc: exynos: move definitions to header file

2014-03-23 Thread Jaehoon Chung
Hi, Seungwon. On 03/21/2014 11:03 PM, Seungwon Jeon wrote: > Moves some parts related to definition to header file > > Signed-off-by: Seungwon Jeon > --- > drivers/mmc/host/dw_mmc-exynos.c | 46 --- > drivers/mmc/host/dw_mmc-exynos.h | 55 > +

Re: [PATCH 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available

2014-03-23 Thread Jaehoon Chung
Hi, Seungwon. On 03/21/2014 11:03 PM, Seungwon Jeon wrote: > Adds checking whether the clock is valid. > > Signed-off-by: Seungwon Jeon > --- > drivers/mmc/host/dw_mmc-exynos.c | 14 +++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-e

Re: [PATCH] mmc: dw_mmc: Fix the max_blk_count in IDMAC

2014-03-23 Thread Jaehoon Chung
Hi, Did you know that Seungwon has sent the patch "[PATCH 1/7] mmc: dw_mmc: fix the max_blk_count in IDMAC"? I think this patch looks like same, isn't it? Plz check it. Best Regards, Jaehoon Chung On 03/24/2014 12:53 PM, Yuvaraj Kumar C D wrote: > From: Alim Akhtar > > max_blk_count is curren

[PATCH] mmc: dw_mmc: Fix the max_blk_count in IDMAC

2014-03-23 Thread Yuvaraj Kumar C D
From: Alim Akhtar max_blk_count is currently set incorrectly, and the correct value can be determined by looking at the maximum number of bytes which can be transferred and the block size. We use the maximum block size to determine the minimum number of blocks that the controller should support.

[PATCH V2] mmc: sdhci: don't read cd-gpio while holding spinlock

2014-03-23 Thread Andrew Bresticker
sdhci_request() and sdhci_card_event() read the cd-gpio via mmc_gpio_get_cd(), which can sleep, while holding host->lock. This may result in the following BUG: BUG: spinlock wrong CPU on CPU#2, kworker/u8:16/4296 lock: 0xea6b9c80, .magic: dead4ead, .owner: kworker/u8:16/4296, .owner_cpu: 0 C

[PATCH 2/2] mmc: rtsx: modify error handle and remove smatch warnings

2014-03-23 Thread micky_ching
From: Micky Ching Using non-DMA dump-regs, which would be more exactly for DMA transfer failed. More careful handle when cmd/data timeout, add stop(CMD12) cmd before go to finish request when multi-rw timeout. Remove some static checher warings. on commit: drivers/mmc/host/rtsx_pci_sdmmc.c:194

mmc: rtsx: add new cmd type handle and modify error handle

2014-03-23 Thread micky_ching
From: Micky Ching Add new command type(R1 without CRC) handle, without this patch mmc card initialize will be failed. Using a more careful handle in request timeout, this would improve error recover capability. Debug info is printed using non DMA mode, this would help print more accurately for D

[PATCH 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

2014-03-23 Thread micky_ching
From: Micky Ching commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a produced a cmd.flags unhandled in realtek pci host driver. This will make MMC card failed initialize, this patch is used to handle the new cmd.flags condition and MMC card can be used. Signed-off-by: Micky Ching --- drivers/mmc