Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Alexandre Courbot
On Tue, Apr 15, 2014 at 10:42 AM, Andrew Bresticker abres...@chromium.org wrote: If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but the corresponding regulator may not have probed). Instead of continuing

[PATCH] mmc: mmci: switch the driver to using gpio descriptors

2014-04-15 Thread Linus Walleij
The next step in modernization of GPIO is to let drivers handle descriptors rather than integer numbers representing GPIO pins, akin to how clocks or regulators are already handled today. This patch makes the MMCI driver use GPIO descriptos in the core code with fallback code using the platform

Re: [PATCH] mmc: mmci: switch the driver to using gpio descriptors

2014-04-15 Thread Alexander Shiyan
Tue, 15 Apr 2014 10:33:06 +0200 от Linus Walleij linus.wall...@linaro.org: The next step in modernization of GPIO is to let drivers handle descriptors rather than integer numbers representing GPIO pins, akin to how clocks or regulators are already handled today. This patch makes the MMCI

RE: [PATCH v2 4/7] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2014-04-15 Thread Seungwon Jeon
Hi Jaehoon, On Mon, April 14, 2014, Jaehoon Chung wrote: Hi, Seungwon. On 03/26/2014 08:31 PM, Seungwon Jeon wrote: ciu_div may not be common value for all speed mode. So, it needs to be attached to CLKSEL timing. Signed-off-by: Seungwon Jeon tgih@samsung.com ---

Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation

2014-04-15 Thread Axel Lin
2014-04-15 5:16 GMT+08:00 Mark Brown broo...@kernel.org: On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote: The is_enabled implementation is wrong in some cases: e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26) However, pbias_regulator_enable() only sets BIT(27) |

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-15 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson ulf.hans...@linaro.org wrote: I have seen some patches around lately touching the code for handling the regulators (vcc and vccq) in sdhci. Was it this patch you were thinking of or something else?

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Stephen Warren
On 04/14/2014 07:42 PM, Andrew Bresticker wrote: If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but the corresponding regulator may not have probed). Instead of continuing without the regulator, return

Re: [PATCH 4/4] ARM: tegra: fix Venice2 VQMMC regulators

2014-04-15 Thread Stephen Warren
On 04/14/2014 07:42 PM, Andrew Bresticker wrote: VDDIO_SDMMC3 is the VQMMC supply, not the VMMC supply, for the SD slot. Add 1.8V_VDDIO as the VQMMC supply for the eMMC. Is there documentation re: what vmmc-supply and vqmmc-supply actually refer to? I looked a long while ago and couldn't find

Re: [PATCH 2/4] mmc: tegra: fix reporting of base clock frequency

2014-04-15 Thread Stephen Warren
On 04/14/2014 07:42 PM, Andrew Bresticker wrote: Tegra SDHCI controllers, by default, report a base clock frequency of 208Mhz in SDHCI_CAPABILTIES which may or may not be equal to the actual base clock frequency. Some explanation of why this may or may not be equal to the actual base clock

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Tim Kryger
On Mon, Apr 14, 2014 at 6:42 PM, Andrew Bresticker abres...@chromium.org wrote: If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but the corresponding regulator may not have probed). Instead of continuing

Re: [PATCH 4/4] ARM: tegra: fix Venice2 VQMMC regulators

2014-04-15 Thread Chris Ball
Hi Stephen, On Tue, Apr 15 2014, Stephen Warren wrote: Is there documentation re: what vmmc-supply and vqmmc-supply actually refer to? I looked a long while ago and couldn't find any, and didn't get an answer when I asked. Neither

Re: [PATCH 2/4] mmc: tegra: fix reporting of base clock frequency

2014-04-15 Thread Andrew Bresticker
On Tue, Apr 15, 2014 at 11:25 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 04/14/2014 07:42 PM, Andrew Bresticker wrote: Tegra SDHCI controllers, by default, report a base clock frequency of 208Mhz in SDHCI_CAPABILTIES which may or may not be equal to the actual base clock frequency.

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Andrew Bresticker
On Tue, Apr 15, 2014 at 12:03 PM, Tim Kryger tim.kry...@linaro.org wrote: On Mon, Apr 14, 2014 at 6:42 PM, Andrew Bresticker abres...@chromium.org wrote: If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Andrew Bresticker
On Tue, Apr 15, 2014 at 11:28 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 04/14/2014 07:42 PM, Andrew Bresticker wrote: If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but the corresponding regulator

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Russell King - ARM Linux
On Tue, Apr 15, 2014 at 12:59:37PM -0700, Andrew Bresticker wrote: I believe the crash Alex is seeing is due to a race between tearing down the sdhci driver on probe deferral and the card-detect IRQ. Looking at it now. You probably want to check out my massive sdhci patch set posted a while

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Andrew Bresticker
On Mon, Apr 14, 2014 at 11:06 PM, Alexandre Courbot gnu...@gmail.com wrote: On Tue, Apr 15, 2014 at 10:42 AM, Andrew Bresticker abres...@chromium.org wrote: If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but

Re: [PATCH 4/4] ARM: tegra: fix Venice2 VQMMC regulators

2014-04-15 Thread Andrew Bresticker
sdhci@0,700b0600 { status = okay; bus-width = 8; + vqmmc-supply = vddio_1v8; It turns out this bit isn't needed as the initialization failures are instead due to +3V3_RUN toggling, which Stephen has fixed:

[PATCH] mmc: rtsx: fix possible circular locking dependency

2014-04-15 Thread micky_ching
From: Micky Ching micky_ch...@realsil.com.cn To avoid dead lock, we need make sure host-lock is always acquire before pcr-lock. But in irq handler, we acquired pcr-lock in rtsx mfd driver, and sd_isr_done_transfer() is called during pcr-lock already acquired. Since in sd_isr_done_transfer() the

Re: [PATCH v7 0/4] Add modules for realtek USB card reader

2014-04-15 Thread Roger
On 04/11/2014 06:36 PM, Oliver Neukum wrote: On Fri, 2014-04-11 at 11:28 +0100, Lee Jones wrote: From: Roger Tseng rogera...@realtek.com This patchset adds modules to support Realtek USB vendor specific class flash card reader: one base module in MFD subsystem and two host modules in both mmc

Re: [PATCH v2 4/7] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2014-04-15 Thread Jaehoon Chung
Hi, Seungwon. On 04/15/2014 08:03 PM, Seungwon Jeon wrote: Hi Jaehoon, On Mon, April 14, 2014, Jaehoon Chung wrote: Hi, Seungwon. On 03/26/2014 08:31 PM, Seungwon Jeon wrote: ciu_div may not be common value for all speed mode. So, it needs to be attached to CLKSEL timing.