Hi Tim,
> It is important that callers of mmc_regulator_get_supply know if either
> vmmc or vqmmc are present but not yet available. To support this need,
> modify this function to return zero except when either of the regulator
> get operations fail with -EPROBE_DEFER. Current callers don't che
It is important that callers of mmc_regulator_get_supply know if either
vmmc or vqmmc are present but not yet available. To support this need,
modify this function to return zero except when either of the regulator
get operations fail with -EPROBE_DEFER. Current callers don't check the
return val
On Fri, Apr 25, 2014 at 02:15:30PM +0100, Russell King - ARM Linux wrote:
> On Fri, Apr 25, 2014 at 03:08:49PM +0200, Markus Pargmann wrote:
> > I just tried the different parts of the patch. Without the following
> > change, emmc works:
> >
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc
We no longer need to emulate the uhs_mode field of the host control2
register - the main sdhci driver never reads this back to evaluate
the current mode as it caches the current mode instead.
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci-esdhc-imx.c | 17 +++--
1 file change
We don't need these hooks in order to insert code in these paths, we
can just provide our own handlers and call the main sdhci handlers as
appropriate.
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci-of-esdhc.c | 55 +--
1 file changed, 36 insertions(+)
Move the regulator handling into sdhci_set_power() rather than being in
sdhci_do_set_ios(). This wraps all power control up into this function.
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci.c | 72 +++-
1 file changed, 35 insertions(+), 37 de
Track whether preset mode is currently enabled in hardware, and use that
when making decisions elsewhere in the code rather than reading the
register and checking the bit.
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci.c | 44 ++--
include/linux/m
Move the remaining parts of the power handling in sdhci_do_set_ios()
into sdhci_set_power().
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 956
The set_uhs_signaling() method gives the impression that it can fail,
but anything returned from the method is entirely ignored by the sdhci
driver. So returning failure has no effect.
So, kill the idea that it's possible for this to return an error by
removing the returned value.
Signed-off-by:
Clean up the code in sdhci_execute_tuning() so the decision whether
to execute tuning is clearer - and despite this reflecting what the
original code was doing, it shows that it may not be what the author
actually intended.
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci.c | 31 ++
The only user (sdhci-of-esdhc) no longer uses these callbacks, so lets
remove them to discourage any further use.
Acked-by: Ulf Hansson
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci.c | 6 --
drivers/mmc/host/sdhci.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/drivers/mmc
sdhci-tegra provides a get_ro method, which overrides the checking
of the write protect bit in the PRESENT_STATE register in sdhci.c:
if (host->flags & SDHCI_DEVICE_DEAD)
is_readonly = 0;
else if (host->ops->get_ro)
is_readonly = host->ops->get_ro(ho
Signed-off-by: Russell King
---
drivers/mmc/host/Kconfig | 63
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 8aaf8c1f3f63..d8c1f31ab37f 100644
--- a/drivers/mmc/host/Kconfi
Add sdhci_set_uhs_signaling() and always call the set_uhs_signaling
method. This avoids quirks being added into sdhci_set_uhs_signaling().
Signed-off-by: Russell King
---
drivers/mmc/host/sdhci-acpi.c | 2 ++
drivers/mmc/host/sdhci-bcm-kona.c | 1 +
drivers/mmc/host/sdhci-bcm2835.c |
Rather than reading back the timing information from the registers,
cache it locally. This allows implementations to translate the UHS
timing by overriding the set_uhs_signaling() method as required
without also having to emulate the SDHCI_HOST_CONTROL2 register.
Signed-off-by: Russell King
---
On Fri, Apr 25, 2014 at 02:15:30PM +0100, Russell King - ARM Linux wrote:
> On Fri, Apr 25, 2014 at 03:08:49PM +0200, Markus Pargmann wrote:
> > I just tried the different parts of the patch. Without the following
> > change, emmc works:
> >
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc
On Fri, Apr 25, 2014 at 03:08:49PM +0200, Markus Pargmann wrote:
> I just tried the different parts of the patch. Without the following
> change, emmc works:
>
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1507,12 +1507,6 @@ static void sdhci_do_set_ios(struct sdhci_host
On Fri, Apr 25, 2014 at 01:49:45PM +0100, Russell King - ARM Linux wrote:
> On Fri, Apr 25, 2014 at 02:38:20PM +0200, Markus Pargmann wrote:
> > Hi,
> >
> > On Wed, Apr 23, 2014 at 08:07:57PM +0100, Russell King wrote:
> > > Patch suggested by Dong Aisheng , this avoids
> > > additional clock star
On Fri, Apr 25, 2014 at 02:38:20PM +0200, Markus Pargmann wrote:
> Hi,
>
> On Wed, Apr 23, 2014 at 08:07:57PM +0100, Russell King wrote:
> > Patch suggested by Dong Aisheng , this avoids
> > additional clock start/stop cycles during the transition to 1.8V
> > signalling mode.
> >
> > Signed-off-b
Hi,
On Wed, Apr 23, 2014 at 08:07:57PM +0100, Russell King wrote:
> Patch suggested by Dong Aisheng , this avoids
> additional clock start/stop cycles during the transition to 1.8V
> signalling mode.
>
> Signed-off-by: Russell King
I tested the series on imx6s with a RIoT board. With this patch
On 25 April 2014 13:20, Russell King - ARM Linux wrote:
> On Fri, Apr 25, 2014 at 01:18:28PM +0200, Ulf Hansson wrote:
>> On 25 April 2014 11:03, Russell King - ARM Linux
>> wrote:
>> > On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote:
>> >> On 24 April 2014 12:57, Russell King - ARM
On Fri, Apr 25, 2014 at 01:18:28PM +0200, Ulf Hansson wrote:
> On 25 April 2014 11:03, Russell King - ARM Linux
> wrote:
> > On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote:
> >> On 24 April 2014 12:57, Russell King - ARM Linux
> >> wrote:
> >> > This is nothing new or unexpected -
On 25 April 2014 11:03, Russell King - ARM Linux wrote:
> On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote:
>> On 24 April 2014 12:57, Russell King - ARM Linux
>> wrote:
>> > This is nothing new or unexpected - it was last posted back in February,
>> > and I elected that it should be
On Wed, Apr 16, 2014 at 09:13:52AM +0100, Lee Jones wrote:
> It seems Max and Alex are less than interested in this patch, so I'm
> going to apply it anyway. In your last review you mentioned that it
> looked good to your inexpert eye. Can I apply your Ack to that effect?
>
Just apply it... He s
On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote:
> On 24 April 2014 12:57, Russell King - ARM Linux
> wrote:
> > This is nothing new or unexpected - it was last posted back in February,
> > and I elected that it should be held off until after the last merge
> > window.
> >
> > Unfortu
On 24 April 2014 23:44, Tim Kryger wrote:
> The eMMC signalling voltage is determined by VCCQ which is provided to
> the card by the host. Signalling is not required to begin at 3.3v and,
> if the host and card both support a particular VCC/VCCQ combination, it
> can be used immediately.
>
> In c
On 25 April 2014 00:36, Tim Kryger wrote:
> Switch the common SDHCI code over to use mmc_host's regulator pointers
> and remove the ones in the sdhci_host structure. Additionally, use the
> common mmc_regulator_get_supply function to get the regulators and set
> the ocr_avail mask.
>
> This chang
On 04/16/2014 04:13 PM, Lee Jones wrote:
Hi Andrew,
From: Roger Tseng
Realtek USB memstick host driver provides memstick host support based on the
Realtek USB card reader MFD driver.
Signed-off-by: Roger Tseng
---
drivers/memstick/host/Kconfig | 10 +
drivers/memstick/host/Makefi
28 matches
Mail list logo
