Re: [PATCH v10 15/15] ARM: dts: sun7i: Add basic support for the Cubietruck WiFi module

2014-05-05 Thread Maxime Ripard
On Fri, May 02, 2014 at 05:57:29PM +0200, Hans de Goede wrote: > From: Chen-Yu Tsai > > The CubieTruck has an AMPAK AP6210 WiFi+Bluetooth module. The WiFi > part is a BCM43362 IC connected to MMC3 in the A20 SoC via SDIO. > The IC also takes a power enable signal via GPIO. > > The WiFi module su

Re: [PATCH v10 15/15] ARM: dts: sun7i: Add basic support for the Cubietruck WiFi module

2014-05-05 Thread Maxime Ripard
On Mon, May 05, 2014 at 12:20:56PM +0800, Chen-Yu Tsai wrote: > On Mon, May 5, 2014 at 12:02 PM, Maxime Ripard > wrote: > > On Fri, May 02, 2014 at 05:57:29PM +0200, Hans de Goede wrote: > >> From: Chen-Yu Tsai > >> > >> The CubieTruck has an AMPAK AP6210 WiFi+Bluetooth module. The WiFi > >> part

Re: TRIM timeout calculation

2014-05-05 Thread Ulf Hansson
On 5 May 2014 18:55, Joakim Tjernlund wrote: > I got a Micron eMMC 4.41 memory and I am trying to use the TRIM function. > my EXT_CSD_TRIM_MULT is 15 which gets me a tmo of 15*300=4500 ms > Then in mmc_calc_max_discard() I have: > max_discard = mmc_do_calc_max_discard(card, MMC_ERASE_ARG)

Re: [PATCH v10 03/15] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-05-05 Thread Ulf Hansson
[snip] > On 05/05/2014 02:41 PM, Ulf Hansson wrote: >>> +struct sunxi_mmc_host { >>> + struct mmc_host *mmc; >>> + struct regulator *vmmc; >> >> Instead of having a specific regulator for this driver, please use the >> mmc_regulator_get_supply API. > > We cannot use mmc_regulator_get_s

TRIM timeout calculation

2014-05-05 Thread Joakim Tjernlund
I got a Micron eMMC 4.41 memory and I am trying to use the TRIM function. my EXT_CSD_TRIM_MULT is 15 which gets me a tmo of 15*300=4500 ms Then in mmc_calc_max_discard() I have: max_discard = mmc_do_calc_max_discard(card, MMC_ERASE_ARG); if (mmc_can_trim(card)) { ma

Re: [PATCH v10 03/15] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-05-05 Thread Hans de Goede
Hi, Thanks for the review, I will fix most of the issues you've pointed out, but I've what I believe are good reasons for doing things as they are done in some other places. For details see below. Even if you agree with everything I've written below please send me a reply along those lines, as I

Re: [PATCH v10 03/15] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-05-05 Thread Ulf Hansson
On 2 May 2014 17:57, Hans de Goede wrote: > From: David Lanzendörfer > > The Allwinner sunxi mmc host uses dma in bus-master mode using a built-in > designware idmac controller, which is identical to the one found in the mmc-dw > hosts. However the rest of the host is not identical to mmc-dw, it

Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-05-05 Thread Ulf Hansson
On 29 April 2014 09:36, Ulf Hansson wrote: > On 29 April 2014 03:54, wrote: >> From: Micky Ching >> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. >> >> commit did use >> mutex_unlock() in tasklet, but mutex_unlock() can't used in >> tasklet(atomic context). The driver need u

Re: [PATCH] mmc: mxs: fix card detection function for broken card detect

2014-05-05 Thread Ulf Hansson
On 28 April 2014 11:36, Sascha Hauer wrote: > On Mon, Apr 28, 2014 at 11:31:03AM +0200, Ulf Hansson wrote: >> On 28 April 2014 11:13, Sascha Hauer wrote: >> > On Sat, Apr 19, 2014 at 11:59:18PM +0200, Daniel Willmann wrote: >> >> Return -ENOSYS in get_cd if broken-cd is specified in the device tr

Re: [PATCH 1/6] mmc: drop the speed mode of card's state

2014-05-05 Thread Ulf Hansson
On 23 April 2014 10:07, Seungwon Jeon wrote: > Timing mode identifier has same role and can take the place > of speed mode. This change removes all related speed mode. > > Signed-off-by: Seungwon Jeon > Tested-by: Jaehoon Chung > Acked-by: Jaehoon Chung > Signed-off-by: Ulf Hansson > Signed-of