[PATCH 1/1] mmc: moxart: Remove unneeded version.h inclusion

2014-05-21 Thread Sachin Kamat
version.h inclusion is not needed as suggested by versioncheck. Signed-off-by: Sachin Kamat Cc: Jonas Jensen --- drivers/mmc/host/moxart-mmc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c index 74924a04026e..b4b1efbf6c16 100

Re: mmc: moxart: Add MOXA ART SD/MMC driver

2014-05-21 Thread Jonas Jensen
On 21 May 2014 14:28, Dan Carpenter wrote: > Hello Jonas Jensen, > > The patch 1b66e94e6b99: "mmc: moxart: Add MOXA ART SD/MMC driver" > from Apr 9, 2014, leads to the following static checker warning: > > drivers/mmc/host/moxart-mmc.c:691 moxart_remove() > warn: variable dereferen

Re: mmc: moxart: Add MOXA ART SD/MMC driver

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 15:28:25 Dan Carpenter wrote: > Hello Jonas Jensen, > > The patch 1b66e94e6b99: "mmc: moxart: Add MOXA ART SD/MMC driver" > from Apr 9, 2014, leads to the following static checker warning: > > drivers/mmc/host/moxart-mmc.c:691 moxart_remove() > warn: varia

re: mmc: moxart: Add MOXA ART SD/MMC driver

2014-05-21 Thread Dan Carpenter
Hello Jonas Jensen, The patch 1b66e94e6b99: "mmc: moxart: Add MOXA ART SD/MMC driver" from Apr 9, 2014, leads to the following static checker warning: drivers/mmc/host/moxart-mmc.c:691 moxart_remove() warn: variable dereferenced before check 'mmc' (see line 687) drivers/mmc/host/

Re: [PATCH] mmc: omap_hsmmc: use IS_ERR macro for error checking

2014-05-21 Thread Ulf Hansson
On 15 May 2014 15:23, Balaji T K wrote: > Debounce clock is optional, use IS_ERR macro instead of NULL pointer check. > > Signed-off-by: Balaji T K Thanks Balaji, I will include this in the next PR I send to Chris. Kind regards Ulf Hansson -- To unsubscribe from this list: send the line "unsub

Re: [PATCH v2 0/6] mmc: omap_hsmmc: convert to use devm_* and fixes

2014-05-21 Thread Ulf Hansson
On 9 May 2014 18:46, Balaji T K wrote: > v2: > use devm_ioremap_resource > add cmd23 multiblock read/write fix > > Balaji T K (6): > mmc: omap_hsmmc: use devm_clk_get > mmc: omap_hsmmc: use devm_request_irq > mmc: omap_hsmmc: use devm_request_threaded_irq > mmc: omap_hsmmc: use devm_iorema

Re: [PATCH v2] s3cmci: port DMA code to dmaengine API

2014-05-21 Thread Vasily Khoruzhick
On Wed, May 21, 2014 at 11:57 AM, Arnd Bergmann wrote: > On Tuesday 20 May 2014 23:20:59 Vasily Khoruzhick wrote: >> index 1384f67..e70e4cf 100644 >> --- a/drivers/mmc/host/Kconfig >> +++ b/drivers/mmc/host/Kconfig >> @@ -420,6 +420,7 @@ config MMC_SPI >> config MMC_S3C >> tristate "Samsu

RE: [PATCH v2] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-21 Thread Seungwon Jeon
On Wed, May 21, 2014, Doug Anderson wrote: > If we happened to get a data error at just the wrong time the dw_mmc > driver could get into a state where it would never complete its > request. That would leave the caller just hanging there. > > We fix this two ways and both of the two fixes on thei

RE: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-21 Thread Seungwon Jeon
On Wed, May 21, 2014, Doug Anderson wrote: > Seungwon, > > On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon wrote: > >> > >> >> + } else { > >> > >> >> + /* > >> > >> >> +* If we don't have a command > >> > >> >> c

Re: [PATCH v2] s3cmci: port DMA code to dmaengine API

2014-05-21 Thread Arnd Bergmann
On Tuesday 20 May 2014 23:20:59 Vasily Khoruzhick wrote: > index 1384f67..e70e4cf 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -420,6 +420,7 @@ config MMC_SPI > config MMC_S3C > tristate "Samsung S3C SD/MMC Card Interface support" > depends on ARCH_