Re: [linux-sunxi] [PATCH v2 1/4] dt: bindings: mmc: Document the practice of using subnodes for slots

2014-06-01 Thread Sascha Hauer
On Sun, Jun 01, 2014 at 11:23:48AM +0200, Hans de Goede wrote: > Hi, > > >Neither seems to actually ever have been used with > >more than one slot. I doubt anyone building an exynos-based system > >will ever do a multi-slot solution, and it seems that the at91 driver > >doesn't actually handle mor

Re: [PATCH 1/5] mmc: sdhci-esdhc-imx: add f_max field to private data

2014-06-01 Thread Sascha Hauer
On Sun, Jun 01, 2014 at 03:45:43PM +0800, Shawn Guo wrote: > > @@ -594,7 +592,7 @@ static inline void esdhc_pltfm_set_clock(struct > > sdhci_host *host, > > { > > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > > struct pltfm_imx_data *imx_data = pltfm_host->priv; > > - unsign

Re: [PATCH v5 11/13] mmc: mmci: add explicit clk control

2014-06-01 Thread Srinivas Kandagatla
Thanks Russell, On 31/05/14 13:29, Russell King - ARM Linux wrote: >+ if ((host->variant->explicit_mclk_control) && >+ (ios->clock != host->clock_cache)) { Please explain what use these parens have (or just get rid of them as they're completely unnecessary - they do nothing for readabi

[PATCH v3] s3cmci: port DMA code to dmaengine API

2014-06-01 Thread Vasily Khoruzhick
Utilise new s3c24xx-dma dmaengine driver for DMA ops. Signed-off-by: Vasily Khoruzhick --- v2: - Don't store async dma descriptor, it's not used - Request DMA channel via dma_request_slave_channel_compat() and use hardcoded DMA channel. - Add dependency on S3C24XX_DMAC (s3cmci uses

Re: [PATCH 5/5] ARM: dts: imx51-babbage: Fix esdhc setup

2014-06-01 Thread Shawn Guo
On Fri, May 23, 2014 at 02:33:04PM +0200, Sascha Hauer wrote: > - Move cd/wp pinctrl from the hog group to the esdhc groups > - use gpio for card detection / write protection on esdhc2 since > the controller based detection does not work I tracked it a little bit and found that the controller ba

Re: [linux-sunxi] [PATCH v2 1/4] dt: bindings: mmc: Document the practice of using subnodes for slots

2014-06-01 Thread Hans de Goede
Hi, On 05/31/2014 10:13 PM, Olof Johansson wrote: On Sat, May 31, 2014 at 12:03 PM, Hans de Goede wrote: The following existing MMC host controller bindings use slot subnodes: Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt Docum

Re: [PATCH 1/5] mmc: sdhci-esdhc-imx: add f_max field to private data

2014-06-01 Thread Shawn Guo
On Fri, May 23, 2014 at 02:33:00PM +0200, Sascha Hauer wrote: > The driver filled in the clk and clock fields in struct > sdhci_pltfm_host, but they are unused in the sdhci-pltfm > code and only ever used it for internal use. This adds > a field f_max to private data and uses it instead. > > Signe