Re: [PATCHv7 2/2] ARM: dts: unuse the slot-node and deprecated supports-highspeed for dw-mmc.

2014-06-16 Thread Ulf Hansson
On 13 June 2014 15:31, Jae hoon Chung jh80.ch...@gmail.com wrote: Hi, Ulf. 2014-06-13 20:14 GMT+09:00 Ulf Hansson ulf.hans...@linaro.org: On 13 June 2014 06:31, Jaehoon Chung jh80.ch...@samsung.com wrote: dw-mmc controller can support multiple slots. But, there are no use-cases anywhere.

Re: [PATCHv7 2/2] ARM: dts: unuse the slot-node and deprecated supports-highspeed for dw-mmc.

2014-06-16 Thread Jaehoon Chung
On 06/16/2014 03:56 PM, Ulf Hansson wrote: On 13 June 2014 15:31, Jae hoon Chung jh80.ch...@gmail.com wrote: Hi, Ulf. 2014-06-13 20:14 GMT+09:00 Ulf Hansson ulf.hans...@linaro.org: On 13 June 2014 06:31, Jaehoon Chung jh80.ch...@samsung.com wrote: dw-mmc controller can support multiple

[PATCH 0/3] mmc: mmci: Restore irq handling behavior for arm_variant

2014-06-16 Thread Ulf Hansson
Commit mmc: mmci: Handle CMD irq before DATA irq introduced a bug, reported by John Stultz while using the arm_variant in QEMU envrionment. More information can be found here: https://lkml.org/lkml/2014/6/12/19 In this patchset we restores the old behavior for handling irqs, but only for the

[PATCH 1/3] mmc: mmci: Remove redundant check of status for DATA irq

2014-06-16 Thread Ulf Hansson
We don't need to verify the content of the status register twice, while we are about to handle a DATA irq. Instead let's leave all verification to be handled by mmci_data_irq(). Cc: Peter Maydell peter.mayd...@linaro.org Cc: John Stultz john.stu...@linaro.org Cc: Russell King

[PATCH 2/3] mmc: mmci: Move all CMD irq handling to mmci_cmd_irq()

2014-06-16 Thread Ulf Hansson
This patch won't change the behavior of how mmci deals with CMD irqs. By moving code from mmci_irq() to mmci_cmd_irq(), we getter a better overview of what going on. Cc: Peter Maydell peter.mayd...@linaro.org Cc: John Stultz john.stu...@linaro.org Cc: Russell King li...@arm.linux.org.uk

[PATCH 3/3] mmc: mmci: Reverse IRQ handling for the arm_variant

2014-06-16 Thread Ulf Hansson
Commit mmc: mmci: Handle CMD irq before DATA irq, caused an issue when using the ARM model of the PL181 and running QEMU. The bug was reported for the following QEMU version: $ qemu-system-arm -version QEMU emulator version 2.0.0 (Debian 2.0.0+dfsg-2ubuntu1.1), Copyright (c) 2003-2008 Fabrice

Re: [PATCH 3/3] mmc: mmci: Reverse IRQ handling for the arm_variant

2014-06-16 Thread Ulf Hansson
On 16 June 2014 09:58, Ulf Hansson ulf.hans...@linaro.org wrote: Commit mmc: mmci: Handle CMD irq before DATA irq, caused an issue when using the ARM model of the PL181 and running QEMU. The bug was reported for the following QEMU version: $ qemu-system-arm -version QEMU emulator version

[PATCH V2 3/3] mmc: mmci: Reverse IRQ handling for the arm_variant

2014-06-16 Thread Ulf Hansson
Commit mmc: mmci: Handle CMD irq before DATA irq, caused an issue when using the ARM model of the PL181 and running QEMU. The bug was reported for the following QEMU version: $ qemu-system-arm -version QEMU emulator version 2.0.0 (Debian 2.0.0+dfsg-2ubuntu1.1), Copyright (c) 2003-2008 Fabrice

Re: [PATCH] brcmfmac: prevent watchdog from interfering with scanning and connecting

2014-06-16 Thread Arend van Spriel
On 16-06-14 07:49, Fu, Zhonghui wrote: From 14485894add32aedacb3e486ebb2cc2b73861abf Mon Sep 17 00:00:00 2001 From: Fu zhonghui zhonghui...@linux.intel.com Date: Wed, 11 Jun 2014 11:06:55 +0800 Subject: [PATCH] brcmfmac: prevent watchdog from interfering with scanning and connecting Watchdog

Re: [PATCH v4 1/2] mmc: sdhci: Use mmc core regulator infrastucture

2014-06-16 Thread Ulf Hansson
On 13 June 2014 19:13, Markus Mayer markus.ma...@linaro.org wrote: From: Tim Kryger tim.kry...@gmail.com Switch the common SDHCI code over to use mmc_host's regulator pointers and remove the ones in the sdhci_host structure. Additionally, use the common mmc_regulator_get_supply function to

Re: [PATCH v4 2/2] mmc: sdhci: Replace host-mmc with mmc where possible

2014-06-16 Thread Ulf Hansson
On 13 June 2014 19:13, Markus Mayer markus.ma...@linaro.org wrote: After the switch to the MMC core regulator infrastucture, we already have a local mmc pointer in various functions. There is no longer a need to access the data structure via host-mmc. Signed-off-by: Markus Mayer

Re: [PATCHv7 1/2] mmc: dw_mmc: replace disable-wp from slot's quirk to host's quirk

2014-06-16 Thread Ulf Hansson
On 13 June 2014 06:31, Jaehoon Chung jh80.ch...@samsung.com wrote: Replaced the disable-wp into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Thanks! Applied for next. Kind regards Uffe --- Changelog V6/V7:

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread Ulf Hansson
On 6 June 2014 09:05, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn Add support for non-blocking request, pre_req() runs dma_map_sg() and post_req() runs dma_unmap_sg(). This patch can increase card read/write speed, especially for high speed card and slow

Re: [PATCH] mmc: sdhci: Remove unused ret variables

2014-06-16 Thread Ulf Hansson
On 4 June 2014 15:24, Markus Pargmann m...@pengutronix.de wrote: Remove those unused ret variables to make it obvious that these function will not return any errors in the current implementation. Signed-off-by: Markus Pargmann m...@pengutronix.de Thanks! Applied for next. Kind regards Uffe

Re: resend - sh mmcif driver cleanup patch series

2014-06-16 Thread Ulf Hansson
On 4 June 2014 13:42, Ben Dooks ben.do...@codethink.co.uk wrote: This is a re-send of the mmcif driver cleanups that seem to have been missed. If possible, could this be merged for the current merge window? These should be available at: http://git.codethink.co.uk/linux.git

Re: [PATCH 1/1] mmc: quirks: Fixup debug message

2014-06-16 Thread Ulf Hansson
On 20 May 2014 13:29, Alexander Stein alexander.st...@systec-electronic.com wrote: There is no need for an output like this: mmcblk mmc1:0001: calling add_quirk_mmc+0x0/0x20 Instead use this one: mmcblk mmc1:0001: calling add_quirk_mmc Signed-off-by: Alexander Stein

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread micky
On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr; struct mmc_host *mmc; struct mmc_request *mrq; + struct workqueue_struct *workq; +#define SDMMC_WORKQ_NAME

Re: [PATCH v14 0/6] mmc: omap_hsmmc: Enable SDIO IRQ

2014-06-16 Thread Ulf Hansson
On 29 May 2014 10:27, Andreas Fenkart afenk...@gmail.com wrote: Hi Balaji, Tony, Ulf, all v14 - drop all ifdef/endif introduced by v13 -- rely on pinctrl_lookup_state to prevent ifdef CONFIG_PM -- benefit: all code is compile tested no matter the configuration -- drawback: require

Re: [PATCH 1/1] mmc: moxart: Remove unneeded version.h inclusion

2014-06-16 Thread Ulf Hansson
On 22 May 2014 06:06, Sachin Kamat sachin.ka...@linaro.org wrote: version.h inclusion is not needed as suggested by versioncheck. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Jonas Jensen jonas.jen...@gmail.com Thanks! Applied for next. Kind regards Uffe ---

Re: [PATCH] mmc: add new au6601 driver

2014-06-16 Thread Ulf Hansson
Hi Oleksij, Sorry for a late reply. On 8 May 2014 11:58, Oleksij Rempel li...@rempel-privat.de wrote: This driver is based on documentation which was based on my RE-work and comparision with other MMC drivers. It works in legacy mode and can provide 20MB/s R/W spead for most modern SD cards,

Re: [PATCH] mmc: sd: warn if card stays busy during init

2014-06-16 Thread Ulf Hansson
On 23 May 2014 16:15, Johan Rudholm johan.rudh...@axis.com wrote: The initialization of some SD-cards fails because the card never leaves the busy state. Aid trouble shooting by indicating this in the kernel log. Signed-off-by: Johan Rudholm joha...@axis.com Thanks! Applied for next. Kind

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-16 Thread Russell King - ARM Linux
On Wed, Apr 23, 2014 at 08:08:07PM +0100, Russell King wrote: @@ -1507,25 +1529,7 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct mmc_ios *ios) host-ops-set_clock(host, host-clock); } - if (host-ops-set_uhs_signaling) -

Re: [PATCH] mmc: implement driver stage register handling

2014-06-16 Thread Ulf Hansson
On 23 May 2014 15:34, Sascha Hauer s.ha...@pengutronix.de wrote: The eMMC and the SD-Card specifications describe the optional SET_DSR command. During measurements at our lab we found that some cards implementing this feature having really strong driver strengts per default. This can lead to

Re: [PATCH] mmc: implement driver stage register handling

2014-06-16 Thread Russell King - ARM Linux
On Mon, Jun 16, 2014 at 01:36:38PM +0200, Ulf Hansson wrote: On 23 May 2014 15:34, Sascha Hauer s.ha...@pengutronix.de wrote: @@ -970,6 +971,9 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, goto free_card; } + if (card-csd.dsr_imp

Re: [RESEND][PATCH] mmc: wmt-sdmmc: Fix settting BM_EIGHTBIT_MODE bit in wmt_mci_set_ios()

2014-06-16 Thread Ulf Hansson
On 27 April 2014 12:22, Axel Lin axel@ingics.com wrote: For MMC_BUS_WIDTH_8 case, current code missed setting BM_EIGHTBIT_MODE bit. Also has a small refactor to make the code looks better in readability. So the bit settings witch below logic: SDMMC_BUSMODE register: Set EIGHTBIT_MODE

Re: [RESEND][PATCH] mmc: wmt-sdmmc: Remove deprecated IRQF_DISABLED

2014-06-16 Thread Ulf Hansson
On 27 April 2014 12:25, Axel Lin axel@ingics.com wrote: It's a NOOP since 2.6.35 and it will be removed one day. This is not trivial because current code uses hard coded 32 instead of IRQF_DISABLED in the request_irq call. Signed-off-by: Axel Lin axel@ingics.com Thanks! Applied for

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-16 Thread Ulf Hansson
On 16 June 2014 12:46, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Apr 23, 2014 at 08:08:07PM +0100, Russell King wrote: @@ -1507,25 +1529,7 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct mmc_ios *ios) host-ops-set_clock(host,

[PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

2014-06-16 Thread Jean Delvare
I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are only needed on the MMP architecture. So add a hardware dependency on ARCH_MMP, so that other users don't get to build useless drivers. Signed-off-by: Jean Delvare jdelv...@suse.de Cc: Chris Ball ch...@printf.net Cc: Ulf Hansson

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-16 Thread Lee Jones
From: Micky Ching micky_ch...@realsil.com.cn rtsx driver using a single function for transfer data, dma map/unmap are placed in one fix function. We need map/unmap dma in different place(for mmc async driver), so add three function for dma map, dma transfer and dma unmap. Signed-off-by:

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread Ulf Hansson
On 16 June 2014 11:09, micky micky_ch...@realsil.com.cn wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr; struct mmc_host *mmc; struct mmc_request *mrq; + struct

Re: how to creat watchpoint in kernel for data access debug

2014-06-16 Thread Will Deacon
On Thu, Jun 05, 2014 at 04:40:02AM +0100, Wang, Yalin wrote: Hi Will, Thanks for your point out very much , I see your meaning , And I do a try , But Seems it can just work when you register a Perf event with a NULL callback function,

Re: [PATCH] mmc: core: Fix DT documentation of eMMC high-speed DDR 1.8/1.2V bindings.

2014-06-16 Thread Ulf Hansson
On 16 June 2014 13:06, Peter Griffin peter.grif...@linaro.org wrote: Currently the documentation doesn't match the code in mmc_of_parse. This patch rectifies this. Signed-off-by: Peter Griffin peter.grif...@linaro.org Thanks! Applied to my mmc tree for next. Kind regards Uffe ---

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-16 Thread Ulf Hansson
On 16 June 2014 14:20, Lee Jones lee.jo...@linaro.org wrote: From: Micky Ching micky_ch...@realsil.com.cn rtsx driver using a single function for transfer data, dma map/unmap are placed in one fix function. We need map/unmap dma in different place(for mmc async driver), so add three function

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-16 Thread Ulf Hansson
On 16 June 2014 14:17, Ulf Hansson ulf.hans...@linaro.org wrote: On 16 June 2014 12:46, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Apr 23, 2014 at 08:08:07PM +0100, Russell King wrote: @@ -1507,25 +1529,7 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct

[PATCH] ARM: multi_v7_defconfig: re-enable SDHCI drivers

2014-06-16 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Following 5d01b7684b7e mmc: simplify SDHCI Kconfig dependencies, SDHCI drivers that use MMC_SDHCI_PLTFM no longer select it, but instead depend on it. This means that multi_v7_defconfig no longer selects it, and hence many SDHCI drivers are no longer

Re: [PATCH v4 2/2] mmc: sdhci: Replace host-mmc with mmc where possible

2014-06-16 Thread Markus Mayer
On 16 June 2014 01:23, Ulf Hansson ulf.hans...@linaro.org wrote: On 13 June 2014 19:13, Markus Mayer markus.ma...@linaro.org wrote: After the switch to the MMC core regulator infrastucture, we already have a local mmc pointer in various functions. There is no longer a need to access the data

Re: [PATCH] ARM: multi_v7_defconfig: re-enable SDHCI drivers

2014-06-16 Thread Matt Porter
On Mon, Jun 16, 2014 at 10:50:42AM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Following 5d01b7684b7e mmc: simplify SDHCI Kconfig dependencies, SDHCI drivers that use MMC_SDHCI_PLTFM no longer select it, but instead depend on it. This means that multi_v7_defconfig no

[PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

2014-06-16 Thread Matt Porter
Since 5d01b7684b7e mmc: simplify SDHCI Kconfig dependencies, MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure. Explictly enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona

Re: [PATCH V2 3/3] mmc: mmci: Reverse IRQ handling for the arm_variant

2014-06-16 Thread John Stultz
On Mon, Jun 16, 2014 at 1:09 AM, Ulf Hansson ulf.hans...@linaro.org wrote: Commit mmc: mmci: Handle CMD irq before DATA irq, caused an issue when using the ARM model of the PL181 and running QEMU. The bug was reported for the following QEMU version: $ qemu-system-arm -version QEMU emulator

Re: [PATCH] ARM: multi_v7_defconfig: re-enable SDHCI drivers

2014-06-16 Thread Ulf Hansson
On 16 June 2014 18:50, Stephen Warren swar...@wwwdotorg.org wrote: From: Stephen Warren swar...@nvidia.com Following 5d01b7684b7e mmc: simplify SDHCI Kconfig dependencies, SDHCI drivers that use MMC_SDHCI_PLTFM no longer select it, but instead depend on it. This means that multi_v7_defconfig

Re: [PATCH V2 3/3] mmc: mmci: Reverse IRQ handling for the arm_variant

2014-06-16 Thread Ulf Hansson
On 16 June 2014 20:58, John Stultz john.stu...@linaro.org wrote: On Mon, Jun 16, 2014 at 1:09 AM, Ulf Hansson ulf.hans...@linaro.org wrote: Commit mmc: mmci: Handle CMD irq before DATA irq, caused an issue when using the ARM model of the PL181 and running QEMU. The bug was reported for the

Re: [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

2014-06-16 Thread Ulf Hansson
On 16 June 2014 19:56, Matt Porter mpor...@linaro.org wrote: Since 5d01b7684b7e mmc: simplify SDHCI Kconfig dependencies, MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure.

Re: [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

2014-06-16 Thread Russell King - ARM Linux
On Mon, Jun 16, 2014 at 01:56:16PM -0400, Matt Porter wrote: Since 5d01b7684b7e mmc: simplify SDHCI Kconfig dependencies, MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results in the SDHCI driver not being built and a boot failure.

Re: [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver

2014-06-16 Thread Stephen Warren
On 06/16/2014 03:55 PM, Russell King - ARM Linux wrote: On Mon, Jun 16, 2014 at 01:56:16PM -0400, Matt Porter wrote: Since 5d01b7684b7e mmc: simplify SDHCI Kconfig dependencies, MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI driver which is enabled in this defconfig. This results

Re: [PATCH V2 3/3] mmc: mmci: Reverse IRQ handling for the arm_variant

2014-06-16 Thread John Stultz
On Mon, Jun 16, 2014 at 2:20 PM, Ulf Hansson ulf.hans...@linaro.org wrote: This patch based upon my latest mmc tree and the next branch. I tried to apply it for 3.15, and I think you will be able resolve the conflict - I should be quite trivial. No worries. I just didn't want to waste time

Re: [PATCH V2 3/3] mmc: mmci: Reverse IRQ handling for the arm_variant

2014-06-16 Thread John Stultz
On Mon, Jun 16, 2014 at 3:41 PM, John Stultz john.stu...@linaro.org wrote: On Mon, Jun 16, 2014 at 2:20 PM, Ulf Hansson ulf.hans...@linaro.org wrote: This patch based upon my latest mmc tree and the next branch. I tried to apply it for 3.15, and I think you will be able resolve the conflict -

Re: [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

2014-06-16 Thread Haojian Zhuang
On Mon, Jun 16, 2014 at 8:18 PM, Jean Delvare jdelv...@suse.de wrote: I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are only needed on the MMP architecture. So add a hardware dependency on ARCH_MMP, so that other users don't get to build useless drivers. Signed-off-by:

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread micky
On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky micky_ch...@realsil.com.cn wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr; struct mmc_host *mmc; struct

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-16 Thread micky
On 06/16/2014 08:20 PM, Lee Jones wrote: I don't see any glaring issues with this patch. Does it rely on the first patch, or vise versa, or can it just be applied? Hi Jones, [PATCH 2/2] need function defined in [PATCH 1/2], so we provide interface in [mfd] and called in [mmc]. Best Regards.